From 007b75942166e1ff138a46893250d4e62e85c85d Mon Sep 17 00:00:00 2001 From: "jeremy@jermolene.com" Date: Fri, 10 Mar 2023 09:41:18 +0000 Subject: [PATCH] Undefined variables in let widget: Revert fix for #7270 Reverts 8c378e0d24e9f4b8986316bc17f077b894d1eb30 and adds a test --- core/modules/widgets/let.js | 4 +--- .../data/widgets/LetWidgetSelfReferences.tid | 15 +++++++++++++++ 2 files changed, 16 insertions(+), 3 deletions(-) create mode 100644 editions/test/tiddlers/tests/data/widgets/LetWidgetSelfReferences.tid diff --git a/core/modules/widgets/let.js b/core/modules/widgets/let.js index dd3aa137a..afd3a2f20 100644 --- a/core/modules/widgets/let.js +++ b/core/modules/widgets/let.js @@ -74,9 +74,7 @@ LetWidget.prototype.getVariableInfo = function(name,options) { text: this.currentValueFor[name] }; } - return Widget.prototype.getVariableInfo.call(this,name,$tw.utils.extend(Object.create(null),options,{ - defaultValue: "" - })); + return Widget.prototype.getVariableInfo.call(this,name,options); }; /* diff --git a/editions/test/tiddlers/tests/data/widgets/LetWidgetSelfReferences.tid b/editions/test/tiddlers/tests/data/widgets/LetWidgetSelfReferences.tid new file mode 100644 index 000000000..b81fc7d75 --- /dev/null +++ b/editions/test/tiddlers/tests/data/widgets/LetWidgetSelfReferences.tid @@ -0,0 +1,15 @@ +title: Widgets/LetWidgetSelfReferences +description: Test let widget self references +type: text/vnd.tiddlywiki-multiple +tags: [[$:/tags/wiki-test-spec]] + +title: Output + +\whitespace trim +<$let default={{{ [[default]is[variable]then[aa]else[bb]] }}} > +<> + ++ +title: ExpectedResult + +

bb

\ No newline at end of file