1
0
mirror of https://github.com/TeamNewPipe/NewPipe synced 2024-07-06 12:03:19 +00:00
NewPipe/app/src/main/java/org/schabi/newpipe
z3r0r4 70354eb73e
Add play next to long press menu & refactor enqueue methods (#6872)
* added mvp play next button in long press menu; new intent handling, new long press dialog entry, new dialog functions, new strings

* changed line length for checkstyle pass

* cleaned comments, moved strings

* Update app/src/main/res/values/strings.xml

to make long press entry more descriptive

Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>

* Update app/src/main/res/values/strings.xml

Co-authored-by: Stypox <stypox@pm.me>

* replace redundant nextOnVideoPlayer methods

Co-authored-by: Stypox <stypox@pm.me>

* add enqueueNextOnPlayer and enqueueOnPlayer without selectOnAppend and RESUME_PLAYBACK/ deprecate enqueueNextOn*Player and enqueueOn*Player methods
add getPlayerIntent, getPlayerEnqueueIntent and getPlayerEnqueueNextIntent without selectOnAppend and RESUME_PLAYBACK/ deprecate those with
add section comments

* removed deprecated methods
removed redundant methods

* removed deprecated methods
removed redundant methods

* replaced APPEND_ONLY, removed SELECT_ON_APPEND / replaced remaining enqueueOn*Player methods

* now works with playlists

* renamed dialog entry

* checking for >1 items in the queue using the PlayerHolder

* making enqueue*OnPlayer safe to call when no video is playing (defaulting to audio)

* corrected strings

* improve getQueueSize in PlayerHolder

* long press to enqueue only if queue isnt empty

* add Whitespace

Co-authored-by: Stypox <stypox@pm.me>

* clarify comments / add spaces

* PlayerType as parameter of the enqueueOnPlayer method
add Helper method

* using the helper function everywhere (except for the background and popup long-press actions (also on playlists, history, ...)), so basically nowhere
/ passing checkstyle

* assimilated the enqueue*OnPlayer methods

* removed redundant comment, variable

* simplify code line

Co-authored-by: Stypox <stypox@pm.me>

* move if

* replace workaround for isPlayerOpen()

Co-authored-by: Stypox <stypox@pm.me>

* replaced workarounds (getType), corrected static access with getInstance

* remove unused imports

* changed method call to original, new method doesnt exist yet.

* Use getter method instead of property access syntax.

* improve conditional for play next entry

Co-authored-by: Stypox <stypox@pm.me>

* show play next btn in feed fragment

Co-authored-by: Stypox <stypox@pm.me>

* add play next to local playlist and statistics fragment

Co-authored-by: Stypox <stypox@pm.me>

* formating

Co-authored-by: Stypox <stypox@pm.me>

* correcting logic

Co-authored-by: Stypox <stypox@pm.me>

* remove 2 year old unused string, formating

Co-authored-by: Stypox <stypox@pm.me>

* correct enqueue (next) conditionals, default to background if no player is open. Dont generally default to background play.

* remove player open checks from button long press enqueue actions

* improve log msg

* Rename next to enqueue_next

* Refactor kotlin

Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
Co-authored-by: Stypox <stypox@pm.me>
2021-09-18 11:22:49 +02:00
..
about Merge pull request #7024 from Stypox/string-fixes 2021-08-31 12:00:07 +02:00
database Remove migration test, add manual testing reminder to Migrations.java 2021-08-17 08:57:03 +08:00
download Rename string finish to ok, as its content was "OK" 2021-08-30 16:36:57 +02:00
error Merge pull request #7004 from litetex/fix-showTextError-and-rework-ErrorPanel 2021-08-31 18:26:51 +02:00
fragments Add play next to long press menu & refactor enqueue methods (#6872) 2021-09-18 11:22:49 +02:00
info_list Replace UniversalImageLoader with Picasso 2021-08-24 10:56:25 +02:00
ktx Make some minor changes 2021-05-15 18:48:16 +03:00
local Add play next to long press menu & refactor enqueue methods (#6872) 2021-09-18 11:22:49 +02:00
player Add play next to long press menu & refactor enqueue methods (#6872) 2021-09-18 11:22:49 +02:00
settings Always use our strings, not android ones 2021-08-30 16:37:01 +02:00
streams Provide mime type to file picker to gray out unselectable files 2021-08-01 13:52:32 +02:00
util Add play next to long press menu & refactor enqueue methods (#6872) 2021-09-18 11:22:49 +02:00
views Apply the requested changes and little improvements 2021-01-16 13:23:42 +01:00
App.java Apply review: move thumbnail loading out of Player 2021-08-24 10:56:25 +02:00
BaseFragment.java Replace UniversalImageLoader with Picasso 2021-08-24 10:56:25 +02:00
CheckForNewAppVersion.java Use PackageInfoCompat.getSignatures(). 2021-07-19 19:48:24 +05:30
DownloaderImpl.java Replace UniversalImageLoader with Picasso 2021-08-24 10:56:25 +02:00
ExitActivity.java Replaced System.Exit calls with FinishAffinity and Start Activity calls 2021-06-17 17:18:15 +01:00
MainActivity.java Update some AndroidX libraries 2021-07-21 19:31:41 -04:00
NewPipeDatabase.java Add uploader_url column to StreamEntity 2021-08-13 16:44:50 +08:00
NewVersionManager.kt Respect expires header when checking for new version 2021-01-23 09:02:11 +01:00
PanicResponderActivity.java Clean up SDK version checks 2020-09-06 12:55:30 +02:00
QueueItemMenuUtil.java Remove TAG parameter, refactor method calls 2021-08-25 17:04:15 +08:00
RouterActivity.java Call DownloadDialog dismiss() in the correct way 2021-07-19 10:59:45 +02:00