FocusOverlayView: Avoid accessing restricted API

Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>

app/build.gradle.kts

@@ -79,7 +79,7 @@ configure<ApplicationExtension> {
                 resValue("string", "app_name", "NewPipe $suffix")
             }
             isMinifyEnabled = true
-            isShrinkResources = false // disabled to fix F-Droid"s reproducible build
+            isShrinkResources = true
             proguardFiles(
                 getDefaultProguardFile("proguard-android-optimize.txt"),
                 "proguard-rules.pro"
@@ -88,13 +88,7 @@ configure<ApplicationExtension> {
     }
 
     lint {
-        checkReleaseBuilds = false
+        lintConfig = file("lint.xml")
-        // Or, if you prefer, you can continue to check for errors in release builds,
-        // but continue the build even when errors are found:
-        abortOnError = false
-        // suppress false warning ("Resource IDs will be non-final in Android Gradle Plugin version
-        // 5.0, avoid using them in switch case statements"), which affects only library projects
-        disable += "NonConstantResourceId"
     }
 
     compileOptions {

app/lint.xml

@@ -0,0 +1,10 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+  ~ SPDX-FileCopyrightText: 2026 NewPipe e.V. <https://newpipe-ev.de>
+  ~ SPDX-License-Identifier: GPL-3.0-or-later
+  -->
+<lint>
+    <issue id="MissingTranslation" severity="ignore" />
+    <issue id="MissingQuantity" severity="ignore" />
+    <issue id="ImpliedQuantity" severity="ignore" />
+</lint>

app/src/main/java/org/schabi/newpipe/MainActivity.java

@@ -309,24 +309,20 @@ public class MainActivity extends AppCompatActivity {
     }
 
     private boolean drawerItemSelected(final MenuItem item) {
-        switch (item.getGroupId()) {
+        final int groupId = item.getGroupId();
-            case R.id.menu_services_group:
+        if (groupId == R.id.menu_services_group) {
             changeService(item);
-                break;
+        } else if (groupId == R.id.menu_tabs_group) {
-            case R.id.menu_tabs_group:
             tabSelected(item);
-                break;
+        } else if (groupId == R.id.menu_kiosks_group) {
-            case R.id.menu_kiosks_group:
             try {
                 kioskSelected(item);
             } catch (final Exception e) {
                 ErrorUtil.showUiErrorSnackbar(this, "Selecting drawer kiosk", e);
             }
-                break;
+        } else if (groupId == R.id.menu_options_about_group) {
-            case R.id.menu_options_about_group:
             optionsAboutSelected(item);
-                break;
+        } else {
-            default:
             return false;
         }
 

app/src/main/java/org/schabi/newpipe/NewVersionWorker.kt

@@ -82,8 +82,10 @@ class NewVersionWorker(
             )
 
         val notificationManager = NotificationManagerCompat.from(applicationContext)
+        if (notificationManager.areNotificationsEnabled()) {
             notificationManager.notify(2000, notificationBuilder.build())
         }
+    }
 
     @Throws(IOException::class, ReCaptchaException::class)
     private fun checkNewVersion() {

app/src/main/java/org/schabi/newpipe/QueueItemMenuUtil.java

@@ -41,18 +41,18 @@ public final class QueueItemMenuUtil {
         }
 
         popupMenu.setOnMenuItemClickListener(menuItem -> {
-            switch (menuItem.getItemId()) {
+            final int itemId = menuItem.getItemId();
-                case R.id.menu_item_remove:
+            if (itemId == R.id.menu_item_remove) {
                 final int index = playQueue.indexOf(item);
                 playQueue.remove(index);
                 return true;
-                case R.id.menu_item_details:
+            } else if (itemId == R.id.menu_item_details) {
                 // playQueue is null since we don't want any queue change
                 NavigationHelper.openVideoDetail(context, item.getServiceId(),
                         item.getUrl(), item.getTitle(), null,
                         false);
                 return true;
-                case R.id.menu_item_append_playlist:
+            } else if (itemId == R.id.menu_item_append_playlist) {
                 PlaylistDialog.createCorrespondingDialog(
                         context,
                         List.of(new StreamEntity(item)),
@@ -63,7 +63,7 @@ public final class QueueItemMenuUtil {
                 );
 
                 return true;
-                case R.id.menu_item_channel_details:
+            } else if (itemId == R.id.menu_item_channel_details) {
                 SparseItemUtil.fetchUploaderUrlIfSparse(context, item.getServiceId(),
                         item.getUrl(), item.getUploaderUrl(),
                         // An intent must be used here.
@@ -73,11 +73,11 @@ public final class QueueItemMenuUtil {
                                 context, item.getServiceId(), uploaderUrl, item.getUploader()
                         ));
                 return true;
-                case R.id.menu_item_share:
+            } else if (itemId == R.id.menu_item_share) {
                 shareText(context, item.getTitle(), item.getUrl(),
                         item.getThumbnails());
                 return true;
-                case R.id.menu_item_download:
+            } else if (itemId == R.id.menu_item_download) {
                 fetchStreamInfoAndSaveToDatabase(context, item.getServiceId(), item.getUrl(),
                         info -> {
                             final DownloadDialog downloadDialog = new DownloadDialog(context,

app/src/main/java/org/schabi/newpipe/download/DownloadDialog.java

@@ -16,6 +16,7 @@ import android.os.IBinder;
 import android.provider.Settings;
 import android.util.Log;
 import android.view.LayoutInflater;
+import android.view.MenuItem;
 import android.view.View;
 import android.view.ViewGroup;
 import android.widget.AdapterView;
@@ -31,7 +32,6 @@ import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
 import androidx.annotation.StringRes;
 import androidx.appcompat.app.AlertDialog;
-import androidx.appcompat.view.menu.ActionMenuItemView;
 import androidx.appcompat.widget.Toolbar;
 import androidx.collection.SparseArrayCompat;
 import androidx.documentfile.provider.DocumentFile;
@@ -113,7 +113,7 @@ public class DownloadDialog extends DialogFragment
     private StoredDirectoryHelper mainStorageAudio = null;
     private StoredDirectoryHelper mainStorageVideo = null;
     private DownloadManager downloadManager = null;
-    private ActionMenuItemView okButton = null;
+    private MenuItem okButton = null;
     private Context context = null;
     private boolean askForSavePath;
 
@@ -558,17 +558,13 @@ public class DownloadDialog extends DialogFragment
         }
         boolean flag = true;
 
-        switch (checkedId) {
+        if (checkedId == R.id.audio_button) {
-            case R.id.audio_button:
             setupAudioSpinner();
-                break;
+        } else if (checkedId == R.id.video_button) {
-            case R.id.video_button:
             setupVideoSpinner();
-                break;
+        } else if (checkedId == R.id.subtitle_button) {
-            case R.id.subtitle_button:
             setupSubtitleSpinner();
             flag = false;
-                break;
         }
 
         dialogBinding.threads.setEnabled(flag);
@@ -585,28 +581,25 @@ public class DownloadDialog extends DialogFragment
                     + "position = [" + position + "], id = [" + id + "]");
         }
 
-        switch (parent.getId()) {
+        final int parentId = parent.getId();
-            case R.id.quality_spinner:
+        if (parentId == R.id.quality_spinner) {
-                switch (dialogBinding.videoAudioGroup.getCheckedRadioButtonId()) {
+            final int checkedRadioButtonId = dialogBinding.videoAudioGroup
-                    case R.id.video_button:
+                    .getCheckedRadioButtonId();
+            if (checkedRadioButtonId == R.id.video_button) {
                 selectedVideoIndex = position;
                 onVideoStreamSelected();
-                        break;
+            } else if (checkedRadioButtonId == R.id.subtitle_button) {
-                    case R.id.subtitle_button:
                 selectedSubtitleIndex = position;
-                        break;
             }
             onItemSelectedSetFileName();
-                break;
+        } else if (parentId == R.id.audio_track_spinner) {
-            case R.id.audio_track_spinner:
             final boolean trackChanged = selectedAudioTrackIndex != position;
             selectedAudioTrackIndex = position;
             if (trackChanged) {
                 updateSecondaryStreams();
                 fetchStreamsSize();
             }
-                break;
+        } else if (parentId == R.id.audio_stream_spinner) {
-            case R.id.audio_stream_spinner:
             selectedAudioIndex = position;
         }
     }
@@ -622,23 +615,20 @@ public class DownloadDialog extends DialogFragment
                 || prevFileName.startsWith(getString(R.string.caption_file_name, fileName, ""))) {
             // only update the file name field if it was not edited by the user
 
-            switch (dialogBinding.videoAudioGroup.getCheckedRadioButtonId()) {
+            final int radioButtonId = dialogBinding.videoAudioGroup
-                case R.id.audio_button:
+                    .getCheckedRadioButtonId();
-                case R.id.video_button:
+            if (radioButtonId == R.id.audio_button || radioButtonId == R.id.video_button) {
                 if (!prevFileName.equals(fileName)) {
                     // since the user might have switched between audio and video, the correct
                     // text might already be in place, so avoid resetting the cursor position
                     dialogBinding.fileName.setText(fileName);
                 }
-                    break;
+            } else if (radioButtonId == R.id.subtitle_button) {
-
-                case R.id.subtitle_button:
                 final String setSubtitleLanguageCode = subtitleStreamsAdapter
                         .getItem(selectedSubtitleIndex).getLanguageTag();
                 // this will reset the cursor position, which is bad UX, but it can't be avoided
                 dialogBinding.fileName.setText(getString(
                         R.string.caption_file_name, fileName, setSubtitleLanguageCode));
-                    break;
             }
         }
     }
@@ -770,8 +760,8 @@ public class DownloadDialog extends DialogFragment
 
         filenameTmp = getNameEditText().concat(".");
 
-        switch (dialogBinding.videoAudioGroup.getCheckedRadioButtonId()) {
+        final int checkedRadioButtonId = dialogBinding.videoAudioGroup.getCheckedRadioButtonId();
-            case R.id.audio_button:
+        if (checkedRadioButtonId == R.id.audio_button) {
             selectedMediaType = getString(R.string.last_download_type_audio_key);
             mainStorage = mainStorageAudio;
             format = audioStreamsAdapter.getItem(selectedAudioIndex).getFormat();
@@ -783,8 +773,7 @@ public class DownloadDialog extends DialogFragment
                 mimeTmp = format.mimeType;
                 filenameTmp += format.getSuffix();
             }
-                break;
+        } else if (checkedRadioButtonId == R.id.video_button) {
-            case R.id.video_button:
             selectedMediaType = getString(R.string.last_download_type_video_key);
             mainStorage = mainStorageVideo;
             format = videoStreamsAdapter.getItem(selectedVideoIndex).getFormat();
@@ -793,8 +782,7 @@ public class DownloadDialog extends DialogFragment
                 mimeTmp = format.mimeType;
                 filenameTmp += format.getSuffix();
             }
-                break;
+        } else if (checkedRadioButtonId == R.id.subtitle_button) {
-            case R.id.subtitle_button:
             selectedMediaType = getString(R.string.last_download_type_subtitle_key);
             mainStorage = mainStorageVideo; // subtitle & video files go together
             format = subtitleStreamsAdapter.getItem(selectedSubtitleIndex).getFormat();
@@ -808,8 +796,7 @@ public class DownloadDialog extends DialogFragment
             } else if (format != null) {
                 filenameTmp += format.getSuffix();
             }
-                break;
+        } else {
-            default:
             throw new RuntimeException("No stream selected");
         }
 
@@ -1057,8 +1044,8 @@ public class DownloadDialog extends DialogFragment
         long nearLength = 0;
 
         // more download logic: select muxer, subtitle converter, etc.
-        switch (dialogBinding.videoAudioGroup.getCheckedRadioButtonId()) {
+        final int checkedRadioButtonId = dialogBinding.videoAudioGroup.getCheckedRadioButtonId();
-            case R.id.audio_button:
+        if (checkedRadioButtonId == R.id.audio_button) {
             kind = 'a';
             selectedStream = audioStreamsAdapter.getItem(selectedAudioIndex);
 
@@ -1067,8 +1054,7 @@ public class DownloadDialog extends DialogFragment
             } else if (selectedStream.getFormat() == MediaFormat.WEBMA_OPUS) {
                 psName = Postprocessing.ALGORITHM_OGG_FROM_WEBM_DEMUXER;
             }
-                break;
+        } else if (checkedRadioButtonId == R.id.video_button) {
-            case R.id.video_button:
             kind = 'v';
             selectedStream = videoStreamsAdapter.getItem(selectedVideoIndex);
 
@@ -1094,21 +1080,19 @@ public class DownloadDialog extends DialogFragment
                     nearLength = secondary.getSizeInBytes() + videoSize;
                 }
             }
-                break;
+        } else if (checkedRadioButtonId == R.id.subtitle_button) {
-            case R.id.subtitle_button:
             threads = 1; // use unique thread for subtitles due small file size
             kind = 's';
             selectedStream = subtitleStreamsAdapter.getItem(selectedSubtitleIndex);
 
             if (selectedStream.getFormat() == MediaFormat.TTML) {
                 psName = Postprocessing.ALGORITHM_TTML_CONVERTER;
-                    psArgs = new String[] {
+                psArgs = new String[]{
                         selectedStream.getFormat().getSuffix(),
                         "false" // ignore empty frames
                 };
             }
-                break;
+        } else {
-            default:
             return;
         }
 

app/src/main/java/org/schabi/newpipe/error/ErrorActivity.java

@@ -133,17 +133,16 @@ public class ErrorActivity extends AppCompatActivity {
 
     @Override
     public boolean onOptionsItemSelected(final MenuItem item) {
-        switch (item.getItemId()) {
+        final int itemId = item.getItemId();
-            case android.R.id.home:
+        if (itemId == android.R.id.home) {
             onBackPressed();
             return true;
-            case R.id.menu_item_share_error:
+        } else if (itemId == R.id.menu_item_share_error) {
             ShareUtils.shareText(getApplicationContext(),
                     getString(R.string.error_report_title), buildJson());
             return true;
-            default:
-                return false;
         }
+        return false;
     }
 
     private void openPrivacyPolicyDialog(final Context context, final String action) {

app/src/main/java/org/schabi/newpipe/error/ErrorUtil.kt

@@ -134,8 +134,11 @@ class ErrorUtil {
                         )
                     )
 
-            NotificationManagerCompat.from(context)
+            val notificationManager = NotificationManagerCompat.from(context)
+            if (notificationManager.areNotificationsEnabled()) {
+                notificationManager
                     .notify(ERROR_REPORT_NOTIFICATION_ID, notificationBuilder.build())
+            }
 
             ContextCompat.getMainExecutor(context).execute {
                 // since the notification is silent, also show a toast, otherwise the user is confused

app/src/main/java/org/schabi/newpipe/error/ReCaptchaActivity.java

@@ -126,6 +126,7 @@ public class ReCaptchaActivity extends AppCompatActivity {
     }
 
     @Override
+    @SuppressLint("MissingSuperCall")
     public void onBackPressed() {
         saveCookiesAndFinish();
     }

app/src/main/java/org/schabi/newpipe/fragments/list/channel/ChannelFragment.java

@@ -160,33 +160,28 @@ public class ChannelFragment extends BaseStateFragment<ChannelInfo>
 
                 @Override
                 public boolean onMenuItemSelected(@NonNull final MenuItem item) {
-                    switch (item.getItemId()) {
+                    final int itemId = item.getItemId();
-                        case R.id.menu_item_notify:
+                    if (itemId == R.id.menu_item_notify) {
                         final boolean value = !item.isChecked();
                         item.setEnabled(false);
                         setNotify(value);
-                            break;
+                    } else if (itemId == R.id.action_settings) {
-                        case R.id.action_settings:
                         NavigationHelper.openSettings(requireContext());
-                            break;
+                    } else if (itemId == R.id.menu_item_rss) {
-                        case R.id.menu_item_rss:
                         if (currentInfo != null) {
                             ShareUtils.openUrlInApp(requireContext(), currentInfo.getFeedUrl());
                         }
-                            break;
+                    } else if (itemId == R.id.menu_item_openInBrowser) {
-                        case R.id.menu_item_openInBrowser:
                         if (currentInfo != null) {
                             ShareUtils.openUrlInBrowser(requireContext(),
                                     currentInfo.getOriginalUrl());
                         }
-                            break;
+                    } else if (itemId == R.id.menu_item_share) {
-                        case R.id.menu_item_share:
                         if (currentInfo != null) {
                             ShareUtils.shareText(requireContext(), name,
                                     currentInfo.getOriginalUrl(), currentInfo.getAvatars());
                         }
-                            break;
+                    } else {
-                        default:
                         return false;
                     }
                     return true;

app/src/main/java/org/schabi/newpipe/fragments/list/playlist/PlaylistFragment.java

@@ -232,21 +232,17 @@ public class PlaylistFragment extends BaseListInfoFragment<StreamInfoItem, Playl
 
     @Override
     public boolean onOptionsItemSelected(final MenuItem item) {
-        switch (item.getItemId()) {
+        final int itemId = item.getItemId();
-            case R.id.action_settings:
+        if (itemId == R.id.action_settings) {
             NavigationHelper.openSettings(requireContext());
-                break;
+        } else if (itemId == R.id.menu_item_openInBrowser) {
-            case R.id.menu_item_openInBrowser:
             ShareUtils.openUrlInBrowser(requireContext(), url);
-                break;
+        } else if (itemId == R.id.menu_item_share) {
-            case R.id.menu_item_share:
             ShareUtils.shareText(requireContext(), name, url,
                     currentInfo == null ? List.of() : currentInfo.getThumbnails());
-                break;
+        } else if (itemId == R.id.menu_item_bookmark) {
-            case R.id.menu_item_bookmark:
             onBookmarkClicked();
-                break;
+        } else if (itemId == R.id.menu_item_append_playlist) {
-            case R.id.menu_item_append_playlist:
             if (currentInfo != null) {
                 disposables.add(PlaylistDialog.createCorrespondingDialog(
                         getContext(),
@@ -258,8 +254,7 @@ public class PlaylistFragment extends BaseListInfoFragment<StreamInfoItem, Playl
                         dialog -> dialog.show(getFM(), TAG)
                 ));
             }
-                break;
+        } else {
-            default:
             return super.onOptionsItemSelected(item);
         }
         return true;

app/src/main/java/org/schabi/newpipe/local/feed/FeedFragment.kt

@@ -255,7 +255,7 @@ class FeedFragment : BaseStateFragment<FeedState>() {
             viewModel.getShowFutureItemsFromPreferences()
         )
 
-        AlertDialog.Builder(context!!)
+        AlertDialog.Builder(requireContext())
             .setTitle(R.string.feed_hide_streams_title)
             .setMultiChoiceItems(dialogItems, checkedDialogItems) { _, which, isChecked ->
                 checkedDialogItems[which] = isChecked

app/src/main/java/org/schabi/newpipe/local/feed/notifications/NotificationHelper.kt

@@ -92,8 +92,10 @@ class NotificationHelper(val context: Context) {
                 // Show individual stream notifications, set channel icon only if there is actually
                 // one
                 showStreamNotifications(newStreams, data.serviceId, data.url, bitmap)
-                // Show summary notification
+                // Show summary notification if enabled
+                if (manager.areNotificationsEnabled()) {
                     manager.notify(data.pseudoId, summaryBuilder.build())
+                }
 
                 iconLoadingTargets.remove(this) // allow it to be garbage-collected
             }
@@ -101,8 +103,10 @@ class NotificationHelper(val context: Context) {
             override fun onBitmapFailed(e: Exception, errorDrawable: Drawable) {
                 // Show individual stream notifications
                 showStreamNotifications(newStreams, data.serviceId, data.url, null)
-                // Show summary notification
+                // Show summary notification if enabled
+                if (manager.areNotificationsEnabled()) {
                     manager.notify(data.pseudoId, summaryBuilder.build())
+                }
                 iconLoadingTargets.remove(this) // allow it to be garbage-collected
             }
 
@@ -126,9 +130,11 @@ class NotificationHelper(val context: Context) {
     ) {
         for (stream in newStreams) {
             val notification = createStreamNotification(stream, serviceId, channelUrl, channelIcon)
+            if (manager.areNotificationsEnabled()) {
                 manager.notify(stream.url.hashCode(), notification)
             }
         }
+    }
 
     private fun createStreamNotification(
         item: StreamInfoItem,

app/src/main/java/org/schabi/newpipe/local/feed/service/FeedLoadService.kt

@@ -185,8 +185,10 @@ class FeedLoadService : Service() {
             }
         }
 
+        if (notificationManager.areNotificationsEnabled()) {
             notificationManager.notify(NOTIFICATION_ID, notificationBuilder.build())
         }
+    }
 
     // /////////////////////////////////////////////////////////////////////////
     // Notification Actions

app/src/main/java/org/schabi/newpipe/local/subscription/dialog/FeedGroupDialog.kt

@@ -506,7 +506,7 @@ class FeedGroupDialog : DialogFragment(), BackPressable {
     private fun hideKeyboardSearch() {
         inputMethodManager.hideSoftInputFromWindow(
             searchLayoutBinding.toolbarSearchEditText.windowToken,
-            InputMethodManager.RESULT_UNCHANGED_SHOWN
+            InputMethodManager.HIDE_NOT_ALWAYS
         )
         searchLayoutBinding.toolbarSearchEditText.clearFocus()
     }
@@ -523,7 +523,7 @@ class FeedGroupDialog : DialogFragment(), BackPressable {
     private fun hideKeyboard() {
         inputMethodManager.hideSoftInputFromWindow(
             feedGroupCreateBinding.groupNameInput.windowToken,
-            InputMethodManager.RESULT_UNCHANGED_SHOWN
+            InputMethodManager.HIDE_NOT_ALWAYS
         )
         feedGroupCreateBinding.groupNameInput.clearFocus()
     }

app/src/main/java/org/schabi/newpipe/local/subscription/services/BaseImportExportService.java

@@ -144,8 +144,10 @@ public abstract class BaseImportExportService extends Service {
             notificationBuilder.setContentText(text);
         }
 
+        if (notificationManager.areNotificationsEnabled()) {
             notificationManager.notify(getNotificationId(), notificationBuilder.build());
         }
+    }
 
     protected void stopService() {
         postErrorResult(null, null);
@@ -174,8 +176,11 @@ public abstract class BaseImportExportService extends Service {
                 .setContentTitle(title)
                 .setStyle(new NotificationCompat.BigTextStyle().bigText(textOrEmpty))
                 .setContentText(textOrEmpty);
+
+        if (notificationManager.areNotificationsEnabled()) {
             notificationManager.notify(getNotificationId(), notificationBuilder.build());
         }
+    }
 
     protected NotificationCompat.Builder createNotification() {
         return new NotificationCompat.Builder(this, getString(R.string.notification_channel_id))

app/src/main/java/org/schabi/newpipe/player/PlayQueueActivity.java

@@ -127,36 +127,36 @@ public final class PlayQueueActivity extends AppCompatActivity
 
     @Override
     public boolean onOptionsItemSelected(final MenuItem item) {
-        switch (item.getItemId()) {
+        final int itemId = item.getItemId();
-            case android.R.id.home:
+        if (itemId == android.R.id.home) {
             finish();
             return true;
-            case R.id.action_settings:
+        } else if (itemId == R.id.action_settings) {
             NavigationHelper.openSettings(this);
             return true;
-            case R.id.action_append_playlist:
+        } else if (itemId == R.id.action_append_playlist) {
             PlaylistDialog.showForPlayQueue(player, getSupportFragmentManager());
             return true;
-            case R.id.action_playback_speed:
+        } else if (itemId == R.id.action_playback_speed) {
             openPlaybackParameterDialog();
             return true;
-            case R.id.action_mute:
+        } else if (itemId == R.id.action_mute) {
             player.toggleMute();
             return true;
-            case R.id.action_system_audio:
+        } else if (itemId == R.id.action_system_audio) {
             startActivity(new Intent(Settings.ACTION_SOUND_SETTINGS));
             return true;
-            case R.id.action_switch_main:
+        } else if (itemId == R.id.action_switch_main) {
             this.player.setRecovery();
             NavigationHelper.playOnMainPlayer(this, player.getPlayQueue(), true);
             return true;
-            case R.id.action_switch_popup:
+        } else if (itemId == R.id.action_switch_popup) {
             if (PermissionHelper.isPopupEnabledElseAsk(this)) {
                 this.player.setRecovery();
                 NavigationHelper.playOnPopupPlayer(this, player.getPlayQueue(), true);
             }
             return true;
-            case R.id.action_switch_background:
+        } else if (itemId == R.id.action_switch_background) {
             this.player.setRecovery();
             NavigationHelper.playOnBackgroundPlayer(this, player.getPlayQueue(), true);
             return true;

app/src/main/java/org/schabi/newpipe/player/notification/NotificationUtil.java

@@ -72,8 +72,10 @@ public final class NotificationUtil {
             notificationBuilder = createNotification();
         }
         updateNotification();
+        if (notificationManager.areNotificationsEnabled()) {
             notificationManager.notify(NOTIFICATION_ID, notificationBuilder.build());
         }
+    }
 
     public synchronized void updateThumbnail() {
         if (notificationBuilder != null) {
@@ -84,9 +86,11 @@ public final class NotificationUtil {
             }
 
             setLargeIcon(notificationBuilder);
+            if (notificationManager.areNotificationsEnabled()) {
                 notificationManager.notify(NOTIFICATION_ID, notificationBuilder.build());
             }
         }
+    }
 
     private synchronized NotificationCompat.Builder createNotification() {
         if (DEBUG) {

app/src/main/java/org/schabi/newpipe/util/KeyboardUtil.java

@@ -48,7 +48,7 @@ public final class KeyboardUtil {
         final InputMethodManager imm = ContextCompat.getSystemService(activity,
                 InputMethodManager.class);
         imm.hideSoftInputFromWindow(editText.getWindowToken(),
-                InputMethodManager.RESULT_UNCHANGED_SHOWN);
+                InputMethodManager.HIDE_NOT_ALWAYS);
 
         editText.clearFocus();
     }

app/src/main/java/org/schabi/newpipe/views/FocusOverlayView.java

@@ -40,7 +40,6 @@ import android.view.Window;
 import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
 import androidx.annotation.RequiresApi;
-import androidx.appcompat.view.WindowCallbackWrapper;
 
 import org.schabi.newpipe.R;
 
@@ -232,7 +231,7 @@ public final class FocusOverlayView extends Drawable implements
         // Unfortunately many such forms of "scrolling" do not count as scrolling for purpose
         // of dispatching ViewTreeObserver callbacks, so we have to intercept them by directly
         // receiving keys from Window.
-        window.setCallback(new WindowCallbackWrapper(window.getCallback()) {
+        window.setCallback(new SimpleWindowCallback(window.getCallback()) {
             @Override
             public boolean dispatchKeyEvent(final KeyEvent event) {
                 final boolean res = super.dispatchKeyEvent(event);

app/src/main/java/org/schabi/newpipe/views/SimpleWindowCallback.kt

@@ -0,0 +1,35 @@
+/*
+ * SPDX-FileCopyrightText: 2026 NewPipe e.V. <https://newpipe-ev.de>
+ * SPDX-License-Identifier: GPL-3.0-or-later
+ */
+
+package org.schabi.newpipe.views
+
+import android.os.Build
+import android.view.KeyEvent
+import android.view.KeyboardShortcutGroup
+import android.view.Menu
+import android.view.Window
+import androidx.annotation.RequiresApi
+
+open class SimpleWindowCallback(private val baseCallback: Window.Callback) :
+    Window.Callback by baseCallback {
+
+    override fun dispatchKeyEvent(event: KeyEvent?): Boolean {
+        return baseCallback.dispatchKeyEvent(event)
+    }
+
+    @RequiresApi(Build.VERSION_CODES.O)
+    override fun onPointerCaptureChanged(hasCapture: Boolean) {
+        baseCallback.onPointerCaptureChanged(hasCapture)
+    }
+
+    @RequiresApi(Build.VERSION_CODES.N)
+    override fun onProvideKeyboardShortcuts(
+        data: List<KeyboardShortcutGroup?>?,
+        menu: Menu?,
+        deviceId: Int
+    ) {
+        baseCallback.onProvideKeyboardShortcuts(data, menu, deviceId)
+    }
+}

app/src/main/java/us/shandian/giga/get/DownloadRunnableFallback.java

@@ -21,7 +21,7 @@ import static us.shandian.giga.get.DownloadMission.ERROR_HTTP_FORBIDDEN;
  * Single-threaded fallback mode
  */
 public class DownloadRunnableFallback extends Thread {
-    private static final String TAG = "DownloadRunnableFallback";
+    private static final String TAG = DownloadRunnableFallback.class.getSimpleName();
 
     private final DownloadMission mMission;
 

app/src/main/java/us/shandian/giga/get/sqlite/FinishedMissionStore.java

@@ -102,14 +102,23 @@ public class FinishedMissionStore extends SQLiteOpenHelper {
                 db.beginTransaction();
                 while (cursor.moveToNext()) {
                     ContentValues values = new ContentValues();
-                    values.put(KEY_SOURCE, cursor.getString(cursor.getColumnIndex(KEY_SOURCE)));
+                    values.put(
-                    values.put(KEY_DONE, cursor.getString(cursor.getColumnIndex(KEY_DONE)));
+                            KEY_SOURCE,
-                    values.put(KEY_TIMESTAMP, cursor.getLong(cursor.getColumnIndex(KEY_TIMESTAMP)));
+                            cursor.getString(cursor.getColumnIndexOrThrow(KEY_SOURCE))
-                    values.put(KEY_KIND, cursor.getString(cursor.getColumnIndex(KEY_KIND)));
+                    );
+                    values.put(
+                            KEY_DONE,
+                            cursor.getString(cursor.getColumnIndexOrThrow(KEY_DONE))
+                    );
+                    values.put(
+                            KEY_TIMESTAMP,
+                            cursor.getLong(cursor.getColumnIndexOrThrow(KEY_TIMESTAMP))
+                    );
+                    values.put(KEY_KIND, cursor.getString(cursor.getColumnIndexOrThrow(KEY_KIND)));
                     values.put(KEY_PATH, Uri.fromFile(
                             new File(
-                                    cursor.getString(cursor.getColumnIndex(KEY_LOCATION)),
+                                    cursor.getString(cursor.getColumnIndexOrThrow(KEY_LOCATION)),
-                                    cursor.getString(cursor.getColumnIndex(KEY_NAME))
+                                    cursor.getString(cursor.getColumnIndexOrThrow(KEY_NAME))
                             )
                     ).toString());
 
@@ -141,7 +150,8 @@ public class FinishedMissionStore extends SQLiteOpenHelper {
     }
 
     private FinishedMission getMissionFromCursor(Cursor cursor) {
-        String kind = Objects.requireNonNull(cursor).getString(cursor.getColumnIndex(KEY_KIND));
+        String kind = Objects.requireNonNull(cursor)
+                .getString(cursor.getColumnIndexOrThrow(KEY_KIND));
         if (kind == null || kind.isEmpty()) kind = "?";
 
         String path = cursor.getString(cursor.getColumnIndexOrThrow(KEY_PATH));

app/src/main/java/us/shandian/giga/ui/adapter/MissionAdapter.java

@@ -632,24 +632,23 @@ public class MissionAdapter extends Adapter<ViewHolder> implements Handler.Callb
         DownloadMission mission = h.item.mission instanceof DownloadMission ? (DownloadMission) h.item.mission : null;
 
         if (mission != null) {
-            switch (id) {
+            if (id == R.id.start) {
-                case R.id.start:
                 h.status.setText(UNDEFINED_PROGRESS);
                 mDownloadManager.resumeMission(mission);
                 return true;
-                case R.id.pause:
+            } else if (id == R.id.pause) {
                 mDownloadManager.pauseMission(mission);
                 return true;
-                case R.id.error_message_view:
+            } else if (id == R.id.error_message_view) {
                 showError(mission);
                 return true;
-                case R.id.queue:
+            } else if (id == R.id.queue) {
                 boolean flag = !h.queue.isChecked();
                 h.queue.setChecked(flag);
                 mission.setEnqueued(flag);
                 updateProgress(h);
                 return true;
-                case R.id.retry:
+            } else if (id == R.id.retry) {
                 if (mission.isPsRunning()) {
                     mission.psContinue(true);
                 } else {
@@ -660,30 +659,26 @@ public class MissionAdapter extends Adapter<ViewHolder> implements Handler.Callb
                         recoverMission(mission);
                 }
                 return true;
-                case R.id.cancel:
+            } else if (id == R.id.cancel) {
                 mission.psContinue(false);
                 return false;
             }
         }
 
-        switch (id) {
+        if (id == R.id.menu_item_share) {
-            case R.id.menu_item_share:
             shareFile(h.item.mission);
             return true;
-            case R.id.delete:
+        } else if (id == R.id.delete) {// delete the entry and the file
-                // delete the entry and the file
             mDeleter.append(h.item.mission, true);
             applyChanges();
             checkMasterButtonsVisibility();
             return true;
-            case R.id.delete_entry:
+        } else if (id == R.id.delete_entry) {// just delete the entry
-                // just delete the entry
             mDeleter.append(h.item.mission, false);
             applyChanges();
             checkMasterButtonsVisibility();
             return true;
-            case R.id.md5:
+        } else if (id == R.id.md5 || id == R.id.sha1) {
-            case R.id.sha1:
             final StoredFileHelper storage = h.item.mission.storage;
             if (!storage.existsAsFile()) {
                 Toast.makeText(mContext, R.string.missing_file, Toast.LENGTH_SHORT).show();
@@ -715,9 +710,7 @@ public class MissionAdapter extends Adapter<ViewHolder> implements Handler.Callb
                             })
             );
             return true;
-            case R.id.source:
+        } else if (id == R.id.source) {
-                /*Intent intent = new Intent(Intent.ACTION_VIEW, Uri.parse(h.item.mission.source));
-                mContext.startActivity(intent);*/
             try {
                 Intent intent = NavigationHelper.getIntentByLink(mContext, h.item.mission.source);
                 intent.addFlags(Intent.FLAG_ACTIVITY_PREVIOUS_IS_TOP);
@@ -726,9 +719,8 @@ public class MissionAdapter extends Adapter<ViewHolder> implements Handler.Callb
                 Log.w(TAG, "Selected item has a invalid source", e);
             }
             return true;
-            default:
-                return false;
         }
+        return false;
     }
 
     public void applyChanges() {

app/src/main/java/us/shandian/giga/ui/fragment/MissionsFragment.java

@@ -186,23 +186,24 @@ public class MissionsFragment extends Fragment {
 
     @Override
     public boolean onOptionsItemSelected(MenuItem item) {
-        switch (item.getItemId()) {
+        int itemId = item.getItemId();
-            case R.id.switch_mode:
+        if (itemId == R.id.switch_mode) {
             mLinear = !mLinear;
             updateList();
             return true;
-            case R.id.clear_list:
+        } else if (itemId == R.id.clear_list) {
             showClearDownloadHistoryPrompt();
             return true;
-            case R.id.start_downloads:
+        } else if (itemId == R.id.start_downloads) {
             mBinder.getDownloadManager().startAllMissions();
             return true;
-            case R.id.pause_downloads:
+        } else if (itemId == R.id.pause_downloads) {
             mBinder.getDownloadManager().pauseAllMissions(false);
             mAdapter.refreshMissionItems();// update items view
-            default:
+
             return super.onOptionsItemSelected(item);
         }
+        return super.onOptionsItemSelected(item);
     }
 
     public void showClearDownloadHistoryPrompt() {

app/src/main/res/drawable/ic_smart_display.xml

@@ -5,6 +5,6 @@
     android:viewportWidth="24"
     android:tint="@color/defaultIconTint">
     <path
-        android:pathData="M20 4H4c-1.1 0-2 .9-2 2v12c0 1.1.9 2 2 2h16c1.1 0 2-.9 2-2V6c0-1.1-.9-2-2-2zM9.5 16.5v-9l7 4.5-7 4.5z"
+        android:pathData="M20 4H4c-1.1 0-2 0.9-2 2v12c0 1.1 0.9 2 2 2h16c1.1 0 2-0.9 2-2V6c0-1.1-0.9-2-2-2zM9.5 16.5v-9l7 4.5-7 4.5z"
         android:fillColor="#FF000000"/>
 </vector>

app/src/main/res/layout-land/activity_player_queue_control.xml

@@ -122,8 +122,8 @@
                 android:focusable="true"
                 android:scaleType="fitCenter"
                 android:src="@drawable/exo_controls_rewind"
-                android:tint="?attr/colorAccent"
+                android:contentDescription="@string/rewind"
-                android:contentDescription="@string/rewind" />
+                app:tint="?attr/colorAccent" />
 
             <ImageButton
                 android:id="@+id/control_play_pause"
@@ -139,8 +139,8 @@
                 android:focusable="true"
                 android:scaleType="fitCenter"
                 android:src="@drawable/ic_pause"
-                android:tint="?attr/colorAccent"
+                android:contentDescription="@string/pause"
-                android:contentDescription="@string/pause" />
+                app:tint="?attr/colorAccent" />
 
             <ProgressBar
                 android:id="@+id/control_progress_bar"
@@ -172,8 +172,8 @@
                 android:focusable="true"
                 android:scaleType="fitCenter"
                 android:src="@drawable/exo_controls_fastforward"
-                android:tint="?attr/colorAccent"
+                android:contentDescription="@string/forward"
-                android:contentDescription="@string/forward" />
+                app:tint="?attr/colorAccent" />
         </RelativeLayout>
 
         <RelativeLayout
@@ -215,8 +215,8 @@
                 android:focusable="true"
                 android:scaleType="fitXY"
                 android:src="@drawable/ic_repeat"
-                android:tint="?attr/colorAccent"
+                android:contentDescription="@string/notification_action_repeat"
-                android:contentDescription="@string/notification_action_repeat" />
+                app:tint="?attr/colorAccent" />
 
             <View
                 android:id="@+id/anchor"
@@ -236,8 +236,8 @@
                 android:focusable="true"
                 android:scaleType="fitXY"
                 android:src="@drawable/ic_shuffle"
-                android:tint="?attr/colorAccent"
+                android:contentDescription="@string/notification_action_shuffle"
-                android:contentDescription="@string/notification_action_shuffle" />
+                app:tint="?attr/colorAccent" />
 
             <androidx.appcompat.widget.AppCompatImageButton
                 android:id="@+id/control_forward"

app/src/main/res/layout/activity_player_queue_control.xml

@@ -175,7 +175,7 @@
             android:focusable="true"
             android:scaleType="fitXY"
             android:src="@drawable/ic_repeat"
-            android:tint="?attr/colorAccent"
+            app:tint="?attr/colorAccent"
             tools:ignore="ContentDescription" />
 
         <androidx.appcompat.widget.AppCompatImageButton
@@ -205,7 +205,7 @@
             android:focusable="true"
             android:scaleType="fitCenter"
             android:src="@drawable/exo_controls_rewind"
-            android:tint="?attr/colorAccent" />
+            app:tint="?attr/colorAccent" />
 
         <ImageButton
             android:id="@+id/control_play_pause"
@@ -220,7 +220,7 @@
             android:focusable="true"
             android:scaleType="fitCenter"
             android:src="@drawable/ic_pause"
-            android:tint="?attr/colorAccent"
+            app:tint="?attr/colorAccent"
             tools:ignore="ContentDescription" />
 
         <ProgressBar
@@ -255,7 +255,7 @@
             android:focusable="true"
             android:scaleType="fitCenter"
             android:src="@drawable/exo_controls_fastforward"
-            android:tint="?attr/colorAccent" />
+            app:tint="?attr/colorAccent" />
 
         <androidx.appcompat.widget.AppCompatImageButton
             android:id="@+id/control_forward"
@@ -285,7 +285,7 @@
             android:focusable="true"
             android:scaleType="fitXY"
             android:src="@drawable/ic_shuffle"
-            android:tint="?attr/colorAccent"
+            app:tint="?attr/colorAccent"
             tools:ignore="ContentDescription" />
 
     </RelativeLayout>

app/src/main/res/values-bn-rIN/strings.xml

@@ -309,6 +309,6 @@
     <string name="notification_action_nothing">কিছু না</string>
     <string name="yes">হ্যাঁ</string>
     <string name="no">না</string>
-    <string name="search_with_service_name">সার্চ</string>
+    <string name="search_with_service_name">সার্চ %1$s</string>
-    <string name="search_with_service_name_and_filter">খুঁজুন</string>
+    <string name="search_with_service_name_and_filter">খুঁজুন %1$s (%2$s)</string>
 </resources>

gradle.properties

@@ -1,4 +1,3 @@
-android.nonFinalResIds=false
 android.useAndroidX=true
 org.gradle.jvmargs=-Xmx2048M --add-opens jdk.compiler/com.sun.tools.javac.model=ALL-UNNAMED
 systemProp.file.encoding=utf-8