mirrors/NewPipe
1
0
Fork 0
mirror of https://github.com/TeamNewPipe/NewPipe synced 2024-11-16 23:04:56 +00:00
Code Issues Releases Wiki Activity
10,676 Commits 8 Branches 134 Tags 134 MiB
4e837e838d
Commit Graph

3714 Commits

Author SHA1 Message Date
Jared Fantaye
1dd0930b83 Fixed some small issues 2023-02-28 17:30:17 +01:00
Jared Fantaye
265de55a07 Merge remote-tracking branch 'origin/1473_remove_duplicates_from_playlist' into 1473_remove_duplicates_from_playlist 2023-02-28 16:44:13 +01:00
Jared Fantaye
d8ed2c8503 Refactoring removeDuplicates function and preventing concurrent calls. 2023-02-28 16:43:58 +01:00
Stypox
73aebc1110
Merge pull request #9847 from Redirion/exo183 
Update to ExoPlayer 2.18.3
 2023-02-26 19:16:25 +01:00
Stypox
a4767fc48a
Listen to ignore hardware buttons pref changes 2023-02-26 14:28:57 +01:00
Nyan Cat
42d861688e
Implement Ignore hardware media button events option 2023-02-26 14:02:50 +01:00
Stypox
2ee4c6e289
Merge pull request #9728 from mahendranv/channel_card 
Larger channel cards in search results
 2023-02-26 13:43:09 +01:00
Stypox
097c2368f4
Merge pull request #8180 from Trust04zh/fix-4053-8176 
Make UI behavior for playback information display more consistent
 2023-02-26 13:22:13 +01:00
Stypox
80e0c6ab0e
Merge pull request #9755 from Jared234/9458_faulty_playlist_thumbnail_update 
Fixed a bug that caused erroneous updates of the playlist thumbnails
 2023-02-26 13:13:12 +01:00
Jared Fantaye
9067c770a7 Made some small code improvements 2023-02-25 22:14:49 +01:00
Stypox
4b050c0dd8
Merge pull request #9850 from Stypox/fix-api33-links-again3 
[Android 11+] Correctly open URLs in browser and fix opening downloads and external players
 2023-02-25 14:33:41 +01:00
Stypox
be4f3d9d62
Improve javadocs in ShareUtils 2023-02-25 13:14:31 +01:00
Stypox
24ff6a4313
Rename videoURL to streamUrl 2023-02-25 13:14:31 +01:00
Stypox
c2968a3ff2
Use non-deprecated resolveActivity method on API 33+ 
But such method is not available before API 33
 2023-02-25 13:14:31 +01:00
Stypox
600ebdae18
Correctly open urls in browser on Android 11+ 
- Fix misconfiguration in manifest ('http|https|market' is not valid)
- Split ShareUtils functions taking a boolean parameter into pairs of functions with better names and less runtime checks
- Move all Kore-related functions to KoreUtils
- Remove the toast_no_player string
 2023-02-25 09:13:59 +01:00
Robin
5560cea470 Update to ExoPlayer 2.18.3 2023-02-23 12:46:05 +01:00
Stypox
39c500f33c
Revert "Use WindowCompat." 2023-02-14 08:27:04 +01:00
pratyaksh1610
624ad6a47c
Prevent NPEs when comment text is null 2023-02-14 08:18:13 +01:00
Jared Fantaye
68ea99d6e6 Made some small code improvements 2023-02-09 23:17:36 +01:00
Jared Fantaye
bc29f40d69 Implemented the suggested changes 2023-02-09 21:18:21 +01:00
Jared234
42fb13f17a
Merge branch 'dev' into 1473_remove_duplicates_from_playlist 2023-02-09 20:47:10 +01:00
Jared Fantaye
d5b54c85ed Made some small adjustments to the database query 2023-02-09 20:41:22 +01:00
Mahendran
75292e099c Larger channel cards in search results 
- Thumbnail larger (100dp) than the usual (92dp) throughout the app
- Description lint count is 8 (normally 3)
 2023-02-09 06:15:22 +05:30
Stypox
e0cb2892b8
Merge branch 'master' into dev 2023-02-08 22:48:14 +01:00
Stypox
4cc653fdf1
Fix opening links on Android 12+ 2023-02-07 22:39:12 +01:00
Stypox
4c5c2a3d79
Merge pull request #9693 from Redirion/accelerometerfix 
Orientation is locked if there is no sensor for it
 2023-02-07 20:07:45 +01:00
Trust_04zh
e947e86eae
Make positions in list depend on watch history, remove confusing animations 
The following is the list of all commits squashed together:

Regain function for option `Positions in lists`

use option `Resume playback` to control display of progress info in VideoDetailFragment, remove this (extra) function from option `Positions in lists`.
remove extra check for live streams, live streams updates just as non-live streams.

fix #8176 by eliminating exit delay

Regain function for option `Positions in lists`

update code with developer's comments

 apply static import to methods in util class DependentPreferenceHelper

Regain function for option `Positions in lists`

use option `Resume playback` to control display of progress info in VideoDetailFragment, remove this (extra) function from option `Positions in lists`.
remove extra check for live streams, live streams updates just as non-live streams.

fix behavior for displaying progress bar when autoplay off but video resume on

not to retrieve unnecessary states when position in lists disabled

fix mistake in code

simplify conditional logic

update doc comment and remove unused method

Fix not showing duration if position indicators disabled

Positions in lists only depends on watch history
 2023-02-07 09:48:18 +01:00
Jared Fantaye
5d3955854e Fixed the merge conflict 2023-02-05 21:21:02 +01:00
Jared234
3ff4b713e8
Merge branch 'dev' into 9458_faulty_playlist_thumbnail_update 2023-02-05 20:45:44 +01:00
Jared Fantaye
68097568d5 Fixed the bug by replacing the thumbnail_url with the thumbnail_stream_id 2023-02-05 20:32:34 +01:00
Jared Fantaye
cd8d57040c Implemented the feature using multiple checkboxes 2023-02-04 18:48:27 +01:00
Tobi
e0ba872b66 Revert "Update ExoPlayer to 2.18.2" 
This commit reverts 1bb166a
 2023-02-03 18:33:35 +01:00
Jared Fantaye
9c82441c19 Implemented the feature and fixed some small issues 2023-02-01 23:10:31 +01:00
Jared Fantaye
d2d324f2dd First draft of the new feature 2023-01-30 22:37:24 +01:00
Stypox
ca421c28a1
Merge pull request #9538 from Jared234/4186_warning_duplicates_in_playlist 
Handle duplicate streams in the "Add to playlist" dialog
 2023-01-29 10:36:31 +01:00
Stypox
102975aeb3
Improve handling playlist duplicate indicator 2023-01-29 10:32:32 +01:00
Stypox
cd12503f99
Merge pull request #9631 from TeamNewPipe/update-npe 
Update NewPipeExtractor and properly linkify comments
 2023-01-28 22:40:19 +01:00
Stypox
1e724eba6c
Merge pull request #9706 from Jared234/9131_bug_background_player 
Fixed a bug that caused the background player to stop working
 2023-01-28 21:56:00 +01:00
Jared Fantaye
c70ce791db Added the duplicate indicator explanation & removed some unnecessary functions 2023-01-27 15:37:33 +01:00
Jared Fantaye
5b3f8a3d30 Replaced the equals method 2023-01-21 14:56:55 +01:00
Jared Fantaye
e26c038565 Made some small adjustments 2023-01-20 11:55:50 +01:00
Jared Fantaye
ddda80a577 Fixed the bug 2023-01-17 22:31:22 +01:00
TobiGr
e9fcad4787 Fix SonarLint 2023-01-16 23:20:50 +01:00
TobiGr
640d4b0280 Fix more NPEs after OnSharedPreferenceChangeListener changes 2023-01-16 23:05:29 +01:00
Stypox
b9378a7c1f
Fix NPEs after OnSharedPreferenceChangeListener changes 
Apps targeting {@link android.os.Build.VERSION_CODES#R} on devices running OS versions {@link android.os.Build.VERSION_CODES#R Android R} or later, will receive a {@code null} value when preferences are cleared.
 2023-01-16 22:30:28 +01:00
Robin
9ecd5dff09 Orientation is locked if there is no sensor for it 2023-01-16 13:56:45 +01:00
Stypox
abe6dfb99c
Merge pull request #9671 from Stypox/fix-toast-crash-api33 
Fix popup enablement toast crash on API 33
 2023-01-15 21:05:05 +01:00
Stypox
6e73c489de
Improve ellipsizing comments 2023-01-15 19:28:01 +01:00
Stypox
489df0ed7d
Update NewPipeExtractor and properly linkify comments 2023-01-15 19:27:56 +01:00
Mahendran
7924bb5b6b Thumbnails used in NewPipe are small (list/grid) mode. This PR facilitates full width thumbnails and dubbed as card mode. 2023-01-15 22:32:03 +05:30
Stypox
c47d1af5e3
Merge pull request #9555 from Marius1501/make_the_channel_images_bigger 
Made the channel-images in the grid list bigger
 2023-01-15 15:16:09 +01:00
Stypox
51af961e0d
Merge pull request #8894 from Isira-Seneviratne/WindowCompat 
Use WindowCompat.
 2023-01-15 15:14:05 +01:00
Stypox
86997794ab
Merge pull request #9678 from Marius1501/change_whats_new_icon 
Changed the What's New icon
 2023-01-15 15:12:26 +01:00
Stypox
22c201be39
Create text subpackage in util 2023-01-15 11:51:07 +01:00
AudricV
cdd5e89b86
Add ability to copy hashtags, URLs and timestamps in descriptions on long-press 
This commit adds the ability to copy to clipboard hashtags, URLs and timestamps
when long-pressing them.

Some changes in our TextView class related to text setting have been required
and metadata items are now using a NewPipeTextView instead of a standard
TextView.

Six new classes have been added:

- a custom LinkMovementMethod class;
- a custom ClickableSpan class, LongPressClickableSpan, in order to set a long
  press event;
- a class to avoid code duplication in CommentTextOnTouchListener, TouchUtils;
- three implementations of LongPressClickableSpan used when linkifying text:
  - HashtagLongPressClickableSpan for hashtags;
  - TimestampLongPressClickableSpan for timestamps;
  - UrlLongPressClickableSpan for URLs.
 2023-01-15 11:40:27 +01:00
ge78fug
764b6aa2b1
Made the channel-images in the grid list bigger 
Also improved the handling of additional information (expanded description, video count, subscriber count)
 2023-01-15 10:50:20 +01:00
Isira Seneviratne
f766ef2033 Replace the system UI visibility flags with WindowCompat calls. 2023-01-15 05:44:45 +05:30
Stypox
ef4a6238c8
See if playlists already contain a stream from db 2023-01-14 18:01:48 +01:00
Jared Fantaye
b3554a6a49
Added the number of duplicates to the toast text. 2023-01-14 18:01:48 +01:00
Jared Fantaye
5fb7b3266b
Removed the duplicate dialog and added another toast option 2023-01-14 18:01:48 +01:00
Jared Fantaye
8b6e110635
Fixed the functionality, improved performance & general code cleanup 2023-01-14 18:01:47 +01:00
Jared Fantaye
f5a1f915be
Continued working on a way to show that items are already in a playlist 2023-01-14 18:01:47 +01:00
Jared Fantaye
ac15339911
Started working on a way to show that items are already in a playlist 2023-01-14 18:01:47 +01:00
Jared Fantaye
fdfeac081a
Implemented a warning before adding duplicate to playlist. 2023-01-14 18:01:46 +01:00
ge78fug
31396a632f Chenged the name of the icon 2023-01-14 09:21:37 +01:00
Jared Fantaye
135fc08212 Implemented the "remove duplicates" feature. 2023-01-13 21:35:22 +01:00
ge78fug
5e3caf68a5 Chenged the What's New icon 2023-01-13 16:33:45 +01:00
Stypox
262b3a2945
Merge pull request #9664 from Marius1501/whats_new_section_to_default_tabs 
Added the "What's New"-section to the default tabs
 2023-01-13 13:25:02 +01:00
Stypox
e44d09208c
Merge pull request #9642 from Jared234/8582_empty_playlists_not_shown 
Fixed a bug that prevented the display of multiple empty playlists
 2023-01-13 13:20:42 +01:00
Jared Fantaye
38c4a1ed85
Fixed the "Remove Watched" bug 
Reverted changes and fixed bug in a different way
 2023-01-12 23:44:26 +01:00
Stypox
fd8e92cf77
Merge pull request #9523 from Jared234/9468_permanently_set_thumbnail 
Allow the user to permanently set a thumbnail
 2023-01-12 23:27:50 +01:00
Stypox
062570cc47
Merge pull request #8886 from Isira-Seneviratne/Remove_Runnable_variables 
Remove Runnable variables for Handlers.
 2023-01-12 15:34:12 +01:00
Isira Seneviratne
9514316be3
Remove Runnable variables for Handlers. 2023-01-12 15:30:19 +01:00
Stypox
a15a5adacc
Merge pull request #9619 from Redirion/avoidreflectionifpossible 
Check availability of Samsung DeX only on Samsung devices
 2023-01-12 12:06:19 +01:00
Stypox
b6e6d39985
Fix toast crash on API 33 
You shouldn't call getView() on toasts.
Also simplified some duplicate code.
 2023-01-12 11:39:25 +01:00
Stypox
48ae830262
Merge pull request #9653 from petlyh/fix-popup-crash 
Ask for permission when enqueuing in a popup
 2023-01-12 11:24:21 +01:00
Stypox
03f5dd71a5
Merge pull request #9499 from pratyaksh1610/branch-9466 
Added Language suffix for subtitle downloads
 2023-01-11 19:46:51 +01:00
Stypox
2afbe58722
UX improvements: keep user edits & do not reset cursor 2023-01-11 19:45:55 +01:00
ge78fug
0a64eac778 Added the "What's New"-section to the default tabs 2023-01-11 16:06:11 +01:00
Stypox
ad605e2c5a
Actually there is no need to use flatMap 
`null` values returned in the lambda are converted to empty `Optional`s in the `map` method: https://developer.android.com/reference/java/util/Optional#map(java.util.function.Function%3C?%20super%20T,%20?%20extends%20U%3E)
 2023-01-11 15:26:46 +01:00
Stypox
944e295ae7
Use Optional for simpler code 2023-01-11 15:14:18 +01:00
devlearner
28109fef38
Improve showing of toast 
We provide visual feedback via a toast to the user that, well, they're supposed to wait; but with the benefit of the cache openAddToPlaylistDialog() may return (almost) immediately, which would render the toast otiose (if not a bit confusing). This commit improves that by cancelling the toast once the wait's over

... (by 'abusing' RxJava's ambWith();
ref on compose() and Transformer: https://blog.danlew.net/2015/03/02/dont-break-the-chain/
and for me, first time laying my hands at RxJava so kindly bear with me; open for suggestions)
 2023-01-11 14:53:48 +01:00
devlearner
40442f3f82
Utilize Lifecycle observer 
I thought it would have required an extra dependency; apparently that doesn't seem to be the case...
 2023-01-11 14:53:48 +01:00
devlearner
61da167b4f
Oops, added back missing return; 2023-01-11 14:53:48 +01:00
devlearner
c744f6756b
Fix Sonar reported code smell 2023-01-11 14:53:48 +01:00
devlearner
de7057ac3a
Skip REORDER_TO_FRONT trick which doesn't seem to work on newer Androids 
probably due to background restrictions on Android 10+
 2023-01-11 14:53:48 +01:00
devlearner
585bfff11d
Utilize a retained fragment to safekeep network requests in flight 
pending result for openAddToPlaylistDialog() and openDownloadDialog()
Despite marked deprecated, setRetainInstance(true) is probably our best bet (since a ViewModel is probably too overkill for our present purpose)
 2023-01-11 14:53:48 +01:00
devlearner
0f9c20c986
Improve (un)registering FragmentLifecycleCallbacks 
to avoid adding it multiple times and ensure proper cleanup
 2023-01-11 14:53:48 +01:00
devlearner
f860392ae9
Address LayoutParams.FLAG_NOT_TOUCHABLE restriction on Andriod 12+ 2023-01-11 14:53:48 +01:00
devlearner
391830558e
Ensure our transparent activity doesn't block touch events to underlying windows 
so we won't hold up UI while fetching media info for Add to Playlist or Download actions
lest user might think it freezes when in fact a network request is underway
 2023-01-11 14:53:48 +01:00
devlearner
c1f37d8591
Also show toast in openDownloadDialog() 
and lengthened a bit to inform user to wait...
 2023-01-11 14:53:48 +01:00
devlearner
b175774ad8
Try to amicably handle DialogFragment in FragmentManager when recreated from orientation change 
- Handle finish() call instead of passing around callbacks to setOnDismissListener()
- Don't start over again if returning to DialogFragment before orientation change
 2023-01-11 14:53:48 +01:00
devlearner
73e32889b6
Don't finish() to allow recreate 
when orientation change is on foot
 2023-01-11 14:53:48 +01:00
devlearner
400ee808e0
Set up theme/locale before super.create() 
This seems to solve a bug where the Open action menu dialog does not appear the first time on cold start on older Android (8.0).
This is also the order of things in MainActivity and probably good practice.
 2023-01-11 14:53:48 +01:00
Stypox
9c7ed80662
Use Optional.map correctly and other improvements 2023-01-11 14:47:53 +01:00
Jared Fantaye
eb3363d4dd Created the first draft. 2023-01-10 20:55:18 +01:00
petlyh
edff696ecc
Ask for permission when enqueuing in a popup 2023-01-10 14:16:19 +01:00
Jared Fantaye
9c19e9813a Fixed a bug that caused multiple empty playlists to be not shown. 2023-01-08 11:53:42 +01:00
Jared Fantaye
2679a4bf1e Removed the "Unset Thumbnail" item if you can't use this feature 2023-01-04 16:21:16 +01:00
Isira Seneviratne
e8216b2e80 Apply code review suggestions. 2023-01-04 06:10:14 +05:30