Isira Seneviratne
c7d392e77e
Merge branch 'dev' into Refactor_VideoDetailFragment
2022-12-06 20:21:28 +05:30
Isira Seneviratne
161007fe92
Merge branch 'dev' into Refactor_VideoPlayerUi
2022-12-06 20:21:08 +05:30
Jared Fantaye
5fc85fa2e0
Implemented suggestions
2022-12-05 21:21:46 +01:00
Stypox
a6f57a8665
Merge pull request #9173 from Theta-Dev/video-sub-count
...
Show subscriber count on video details page
2022-12-04 20:50:13 +01:00
ThetaDev
86ee94eb04
show subscriber count on player page
2022-12-04 20:45:09 +01:00
Jared Fantaye
0923594e51
Added option to download items in the queue
2022-12-04 20:35:06 +01:00
Stypox
3bb51875bc
Merge pull request #9501 from Stypox/import-subscriptions-hint
...
Add hint to improve discoverability of subscription import
2022-12-04 20:19:19 +01:00
Stypox
10977eaefa
Show hint about how to import subscriptions when there are none
2022-12-04 19:16:47 +01:00
Stypox
281ac13eed
Merge pull request #8883 from Douile/dev-enqueue-next-hide
...
Only show "Enqueue next" when in the middle of the queue
2022-12-04 18:43:45 +01:00
Douile
e5f30a07bf
Only show "Enqueue next" when in the middle of the queue
...
Add a check that the queue position is not the last in the queue before
showing "Enqueue next".
Previously the "Enqueue next" action would always be shown if the queue
length was greater than one, this meant even if you were at the end of
the queue (when "Enqueue" would have the same effect as "Enqueue next")
the action would still be shown.
2022-12-04 18:20:50 +01:00
Stypox
9c4d5526f4
Merge pull request #8810 from Isira-Seneviratne/Math_floorDiv
...
Use Math.floorDiv().
2022-12-04 18:08:12 +01:00
pratyaksh1610
1afb9cdba9
added Language suffix for subtitle downloads
2022-12-04 17:59:22 +05:30
Isira Seneviratne
6b210e1542
Apply ktlint formatting.
2022-12-04 12:01:57 +01:00
Isira Seneviratne
f1b15a95a4
Show toast when no updates are available.
...
Co-authored-by: Stypox <stypox@pm.me>
2022-12-04 12:01:56 +01:00
Jared Fantaye
a2f2d562f6
Disabling night theme selection if auto theme is not used
2022-12-01 13:01:58 +01:00
Isira Seneviratne
b0516fbf1d
Use BitmapCompat.createScaledBitmap().
2022-11-29 15:56:19 +01:00
Stypox
9d01d88eed
Request permission to send notifications
2022-11-28 18:49:11 +01:00
AudricV
6b89b44dcd
Merge pull request #8961 from dhruvpatidar359/Toast-Popup
...
Remove the redundant/overlapping toast "Copied to clipboard" for Android 13+
2022-11-26 21:33:12 +01:00
Jared Fantaye
e5af1c93ae
Seeking no longer pauses the played video
2022-11-26 15:35:13 +01:00
Isira Seneviratne
d6617007d4
Use SparseArrayCompat instead of SparseArray in StreamItemAdapter.
...
Make additional small improvements as well.
2022-11-22 18:31:58 +05:30
Isira Seneviratne
8db90ba449
Use SparseArrayCompat for thumbnails.
2022-11-22 17:51:54 +05:30
Stypox
048b0972de
Set compileSdk and targetSdk to 33 (Android 13)
...
android:exported in now required in the manifest on all activities/services/receivers/providers. It was set to true for those that need to interact with outside apps or the OS, while others have exported=false.
This also required updating LeakCanary to the latest version as the older version being used was not using android:exported in AndroidManifest.xml.
2022-11-18 08:33:13 +01:00
Isira Seneviratne
a7989795e8
Merge branch 'dev' into Refactor_VideoPlayerUi
2022-11-14 08:59:03 +05:30
Isira Seneviratne
a40f035810
Merge branch 'dev' into Refactor_VideoDetailFragment
2022-11-14 08:58:45 +05:30
Isira Seneviratne
aad5e26f31
Merge pull request #8870 from Isira-Seneviratne/Locale_forLanguageTag
...
Use Locale.forLanguageTag().
2022-11-10 19:56:34 +05:30
Tobi
627c6e29a2
Merge pull request #8316 from han-sz/fix_video_mouse_hover_overlay
...
Fix persistent hover overlay when in desktop/DeX mode or using a mouse/non-touch input
2022-11-09 17:10:01 +01:00
TobiGr
ef1e7e5b52
Merge branch 'master' into dev
2022-11-09 16:45:22 +01:00
AudricV
abf1cc536d
Improve code of DeviceUtils.isDesktopMode
...
- Avoid NullPointerException crashes if there is no UiModeManager or desktop
system service mode
- Use final for every exception
- Suppress missing fields warnings
- Add missing NonNull annotation
2022-11-09 16:22:49 +01:00
cybersphinx
c38f150562
Remove now obsolete API check.
2022-11-09 15:50:09 +01:00
cybersphinx
d2b6bda7a2
Remove errant return.
2022-11-09 15:50:09 +01:00
cybersphinx
9e5c68c575
Add check for input devices with cursor.
2022-11-09 15:50:06 +01:00
Hanif Shersy
88eed6cc23
Add JSDoc comment and a performance note for isDesktopMode
2022-11-09 15:48:50 +01:00
Hanif Shersy
a1773d166f
Fix JSDoc checkstyle warning
2022-11-09 15:44:36 +01:00
Hanif Shersy
5e2ef7ff0d
Address review comments
2022-11-09 15:44:36 +01:00
Hanif Shersy
cfda073aa5
Fix DeX mode check
2022-11-09 15:44:36 +01:00
Hanif Shersy
ff774a1870
Fix persistent hover overlay when mouse connected
2022-11-09 15:44:27 +01:00
Isira Seneviratne
feb03f7e30
Use Math.floorDiv().
2022-11-09 20:01:40 +05:30
Isira Seneviratne
5c1af6d296
Group private Localization methods together.
2022-11-09 08:54:47 +05:30
Isira Seneviratne
6d812b86aa
Use Locale.forLanguageTag().
2022-11-09 08:51:12 +05:30
dhruvpatidar359
ef35b36eba
Remove the redundant/overlapping toast "Copied to clipboard" for Android 13+
...
Signed-off-by: dhruv <dhruvpatidar35@gmail.com>
Co-authored-by: Tobi <TobiGr@users.noreply.github.com>
Co-authored-by: AudricV <74829229+AudricV@users.noreply.github.com>
2022-11-08 20:47:50 +01:00
Isira Seneviratne
3dc1adb69e
Add helper methods for adding PendingIntent mutability.
2022-11-07 17:12:22 +05:30
Tobi
da61c9f915
Merge pull request #9298 from Stypox/fix-inconsistent-channel-groups
...
Fix inconsistent channel group list and items view mode
2022-11-05 21:11:51 +01:00
Stypox
9472c36cbd
Merge pull request #9109 from TeamNewPipe/fix/overlayPlayQueueButton
...
Hide play queue button in VideoDetailsFragment when queue is empty
2022-11-05 20:28:14 +01:00
Stypox
49c12a31e9
Fix wrongly calculated channel groups span count
2022-11-05 20:05:59 +01:00
Stypox
fc061599f8
Fix inconsistent channel group list and item view mode
2022-11-04 18:21:35 +01:00
Tobi
c8caf48cda
Merge pull request #9230 from Stypox/duplicate-feed-videos
...
Fix duplicate videos in feed group "All"
2022-11-03 17:23:05 +01:00
Isira Seneviratne
e4f97465a4
Use lambdas for VideoDetailFragment listeners.
2022-11-03 20:15:17 +05:30
Isira Seneviratne
e333197ed5
Use OnClickListener and OnLongClickListener lambdas in the player UIs.
2022-11-03 05:09:35 +05:30
Isira Seneviratne
51bdc30ed0
Use TextViewCompat.setCompoundDrawableTintList().
2022-11-01 06:31:35 +05:30
Stypox
9d2ab61993
Merge pull request #9203 from Callisto404/add-chapter-timestamp-share
...
Added timestamped link sharing from the start of a chapter with a long hold press
2022-10-30 22:31:09 +01:00
Stypox
8fdd828de4
Merge pull request #8739 from Isira-Seneviratne/Stream_average
...
Calculate search score using streams.
2022-10-30 22:09:55 +01:00
Stypox
25795c3a96
Merge pull request #8706 from Isira-Seneviratne/Improve_LocalPlaylistFragment
...
Refactor removeWatchedStreams() in LocalPlaylistFragment.
2022-10-30 22:03:39 +01:00
Daniel M
7f3da04fee
Added an "isYouTube" check to start of long click handler
2022-10-30 13:48:03 +11:00
Stypox
9524c6245d
Merge pull request #8747 from Isira-Seneviratne/Range_limit
...
Use range-limiting methods in more places.
2022-10-28 10:34:04 +02:00
Stypox
57d2fe113a
Fix duplicate videos in feed "All"
2022-10-27 23:43:39 +02:00
Stypox
2f6cb87bba
Use GROUP_ALL_ID instead of hardcoded -1
2022-10-27 23:32:19 +02:00
Stypox
3cef7f3201
Merge pull request #9207 from cern1710/list-view-alt-alt-implementation
...
undefined
2022-10-27 22:48:03 +02:00
Samuel Wu
f712ea34e0
Merge remote-tracking branch 'origin/list-view-alt-alt-implementation' into list-view-alt-alt-implementation
2022-10-28 04:54:42 +11:00
Samuel Wu
a44b7c9c9e
Disabled animations for subscription fragment
2022-10-28 04:54:33 +11:00
Stypox
4b32890b5f
Fix random crash in SubscriptionFragment
2022-10-27 18:45:06 +02:00
Stypox
a41aa01461
Solve two SonarCloud smells
2022-10-27 17:52:17 +02:00
Stypox
ea875c59af
Deduplicate isGridLayout calls
2022-10-27 17:25:06 +02:00
YonghaoDeng
a22162ffac
Add an Open in browser button on error panel ( #9180 )
...
* add a open in browser button
* Corrected a few things that needed to be changed
* Remove unneeded changes.
* Remove unneeded changes.
* Add showAndSetOpenInBrowserButtonAction function
* modify some codes
2022-10-27 14:38:08 +02:00
Stypox
83d16dc656
Fix flickering in channel groups list
2022-10-27 14:01:04 +02:00
Stypox
8ceefee1e3
Put "New feed group" item at the top
2022-10-27 13:51:56 +02:00
Samuel Wu
8f157be7e0
Revert changes
2022-10-27 12:15:36 +11:00
Stypox
0e169951f7
Fix grid/list toggle implementation of feed
2022-10-26 23:20:32 +02:00
Samuel Wu
f7e10eb094
Fully working card and list view
2022-10-26 21:05:55 +11:00
Jfax510
0d73d193ad
Added Toast Notification "Hold to enqueue" ( #9196 )
...
* Added Toast Notification "Hold to enqueue"
* Check if enqueue tips are enabled
* created function showHoldToAppendTipIfNeeded() for toast message
2022-10-26 11:35:03 +02:00
plasticanu
40815086ad
Fix crash when the user clicks download then quits the history fragment ( #9143 )
...
* Fix crash when the user clicks download then quits the history fragment
* add a nonnull annotation to the context parameter in the DownloadDialog constructor.
* Revert "Merge branch 'TeamNewPipe:dev' into fix/HistoryFragmentDownloadDialogCrash"
This reverts commit 968d7a7603968d7a760352963ba37dfb3ed83d51f9e1835e71
2022-10-26 11:22:32 +02:00
Yuuu2990
16860603fd
Add Link to FAQ in the app ( #9164 )
...
* Link to FAQ in the app #4447
* remove redundant comments produced by me.
* Update app/src/main/res/values/strings.xml
Update FAQ description
Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
* Format the CodeStyle and readjust the layout.
* Update app/src/main/res/layout/fragment_about.xml
Remove redundant id.
Co-authored-by: Stypox <stypox@pm.me>
* Update app/src/main/res/layout/fragment_about.xml
Remove redundant id.
Co-authored-by: Stypox <stypox@pm.me>
* Update app/src/main/res/values/strings.xml
Keep the uppercase for consistency.
Co-authored-by: Stypox <stypox@pm.me>
* Update app/src/main/res/values/strings.xml
Modify the description of FAQ.
Co-authored-by: Stypox <stypox@pm.me>
Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
Co-authored-by: Stypox <stypox@pm.me>
2022-10-26 09:59:51 +02:00
Samuel Wu
c607089cbb
Altered grid view similar to Youtube app layout
2022-10-26 00:06:48 +11:00
Samuel Wu
28464344c1
Finalized design for vertical card view and removed unneeded variables in SubscriptionFragment.kt
2022-10-25 11:43:25 +11:00
Samuel Wu
ed68e3bd46
Fully working toggle button that change between vertical and horizontal view
2022-10-25 10:54:27 +11:00
Samuel Wu
082d7a3f18
Added working binding for a "new" button that works in the list layout.
2022-10-25 02:38:31 +11:00
Samuel Wu
6eddaa0d38
Added boolean to handle feed groups. May need a better solution for this
2022-10-25 02:20:14 +11:00
Samuel Wu
1aa1a0287e
Could toggle between list view and grid view...once. Requires bug fixing on refreshing
2022-10-25 02:01:57 +11:00
Samuel Wu
3bfcb16f9a
Bug: SubscriptionViewModel.kt did not map values for FeedGroupCardVerticalItem in line 26
2022-10-25 00:32:21 +11:00
Samuel Wu
f37d869ea2
Button can be toggled but not all strings have been fed
2022-10-24 23:01:02 +11:00
Samuel Wu
78547b4fa4
Created a list view for channel group.
2022-10-24 18:55:08 +11:00
Samuel Wu
29e56b9f2d
Created a button in SubscriptionFragment.kt that reads whether button is clicked
2022-10-24 16:55:12 +11:00
Daniel M
83357ca67e
Added sharing a link with timestamp from a chapter into the long click for each chapter
2022-10-24 14:14:41 +11:00
Samuel Wu
8482bf9fed
Created a non-functional button in HeaderWithMenuItem.kt
2022-10-23 23:43:52 +11:00
TobiGr
4a278ef102
Hide play queue button in VideoDetailsFragment mini player when the play queue is empty
...
Related PR introducing the button: #8946
2022-10-11 21:27:04 +02:00
Tobi
7ab8f9f112
Merge pull request #9079 from devlearner/fix-screen-rotate
...
Fix `DownloadDialog` crash on screen rotation
2022-10-10 11:18:50 +02:00
Tobi
7fca0e0786
Merge pull request #9065 from devlearner/fix-spannable-cast
...
Fix potential cast exception in comments text
2022-10-10 10:51:32 +02:00
Tobi
ed4eb124e4
Merge pull request #8734 from Stypox/feed-group-factory
...
Improve `FeedGroupDialogViewModel` factory
2022-10-09 19:35:47 +02:00
Tobi
5b213a19e4
Merge pull request #8934 from Isira-Seneviratne/LinkifyCompat
...
Use LinkifyCompat.
2022-10-09 12:07:50 +02:00
Tobi
8bc8355b68
Merge pull request #8946 from HybridAU/add_play_queue_button_to_video_details_fragment
...
Add play queue button to video details fragment
2022-10-06 18:55:50 +02:00
devlearner
ab99c14fd2
Fix crash on screen rotation
2022-10-06 18:15:36 +08:00
devlearner
1047158a66
Fix potential cast exception
...
when casting to `Spannable` in `CommentTextOnTouchListener`
2022-10-04 17:31:35 +08:00
Stypox
489f052ef9
Fix feed menu tooltips (silly copy-paste error)
2022-09-19 11:21:42 +02:00
Stypox
bf55ed262f
Merge pull request #8972 from Stypox/fix-suggestions-listadapter
...
Fix various issues in the search suggestions list
2022-09-19 08:54:55 +02:00
Stypox
f26bf33ead
Merge pull request #8966 from Stypox/feed-menuitem-tooltip
...
Show correct tooltips for actions in feed
2022-09-19 08:54:06 +02:00
HybridAU
9db0133a5b
Add play queue button to video details fragment
...
* Add play queue button to video details fragment
* Use existing ic_list icon
* Still open play queue even when queue is empty
* Change app:srcCompat to android:src
2022-09-14 21:00:44 +08:00
Stypox
28b34f3796
Fix scroll issues in suggestion list
...
Before if the list before updating contained item 'test' at position 0 and after updating that value went to the bottom, the list would incorrectly scroll to the bottom to follow that item. Now the scrolling is done after the list is updated.
2022-09-14 14:39:32 +02:00
Stypox
1f57c87859
Disable suggestion list animations: not meaningful
...
The animations were just in the way and did not help in choosing items, since the suggestion items keep changing too much.
2022-09-14 14:04:22 +02:00
Stypox
fbf5549182
Fix wrong icons being set on suggestion items
...
The diff util wrongly considered as equal two items with the same text but with different `fromHistory` value
2022-09-14 14:01:59 +02:00
Stypox
051c572e7f
Show correct tooltips for actions in feed
2022-09-13 15:26:04 +02:00
Isira Seneviratne
464a646671
Use LinkifyCompat.
2022-09-06 09:27:50 +05:30
