3485 Commits

Author	SHA1	Message	Date
Stypox	48ae830262	Merge pull request #9653 from petlyh/fix-popup-crash ... Ask for permission when enqueuing in a popup	2023-01-12 11:24:21 +01:00
Stypox	03f5dd71a5	Merge pull request #9499 from pratyaksh1610/branch-9466 ... Added Language suffix for subtitle downloads	2023-01-11 19:46:51 +01:00
Stypox	2afbe58722	UX improvements: keep user edits & do not reset cursor	2023-01-11 19:45:55 +01:00
Stypox	ad605e2c5a	Actually there is no need to use flatMap ... `null` values returned in the lambda are converted to empty `Optional`s in the `map` method: https://developer.android.com/reference/java/util/Optional#map(java.util.function.Function%3C?%20super%20T,%20?%20extends%20U%3E)	2023-01-11 15:26:46 +01:00
Stypox	944e295ae7	Use Optional for simpler code	2023-01-11 15:14:18 +01:00
devlearner	28109fef38	Improve showing of toast ... We provide visual feedback via a toast to the user that, well, they're supposed to wait; but with the benefit of the cache openAddToPlaylistDialog() may return (almost) immediately, which would render the toast otiose (if not a bit confusing). This commit improves that by cancelling the toast once the wait's over ... (by 'abusing' RxJava's ambWith(); ref on compose() and Transformer: https://blog.danlew.net/2015/03/02/dont-break-the-chain/ and for me, first time laying my hands at RxJava so kindly bear with me; open for suggestions)	2023-01-11 14:53:48 +01:00
devlearner	40442f3f82	Utilize Lifecycle observer ... I thought it would have required an extra dependency; apparently that doesn't seem to be the case...	2023-01-11 14:53:48 +01:00
devlearner	61da167b4f	Oops, added back missing return;	2023-01-11 14:53:48 +01:00
devlearner	c744f6756b	Fix Sonar reported code smell	2023-01-11 14:53:48 +01:00
devlearner	de7057ac3a	Skip REORDER_TO_FRONT trick which doesn't seem to work on newer Androids ... probably due to background restrictions on Android 10+	2023-01-11 14:53:48 +01:00
devlearner	585bfff11d	Utilize a retained fragment to safekeep network requests in flight ... pending result for openAddToPlaylistDialog() and openDownloadDialog() Despite marked deprecated, setRetainInstance(true) is probably our best bet (since a ViewModel is probably too overkill for our present purpose)	2023-01-11 14:53:48 +01:00
devlearner	0f9c20c986	Improve (un)registering FragmentLifecycleCallbacks ... to avoid adding it multiple times and ensure proper cleanup	2023-01-11 14:53:48 +01:00
devlearner	f860392ae9	Address LayoutParams.FLAG_NOT_TOUCHABLE restriction on Andriod 12+	2023-01-11 14:53:48 +01:00
devlearner	391830558e	Ensure our transparent activity doesn't block touch events to underlying windows ... so we won't hold up UI while fetching media info for Add to Playlist or Download actions lest user might think it freezes when in fact a network request is underway	2023-01-11 14:53:48 +01:00
devlearner	c1f37d8591	Also show toast in openDownloadDialog() ... and lengthened a bit to inform user to wait...	2023-01-11 14:53:48 +01:00
devlearner	b175774ad8	Try to amicably handle DialogFragment in FragmentManager when recreated from orientation change ... - Handle finish() call instead of passing around callbacks to setOnDismissListener() - Don't start over again if returning to DialogFragment before orientation change	2023-01-11 14:53:48 +01:00
devlearner	73e32889b6	Don't finish() to allow recreate ... when orientation change is on foot	2023-01-11 14:53:48 +01:00
devlearner	400ee808e0	Set up theme/locale before super.create() ... This seems to solve a bug where the Open action menu dialog does not appear the first time on cold start on older Android (8.0). This is also the order of things in MainActivity and probably good practice.	2023-01-11 14:53:48 +01:00
Stypox	9c7ed80662	Use Optional.map correctly and other improvements	2023-01-11 14:47:53 +01:00
petlyh	edff696ecc	Ask for permission when enqueuing in a popup	2023-01-10 14:16:19 +01:00
Isira Seneviratne	e8216b2e80	Apply code review suggestions.	2023-01-04 06:10:14 +05:30
Isira Seneviratne	e3062d7c66	Use Optional chaining.	2023-01-04 05:16:21 +05:30
Isira Seneviratne	fd55d85bbf	Remove SimplifyOptionalCallChains.	2023-01-04 05:16:21 +05:30
pratyaksh1610	3e15c77a05	move string to donottranslate.xml and fix nits	2023-01-03 14:07:28 +05:30
Stypox	1bb166a9e8	Merge pull request #9553 from Redirion/exo182 ... Update ExoPlayer to 2.18.2	2023-01-02 18:21:53 +01:00
Stypox	8fa949537b	Merge pull request #8769 from Isira-Seneviratne/New_Utils_methods ... Use new NPE UTF8 Utils methods	2023-01-02 17:59:26 +01:00
Stypox	7454b31788	Merge pull request #9562 from bravenewpipe/use-videostream-for-audio-only-background-playback ... Support audio only background for services only supporting video streams	2023-01-02 17:51:10 +01:00
Stypox	b6488fe342	Merge pull request #8841 from Isira-Seneviratne/Notification_mode_ListAdapter ... Use ListAdapter in NotificationModeConfigAdapter.	2023-01-02 14:47:25 +01:00
Stypox	b1d9080a0f	Simplify disposables handling in notification mode settings	2023-01-02 14:45:11 +01:00
pratyaksh1610	50269d0f5e	updated caption file name and clean code	2023-01-02 16:23:45 +05:30
Robin	f17155bb3f	Merge branch 'TeamNewPipe:dev' into exo182	2023-01-02 10:35:20 +01:00
Isira Seneviratne	7988fe0c5a	Use new NewPipe Extractor Utils methods.	2023-01-02 07:03:18 +05:30
evermind	f4a5b3bcbf	set 'playback in background button' visible if there are videostreams	2023-01-01 21:55:03 +01:00
Stypox	6af2242d5d	Merge pull request #9521 from pratyaksh1610/branch-9518 ... Fixes #9518: Crash fix when click "Add to playlist" while the current list is still loading	2022-12-31 23:31:58 +01:00
Stypox	d21fac658b	Remove playlist details toasts	2022-12-31 23:30:17 +01:00
Stypox	27f6c3b634	Merge pull request #9502 from Jared234/8585_download_in_queue ... Added option to download items in the queue	2022-12-31 19:34:07 +01:00
Stypox	b3bfec9505	Use correct fragment manager for download dialog ... Tapping download on the long-press menu of queue items when the queue is shown inside the player would crash otherwise	2022-12-31 19:31:24 +01:00
Stypox	367ece8ffa	Merge pull request #9496 from Jared234/9437_continue_playing_while_seeking ... Seeking no longer pauses the played video	2022-12-31 19:19:21 +01:00
Stypox	661cd4c182	Merge pull request #9159 from Isira-Seneviratne/Refactor_VideoPlayerUi ... Refactor VideoPlayerUi.	2022-12-31 19:01:19 +01:00
Stypox	be856f71c8	Merge pull request #8847 from Isira-Seneviratne/Refactor_VideoDetailFragment ... Refactor VideoDetailFragment.	2022-12-31 18:41:06 +01:00
Stypox	97978033dd	Activate on click listeners only when not loading ... For consistency with long click listeners, in VideoDetailFragment	2022-12-31 17:49:10 +01:00
Stypox	413a1b504a	Refactor constrolsTouchListener code	2022-12-31 17:47:57 +01:00
Stypox	69e8e4d63e	Merge pull request #9306 from Stypox/target-api-33 ... Set compileSdk and targetSdk to 33 (Android 13)	2022-12-31 14:49:30 +01:00
Isira Seneviratne	fb1360b72a	Use ListAdapter in NotificationModeConfigAdapter.	2022-12-29 06:14:46 +05:30
Stypox	231e677b16	Merge pull request #8895 from Isira-Seneviratne/SparseArrayCompat ... Use SparseArrayCompat.	2022-12-28 20:37:05 +01:00
Tobi	fcac53cdc0	Merge pull request #9488 from Jared234/9353_night_theme_selection ... Disabling night theme selection if auto theme is not used	2022-12-25 22:19:02 +01:00
evermind	dfc46c3b6c	Support audio only background for services only supporting video streams ... Some services may only have video streams and no separate audio streams available. This commit will add audio background playback support for those services. It uses the video source as audio source for background playback.	2022-12-17 21:17:42 +01:00
Robin	eea4f0f41c	Update ExoPlayer to 2.18.2	2022-12-16 17:53:56 +01:00
Jared Fantaye	12796920a3	Removed the wasPlaying variable	2022-12-10 21:56:04 +01:00
pratyaksh1610	c537776826	Fixes #9518 ... - Crash fix on clicking on add to playlist. - Added toast when clicked on share button for better UI.	2022-12-09 14:09:40 +05:30