krlvm
80d1c5b9f5
Fix Repeat Button color in Player
2021-03-28 22:04:54 +03:00
krlvm
0afdac5683
Fix Light Player Popups in Dark Theme, make Player Controls Overlay always Dark
2021-03-28 18:48:51 +03:00
krlvm
fd14c8cdce
Fix Dark elements in Light Theme
2021-03-27 17:46:05 +03:00
Stypox
86381696f4
Merge pull request #5457 from Redirion/exo123
...
Update to ExoPlayer 2.12.3
2021-03-18 18:59:56 +01:00
Stypox
feb65cf8f3
Merge pull request #5792 from TeamNewPipe/resize_mode
...
Fix last resize mode not being restored correctly
2021-03-17 09:07:44 +01:00
TobiGr
71d3227791
Fix bottom controls being out of the screen
...
This was caused by too large end screen thumbnails enlarging the whole palyer. Fixed by scaling the thumbnail.
Ensure that the player does not use the whole screen height in detail fragment to keep the additional content like title, comments, etc. available.
2021-03-14 17:52:15 +01:00
TobiGr
86fa629591
Fix last resize mode not being restored correctly
...
I think the settings key "last_resize_mode" is ambiguous. While it is used to get the recently used resize mode, someone thought while working on the resize mode switcher, that the old (to be replaced) resize mode should be stored.
Fixes #5613
2021-03-08 09:46:33 +01:00
Stypox
8978187c64
Improve code style and fix some warnings
...
Removed a textTrack null check on a now- NonNull method
Added a error type switch case (TIMEOUT)
2021-02-16 16:54:44 +01:00
Robin
eba0b07782
Update to ExoPlayer 2.12.3
2021-02-16 16:42:51 +01:00
karol
156d7139fa
removed resizig text from popup player, as requested in #5514
2021-02-11 11:20:27 +01:00
Stypox
fdb0f01b38
Add Objects.requireNotNull to warning which is surely not null
2021-01-28 14:35:47 +01:00
Stypox
376cba696e
Remove useless getString for default setting value
2021-01-28 14:35:00 +01:00
Stypox
cade272501
Use PlayerHelper.retrieveResizeModeFromPrefs in Player
2021-01-28 14:33:50 +01:00
Stypox
4f828fbe00
Fix always minimizing to popup player
2021-01-28 14:33:12 +01:00
Stypox
e327f7ba2c
Fix popup closing x button animation
2021-01-19 09:34:21 +01:00
XiangRongLin
23b5cd5b72
Merge pull request #5442 from Stypox/fix-close-popup
...
Prevent IllegalArgumentException when closing popup
2021-01-18 09:39:02 +01:00
Stypox
d4a33603ab
Prevent IllegalArgumentException when closing popup
2021-01-18 08:27:49 +01:00
Stypox
4c3ba0fe3d
Add icons to VideoDetailFragment tab layout for better accessibility
2021-01-17 15:34:24 +01:00
Isira Seneviratne
fe92abde0e
Use view binding in VideoDetailFragment.
2021-01-17 09:57:40 +05:30
TiA4f8R
79e98db3bd
Apply the requested changes and little improvements
...
Apply the requested changes, use ShareUtils.shareText to share an stream in the play queue and optimize imports for Java files, using Android Studio functionality.
Apply the requested changes and do little improvements
Apply the requested changes, use ShareUtils.shareText to share an stream in the play queue and optimize imports for Java files, using Android Studio functionality.
2021-01-16 13:23:42 +01:00
Isira Seneviratne
920e560b4b
Convert AnimationUtils functions to extension functions.
2021-01-16 14:49:37 +05:30
vkay94
37aa41afae
Add stream segments to player
2021-01-14 21:58:19 +01:00
Stypox
059bb7622d
Merge and rename into PlayQueueActivity
2021-01-14 10:25:48 +01:00
Stypox
cece83328a
Fix wrong speed indicator in queue activity
2021-01-14 10:25:48 +01:00
Stypox
f6e2dd1480
Merge player classes into a single one
2021-01-14 10:25:44 +01:00
Isira Seneviratne
fa75c79d34
Use view binding (PlayerPopupCloseOverlayBinding) in VideoPlayerImpl.
2021-01-13 20:44:00 +01:00
Isira Seneviratne
0c86a4e608
Use view binding (PlayerBinding) in VideoPlayer.
2021-01-13 20:43:56 +01:00
Tobias Groza
92a87a5ed2
Merge pull request #5310 from khimaros/list-play-kodi
...
add list item to play video on kodi
2021-01-13 17:02:56 +01:00
Mikhail Barashkov
907106156f
When in Fullscreen playback mode, toggle play/pause with the hardware Space button.
2021-01-07 17:32:16 +02:00
khimaros
ac59382b84
pass serviceId instead of item, reduce duplication
2021-01-02 11:24:33 -08:00
Stypox
1b4bde4e78
Merge pull request #5221 from B0pol/notifications
...
Dynamically get package name
2021-01-01 18:05:43 +01:00
Robin
ce2719d77e
Merge pull request #5317 from XiangRongLin/timestamp
...
Fix urls with timestamps not being played
2020-12-31 12:46:40 +01:00
Robin
8193a0df63
Merge pull request #5065 from TacoTheDank/androidx-media-audioreactor
...
Use AndroidX Media compat in AudioReactor
2020-12-31 10:55:11 +01:00
TacoTheDank
ebd589c9cb
Use AndroidX Media compat in AudioReactor
2020-12-30 17:10:57 -05:00
XiangRongLin
1f15368b7b
Fix urls with timestamps not being played
...
Else path is now executed, when a timestamp (item.getRecoveryPosition) is present
2020-12-30 21:07:30 +01:00
Eric Lemieux
0a05534c84
Fix null pointer exception in play button method
...
When the play queue was null, and this method was called a null pointer
exception would be thrown. This change adds an additional check to see
if the play queue is not null before making additional changes.
2020-12-29 14:51:24 -05:00
Isira Seneviratne
b2e9981313
Fix queue display in ServicePlayerActivity.
2020-12-23 20:06:02 +05:30
bopol
2b8837609b
dynamically get package name
...
it fixes issues with forks or debug builds, e.g. when you open two newpipe apps (with debug or fork apps), close one notification, it closes all newpipe notifications
fixes https://github.com/TeamNewPipe/NewPipe/issues/4653
2020-12-20 13:52:20 +01:00
bopol
7a7a90bf79
remove timestamp from share url for all services except youtube
...
It produces not found error for PeerTube, media.ccc.de, SoundCloud
2020-12-20 10:53:22 +01:00
Isira Seneviratne
0fe3fe7594
Use ServiceCompat.stopForeground().
2020-12-19 16:52:17 +05:30
Isira Seneviratne
e6021465f6
Use view binding in ServicePlayerActivity.
2020-12-19 04:21:59 +05:30
Isira Seneviratne
807e4d4af9
Use ActivityCompat.recreate().
2020-12-15 13:55:05 +05:30
Tobias Groza
db9f20a22f
Merge pull request #4961 from TeamNewPipe/lint
...
Fix some Lint errors
2020-12-07 11:19:01 +01:00
Stypox
b66047e084
Fix ktlint errors
2020-11-22 14:03:10 +01:00
Stypox
f0ca916432
Update most dependencies
2020-11-22 14:03:10 +01:00
TobiGr
7a8dab2d58
Fix typos
2020-11-22 10:39:00 +01:00
vkay94
b5321152fd
Player gestures: Fix respecting brightness-volume-gesture settings
2020-11-20 21:08:02 +01:00
Stypox
06b7072240
Merge pull request #4642 from XiangRongLin/hide_thumbnail
...
Add option to hide thumbnail on lock screen
2020-11-20 16:35:10 +01:00
TacoTheDank
2669ba944d
Correct some other small lints
2020-11-19 18:54:27 -05:00
TacoTheDank
0274cd6beb
Lint: Inner class may be static
2020-11-18 18:02:33 -05:00
TacoTheDank
39e5d8ccc2
Lint: Make a bunch of stuff final
2020-11-18 17:50:00 -05:00
TacoTheDank
ea5939c1b7
Kotlin lint fixing
2020-11-18 17:45:19 -05:00
Stypox
7476498823
[Regression] Revert "Removed remember popup properties setting"
...
This reverts commit 314615bfef
2020-11-15 22:24:27 +01:00
XiangRongLin
7805f8a9b1
Add option to hide thumbnail on lock screen and inside notification
2020-11-14 10:01:07 +01:00
Stypox
617ee0afc0
Fix brightness and volume scroll swapped
2020-11-08 10:00:28 +01:00
Stypox
1b47a1a994
Fix switching to main player when MainActivity is closed
2020-11-08 10:00:28 +01:00
Stypox
5a87cfc25d
Open mini player if player running on app open
2020-11-08 10:00:28 +01:00
Stypox
2a2c82e73b
More fixes with opening VideoDetailFragment
2020-11-08 10:00:28 +01:00
Stypox
1d42e45d78
Unify all ways of opening VideoDetailFragment
2020-11-08 10:00:27 +01:00
Tobias Groza
f4435f9031
Merge pull request #4555 from Stypox/playqueue-crash
...
Fix NullPointerException in queue handling
2020-11-08 01:19:38 +01:00
Stypox
f1583b6e0c
Merge pull request #4587 from vkay94/separate-player-gesture-logic-ui
...
Separate player gesture logic and UI
2020-11-02 16:36:50 +01:00
vkay94
347566c311
Player gestures: Add multi-double-tap logic
2020-11-02 15:50:34 +01:00
Xiang Rong Lin
974f8f692c
Add option to not colorize notification
2020-11-01 22:13:00 +01:00
TacoTheDank
31cffa68c5
Push conditionals inside branch expressions
2020-10-31 15:57:26 -04:00
vkay94
2683043762
Player gestures: separate logic and UI
2020-10-29 12:46:34 +01:00
Stypox
e406b6f780
Fix NullPointerException in queue handling
2020-10-26 18:15:59 +01:00
vkay94
32a142bf79
Fix PlaylistAppendDialog: Renamed method and replaced with Runnable
2020-10-23 09:44:26 +02:00
vkay94
2680d41a3d
Fix PlaylistAppendDialog showing when no local playlists exist
2020-10-23 09:44:26 +02:00
Stypox
941028ba6f
Don't rearrange lists by dragging the thumbnails
2020-10-17 16:25:06 +02:00
Stypox
ae33c6cf18
Merge pull request #4476 from vkay94/two-finger-to-close-player
...
Two finger to close player gesture
2020-10-11 14:51:45 +02:00
vkay94
f8cd6afbf8
Two finger gesture: Less code lines
2020-10-11 13:56:30 +02:00
vkay94
f6925fc5b8
Added two finger to close player gesture
2020-10-10 15:00:39 +02:00
Isira Seneviratne
58b720b004
Use ContextCompat.getSystemService() and the Context.getSystemService() extension function.
2020-10-09 08:52:05 +05:30
Panorea
314615bfef
Removed remember popup properties setting
2020-10-06 18:32:20 -04:00
Stypox
44e82217c1
Merge pull request #4425 from vkay94/enqueue-stream
...
Replace specific enqueue options with one
2020-10-06 22:37:19 +02:00
vkay94
12f615c6da
Enqueue: Removed unneeded dialog-entries and strings + adjustments
2020-10-06 17:22:12 +02:00
vkay94
ed6fc4d848
Enqueue: Replaced specific StreamDialogEntry items with one
...
The enqueue options won't be shown in the dialogs if the Player service is not running. When it's running one item (enqueue stream) will be shown and enqueues the item into the Player type which is currently selected.
2020-10-06 14:38:48 +02:00
vkay94
cd515993f5
Enqueue: Add auto-select StreamDialogEntry for current PlayerType
2020-10-06 13:33:44 +02:00
Tobias Groza
9f63e2d39a
Merge pull request #4410 from Stypox/notification-fixes
...
Notification fixes
2020-10-05 19:08:26 +02:00
Stypox
a88f5113e0
Hide player notification "when" time
...
It is useless to see how much time ago a player notification was created
2020-10-05 15:57:14 +02:00
Stypox
06fb89fae2
Fix crash on fast forward
2020-10-05 15:55:10 +02:00
Isira Seneviratne
63d54e6570
Use DisplayCutoutCompat in VideoPlayerImpl.
2020-10-04 05:44:13 +05:30
Tobias Groza
83ea91586b
Merge pull request #4362 from Stypox/fix-queue
...
Random fixes and improvements
2020-10-02 16:48:04 +02:00
Tobias Groza
794c74e514
Merge pull request #4360 from avently/player-overlays
...
Player overlays now centered
2020-10-02 15:37:28 +02:00
Stypox
fbcdaa77e3
Initialize player notification asap
...
Otherwise Android's foreground services implementation would complain
2020-10-02 15:17:04 +02:00
Tobias Groza
4e7632949d
Merge pull request #4347 from avently/player-rebind
...
Player rebind
2020-10-01 15:03:43 +02:00
Avently
26a8bd147b
Now player's overlays are aware of insets
2020-10-01 03:10:51 +03:00
Avently
dd726fac02
Skipped interception of buttons in the player in some cases and made image view from playQueue visible
2020-10-01 03:10:42 +03:00
wb9688
f4bd20361a
Fix auto-queue with no next videos
2020-09-29 10:43:17 +02:00
Avently
c1d5a5cd98
Player will be rebound when needed, prev/next/queue buttons, preserving paused state
...
- each time something starts to play in any player VideoDetailFragment will be started (if not yet started) and mini player will show up. It makes possible to see a playing stream in mini player even if the stream was started without using fragment or after player service was closed somehow
- play/next/queue buttons will be updated in realtime when stream was added/removed from queue instead of waiting for a onPlay/onPause action to happen
- when popup or background players start the stream will start playing only if paused state wasn't requested. Which means, for example, if a user opens popup it will be started when START_PAUSED is false. If, for example, the stream was played in main player and then popup was started the stream will still be playing, but if it was paused it still be paused in popup (or background) in APPEND_ONLY mode (but will be playing on new queue initialization)
2020-09-29 06:22:53 +03:00
Avently
0370fa6c00
Merged 'dev' branch
2020-09-27 18:02:31 +03:00
Avently
e53e5ca20e
Disabled nested scrolling of queue
2020-09-27 15:50:21 +03:00
Avently
609bf64856
Merged 'dev' branch
2020-09-27 15:04:20 +03:00
Tobias Groza
d5f603303d
Merge pull request #4259 from TeamNewPipe/pref_migration
...
Add settings migration, remove "Detail page" option from share dialog and minimize to background by default
2020-09-27 11:20:39 +02:00
Tobias Groza
fc9c073a60
Merge pull request #3178 from cool-student/notificationImprovements
...
Notification Improvements
2020-09-27 10:43:11 +02:00
Avently
9a0c2c40bd
Refactoring and made the player returning from landscape & fullscreen on vertical video to portrait after clicking on fullscreen button
2020-09-27 06:39:42 +03:00
Avently
df9823988e
Changes for tablets and device's orientation behavior
...
- the app will not rotate the screen to portrait after video completes, it will just exit from fullscreen mode
- ability to rotate the orientation via fullscreen button from landscape to portrait when device has locked orientation in landscape
- ability to enter/exit to/from fullscreen on tablets with unlocked global orientation in portrait mode
2020-09-27 04:11:38 +03:00
TobiGr
0e5f85db95
Remove "Detail Page" open action from share dialog under certain circumstances
...
With the new application workflow and unified player, video detail page and video player are the same activity. So show only one of these options based on whether autoplay is enabled or not, and show both if using external player
2020-09-26 21:58:34 +02:00
Avently
3add24b8aa
Merged 'dev' branch
2020-09-26 02:42:26 +03:00
Tobias Groza
e0f02d4080
Merge pull request #4246 from avently/preloading
...
Disabled preloading when switching streams
2020-09-25 21:22:31 +02:00
Avently
c843e77183
Made notification thumbnail smaller
2020-09-23 15:20:25 +03:00
Stypox
b4e073cde7
Show replay icon in notification when player state is completed
2020-09-22 18:17:16 +02:00
Stypox
814efbf8df
Remove ACTION_BUFFERING, update buffering only if needed
...
- ACTION_BUFFERING was just wrong: why should the user be able to trigger the internal onBuffering() state by pressing on the buffering button? So that was replaced by a null intent, doing nothing.
- Now updating notification in onBuffering() only when buffering actions are not already buffering, to prevent useless updates
2020-09-22 18:17:16 +02:00
Stypox
11e048abb1
Remove hardcoded and duplicate strings, use exoplayer ones
2020-09-22 18:17:09 +02:00
Avently
518eb97e3a
Variable width for caption button and hiding system UI after popup close
2020-09-19 22:52:59 +03:00
Avently
f41549ccf1
Added a comment and excluded automatic switch of orientation on tablets and Android TVs
2020-09-19 17:21:01 +03:00
Avently
5b8eda4805
Increased performance of the UI. main thread is not as busy as before
2020-09-17 23:42:35 +03:00
Avently
886a949a00
Enable/disable video after screen on/off regardless of background playback setting
2020-09-17 22:30:03 +03:00
Avently
92e13dafe5
Correct exit from fullscreen in case of error or close from notification,
2020-09-17 19:01:20 +03:00
Avently
c9be812330
Fix for untouchable area
2020-09-16 23:41:49 +03:00
Stypox
59e7ebabfa
Random adjustements to notification
2020-09-16 14:00:22 +02:00
Avently
5ada0ae2c7
Hiding controls when orientation changes to landscape
2020-09-15 22:10:38 +03:00
Avently
a5312c1341
Perfect shadow
2020-09-15 19:50:46 +03:00
Avently
150e156d26
Reimagined player positioning
2020-09-15 14:43:43 +03:00
Avently
6d38615ea8
Android 11: transparent navigation and status bars
2020-09-14 11:30:41 +03:00
Avently
883e4fcd7c
Small fixes of issues with old devices support, brightness, etc
2020-09-11 20:52:38 +03:00
Stypox
2017e6a3e3
Refactor MediaSessionManager
2020-09-10 20:36:52 +02:00
Stypox
bccfe500b3
Fix seekbar invisible or not updating
...
Have the notification recreate only when strictly necessary, and recreate it if there was a timeline change, fixing the seekbar not updating at all sometimes
2020-09-10 20:22:22 +02:00
Stypox
52e89c1d1c
Prevent seeking out of video duration in player
2020-09-10 19:47:02 +02:00
Stypox
1605e50cef
Update notification when play queue is edited
2020-09-10 13:36:34 +02:00
Stypox
a13e6b69e3
Merge branch 'dev' into pr3178
2020-09-08 23:58:10 +02:00
Stypox
bc8954fbba
Fix notification content intent not being updated when needed
2020-09-08 22:00:28 +02:00
Stypox
9cf0bc6c82
Make notification creation and cancelling more consistent
2020-09-08 22:00:28 +02:00
Stypox
71b32fe641
Add notification costumization settings menu
2020-09-08 22:00:24 +02:00
Stypox
530f745e44
Merge pull request #4154 from avently/video-placement
...
Prevent jumping of the player and wrong padding on devices with cutout
2020-09-08 19:47:09 +02:00
Avently
31814b70da
Disabled preloading when switching streams
2020-09-07 19:34:10 +03:00
TacoTheDank
06d54ef77e
Clean up SDK version checks
2020-09-06 12:55:30 +02:00
TacoTheDank
f86b40302d
Some general-purpose lint cleanup
2020-09-06 12:55:26 +02:00
TacoTheDank
a4feb3fc09
Fix some deprecations
2020-09-06 12:52:43 +02:00
TacoTheDank
ba6c7de35a
Use AndroidX preference
2020-09-06 12:52:42 +02:00
Stypox
628575dc5f
Clean up MediaSessionManager
2020-09-04 18:44:09 +02:00
Avently
0a22f21410
Small fixes of issues with brightness, background playback, gestures
2020-09-04 05:39:55 +03:00
Stypox
97ff9e9c5b
Merge branch 'dev' into pr3178
2020-09-03 21:56:48 +02:00
Stypox
8b3a09306b
Various notification code improvements
...
Improve builder parameters
Reorder code and extract large icon function
service.startForeground() now is also provided with service type in android versions >= Q
2020-09-03 21:54:31 +02:00
Stypox
7766fd13fd
Extract hardcoded strings into strings.xml and improve them
2020-09-03 21:54:31 +02:00
Stypox
c79997ebe3
Show hourglass icon when buffering
2020-09-03 21:54:28 +02:00
Avently
b8a35e9e4a
Moved device-specific code into DeviceUtils
2020-09-03 15:48:17 +03:00
Avently
e833d415e3
Fixed wrong padding on devices with cutout on vertical videos
2020-09-03 15:48:17 +03:00
TobiGr
c66c81294e
Remove unused and redundant code.
2020-09-01 17:39:06 +02:00
Tobias Groza
bfdc215c65
Merge pull request #4155 from avently/gestures-interception
...
Skipping interception of some gestures
2020-09-01 16:51:34 +02:00
Tobias Groza
8d2ec30818
Merge pull request #4120 from mhmdanas/replace-SubtitlesStream-getURL-with-getUrl
...
Use SubtitlesStream#getUrl instead of getURL
2020-08-26 22:15:44 +02:00
mhmdanas
e5ffddfc6b
Use SubtitlesStream#getUrl instead of getURL
2020-08-26 23:04:18 +03:00
TobiGr
552d585fca
Extract common part from if
2020-08-18 13:28:13 +02:00
Avently
24c24d6c72
Skipping interception of some gestures
2020-08-17 20:42:05 +03:00
Tobias Groza
5485e994ee
Merge pull request #4138 from XiangRongLin/checkstyle_final
...
Add checkstyle rule to show final local variable violations as warning
2020-08-16 11:55:46 +02:00
wb9688
87228673b4
Use final where possible
2020-08-16 10:25:09 +02:00
Stypox
e08480f345
Completely remove old player notification
2020-08-15 22:03:32 +02:00
Stypox
12ac5ef781
[regression] Close player in onPlaybackShutdown()
2020-08-15 15:58:25 +02:00
Stypox
adef9a8acf
Rename notification functions: they are not background player only
2020-08-15 15:16:17 +02:00
nmurali94
04bb070afa
Remove timestamp when sharing a live stream
2020-08-12 09:54:35 -04:00
