mirrors
/
NewPipe
mirror of https://github.com/TeamNewPipe/NewPipe
1
0
Fork 0
Code Issues Releases Wiki Activity
11,083 Commits 6 Branches 132 Tags 123 MiB
Commit Graph

928 Commits

Author SHA1 Message Date
Isira Seneviratne 097d32b684 Migrate to non-transitive R classes. 2024-03-25 15:12:30 +01:00
Stypox 8345f348f6
Merge pull request #10091 from TeamNewPipe/feat/playlist_description 
Add playlist description to playlist fragment
 2023-12-29 10:58:13 +01:00
Stypox 845e72bf4a
Merge branch 'master' into dev 2023-12-29 10:48:37 +01:00
TobiGr 0fa2e76c3e Fix NPE when ChannelTabLHFactory not implemented for a service 
Fixes #10698
 2023-12-26 16:55:52 +01:00
TobiGr 65eb631711
Ellipsize playlist description if it is longer than 5 lines 
The description can be expanded / collapsed via a "show more" / "show less" button.
 2023-12-23 12:33:52 +01:00
TobiGr 6c99557553
Add playlist description to PlaylistFragment 2023-12-23 12:13:34 +01:00
Stypox aa84d6fc8f
Add @NonNull annotations 2023-12-22 18:52:42 +01:00
Stypox d76e9b0bd8
Fix scrolling to correct comment after closing replies 2023-12-22 18:52:42 +01:00
TobiGr b4016c91c1
scroll last comment into view 2023-12-22 11:57:55 +01:00
TobiGr 5f32d001cc
Expand DetailFragment again when exiting the CommentRepliesFragment 2023-12-22 11:57:55 +01:00
Stypox 8c9287d0c8
Revert relying on source ListInfo, use commentsInfoItem.getUrl() instead 
This reverts commit bb01da3691ff1d5c3dccd41b7ca1a5deb1b5676f. This commit was not needed
 2023-12-22 11:57:55 +01:00
Stypox 3f37e27852
Add some documentation and javadocs 
Also further simplify CommentRepliesInfo and RelatedItemsInfo
 2023-12-22 11:57:55 +01:00
Stypox f41ab8b086
Add comment replies fragment header 2023-12-22 11:57:55 +01:00
Stypox 4b6392df54
Set comment replies fragment title 2023-12-22 11:48:07 +01:00
Stypox 94ea329b50
Always show comment replies in list mode 2023-12-22 11:48:07 +01:00
Stypox 591ed2e01f
Fix some code smells 2023-12-22 11:48:07 +01:00
Stypox 78cf9aaa7d
Save and restore state in CommentRepliesFragment 2023-12-22 11:48:07 +01:00
Stypox f9494a294f
Implement CommentRepliesFragment 2023-12-22 11:48:07 +01:00
Stypox 0dd4553700
Load more items even if initial related items are empty 2023-12-22 11:48:07 +01:00
Stypox 4f7b36cd70
Keep source list info in InfoItemBuilder 
Also remove some unused code
 2023-12-22 11:48:07 +01:00
Stypox 5d350aec87
Move RelatedItemInfo next to fragment using it 2023-12-22 11:48:07 +01:00
Stypox 5b999a88f8
Merge pull request #10673 from Stypox/transaction-too-large 
Fix transaction too large in channel tab fragments
 2023-12-21 22:30:22 +01:00
Stypox 495c9850b4
Fix transaction too large for channel tab fragments 2023-12-20 23:57:43 +01:00
Stypox c0f8d145f8
Fix lag with many channels on main page 
Disable loading all tabs at once, since there can be many of them, and use default strategy of only keeping in memory the two tabs adjacent to the current tab.
 2023-12-20 22:47:57 +01:00
Stypox 8d59812827
Fix channel avatar not loading correctly sometimes 
The fix just involves removing some really outdated code (6 years ago) added in 33e29be7db (diff-38bd2cf1b92659b499c08e1cf6ac9ef384c7e13381b906f2f98c57cbb758756dR778) (blame: 9318bb5306/app/src/main/java/org/schabi/newpipe/detail/VideoItemDetailActivity.java (L778)).
What that code did was setting the 'buddy' image to the uploader avatar as a placeholder, and then setting the actual image if it existed and after it had loaded.
That code remained there up until now, but now it doesn't make sense anymore, since Picasso already takes care of setting placeholders.
The problem is, starting from #10066 the actual uploader image is set before (not after) those lines of code, making them do the wrong thing, i.e. always overwrite the currently set image.
But then why did the channel avatar image work normally sometimes?
My guess is that since Picasso loads images in the background, when opening a video from scratch setting the placeholder still happened before Picasso finished loading the image.
However when the image is already cached it's loaded much faster and therefore setting the placeholder happens after, effectively hiding the loaded image.
 2023-12-10 15:12:38 +01:00
TobiGr 3d5a8af52b Fix inconsistency when LocalPlaylist is used as MainFragment tab 2023-10-02 02:56:30 +02:00
Yingwei Zheng 1cf670dad9 Fix inconsistency between user interaction and database commit order when re-adding videos to the playlist 2023-10-02 02:56:30 +02:00
Stypox f8b756c8bc
Make question mark localizable 2023-09-22 10:14:45 +02:00
Stypox 87dca0f7ec
Separate imageListToDbUrl from choosePreferredImage 
imageListToDbUrl should be used if the URL is going to be saved to the database, to avoid saving nothing in case at the moment of saving the user preference is to not show images.
 2023-09-22 10:14:44 +02:00
Stypox bf908f0b7d
Add documentation and fix SonarCloud issue 2023-09-22 10:14:44 +02:00
Stypox 4f7d206736
Display all thumbnails in description tab 2023-09-22 10:14:44 +02:00
Stypox 35073c780d
Implement better image selection strategy 2023-09-22 10:14:44 +02:00
Stypox 0a8f28b1c6
Add image quality preference 2023-09-22 10:14:43 +02:00
Stypox af2375948d
Support obtaining multiple images from the extractor 2023-09-22 09:57:33 +02:00
TobiGr 748c2babe9 Add comments and annotations 2023-09-20 15:41:21 +02:00
TobiGr 8f83e39970 Fix three memory leaks 
Add documentation to BaseFragment.initViews(View, Bundle) and BaseFragment.initListeners()
 2023-09-19 00:13:16 +02:00
TobiGr 64da7a06c0
Fix previous ActionBar title visible for a few miliseconds when opening ChannelFragment 2023-09-18 23:22:32 +02:00
TobiGr 57eaa1bbe1
Apply review 
Co-Authored-By:  Audric V <74829229+AudricV@users.noreply.github.com>
 2023-09-18 23:22:32 +02:00
TobiGr 109d06b4bb
Deduplicate code to initialize ClickListeners on playlist controls 
Add the separate utility class PlayButtonHelper to handle the initialization of the listeners.
The ClickListeners on playlist controls had different behaviours. This commit fixes that.

The commit also refactors the way how the app determines whether it is started for the first time. The previous version was not clean and recent in this PR caused it to fail.
 2023-09-18 23:22:32 +02:00
AudricV f2ee3859ab
Hide the upload date element on the About tab 
This empty element should be always hidden for this tab, as there is no upload
date available for channels.
 2023-09-18 23:22:32 +02:00
AudricV 89dc44be61
Always show the About tab and support having no description 2023-09-18 23:22:32 +02:00
TobiGr 5c7c382323
Add missing `@Override` annotations to setupMetadata() implementations 2023-09-18 23:22:32 +02:00
Stypox 78b4b9441e
Update NewPipeExtractor and adapt imports 2023-09-18 23:22:32 +02:00
Stypox c48e702a50
Improve placeholder channel banner handling 
Now the placeholder gets hidden if there is no banner url or the user disabled images, to save space
 2023-09-18 23:22:32 +02:00
Stypox 1061bce4f3
Add avatar and bannner URLs to channel About tab 2023-09-18 23:22:32 +02:00
Stypox 013d513450
Add space above channel description (About tab) 2023-09-18 23:22:32 +02:00
ThetaDev 753a92055c
feat: add playlist controls to channel tab 2023-09-18 23:22:32 +02:00
Stypox 371f986773
Fix some code smells 2023-09-18 23:22:32 +02:00
Stypox a1e8b9be4e
Fix channel tabs in main page setting title themselves 2023-09-18 23:22:32 +02:00
Stypox c076a0f771
Channels are now an Info 
The previous "main" tab is now just a normal tab returned in getTabs().
Various part of the code that used to handle channels as ListInfo now either take the first (playable, i.e. with streams) tab (e.g. the ChannelTabPlayQueue), or take all of them combined (e.g. the feed).
 2023-09-18 23:22:32 +02:00