From f5a4af2d6788b93e6698853afe6d1dc9c445cda9 Mon Sep 17 00:00:00 2001 From: Profpatsch Date: Tue, 13 May 2025 15:51:21 +0200 Subject: [PATCH] Player: destroy -> saveAndShutdown --- .../main/java/org/schabi/newpipe/player/Player.java | 10 ++++++++-- .../java/org/schabi/newpipe/player/PlayerService.kt | 2 +- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/org/schabi/newpipe/player/Player.java b/app/src/main/java/org/schabi/newpipe/player/Player.java index 111a98551..d3e3ff1df 100644 --- a/app/src/main/java/org/schabi/newpipe/player/Player.java +++ b/app/src/main/java/org/schabi/newpipe/player/Player.java @@ -591,9 +591,15 @@ public final class Player implements PlaybackListener, Listener { } } - public void destroy() { + + /** + * Shut down this player. + * Saves the stream progress, sets recovery. + * Then destroys the player in all UIs and destroys the UIs as well. + */ + public void saveAndShutdown() { if (DEBUG) { - Log.d(TAG, "destroy() called"); + Log.d(TAG, "saveAndShutdown() called"); } saveStreamProgressState(); diff --git a/app/src/main/java/org/schabi/newpipe/player/PlayerService.kt b/app/src/main/java/org/schabi/newpipe/player/PlayerService.kt index 8fe42ebff..10ae01e17 100644 --- a/app/src/main/java/org/schabi/newpipe/player/PlayerService.kt +++ b/app/src/main/java/org/schabi/newpipe/player/PlayerService.kt @@ -226,7 +226,7 @@ class PlayerService : MediaBrowserServiceCompat() { // notify that the player is being destroyed onPlayerStartedOrStopped!!.accept(null) } - player!!.destroy() + player!!.saveAndShutdown() player = null }