mirrors/NewPipe
1
0
Fork 0
mirror of https://github.com/TeamNewPipe/NewPipe synced 2025-09-07 05:17:56 +00:00
Code Issues Releases Wiki Activity

Player/handleIntent: a few comments

Browse Source
This commit is contained in:
Profpatsch
2025-05-04 20:11:03 +02:00
parent 4e8c034c22
commit d84114ba97
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
app/src/main/java/org/schabi/newpipe/player/Player.java
View File

@@ -359,6 +359,7 @@ public final class Player implements PlaybackListener, Listener {
final PlayerType oldPlayerType = playerType; final PlayerType oldPlayerType = playerType;
playerType = PlayerType.retrieveFromIntent(intent); playerType = PlayerType.retrieveFromIntent(intent);
initUIsForCurrentPlayerType(); initUIsForCurrentPlayerType();
// TODO: what does the following comment mean? Is that a relict?
// We need to setup audioOnly before super(), see "sourceOf" // We need to setup audioOnly before super(), see "sourceOf"
isAudioOnly = audioPlayerSelected(); isAudioOnly = audioPlayerSelected();
@@ -371,7 +372,7 @@ public final class Player implements PlaybackListener, Listener {
playQueue.append(newQueue.getStreams()); playQueue.append(newQueue.getStreams());
return; return;
// Resolve enqueue next intents // Resolve enqueue next intents
} else if (intent.getBooleanExtra(ENQUEUE_NEXT, false) && playQueue != null) { } else if (intent.getBooleanExtra(ENQUEUE_NEXT, false) && playQueue != null) {
final int currentIndex = playQueue.getIndex(); final int currentIndex = playQueue.getIndex();
playQueue.append(newQueue.getStreams()); playQueue.append(newQueue.getStreams());
@@ -379,16 +380,18 @@ public final class Player implements PlaybackListener, Listener {
return; return;
} }
// initPlayback Parameters
final PlaybackParameters savedParameters = retrievePlaybackParametersFromPrefs(this); final PlaybackParameters savedParameters = retrievePlaybackParametersFromPrefs(this);
final float playbackSpeed = savedParameters.speed; final float playbackSpeed = savedParameters.speed;
final float playbackPitch = savedParameters.pitch; final float playbackPitch = savedParameters.pitch;
final boolean playbackSkipSilence = getPrefs().getBoolean(getContext().getString( final boolean playbackSkipSilence = getPrefs().getBoolean(getContext().getString(
R.string.playback_skip_silence_key), getPlaybackSkipSilence()); R.string.playback_skip_silence_key), getPlaybackSkipSilence());
final boolean samePlayQueue = playQueue != null && playQueue.equalStreamsAndIndex(newQueue);
final int repeatMode = intent.getIntExtra(REPEAT_MODE, getRepeatMode()); final int repeatMode = intent.getIntExtra(REPEAT_MODE, getRepeatMode());
final boolean playWhenReady = intent.getBooleanExtra(PLAY_WHEN_READY, true); final boolean playWhenReady = intent.getBooleanExtra(PLAY_WHEN_READY, true);
// branching parameters for below
final boolean samePlayQueue = playQueue != null && playQueue.equalStreamsAndIndex(newQueue);
/* /*
* TODO As seen in #7427 this does not work: * TODO As seen in #7427 this does not work:
* There are 3 situations when playback shouldn't be started from scratch (zero timestamp): * There are 3 situations when playback shouldn't be started from scratch (zero timestamp):