Hide meta info panel in search when starting a new search

app/src/main/java/org/schabi/newpipe/fragments/BaseStateFragment.java

@@ -1,11 +1,9 @@
 package org.schabi.newpipe.fragments;
 
-import android.content.Context;
 import android.os.Bundle;
 import android.util.Log;
 import android.view.View;
 import android.widget.ProgressBar;
-import android.widget.Toast;
 
 import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
@@ -138,10 +136,10 @@ public abstract class BaseStateFragment<I> extends BaseFragment implements ViewC
         isLoading.set(false);
         InfoCache.getInstance().clearCache();
         if (emptyStateView != null) {
-            animateView(emptyStateView, false, 150);
+            animate(emptyStateView, false, 150);
         }
         if (loadingProgressBar != null) {
-            animateView(loadingProgressBar, false, 0);
+            animate(loadingProgressBar, false, 0);
         }
     }
 

app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java

@@ -148,6 +148,7 @@ public final class VideoDetailFragment
     private static final String COMMENTS_TAB_TAG = "COMMENTS";
     private static final String RELATED_TAB_TAG = "NEXT VIDEO";
     private static final String DESCRIPTION_TAB_TAG = "DESCRIPTION TAB";
+    private static final String EMPTY_TAB_TAG = "EMPTY TAB";
 
     // tabs
     private boolean showComments;

app/src/main/java/org/schabi/newpipe/fragments/list/search/SearchFragment.java

@@ -161,11 +161,6 @@ public class SearchFragment extends BaseListFragment<SearchInfo, ListExtractor.I
     private EditText searchEditText;
     private View searchClear;
 
-    private TextView correctSuggestion;
-    private TextView metaInfoTextView;
-    private View metaInfoSeparator;
-
-    private View suggestionsPanel;
     private boolean suggestionsPanelVisible = false;
 
     /*////////////////////////////////////////////////////////////////////////*/
@@ -277,7 +272,7 @@ public class SearchFragment extends BaseListFragment<SearchInfo, ListExtractor.I
         handleSearchSuggestion();
 
         disposables.add(showMetaInfoInTextView(metaInfo == null ? null : Arrays.asList(metaInfo),
-                    metaInfoTextView, metaInfoSeparator));
+                    searchBinding.searchMetaInfoTextView, searchBinding.searchMetaInfoSeparator));
 
         if (suggestionDisposable == null || suggestionDisposable.isDisposed()) {
             initSuggestionObserver();
@@ -363,10 +358,6 @@ public class SearchFragment extends BaseListFragment<SearchInfo, ListExtractor.I
         searchToolbarContainer = activity.findViewById(R.id.toolbar_search_container);
         searchEditText = searchToolbarContainer.findViewById(R.id.toolbar_search_edit_text);
         searchClear = searchToolbarContainer.findViewById(R.id.toolbar_search_clear);
-
-        correctSuggestion = rootView.findViewById(R.id.correct_suggestion);
-        metaInfoTextView = rootView.findViewById(R.id.search_meta_info_text_view);
-        metaInfoSeparator = rootView.findViewById(R.id.search_meta_info_separator);
     }
 
     /*//////////////////////////////////////////////////////////////////////////
@@ -839,6 +830,8 @@ public class SearchFragment extends BaseListFragment<SearchInfo, ListExtractor.I
         this.searchString = theSearchString;
         infoListAdapter.clearStreamItemList();
         hideSuggestionsPanel();
+        showMetaInfoInTextView(null, searchBinding.searchMetaInfoTextView,
+                searchBinding.searchMetaInfoSeparator);
         hideKeyboardSearch();
 
         disposables.add(historyRecordManager.onSearched(serviceId, theSearchString)
@@ -983,8 +976,8 @@ public class SearchFragment extends BaseListFragment<SearchInfo, ListExtractor.I
         // List<MetaInfo> cannot be bundled without creating some containers
         metaInfo = new MetaInfo[result.getMetaInfo().size()];
         metaInfo = result.getMetaInfo().toArray(metaInfo);
-        disposables.add(showMetaInfoInTextView(result.getMetaInfo(), metaInfoTextView,
-                metaInfoSeparator));
+        disposables.add(showMetaInfoInTextView(result.getMetaInfo(),
+                searchBinding.searchMetaInfoTextView, searchBinding.searchMetaInfoSeparator));
 
         handleSearchSuggestion();
 

app/src/main/java/org/schabi/newpipe/ktx/View.kt

@@ -35,11 +35,11 @@ inline var View.backgroundTintListCompat: ColorStateList?
  */
 @JvmOverloads
 fun View.animate(
-        enterOrExit: Boolean,
-        duration: Long,
-        animationType: AnimationType = AnimationType.ALPHA,
-        delay: Long = 0,
-        execOnEnd: Runnable? = null
+    enterOrExit: Boolean,
+    duration: Long,
+    animationType: AnimationType = AnimationType.ALPHA,
+    delay: Long = 0,
+    execOnEnd: Runnable? = null
 ) {
     if (MainActivity.DEBUG) {
         val id = try {
@@ -48,8 +48,8 @@ fun View.animate(
             id.toString()
         }
         val msg = String.format(
-                "%8s →  [%s:%s] [%s %s:%s] execOnEnd=%s", enterOrExit,
-                javaClass.simpleName, id, animationType, duration, delay, execOnEnd
+            "%8s →  [%s:%s] [%s %s:%s] execOnEnd=%s", enterOrExit,
+            javaClass.simpleName, id, animationType, duration, delay, execOnEnd
         )
         Log.d(TAG, "animate(): $msg")
     }
@@ -93,10 +93,10 @@ fun View.animate(
 fun View.animateBackgroundColor(duration: Long, @ColorInt colorStart: Int, @ColorInt colorEnd: Int) {
     if (MainActivity.DEBUG) {
         Log.d(
-                TAG,
-                "animateBackgroundColor() called with: " +
-                        "view = [" + this + "], duration = [" + duration + "], " +
-                        "colorStart = [" + colorStart + "], colorEnd = [" + colorEnd + "]"
+            TAG,
+            "animateBackgroundColor() called with: " +
+                "view = [" + this + "], duration = [" + duration + "], " +
+                "colorStart = [" + colorStart + "], colorEnd = [" + colorEnd + "]"
         )
     }
     val empty = arrayOf(IntArray(0))
@@ -121,9 +121,9 @@ fun View.animateBackgroundColor(duration: Long, @ColorInt colorStart: Int, @Colo
 fun View.animateHeight(duration: Long, targetHeight: Int): ValueAnimator {
     if (MainActivity.DEBUG) {
         Log.d(
-                TAG,
-                "animateHeight: duration = [" + duration + "], " +
-                        "from " + height + " to → " + targetHeight + " in: " + this
+            TAG,
+            "animateHeight: duration = [" + duration + "], " +
+                "from " + height + " to → " + targetHeight + " in: " + this
         )
     }
     val animator = ValueAnimator.ofFloat(height.toFloat(), targetHeight.toFloat())
@@ -152,9 +152,9 @@ fun View.animateHeight(duration: Long, targetHeight: Int): ValueAnimator {
 fun View.animateRotation(duration: Long, targetRotation: Int) {
     if (MainActivity.DEBUG) {
         Log.d(
-                TAG,
-                "animateRotation: duration = [" + duration + "], " +
-                        "from " + rotation + " to → " + targetRotation + " in: " + this
+            TAG,
+            "animateRotation: duration = [" + duration + "], " +
+                "from " + rotation + " to → " + targetRotation + " in: " + this
         )
     }
     animate().setListener(null).cancel()
@@ -319,7 +319,6 @@ fun View.slideUp(duration: Long, delay: Long, @FloatRange(from = 0.0, to = 1.0)
         .start()
 }
 
-
 /**
  * Instead of hiding normally using [animate], which would make
  * the recycler view unable to capture touches after being hidden, this just animates the alpha

app/src/main/java/org/schabi/newpipe/util/ExtractorHelper.java

@@ -274,10 +274,9 @@ public final class ExtractorHelper {
                                                     final TextView metaInfoTextView,
                                                     final View metaInfoSeparator) {
         final Context context = metaInfoTextView.getContext();
-        final boolean showMetaInfo = PreferenceManager.getDefaultSharedPreferences(context)
-                .getBoolean(context.getString(R.string.show_meta_info_key), true);
-
-        if (!showMetaInfo || metaInfos == null || metaInfos.isEmpty()) {
+        if (metaInfos == null || metaInfos.isEmpty()
+                || !PreferenceManager.getDefaultSharedPreferences(context).getBoolean(
+                        context.getString(R.string.show_meta_info_key), true)) {
             metaInfoTextView.setVisibility(View.GONE);
             metaInfoSeparator.setVisibility(View.GONE);
             return Disposable.empty();