1
0
mirror of https://github.com/TeamNewPipe/NewPipe synced 2024-12-23 08:30:44 +00:00

Applied code review changes.

This commit is contained in:
Isira Seneviratne 2022-08-05 06:54:03 +05:30
parent fc46233baf
commit a9af1dfdd2
3 changed files with 6 additions and 6 deletions

View File

@ -180,7 +180,7 @@ public final class NotificationConstants {
if (compactSlot == Integer.MAX_VALUE) { if (compactSlot == Integer.MAX_VALUE) {
// settings not yet populated, return default values // settings not yet populated, return default values
return SLOT_COMPACT_DEFAULTS; return new ArrayList<>(SLOT_COMPACT_DEFAULTS);
} }
// a negative value (-1) is set when the user does not want a particular compact slot // a negative value (-1) is set when the user does not want a particular compact slot

View File

@ -99,7 +99,7 @@ public final class NotificationUtil {
// build the compact slot indices array (need code to convert from Integer... because Java) // build the compact slot indices array (need code to convert from Integer... because Java)
final List<Integer> compactSlotList = NotificationConstants.getCompactSlotsFromPreferences( final List<Integer> compactSlotList = NotificationConstants.getCompactSlotsFromPreferences(
player.getContext(), player.getPrefs(), nonNothingSlotCount); player.getContext(), player.getPrefs(), nonNothingSlotCount);
final int[] compactSlots = compactSlotList.stream().mapToInt(i -> i).toArray(); final int[] compactSlots = compactSlotList.stream().mapToInt(Integer::intValue).toArray();
builder.setStyle(new androidx.media.app.NotificationCompat.MediaStyle() builder.setStyle(new androidx.media.app.NotificationCompat.MediaStyle()
.setMediaSession(player.getMediaSessionManager().getSessionToken()) .setMediaSession(player.getMediaSessionManager().getSessionToken())

View File

@ -34,7 +34,6 @@ import org.schabi.newpipe.util.DeviceUtils;
import org.schabi.newpipe.util.ThemeHelper; import org.schabi.newpipe.util.ThemeHelper;
import org.schabi.newpipe.views.FocusOverlayView; import org.schabi.newpipe.views.FocusOverlayView;
import java.util.ArrayList;
import java.util.List; import java.util.List;
import java.util.stream.IntStream; import java.util.stream.IntStream;
@ -76,9 +75,10 @@ public class NotificationActionsPreference extends Preference {
//////////////////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////////
private void setupActions(@NonNull final View view) { private void setupActions(@NonNull final View view) {
compactSlots = new ArrayList<>(NotificationConstants compactSlots = NotificationConstants.getCompactSlotsFromPreferences(getContext(),
.getCompactSlotsFromPreferences(getContext(), getSharedPreferences(), 5)); getSharedPreferences(), 5);
notificationSlots = IntStream.range(0, 5).mapToObj(i -> new NotificationSlot(i, view)) notificationSlots = IntStream.range(0, 5)
.mapToObj(i -> new NotificationSlot(i, view))
.toArray(NotificationSlot[]::new); .toArray(NotificationSlot[]::new);
} }