mirrors/NewPipe
1
0
Fork 0
mirror of https://github.com/TeamNewPipe/NewPipe synced 2025-10-31 15:23:00 +00:00
Code Issues Releases Wiki Activity

Merge pull request #12188 from VougJo23/commentsfix

Browse Source 
fix: support RTL usernames in comment header
This commit is contained in:
Profpatsch
2025-05-07 12:20:23 +02:00
committed by GitHub
parent 88395fa852 8d679626f0
commit 862a8e8f26
2 changed files with 26 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
app/src/main/java/org/schabi/newpipe/info_list/holder/CommentInfoItemHolder.java
View File

@@ -101,14 +101,16 @@ public class CommentInfoItemHolder extends InfoItemHolder {
} }
itemThumbnailView.setOnClickListener(view -> openCommentAuthor(item)); itemThumbnailView.setOnClickListener(view -> openCommentAuthor(item));
// setup the top row, with pinned icon, author name and comment date // setup the top row, with pinned icon, author name and comment date
itemPinnedView.setVisibility(item.isPinned() ? View.VISIBLE : View.GONE); itemPinnedView.setVisibility(item.isPinned() ? View.VISIBLE : View.GONE);
itemTitleView.setText(Localization.concatenateStrings(item.getUploaderName(), final String uploaderName = Localization.localizeUserName(item.getUploaderName());
Localization.relativeTimeOrTextual(itemBuilder.getContext(), item.getUploadDate(), itemTitleView.setText(Localization.concatenateStrings(
uploaderName,
Localization.relativeTimeOrTextual(
itemBuilder.getContext(),
item.getUploadDate(),
item.getTextualUploadDate()))); item.getTextualUploadDate())));
// setup bottom row, with likes, heart and replies button // setup bottom row, with likes, heart and replies button
itemLikesCountView.setText( itemLikesCountView.setText(
Localization.likeCount(itemBuilder.getContext(), item.getLikeCount())); Localization.likeCount(itemBuilder.getContext(), item.getLikeCount()));

20
app/src/main/java/org/schabi/newpipe/util/Localization.java
View File

@@ -11,6 +11,7 @@ import android.icu.text.CompactDecimalFormat;
import android.os.Build; import android.os.Build;
import android.text.TextUtils; import android.text.TextUtils;
import android.text.format.DateUtils; import android.text.format.DateUtils;
import android.text.BidiFormatter;
import android.util.DisplayMetrics; import android.util.DisplayMetrics;
import android.util.Log; import android.util.Log;
@@ -85,6 +86,25 @@ public final class Localization {
.collect(Collectors.joining(delimiter)); .collect(Collectors.joining(delimiter));
} }
/**
* Localize a user name like <code>@foobar</code>.
*
* Will correctly handle right-to-left usernames by using a {@link BidiFormatter}.
*
* @param plainName username, with an optional leading <code>@</code>
* @return a usernames that can include RTL-characters
*/
@NonNull
public static String localizeUserName(final String plainName) {
final BidiFormatter bidi = BidiFormatter.getInstance();
if (plainName.startsWith("@")) {
return "@" + bidi.unicodeWrap(plainName.substring(1));
} else {
return bidi.unicodeWrap(plainName);
}
}
public static org.schabi.newpipe.extractor.localization.Localization getPreferredLocalization( public static org.schabi.newpipe.extractor.localization.Localization getPreferredLocalization(
final Context context) { final Context context) {
return org.schabi.newpipe.extractor.localization.Localization return org.schabi.newpipe.extractor.localization.Localization