1
0
mirror of https://github.com/TeamNewPipe/NewPipe synced 2024-12-23 08:30:44 +00:00

Merge pull request #8349 from litetex/fix-PlaybackParameterDialog-resetting

Fixed accidental reset of ``PlaybackParameterDialog`` on initialization
This commit is contained in:
Stypox 2022-05-04 09:12:59 +02:00 committed by GitHub
commit 8395cf8d5a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -213,7 +213,7 @@ public class PlaybackParameterDialog extends DialogFragment {
getPitchControlModeComponentMappings() getPitchControlModeComponentMappings()
.forEach(this::setupPitchControlModeTextView); .forEach(this::setupPitchControlModeTextView);
changePitchControlMode(isCurrentPitchControlModeSemitone()); // Initialization is done at the end
// Pitch - Percent // Pitch - Percent
setText(binding.pitchPercentMinimumText, PlayerHelper::formatPitch, MIN_PITCH_OR_SPEED); setText(binding.pitchPercentMinimumText, PlayerHelper::formatPitch, MIN_PITCH_OR_SPEED);
@ -275,6 +275,9 @@ public class PlaybackParameterDialog extends DialogFragment {
skipSilence = isChecked; skipSilence = isChecked;
updateCallback(); updateCallback();
}); });
// PitchControlMode has to be initialized at the end because it requires the unhookCheckbox
changePitchControlMode(isCurrentPitchControlModeSemitone());
} }
// -- General formatting -- // -- General formatting --