mirrors/NewPipe
1
0
Fork 0
mirror of https://github.com/TeamNewPipe/NewPipe synced 2025-10-30 06:43:00 +00:00
Code Issues Releases Wiki Activity

Make all buttons in player have selectable item background borderless (#7042)

Browse Source 
Except buttons with long text or text that changes on click
This commit is contained in:
Stypox
2021-09-18 11:29:15 +02:00
committed by GitHub
parent 70354eb73e
commit 8272b2508b
2 changed files with 31 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
app/src/main/res/layout-large-land/player.xml
View File

@@ -166,7 +166,7 @@
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="35dp" android:layout_height="35dp"
android:layout_marginEnd="8dp" android:layout_marginEnd="8dp"
android:background="?attr/selectableItemBackground" android:background="?attr/selectableItemBackgroundBorderless"
android:gravity="center" android:gravity="center"
android:minWidth="0dp" android:minWidth="0dp"
android:padding="@dimen/player_main_buttons_padding" android:padding="@dimen/player_main_buttons_padding"
@@ -180,7 +180,7 @@
android:layout_width="35dp" android:layout_width="35dp"
android:layout_height="35dp" android:layout_height="35dp"
android:layout_marginEnd="8dp" android:layout_marginEnd="8dp"
android:background="?attr/selectableItemBackground" android:background="?attr/selectableItemBackgroundBorderless"
android:clickable="true" android:clickable="true"
android:focusable="true" android:focusable="true"
android:paddingStart="3dp" android:paddingStart="3dp"
@@ -199,7 +199,7 @@
android:layout_width="35dp" android:layout_width="35dp"
android:layout_height="35dp" android:layout_height="35dp"
android:layout_marginEnd="8dp" android:layout_marginEnd="8dp"
android:background="?attr/selectableItemBackground" android:background="?attr/selectableItemBackgroundBorderless"
android:clickable="true" android:clickable="true"
android:focusable="true" android:focusable="true"
android:paddingStart="3dp" android:paddingStart="3dp"
@@ -281,7 +281,7 @@
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="35dp" android:layout_height="35dp"
android:layout_marginEnd="8dp" android:layout_marginEnd="8dp"
android:background="?attr/selectableItemBackground" android:background="?attr/selectableItemBackgroundBorderless"
android:clickable="true" android:clickable="true"
android:contentDescription="@string/play_with_kodi_title" android:contentDescription="@string/play_with_kodi_title"
android:focusable="true" android:focusable="true"
@@ -296,7 +296,7 @@
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="35dp" android:layout_height="35dp"
android:layout_marginEnd="8dp" android:layout_marginEnd="8dp"
android:background="?attr/selectableItemBackground" android:background="?attr/selectableItemBackgroundBorderless"
android:clickable="true" android:clickable="true"
android:contentDescription="@string/open_in_browser" android:contentDescription="@string/open_in_browser"
android:focusable="true" android:focusable="true"
@@ -311,7 +311,7 @@
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="35dp" android:layout_height="35dp"
android:layout_marginEnd="8dp" android:layout_marginEnd="8dp"
android:background="?attr/selectableItemBackground" android:background="?attr/selectableItemBackgroundBorderless"
android:clickable="true" android:clickable="true"
android:contentDescription="@string/share" android:contentDescription="@string/share"
android:focusable="true" android:focusable="true"
@@ -325,7 +325,7 @@
android:id="@+id/switchMute" android:id="@+id/switchMute"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="37dp" android:layout_height="37dp"
android:background="?attr/selectableItemBackground" android:background="?attr/selectableItemBackgroundBorderless"
android:clickable="true" android:clickable="true"
android:contentDescription="@string/mute" android:contentDescription="@string/mute"
android:focusable="true" android:focusable="true"
@@ -339,7 +339,7 @@
android:id="@+id/fullScreenButton" android:id="@+id/fullScreenButton"
android:layout_width="40dp" android:layout_width="40dp"
android:layout_height="40dp" android:layout_height="40dp"
android:background="?attr/selectableItemBackground" android:background="?attr/selectableItemBackgroundBorderless"
android:clickable="true" android:clickable="true"
android:focusable="true" android:focusable="true"
android:padding="@dimen/player_main_buttons_padding" android:padding="@dimen/player_main_buttons_padding"
@@ -447,7 +447,7 @@
android:id="@+id/playbackLiveSync" android:id="@+id/playbackLiveSync"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="match_parent" android:layout_height="match_parent"
android:background="?attr/selectableItemBackground" android:background="?attr/selectableItemBackgroundBorderless"
android:gravity="center" android:gravity="center"
android:paddingLeft="4dp" android:paddingLeft="4dp"
android:paddingRight="4dp" android:paddingRight="4dp"
@@ -462,7 +462,7 @@
android:layout_width="40dp" android:layout_width="40dp"
android:layout_height="40dp" android:layout_height="40dp"
android:layout_marginStart="4dp" android:layout_marginStart="4dp"
android:background="?attr/selectableItemBackground" android:background="?attr/selectableItemBackgroundBorderless"
android:clickable="true" android:clickable="true"
android:focusable="true" android:focusable="true"
android:nextFocusUp="@id/playbackSeekBar" android:nextFocusUp="@id/playbackSeekBar"
@@ -566,7 +566,7 @@
android:layout_alignParentEnd="true" android:layout_alignParentEnd="true"
android:layout_centerVertical="true" android:layout_centerVertical="true"
android:layout_marginEnd="40dp" android:layout_marginEnd="40dp"
android:background="?android:selectableItemBackground" android:background="?attr/selectableItemBackgroundBorderless"
android:clickable="true" android:clickable="true"
android:contentDescription="@string/close" android:contentDescription="@string/close"
android:focusable="true" android:focusable="true"
@@ -584,7 +584,7 @@
android:layout_centerVertical="true" android:layout_centerVertical="true"
android:layout_marginStart="40dp" android:layout_marginStart="40dp"
android:layout_marginLeft="40dp" android:layout_marginLeft="40dp"
android:background="?android:selectableItemBackground" android:background="?attr/selectableItemBackgroundBorderless"
android:clickable="true" android:clickable="true"
android:focusable="true" android:focusable="true"
android:padding="10dp" android:padding="10dp"
@@ -599,7 +599,7 @@
android:layout_height="50dp" android:layout_height="50dp"
android:layout_centerVertical="true" android:layout_centerVertical="true"
android:layout_toRightOf="@id/repeatButton" android:layout_toRightOf="@id/repeatButton"
android:background="?android:selectableItemBackground" android:background="?attr/selectableItemBackgroundBorderless"
android:clickable="true" android:clickable="true"
android:focusable="true" android:focusable="true"
android:padding="10dp" android:padding="10dp"
@@ -614,8 +614,8 @@
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_centerVertical="true" android:layout_centerVertical="true"
android:layout_toLeftOf="@id/itemsListClose" android:layout_toStartOf="@id/itemsListClose"
android:layout_toRightOf="@id/shuffleButton" android:layout_toEndOf="@id/shuffleButton"
android:gravity="center" android:gravity="center"
android:textColor="@android:color/white" /> android:textColor="@android:color/white" />
</RelativeLayout> </RelativeLayout>

32
app/src/main/res/layout/player.xml
View File

@@ -168,7 +168,7 @@
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="35dp" android:layout_height="35dp"
android:layout_marginEnd="8dp" android:layout_marginEnd="8dp"
android:background="?attr/selectableItemBackground" android:background="?attr/selectableItemBackgroundBorderless"
android:gravity="center" android:gravity="center"
android:minWidth="0dp" android:minWidth="0dp"
android:padding="@dimen/player_main_buttons_padding" android:padding="@dimen/player_main_buttons_padding"
@@ -182,7 +182,7 @@
android:layout_width="35dp" android:layout_width="35dp"
android:layout_height="35dp" android:layout_height="35dp"
android:layout_marginEnd="8dp" android:layout_marginEnd="8dp"
android:background="?attr/selectableItemBackground" android:background="?attr/selectableItemBackgroundBorderless"
android:clickable="true" android:clickable="true"
android:focusable="true" android:focusable="true"
android:paddingStart="3dp" android:paddingStart="3dp"
@@ -200,7 +200,7 @@
android:layout_width="35dp" android:layout_width="35dp"
android:layout_height="35dp" android:layout_height="35dp"
android:layout_marginEnd="8dp" android:layout_marginEnd="8dp"
android:background="?attr/selectableItemBackground" android:background="?attr/selectableItemBackgroundBorderless"
android:clickable="true" android:clickable="true"
android:focusable="true" android:focusable="true"
android:paddingStart="6dp" android:paddingStart="6dp"
@@ -280,7 +280,7 @@
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="35dp" android:layout_height="35dp"
android:layout_marginEnd="8dp" android:layout_marginEnd="8dp"
android:background="?attr/selectableItemBackground" android:background="?attr/selectableItemBackgroundBorderless"
android:clickable="true" android:clickable="true"
android:contentDescription="@string/play_with_kodi_title" android:contentDescription="@string/play_with_kodi_title"
android:focusable="true" android:focusable="true"
@@ -295,7 +295,7 @@
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="35dp" android:layout_height="35dp"
android:layout_marginEnd="8dp" android:layout_marginEnd="8dp"
android:background="?attr/selectableItemBackground" android:background="?attr/selectableItemBackgroundBorderless"
android:clickable="true" android:clickable="true"
android:contentDescription="@string/open_in_browser" android:contentDescription="@string/open_in_browser"
android:focusable="true" android:focusable="true"
@@ -310,7 +310,7 @@
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="35dp" android:layout_height="35dp"
android:layout_marginEnd="8dp" android:layout_marginEnd="8dp"
android:background="?attr/selectableItemBackground" android:background="?attr/selectableItemBackgroundBorderless"
android:clickable="true" android:clickable="true"
android:contentDescription="@string/share" android:contentDescription="@string/share"
android:focusable="true" android:focusable="true"
@@ -324,7 +324,7 @@
android:id="@+id/switchMute" android:id="@+id/switchMute"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="37dp" android:layout_height="37dp"
android:background="?attr/selectableItemBackground" android:background="?attr/selectableItemBackgroundBorderless"
android:clickable="true" android:clickable="true"
android:contentDescription="@string/mute" android:contentDescription="@string/mute"
android:focusable="true" android:focusable="true"
@@ -338,7 +338,7 @@
android:id="@+id/fullScreenButton" android:id="@+id/fullScreenButton"
android:layout_width="40dp" android:layout_width="40dp"
android:layout_height="40dp" android:layout_height="40dp"
android:background="?attr/selectableItemBackground" android:background="?attr/selectableItemBackgroundBorderless"
android:clickable="true" android:clickable="true"
android:focusable="true" android:focusable="true"
android:padding="@dimen/player_main_buttons_padding" android:padding="@dimen/player_main_buttons_padding"
@@ -445,7 +445,7 @@
android:id="@+id/playbackLiveSync" android:id="@+id/playbackLiveSync"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="match_parent" android:layout_height="match_parent"
android:background="?attr/selectableItemBackground" android:background="?attr/selectableItemBackgroundBorderless"
android:gravity="center" android:gravity="center"
android:paddingLeft="4dp" android:paddingLeft="4dp"
android:paddingRight="4dp" android:paddingRight="4dp"
@@ -460,7 +460,7 @@
android:layout_width="40dp" android:layout_width="40dp"
android:layout_height="40dp" android:layout_height="40dp"
android:layout_marginStart="4dp" android:layout_marginStart="4dp"
android:background="?attr/selectableItemBackground" android:background="?attr/selectableItemBackgroundBorderless"
android:clickable="true" android:clickable="true"
android:focusable="true" android:focusable="true"
android:padding="@dimen/player_main_buttons_padding" android:padding="@dimen/player_main_buttons_padding"
@@ -562,7 +562,7 @@
android:layout_alignParentEnd="true" android:layout_alignParentEnd="true"
android:layout_centerVertical="true" android:layout_centerVertical="true"
android:layout_marginEnd="40dp" android:layout_marginEnd="40dp"
android:background="?android:selectableItemBackground" android:background="?attr/selectableItemBackgroundBorderless"
android:clickable="true" android:clickable="true"
android:contentDescription="@string/close" android:contentDescription="@string/close"
android:focusable="true" android:focusable="true"
@@ -580,7 +580,7 @@
android:layout_centerVertical="true" android:layout_centerVertical="true"
android:layout_marginStart="40dp" android:layout_marginStart="40dp"
android:layout_marginLeft="40dp" android:layout_marginLeft="40dp"
android:background="?android:selectableItemBackground" android:background="?attr/selectableItemBackgroundBorderless"
android:clickable="true" android:clickable="true"
android:focusable="true" android:focusable="true"
android:padding="10dp" android:padding="10dp"
@@ -595,7 +595,7 @@
android:layout_height="50dp" android:layout_height="50dp"
android:layout_centerVertical="true" android:layout_centerVertical="true"
android:layout_toRightOf="@id/repeatButton" android:layout_toRightOf="@id/repeatButton"
android:background="?android:selectableItemBackground" android:background="?attr/selectableItemBackgroundBorderless"
android:clickable="true" android:clickable="true"
android:focusable="true" android:focusable="true"
android:padding="10dp" android:padding="10dp"
@@ -611,8 +611,8 @@
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_centerVertical="true" android:layout_centerVertical="true"
android:layout_toRightOf="@id/shuffleButton" android:layout_toEndOf="@id/shuffleButton"
android:layout_toLeftOf="@id/itemsListClose" android:layout_toStartOf="@id/itemsListClose"
android:textColor="@android:color/white" /> android:textColor="@android:color/white" />
</RelativeLayout> </RelativeLayout>
@@ -722,7 +722,7 @@
android:layout_height="70dp" android:layout_height="70dp"
android:layout_centerInParent="true" android:layout_centerInParent="true"
tools:ignore="ContentDescription" tools:ignore="ContentDescription"
tools:src="@drawable/ic_brightness" /> tools:src="@drawable/ic_brightness_high" />
</RelativeLayout> </RelativeLayout>
</RelativeLayout> </RelativeLayout>