From 34f19c42685defb49ad24d6e570e45fe0ee02ecb Mon Sep 17 00:00:00 2001 From: John Zhen Mo Date: Wed, 21 Feb 2018 10:42:54 -0800 Subject: [PATCH] -Changed Rx exception handling to swallow undeliverable exceptions by default. --- app/src/debug/java/org/schabi/newpipe/DebugApp.java | 2 +- app/src/main/java/org/schabi/newpipe/App.java | 2 +- app/src/main/res/xml/debug_settings.xml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/src/debug/java/org/schabi/newpipe/DebugApp.java b/app/src/debug/java/org/schabi/newpipe/DebugApp.java index df4949edd..ce1cff0b6 100644 --- a/app/src/debug/java/org/schabi/newpipe/DebugApp.java +++ b/app/src/debug/java/org/schabi/newpipe/DebugApp.java @@ -61,7 +61,7 @@ public class DebugApp extends App { @Override protected boolean isDisposedRxExceptionsReported() { return PreferenceManager.getDefaultSharedPreferences(this) - .getBoolean(getString(R.string.allow_disposed_exceptions_key), true); + .getBoolean(getString(R.string.allow_disposed_exceptions_key), false); } @Override diff --git a/app/src/main/java/org/schabi/newpipe/App.java b/app/src/main/java/org/schabi/newpipe/App.java index 9de6f183d..deeec94ca 100644 --- a/app/src/main/java/org/schabi/newpipe/App.java +++ b/app/src/main/java/org/schabi/newpipe/App.java @@ -210,6 +210,6 @@ public class App extends Application { } protected boolean isDisposedRxExceptionsReported() { - return true; + return false; } } diff --git a/app/src/main/res/xml/debug_settings.xml b/app/src/main/res/xml/debug_settings.xml index 67705e018..c0bb1505d 100644 --- a/app/src/main/res/xml/debug_settings.xml +++ b/app/src/main/res/xml/debug_settings.xml @@ -11,7 +11,7 @@ android:summary="@string/enable_leak_canary_summary"/>