From 5db0cc524174dfda56d19cc7e1bd61d91fa8ec06 Mon Sep 17 00:00:00 2001
From: BO41 <lukasw41@gmail.com>
Date: Tue, 28 Aug 2018 19:40:05 +0200
Subject: [PATCH] performance + usability

obsolete layout params
Ellipsis string can be replaced with ellipsis character
Missing inputType
Usage of showAsAction=always

BUILD SUCCESSFUL in 5s
39 actionable tasks: 4 executed, 35 up-to-date
---
 app/src/main/res/layout/activity_error.xml      | 3 ++-
 app/src/main/res/layout/mission_item_linear.xml | 3 +--
 app/src/main/res/menu/menu_videooptions.xml     | 6 +++---
 app/src/main/res/values-hu/strings.xml          | 2 +-
 app/src/main/res/values-ko/strings.xml          | 2 +-
 5 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/app/src/main/res/layout/activity_error.xml b/app/src/main/res/layout/activity_error.xml
index 7752dc7cb..c47077c73 100644
--- a/app/src/main/res/layout/activity_error.xml
+++ b/app/src/main/res/layout/activity_error.xml
@@ -114,7 +114,8 @@
             <EditText
                 android:id="@+id/errorCommentBox"
                 android:layout_width="match_parent"
-                android:layout_height="wrap_content"/>
+                android:layout_height="wrap_content"
+                android:inputType="" />
 
             <Button
                 android:id="@+id/errorReportButton"
diff --git a/app/src/main/res/layout/mission_item_linear.xml b/app/src/main/res/layout/mission_item_linear.xml
index 27c818fb9..21f637839 100644
--- a/app/src/main/res/layout/mission_item_linear.xml
+++ b/app/src/main/res/layout/mission_item_linear.xml
@@ -45,8 +45,7 @@
 				android:id="@+id/item_size"
 				android:layout_width="match_parent"
 				android:layout_height="wrap_content"
-				android:layout_below="@id/item_name"
-				android:padding="6dp"
+                android:padding="6dp"
 				android:singleLine="true"
 				android:text="100.00MB"
 				android:textSize="12sp"
diff --git a/app/src/main/res/menu/menu_videooptions.xml b/app/src/main/res/menu/menu_videooptions.xml
index ce69ba9c1..9a3262148 100644
--- a/app/src/main/res/menu/menu_videooptions.xml
+++ b/app/src/main/res/menu/menu_videooptions.xml
@@ -7,16 +7,16 @@
         android:id="@+id/toggleOrientation"
         android:icon="@drawable/ic_screen_rotation_white"
         android:title="@string/toggle_orientation"
-        app:showAsAction="always|withText" />
+        app:showAsAction="ifRoom|withText" />
     <item
         android:id="@+id/switchPopup"
         android:icon="@drawable/ic_fullscreen_exit_white"
         android:title="@string/switch_to_popup"
-        app:showAsAction="always|withText" />
+        app:showAsAction="ifRoom|withText" />
     <item
         android:id="@+id/switchBackground"
         android:icon="?audio"
         android:title="@string/switch_to_background"
-        app:showAsAction="always|withText" />
+        app:showAsAction="ifRoom|withText" />
 </menu>
 
diff --git a/app/src/main/res/values-hu/strings.xml b/app/src/main/res/values-hu/strings.xml
index 1f925eb39..f4687149a 100644
--- a/app/src/main/res/values-hu/strings.xml
+++ b/app/src/main/res/values-hu/strings.xml
@@ -111,7 +111,7 @@
     <string name="msg_url_malform">Hibás URL vagy nincs internet</string>
     <string name="msg_running">NewPipe letöltés folyamatban</string>
     <string name="msg_running_detail">Katt a részletekért</string>
-    <string name="msg_wait">Kérlek várj...</string>
+    <string name="msg_wait">Kérlek várj…</string>
     <string name="msg_copied">Vágólapra másolva.</string>
     <string name="no_available_dir">Kérlek válassz egy létező könyvtárat a letöltésekhez.</string>
 
diff --git a/app/src/main/res/values-ko/strings.xml b/app/src/main/res/values-ko/strings.xml
index 2eee6b809..d00ee12ea 100644
--- a/app/src/main/res/values-ko/strings.xml
+++ b/app/src/main/res/values-ko/strings.xml
@@ -414,7 +414,7 @@
 \n
 \n만약 모르신다면, 다음을 참고하세요:
 \n
-\n1. 모바일 환경이시면 브라우저 설정에서 데스크탑 모드를 활성화해주세요. Chrome 모바일에서는 오른쪽 ... 클릭시 아래쪽에 있습니다.
+\n1. 모바일 환경이시면 브라우저 설정에서 데스크탑 모드를 활성화해주세요. Chrome 모바일에서는 오른쪽 … 클릭시 아래쪽에 있습니다.
 \n2. 이 주소로 가세요: %1$s 
 \n3. 로그인이 필요하면 하세요.
 \n4. 리디렉트된 곳의 URL을 복사하세요. (이 URL이 당신의 프로필 URL 입니다)</string>