use the standard "Movies" folder for downloads

On all of the devices that I've checked, there is a folder called "Movies"
on the SD Card by default.  NewPipe should use that standard location
since it is always downloading movies :).  People can always change that
via the preferences.

Also, this makes the defaults the same when creating the dir and when
setting the destination URL.

app/src/main/java/org/schabi/newpipe/DownloadDialog.java

@@ -57,7 +57,7 @@ public class DownloadDialog extends DialogFragment {
                     @Override
                     public void onClick(DialogInterface dialog, int which) {
                         Context context = getActivity();
-                        SharedPreferences defaultPreferences = PreferenceManager.getDefaultSharedPreferences(context);
+                        SharedPreferences prefs = PreferenceManager.getDefaultSharedPreferences(context);
                         String suffix = "";
                         String title = arguments.getString(TITLE);
                         String url = "";
@@ -73,10 +73,10 @@ public class DownloadDialog extends DialogFragment {
                             default:
                                 Log.d(TAG, "lolz");
                         }
-                        //to avoid hard-coded string like "/storage/emulated/0/NewPipe"
+                        //to avoid hard-coded string like "/storage/emulated/0/Movies"
-                        final File dir = new File(defaultPreferences.getString(
+                        String downloadPath = prefs.getString(getString(R.string.downloadPathPreference),
-                                "download_path_preference",
+                                Environment.getExternalStorageDirectory().getAbsolutePath() + "/Movies");
-                                Environment.getExternalStorageDirectory().getAbsolutePath() + "/NewPipe"));
+                        final File dir = new File(downloadPath);
                         if(!dir.exists()) {
                             boolean mkdir = dir.mkdir(); //attempt to create directory
                             if(!mkdir && !dir.isDirectory()) {
@@ -87,9 +87,7 @@ public class DownloadDialog extends DialogFragment {
                         DownloadManager dm = (DownloadManager) context.getSystemService(Context.DOWNLOAD_SERVICE);
                         DownloadManager.Request request = new DownloadManager.Request(
                                 Uri.parse(url));
-                        request.setDestinationUri(Uri.fromFile(new File(
+                        request.setDestinationUri(Uri.fromFile(new File(dir + "/" + title + suffix)));
-                                defaultPreferences.getString("download_path_preference", "/storage/emulated/0/NewPipe")
-                                        + "/" + title + suffix)));
                         request.setNotificationVisibility(DownloadManager.Request.VISIBILITY_VISIBLE_NOTIFY_COMPLETED);
                         try {
                             dm.enqueue(request);

app/src/main/java/org/schabi/newpipe/SettingsActivity.java

@@ -1,13 +1,9 @@
 package org.schabi.newpipe;
 
-import android.content.Context;
-import android.content.SharedPreferences;
 import android.content.res.Configuration;
 import android.os.Bundle;
-import android.os.Environment;
 import android.preference.PreferenceActivity;
 import android.preference.PreferenceFragment;
-import android.preference.PreferenceManager;
 import android.support.annotation.LayoutRes;
 import android.support.annotation.NonNull;
 import android.support.v7.app.ActionBar;
@@ -148,17 +144,4 @@ public class SettingsActivity extends PreferenceActivity {
         }
         return true;
     }
-
-    public static void initSettings(Context context) {
-        PreferenceManager.setDefaultValues(context, R.xml.settings_screen, false);
-        SharedPreferences sp = PreferenceManager.getDefaultSharedPreferences(context);
-        if(sp.getString(context.getString(R.string.downloadPathPreference), "").isEmpty()){
-            SharedPreferences.Editor spEditor = sp.edit();
-            String newPipeDownloadStorage =
-                    Environment.getExternalStorageDirectory().getAbsolutePath() + "/NewPipe";
-            spEditor.putString(context.getString(R.string.downloadPathPreference)
-                    , newPipeDownloadStorage);
-            spEditor.apply();
-        }
-    }
 }

app/src/main/java/org/schabi/newpipe/VideoItemListActivity.java

@@ -3,6 +3,7 @@ package org.schabi.newpipe;
 import android.content.Context;
 import android.content.Intent;
 import android.os.Bundle;
+import android.preference.PreferenceManager;
 import android.support.v4.app.NavUtils;
 import android.support.v7.app.AppCompatActivity;
 import android.support.v7.widget.SearchView;
@@ -171,7 +172,7 @@ public class VideoItemListActivity extends AppCompatActivity
             }
         }
 
-        SettingsActivity.initSettings(this);
+        PreferenceManager.setDefaultValues(this, R.xml.settings_screen, false);
     }
 
     /**

app/src/main/res/xml/settings_screen.xml

@@ -64,8 +64,7 @@
             android:key="@string/downloadPathPreference"
             android:title="@string/downloadLocation"
             android:summary="@string/downloadLocationSummary"
-            android:dialogTitle="@string/downloadLocationDialogTitle"
+            android:dialogTitle="@string/downloadLocationDialogTitle" />
-            android:defaultValue=""/>
 
         <CheckBoxPreference
             android:key="@string/autoPlayThroughIntent"
@@ -74,4 +73,4 @@
             android:defaultValue="false" />
 
     </PreferenceCategory>
-</PreferenceScreen>
+</PreferenceScreen>