From 4fbd1182c2f3ddf86c9f742d1934081ea8a9bfa2 Mon Sep 17 00:00:00 2001 From: John Zhen Mo Date: Tue, 26 Jun 2018 10:19:16 -0700 Subject: [PATCH] -Fixed minimizing to popup player does not destroying existing player when drawing over app permission is not granted. --- .../java/org/schabi/newpipe/player/MainVideoPlayer.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/src/main/java/org/schabi/newpipe/player/MainVideoPlayer.java b/app/src/main/java/org/schabi/newpipe/player/MainVideoPlayer.java index 8a4fb62da..8a5844a43 100644 --- a/app/src/main/java/org/schabi/newpipe/player/MainVideoPlayer.java +++ b/app/src/main/java/org/schabi/newpipe/player/MainVideoPlayer.java @@ -219,11 +219,10 @@ public final class MainVideoPlayer extends AppCompatActivity getWindow().getAttributes().screenBrightness); if (playerImpl == null) return; - if (isBackPressed) { - playerImpl.destroy(); - } else { + if (!isBackPressed) { playerImpl.minimize(); } + playerImpl.destroy(); isInMultiWindow = false; isBackPressed = false; @@ -465,7 +464,8 @@ public final class MainVideoPlayer extends AppCompatActivity onFullScreenButtonClicked(); break; case PlayerHelper.MinimizeMode.MINIMIZE_ON_EXIT_MODE_NONE: - destroy(); + default: + // No action break; } }