mirrors/NewPipe
1
0
Fork 0
mirror of https://github.com/TeamNewPipe/NewPipe synced 2025-01-10 17:30:31 +00:00
Code Issues Releases Wiki Activity

Improve HistoryRecordManager tests (#7700)

Browse Source 
* Improve HistoryRecordManager tests

* Improve shuffle as requested
This commit is contained in:
Stypox 2022-01-27 14:43:51 +01:00 committed by GitHub
parent 17c0fffd73
commit 466db83375
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 34 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
app/src/androidTest/java/org/schabi/newpipe/local/history/HistoryRecordManagerTest.kt
View File

@ -97,14 +97,23 @@ class HistoryRecordManagerTest {
assertThat(database.searchHistoryDAO().all.blockingFirst()).isEmpty() assertThat(database.searchHistoryDAO().all.blockingFirst()).isEmpty()
} }
@Test private fun insertShuffledRelatedSearches(relatedSearches: Collection<SearchHistoryEntry>) {
fun getRelatedSearches_emptyQuery() {
// shuffle to make sure the order of items returned by queries depends only on
// SearchHistoryEntry.creationDate, not on the actual insertion time, so that we can
// verify that the `ORDER BY` clause does its job
database.searchHistoryDAO().insertAll(relatedSearches.shuffled())
// make sure all entries were inserted // make sure all entries were inserted
database.searchHistoryDAO().insertAll(RELATED_SEARCHES_ENTRIES)
assertEquals( assertEquals(
RELATED_SEARCHES_ENTRIES.size, relatedSearches.size,
database.searchHistoryDAO().all.blockingFirst().size database.searchHistoryDAO().all.blockingFirst().size
) )
}
@Test
fun getRelatedSearches_emptyQuery() {
insertShuffledRelatedSearches(RELATED_SEARCHES_ENTRIES)
// make sure correct number of searches is returned and in correct order // make sure correct number of searches is returned and in correct order
val searches = manager.getRelatedSearches("", 6, 4).blockingFirst() val searches = manager.getRelatedSearches("", 6, 4).blockingFirst()
@ -117,14 +126,29 @@ class HistoryRecordManagerTest {
} }
@Test @Test
fun getRelatedSearched_nonEmptyQuery() { fun getRelatedSearches_emptyQuery_manyDuplicates() {
// make sure all entries were inserted insertShuffledRelatedSearches(
database.searchHistoryDAO().insertAll(RELATED_SEARCHES_ENTRIES) listOf(
assertEquals( SearchHistoryEntry(time.minusSeconds(9), 3, "A"),
RELATED_SEARCHES_ENTRIES.size, SearchHistoryEntry(time.minusSeconds(8), 3, "AB"),
database.searchHistoryDAO().all.blockingFirst().size SearchHistoryEntry(time.minusSeconds(7), 3, "A"),
SearchHistoryEntry(time.minusSeconds(6), 3, "A"),
SearchHistoryEntry(time.minusSeconds(5), 3, "BA"),
SearchHistoryEntry(time.minusSeconds(4), 3, "A"),
SearchHistoryEntry(time.minusSeconds(3), 3, "A"),
SearchHistoryEntry(time.minusSeconds(2), 0, "A"),
SearchHistoryEntry(time.minusSeconds(1), 2, "AA"),
)
) )
val searches = manager.getRelatedSearches("", 9, 3).blockingFirst()
assertThat(searches).containsExactly("AA", "A", "BA")
}
@Test
fun getRelatedSearched_nonEmptyQuery() {
insertShuffledRelatedSearches(RELATED_SEARCHES_ENTRIES)
// make sure correct number of searches is returned and in correct order // make sure correct number of searches is returned and in correct order
val searches = manager.getRelatedSearches("A", 3, 5).blockingFirst() val searches = manager.getRelatedSearches("A", 3, 5).blockingFirst()
assertThat(searches).containsExactly( assertThat(searches).containsExactly(