mirrors/NewPipe
1
0
Fork 0
mirror of https://github.com/TeamNewPipe/NewPipe synced 2025-10-31 07:13:00 +00:00
Code Issues Releases Wiki Activity

added contentDescription for better accesebility

Browse Source
This commit is contained in:
Christian Schabesberger
2015-11-26 18:47:36 +01:00
parent 189bee3e44
commit 2afee89de3
5 changed files with 20 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/src/main/res/layout-land/fragment_videoitem_detail.xml
View File

@@ -31,6 +31,7 @@
android:layout_height="wrap_content"> android:layout_height="wrap_content">
<ImageView android:id="@+id/detailThumbnailView" <ImageView android:id="@+id/detailThumbnailView"
android:contentDescription="@string/detailThumbnailViewDescription"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:scaleType="centerInside" android:scaleType="centerInside"
@@ -58,6 +59,7 @@
android:textAppearance="?android:attr/textAppearanceLarge"/> android:textAppearance="?android:attr/textAppearanceLarge"/>
<ImageView android:id="@+id/detailUploaderThumbnailView" <ImageView android:id="@+id/detailUploaderThumbnailView"
android:contentDescription="@string/detailUploaderThumbnailViewDescription"
android:layout_width="100dp" android:layout_width="100dp"
android:layout_height="100dp" android:layout_height="100dp"
android:layout_below="@id/detailVideoTitleView" android:layout_below="@id/detailVideoTitleView"
@@ -91,6 +93,7 @@
android:textAppearance="?android:attr/textAppearanceMedium" /> android:textAppearance="?android:attr/textAppearanceMedium" />
<ImageView android:id="@+id/detailThumbsDownImgView" <ImageView android:id="@+id/detailThumbsDownImgView"
android:contentDescription="@string/detailThumbsDownImgViewDescription"
android:layout_width="40dp" android:layout_width="40dp"
android:layout_height="20dp" android:layout_height="20dp"
android:layout_below="@id/detailViewCountView" android:layout_below="@id/detailViewCountView"
@@ -108,6 +111,7 @@
android:textAppearance="?android:attr/textAppearanceMedium" /> android:textAppearance="?android:attr/textAppearanceMedium" />
<ImageView android:id="@+id/detailThumbsUpImgView" <ImageView android:id="@+id/detailThumbsUpImgView"
android:contentDescription="@string/detailThumbsUpImgViewDescription"
android:layout_width="40dp" android:layout_width="40dp"
android:layout_height="20dp" android:layout_height="20dp"
android:layout_below="@id/detailViewCountView" android:layout_below="@id/detailViewCountView"

4
app/src/main/res/layout-sw600dp/fragment_videoitem_detail.xml
View File

@@ -31,6 +31,7 @@
android:layout_height="wrap_content"> android:layout_height="wrap_content">
<ImageView android:id="@+id/detailThumbnailView" <ImageView android:id="@+id/detailThumbnailView"
android:contentDescription="@string/detailThumbnailViewDescription"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:scaleType="centerInside" android:scaleType="centerInside"
@@ -58,6 +59,7 @@
android:textAppearance="?android:attr/textAppearanceLarge"/> android:textAppearance="?android:attr/textAppearanceLarge"/>
<ImageView android:id="@+id/detailUploaderThumbnailView" <ImageView android:id="@+id/detailUploaderThumbnailView"
android:contentDescription="@string/detailUploaderThumbnailViewDescription"
android:layout_width="100dp" android:layout_width="100dp"
android:layout_height="100dp" android:layout_height="100dp"
android:layout_below="@id/detailVideoTitleView" android:layout_below="@id/detailVideoTitleView"
@@ -91,6 +93,7 @@
android:textAppearance="?android:attr/textAppearanceMedium"/> android:textAppearance="?android:attr/textAppearanceMedium"/>
<ImageView android:id="@+id/detailThumbsDownImgView" <ImageView android:id="@+id/detailThumbsDownImgView"
android:contentDescription="@string/detailThumbsDownImgViewDescription"
android:layout_width="40dp" android:layout_width="40dp"
android:layout_height="20dp" android:layout_height="20dp"
android:layout_below="@id/detailViewCountView" android:layout_below="@id/detailViewCountView"
@@ -108,6 +111,7 @@
android:textAppearance="?android:attr/textAppearanceMedium" /> android:textAppearance="?android:attr/textAppearanceMedium" />
<ImageView android:id="@+id/detailThumbsUpImgView" <ImageView android:id="@+id/detailThumbsUpImgView"
android:contentDescription="@string/detailThumbsUpImgViewDescription"
android:layout_width="40dp" android:layout_width="40dp"
android:layout_height="20dp" android:layout_height="20dp"
android:layout_below="@id/detailViewCountView" android:layout_below="@id/detailViewCountView"

4
app/src/main/res/layout/fragment_videoitem_detail.xml
View File

@@ -31,6 +31,7 @@
android:layout_height="wrap_content"> android:layout_height="wrap_content">
<ImageView android:id="@+id/detailThumbnailView" <ImageView android:id="@+id/detailThumbnailView"
android:contentDescription="@string/detailThumbnailViewDescription"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:scaleType="centerInside" android:scaleType="centerInside"
@@ -58,6 +59,7 @@
android:textAppearance="?android:attr/textAppearanceLarge"/> android:textAppearance="?android:attr/textAppearanceLarge"/>
<ImageView android:id="@+id/detailUploaderThumbnailView" <ImageView android:id="@+id/detailUploaderThumbnailView"
android:contentDescription="@string/detailUploaderThumbnailViewDescription"
android:layout_width="80dp" android:layout_width="80dp"
android:layout_height="80dp" android:layout_height="80dp"
android:layout_below="@id/detailVideoTitleView" android:layout_below="@id/detailVideoTitleView"
@@ -91,6 +93,7 @@
android:textAppearance="?android:attr/textAppearanceMedium" /> android:textAppearance="?android:attr/textAppearanceMedium" />
<ImageView android:id="@+id/detailThumbsDownImgView" <ImageView android:id="@+id/detailThumbsDownImgView"
android:contentDescription="@string/detailThumbsDownImgViewDescription"
android:layout_width="30dp" android:layout_width="30dp"
android:layout_height="15dp" android:layout_height="15dp"
android:layout_below="@id/detailViewCountView" android:layout_below="@id/detailViewCountView"
@@ -108,6 +111,7 @@
android:textAppearance="?android:attr/textAppearanceMedium"/> android:textAppearance="?android:attr/textAppearanceMedium"/>
<ImageView android:id="@+id/detailThumbsUpImgView" <ImageView android:id="@+id/detailThumbsUpImgView"
android:contentDescription="@string/detailThumbsUpImgViewDescription"
android:layout_width="30dp" android:layout_width="30dp"
android:layout_height="15dp" android:layout_height="15dp"
android:layout_below="@id/detailViewCountView" android:layout_below="@id/detailViewCountView"

1
app/src/main/res/layout/video_item.xml
View File

@@ -7,6 +7,7 @@
android:padding="6dp"> android:padding="6dp">
<ImageView android:id="@+id/itemThumbnailView" <ImageView android:id="@+id/itemThumbnailView"
android:contentDescription="@string/itemThumbnailViewDescription"
android:layout_width="142dp" android:layout_width="142dp"
android:layout_height="80dp" android:layout_height="80dp"
android:layout_marginRight="6dp" android:layout_marginRight="6dp"

7
app/src/main/res/values/strings.xml
View File

@@ -53,4 +53,11 @@
<string name="settingsCategoryVideoAudioTitle">VIDEO &amp; AUDIO</string> <string name="settingsCategoryVideoAudioTitle">VIDEO &amp; AUDIO</string>
<string name="settingsCategoryVideoInfoTittle">INFO</string> <string name="settingsCategoryVideoInfoTittle">INFO</string>
<string name="settingsCategoryEtcTitle">ETC</string> <string name="settingsCategoryEtcTitle">ETC</string>
<!-- Content descriptions (for better accessibility) -->
<string name="itemThumbnailViewDescription">Video preview thumbnail</string>
<string name="detailThumbnailViewDescription">Video preview thumbnail</string>
<string name="detailUploaderThumbnailViewDescription">Uploader thumbnail</string>
<string name="detailThumbsDownImgViewDescription">Unlikes</string>
<string name="detailThumbsUpImgViewDescription">Likes</string>
</resources> </resources>