From 505c528194ec3d6c2345d9e20337ab1a90ac20b8 Mon Sep 17 00:00:00 2001
From: Vasily <nvasya95@gmail.com>
Date: Thu, 27 Dec 2018 16:29:17 +0200
Subject: [PATCH] Show close button when playing completed

---
 .../schabi/newpipe/player/MainVideoPlayer.java   | 12 +++++++++++-
 .../layout-large-land/activity_main_player.xml   | 16 ++++++++++++++++
 app/src/main/res/layout/activity_main_player.xml | 16 ++++++++++++++++
 app/src/main/res/values-ru/strings.xml           |  1 +
 app/src/main/res/values/strings.xml              |  1 +
 5 files changed, 45 insertions(+), 1 deletion(-)

diff --git a/app/src/main/java/org/schabi/newpipe/player/MainVideoPlayer.java b/app/src/main/java/org/schabi/newpipe/player/MainVideoPlayer.java
index f4fea5165..cc906bbca 100644
--- a/app/src/main/java/org/schabi/newpipe/player/MainVideoPlayer.java
+++ b/app/src/main/java/org/schabi/newpipe/player/MainVideoPlayer.java
@@ -46,6 +46,7 @@ import android.view.GestureDetector;
 import android.view.MotionEvent;
 import android.view.View;
 import android.view.WindowManager;
+import android.widget.Button;
 import android.widget.ImageButton;
 import android.widget.ImageView;
 import android.widget.PopupMenu;
@@ -397,6 +398,7 @@ public final class MainVideoPlayer extends AppCompatActivity
         private ImageButton playPauseButton;
         private ImageButton playPreviousButton;
         private ImageButton playNextButton;
+        private Button closeButton;
 
         private RelativeLayout queueLayout;
         private ImageButton itemsListCloseButton;
@@ -437,6 +439,7 @@ public final class MainVideoPlayer extends AppCompatActivity
             this.playPauseButton = rootView.findViewById(R.id.playPauseButton);
             this.playPreviousButton = rootView.findViewById(R.id.playPreviousButton);
             this.playNextButton = rootView.findViewById(R.id.playNextButton);
+            this.closeButton = rootView.findViewById(R.id.closeButton);
 
             this.moreOptionsButton = rootView.findViewById(R.id.moreOptionsButton);
             this.secondaryControls = rootView.findViewById(R.id.secondaryControls);
@@ -483,6 +486,7 @@ public final class MainVideoPlayer extends AppCompatActivity
             playPauseButton.setOnClickListener(this);
             playPreviousButton.setOnClickListener(this);
             playNextButton.setOnClickListener(this);
+            closeButton.setOnClickListener(this);
 
             moreOptionsButton.setOnClickListener(this);
             toggleOrientationButton.setOnClickListener(this);
@@ -644,6 +648,9 @@ public final class MainVideoPlayer extends AppCompatActivity
             } else if (v.getId() == switchBackgroundButton.getId()) {
                 onPlayBackgroundButtonClicked();
 
+            } else if (v.getId() == closeButton.getId()) {
+                onPlaybackShutdown();
+                return;
             }
 
             if (getCurrentState() != STATE_COMPLETED) {
@@ -770,6 +777,7 @@ public final class MainVideoPlayer extends AppCompatActivity
             super.onBlocked();
             playPauseButton.setImageResource(R.drawable.ic_pause_white);
             animatePlayButtons(false, 100);
+            animateView(closeButton, false, DEFAULT_CONTROLS_DURATION);
             getRootView().setKeepScreenOn(true);
         }
 
@@ -785,6 +793,7 @@ public final class MainVideoPlayer extends AppCompatActivity
             animateView(playPauseButton, AnimationUtils.Type.SCALE_AND_ALPHA, false, 80, 0, () -> {
                 playPauseButton.setImageResource(R.drawable.ic_pause_white);
                 animatePlayButtons(true, 200);
+                animateView(closeButton, false, DEFAULT_CONTROLS_DURATION);
             });
 
             getRootView().setKeepScreenOn(true);
@@ -796,6 +805,7 @@ public final class MainVideoPlayer extends AppCompatActivity
             animateView(playPauseButton, AnimationUtils.Type.SCALE_AND_ALPHA, false, 80, 0, () -> {
                 playPauseButton.setImageResource(R.drawable.ic_play_arrow_white);
                 animatePlayButtons(true, 200);
+                animateView(closeButton, false, DEFAULT_CONTROLS_DURATION);
             });
 
             showSystemUi();
@@ -815,8 +825,8 @@ public final class MainVideoPlayer extends AppCompatActivity
             animateView(playPauseButton, AnimationUtils.Type.SCALE_AND_ALPHA, false, 0, 0, () -> {
                 playPauseButton.setImageResource(R.drawable.ic_replay_white);
                 animatePlayButtons(true, DEFAULT_CONTROLS_DURATION);
+                animateView(closeButton, true, DEFAULT_CONTROLS_DURATION);
             });
-
             getRootView().setKeepScreenOn(false);
             super.onCompleted();
         }
diff --git a/app/src/main/res/layout-large-land/activity_main_player.xml b/app/src/main/res/layout-large-land/activity_main_player.xml
index 7d7e1230e..eed010ed8 100644
--- a/app/src/main/res/layout-large-land/activity_main_player.xml
+++ b/app/src/main/res/layout-large-land/activity_main_player.xml
@@ -460,6 +460,22 @@
             android:src="@drawable/exo_controls_next"
             tools:ignore="ContentDescription"/>
 
+        <Button
+            android:id="@+id/closeButton"
+            style="@style/Widget.AppCompat.Button.Borderless"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:layout_below="@id/playPauseButton"
+            android:layout_centerInParent="true"
+            android:layout_marginTop="10dp"
+            android:background="?attr/selectableItemBackgroundBorderless"
+            android:clickable="true"
+            android:focusable="true"
+            android:text="@string/close"
+            android:textAllCaps="true"
+            android:textColor="@color/white"
+            android:visibility="invisible" />
+
     </RelativeLayout>
 
 
diff --git a/app/src/main/res/layout/activity_main_player.xml b/app/src/main/res/layout/activity_main_player.xml
index 3dccc5c4c..c2aaca55f 100644
--- a/app/src/main/res/layout/activity_main_player.xml
+++ b/app/src/main/res/layout/activity_main_player.xml
@@ -458,6 +458,22 @@
             android:src="@drawable/exo_controls_next"
             tools:ignore="ContentDescription"/>
 
+        <Button
+            android:id="@+id/closeButton"
+            style="@style/Widget.AppCompat.Button.Borderless"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:layout_below="@id/playPauseButton"
+            android:layout_centerInParent="true"
+            android:layout_marginTop="10dp"
+            android:background="?attr/selectableItemBackgroundBorderless"
+            android:clickable="true"
+            android:focusable="true"
+            android:text="@string/close"
+            android:textAllCaps="true"
+            android:textColor="@color/white"
+            android:visibility="invisible" />
+
     </RelativeLayout>
 
 
diff --git a/app/src/main/res/values-ru/strings.xml b/app/src/main/res/values-ru/strings.xml
index 3fad6b288..afdc734d2 100644
--- a/app/src/main/res/values-ru/strings.xml
+++ b/app/src/main/res/values-ru/strings.xml
@@ -524,5 +524,6 @@
     <string name="unsubscribe">Отписаться</string>
     <string name="volume_gesture_control_summary">Менять громкость плеера жестом</string>
     <string name="volume_gesture_control_title">Жест громкости</string>
+    <string name="close">Закрыть</string>
 
 </resources>
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index ec366ebed..e9cad3e67 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -570,5 +570,6 @@
     <string name="max_retry_desc">Maximum number of attempts before canceling the download</string>
     <string name="pause_downloads_on_mobile">Pause on switching to mobile data</string>
     <string name="pause_downloads_on_mobile_desc">Not all downloads can be suspended, in those cases, will be restarted</string>
+    <string name="close">Close</string>
 
 </resources>