mirrors/NewPipe
1
0
Fork 0
mirror of https://github.com/TeamNewPipe/NewPipe synced 2025-10-30 23:03:00 +00:00
Code Issues Releases Wiki Activity

Code improvements

Browse Source
This commit is contained in:
litetex
2022-01-24 20:57:23 +01:00
parent 85f701b94e
commit 01683aa816
1 changed files with 9 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
app/src/main/java/org/schabi/newpipe/info_list/InfoListAdapter.java
View File

@@ -79,7 +79,7 @@ public class InfoListAdapter extends RecyclerView.Adapter<RecyclerView.ViewHolde
private final LayoutInflater layoutInflater; private final LayoutInflater layoutInflater;
private final InfoItemBuilder infoItemBuilder; private final InfoItemBuilder infoItemBuilder;
private final ArrayList<InfoItem> infoItemList; private final List<InfoItem> infoItemList;
private final HistoryRecordManager recordManager; private final HistoryRecordManager recordManager;
private boolean useMiniVariant = false; private boolean useMiniVariant = false;
@@ -134,7 +134,7 @@ public class InfoListAdapter extends RecyclerView.Adapter<RecyclerView.ViewHolde
if (DEBUG) { if (DEBUG) {
Log.d(TAG, "addInfoItemList() after > offsetStart = " + offsetStart + ", " Log.d(TAG, "addInfoItemList() after > offsetStart = " + offsetStart + ", "
+ "infoItemList.size() = " + infoItemList.size() + ", " + "infoItemList.size() = " + infoItemList.size() + ", "
+ "header = " + hasHeader() + ", " + "hasHeader = " + hasHeader() + ", "
+ "showFooter = " + showFooter); + "showFooter = " + showFooter);
} }
notifyItemRangeInserted(offsetStart, data.size()); notifyItemRangeInserted(offsetStart, data.size());
@@ -211,7 +211,7 @@ public class InfoListAdapter extends RecyclerView.Adapter<RecyclerView.ViewHolde
if (DEBUG) { if (DEBUG) {
Log.d(TAG, "getItemCount() called with: " Log.d(TAG, "getItemCount() called with: "
+ "count = " + count + ", infoItemList.size() = " + infoItemList.size() + ", " + "count = " + count + ", infoItemList.size() = " + infoItemList.size() + ", "
+ "header = " + hasHeader() + ", " + "hasHeader = " + hasHeader() + ", "
+ "showFooter = " + showFooter); + "showFooter = " + showFooter);
} }
return count; return count;
@@ -296,21 +296,18 @@ public class InfoListAdapter extends RecyclerView.Adapter<RecyclerView.ViewHolde
} }
} }
@SuppressWarnings("FinalParameters")
@Override @Override
public void onBindViewHolder(@NonNull final RecyclerView.ViewHolder holder, int position) { public void onBindViewHolder(@NonNull final RecyclerView.ViewHolder holder,
final int position) {
if (DEBUG) { if (DEBUG) {
Log.d(TAG, "onBindViewHolder() called with: " Log.d(TAG, "onBindViewHolder() called with: "
+ "holder = [" + holder.getClass().getSimpleName() + "], " + "holder = [" + holder.getClass().getSimpleName() + "], "
+ "position = [" + position + "]"); + "position = [" + position + "]");
} }
if (holder instanceof InfoItemHolder) { if (holder instanceof InfoItemHolder) {
// If header isn't null, offset the items by -1 ((InfoItemHolder) holder).updateFromItem(
if (hasHeader()) { // If header is present, offset the items by -1
position--; infoItemList.get(hasHeader() ? position - 1 : position), recordManager);
}
((InfoItemHolder) holder).updateFromItem(infoItemList.get(position), recordManager);
} }
} }
@@ -318,6 +315,7 @@ public class InfoListAdapter extends RecyclerView.Adapter<RecyclerView.ViewHolde
public void onBindViewHolder(@NonNull final RecyclerView.ViewHolder holder, public void onBindViewHolder(@NonNull final RecyclerView.ViewHolder holder,
final int position, final int position,
@NonNull final List<Object> payloads) { @NonNull final List<Object> payloads) {
// an empty payload requires a full update (see RecyclerView javadoc)
if (payloads.isEmpty() || !(holder instanceof InfoItemHolder)) { if (payloads.isEmpty() || !(holder instanceof InfoItemHolder)) {
onBindViewHolder(holder, position); onBindViewHolder(holder, position);
return; return;