mirror of
https://github.com/SquidDev-CC/CC-Tweaked
synced 2025-03-13 06:58:12 +00:00
36599b321e
- Add support for version overrides/exclusions in our dependency check. Sometimes mod loaders use different versions to vanilla, and we need some way to handle that. - Rescan wired network connections on the tick after invalidation, rather than when invalidated. - Convert some constant lambdas to static method references. Lambdas don't allocate if they don't capture variables, so this has the same performance and is a little less ugly. - Small code-style/formatting changes.
93 lines
3.5 KiB
Kotlin
93 lines
3.5 KiB
Kotlin
// SPDX-FileCopyrightText: 2023 The CC: Tweaked Developers
|
|
//
|
|
// SPDX-License-Identifier: MPL-2.0
|
|
|
|
package cc.tweaked.gradle
|
|
|
|
import org.gradle.api.DefaultTask
|
|
import org.gradle.api.GradleException
|
|
import org.gradle.api.artifacts.Configuration
|
|
import org.gradle.api.artifacts.MinimalExternalModuleDependency
|
|
import org.gradle.api.artifacts.component.ModuleComponentIdentifier
|
|
import org.gradle.api.artifacts.component.ModuleComponentSelector
|
|
import org.gradle.api.artifacts.component.ProjectComponentIdentifier
|
|
import org.gradle.api.artifacts.result.DependencyResult
|
|
import org.gradle.api.artifacts.result.ResolvedDependencyResult
|
|
import org.gradle.api.provider.ListProperty
|
|
import org.gradle.api.provider.MapProperty
|
|
import org.gradle.api.provider.Provider
|
|
import org.gradle.api.tasks.Input
|
|
import org.gradle.api.tasks.TaskAction
|
|
import org.gradle.language.base.plugins.LifecycleBasePlugin
|
|
|
|
abstract class DependencyCheck : DefaultTask() {
|
|
@get:Input
|
|
abstract val configuration: ListProperty<Configuration>
|
|
|
|
/**
|
|
* A mapping of module coordinates (`group:module`) to versions, overriding the requested version.
|
|
*/
|
|
@get:Input
|
|
abstract val overrides: MapProperty<String, String>
|
|
|
|
init {
|
|
description = "Check :core's dependencies are consistent with Minecraft's."
|
|
group = LifecycleBasePlugin.VERIFICATION_GROUP
|
|
|
|
configuration.finalizeValueOnRead()
|
|
overrides.finalizeValueOnRead()
|
|
}
|
|
|
|
/**
|
|
* Override a module with a different version.
|
|
*/
|
|
fun override(module: Provider<MinimalExternalModuleDependency>, version: String) {
|
|
overrides.putAll(project.provider { mutableMapOf(module.get().module.toString() to version) })
|
|
}
|
|
|
|
@TaskAction
|
|
fun run() {
|
|
var ok = true
|
|
for (configuration in configuration.get()) {
|
|
configuration.incoming.resolutionResult.allDependencies {
|
|
if (!check(this@allDependencies)) ok = false
|
|
}
|
|
}
|
|
|
|
if (!ok) {
|
|
throw GradleException("Mismatched versions in Minecraft dependencies. gradle/libs.versions.toml may need updating.")
|
|
}
|
|
}
|
|
|
|
private fun check(dependency: DependencyResult): Boolean {
|
|
if (dependency !is ResolvedDependencyResult) {
|
|
logger.warn("Found unexpected dependency result {}", dependency)
|
|
return false
|
|
}
|
|
|
|
// Skip dependencies on non-modules.
|
|
val requested = dependency.requested
|
|
if (requested !is ModuleComponentSelector) return true
|
|
|
|
// If this dependency is specified within some project (so is non-transitive), or is pulled in via Minecraft,
|
|
// then check for consistency.
|
|
// It would be nice to be smarter about transitive dependencies, but avoiding false positives is hard.
|
|
val from = dependency.from.id
|
|
if (
|
|
from is ProjectComponentIdentifier ||
|
|
from is ModuleComponentIdentifier && (from.group == "net.minecraft" || from.group == "io.netty")
|
|
) {
|
|
// If the version is different between the requested and selected version, report an error.
|
|
val selected = dependency.selected.moduleVersion!!.version
|
|
val requestedVersion = overrides.get()["${requested.group}:${requested.module}"] ?: requested.version
|
|
if (requestedVersion != selected) {
|
|
logger.error("Requested dependency {} (via {}) but got version {}", requested, from, selected)
|
|
return false
|
|
}
|
|
|
|
return true
|
|
}
|
|
return true
|
|
}
|
|
}
|