mirror of
https://github.com/SquidDev-CC/CC-Tweaked
synced 2025-07-17 09:22:53 +00:00
0e5248e5e6
I have mixed feelings about speaker.playSound. On one hand, it's pretty useful to be able to play any sound. On the other, it sometimes feels ... maybe a little too magic? One particular thing I don't like is that it allows you to play arbitrary records, which sidesteps both a vanilla mechanic (finding record discs) and existing CC functionality (disk.playAudio). We now prevent playing record tracks from the speaker.
44 lines
1.6 KiB
Kotlin
44 lines
1.6 KiB
Kotlin
// SPDX-FileCopyrightText: 2024 The CC: Tweaked Developers
|
|
//
|
|
// SPDX-License-Identifier: MPL-2.0
|
|
|
|
package dan200.computercraft.gametest
|
|
|
|
import dan200.computercraft.gametest.api.sequence
|
|
import dan200.computercraft.gametest.api.thenOnComputer
|
|
import dan200.computercraft.gametest.api.tryMultipleTimes
|
|
import dan200.computercraft.shared.peripheral.speaker.SpeakerPeripheral
|
|
import dan200.computercraft.test.core.assertArrayEquals
|
|
import net.minecraft.gametest.framework.GameTest
|
|
import net.minecraft.gametest.framework.GameTestHelper
|
|
import net.minecraft.sounds.SoundEvents
|
|
|
|
class Speaker_Test {
|
|
/**
|
|
* [SpeakerPeripheral.playSound] fails if there is already a sound queued.
|
|
*/
|
|
@GameTest
|
|
fun Fails_to_play_multiple_sounds(helper: GameTestHelper) = helper.sequence {
|
|
thenOnComputer {
|
|
callPeripheral("right", "playSound", SoundEvents.NOTE_BLOCK_HARP.key().location().toString())
|
|
.assertArrayEquals(true)
|
|
|
|
tryMultipleTimes(2) { // We could technically call this a tick later, so try twice
|
|
callPeripheral("right", "playSound", SoundEvents.NOTE_BLOCK_HARP.key().location().toString())
|
|
.assertArrayEquals(false)
|
|
}
|
|
}
|
|
}
|
|
|
|
/**
|
|
* [SpeakerPeripheral.playSound] will not play records.
|
|
*/
|
|
@GameTest
|
|
fun Will_not_play_record(helper: GameTestHelper) = helper.sequence {
|
|
thenOnComputer {
|
|
callPeripheral("right", "playSound", SoundEvents.MUSIC_DISC_PIGSTEP.location.toString())
|
|
.assertArrayEquals(false)
|
|
}
|
|
}
|
|
}
|