Basic network visualiser

.github/ISSUE_TEMPLATE/bug_report.md

@@ -1,15 +1,16 @@
 ---
 name: Bug report
 about: Report some misbehaviour in the mod
-labels: bug
+
 ---
 
 <!--
 ## Before reporting
- - Search for the bug on the issue tracker. Make sure to look at closed issues too!
+ - Search for the bug both here and [on the ComputerCraft issues page](https://github.com/dan200/ComputerCraft/issues?utf8=%E2%9C%93&q=is%3Aissue+)
+ - If possible, try to reproduce on vanilla ComputerCraft. If it still occurs, [report on the ComputerCraft repo](https://github.com/dan200/ComputerCraft/issues/new) instead.
 -->
 
 ## Useful information to include:
  - Minecraft version
  - CC: Tweaked version
- - Detailed reproduction steps: sometimes I can spot a bug pretty easily, but often it's much more obscure. The more information I have to help reproduce it, the quicker it'll get fixed.
+ - Detailed reproduction steps!** Sometimes I can spot a bug pretty easily, but often it's much more obscure. Anything you can give which will help reproduce it means it'll get fixed quicker.

.github/ISSUE_TEMPLATE/feature_request.md

@@ -1,14 +1,15 @@
 ---
 name: Feature request
 about: Suggest an idea or improvement
-labels: enhancement
+
 ---
 
 <!--
 ## Before reporting
- - Search for the suggestion here. It's possible someone's suggested it before!
+ - Search for the suggestion both here and [on the ComputerCraft issues page](https://github.com/dan200/ComputerCraft/issues?utf8=%E2%9C%93&q=is%3Aissue+). It's possible someone's suggested it before!
+ - Unless something is specific to CC:Tweaked, try to [suggest them on the ComputerCraft repo](https://github.com/dan200/ComputerCraft/issues/new). There's a lot more people watching it, so it allows the wider community to contribute.
 -->
 
 ## Useful information to include:
- - Explanation of how the feature/change should work.
+ - Explanation of how the feature/change chould work.
- - Some rationale/use case for a feature. My general approach to designing new features is to ask yourself "what issue are we trying to solve" and _then_ "is this the best way to solve this issue?".
+ - Some rationale/use case for a feature. I'd like to keep CC:T as minimal

.github/pull_request_template.md

@@ -1,3 +1,9 @@
-## A quick checklist
+<!--
- - If there's a existing issue, please link to it. If not, provide fill out the same information you would in a normal issue - reproduction steps for bugs, rationale for use-case.
+Unless this feature is specific to CC:Tweaked, try to [target the original ComputerCraft repo](https://github.com/dan200/ComputerCraft/) instead. There's a lot more people watching it, so it allows the wider community to contribute.
- - If you're working on CraftOS, try to write a few test cases so we can ensure everything continues to work in the future. Tests live in `src/test/resources/test-rom/spec` and can be run with `./gradlew check`.
+-->
+
+## Useful information to include:
+ - Brief explanation of the changes you've made.
+ - Rationale of why this change has been made/reasoning behind it.
+
+The more information you can provide, the easier it is to review something now _and_ to see why a change was made, when the code needs updating in the future.

.github/workflows/main-ci.yml

@@ -1,18 +0,0 @@
-name: Build
-
-on: [push, pull_request]
-
-jobs:
-  build:
-    runs-on: ubuntu-latest
-
-    steps:
-    - uses: actions/checkout@v1
-
-    - name: Set up JDK 1.8
-      uses: actions/setup-java@v1
-      with:
-        java-version: 1.8
-
-    - name: Build with Gradle
-      run: ./gradlew build --no-daemon

.gitignore

@@ -15,9 +15,3 @@
 .idea
 .gradle
 *.DS_Store
-
-.classpath
-.project
-.settings/
-bin/
-*.launch

.luacheckrc

@@ -17,8 +17,7 @@ ignore = {
 -- are largely unsupported.
 include_files = {
     'src/main/resources/assets/computercraft/lua/rom',
-    'src/main/resources/assets/computercraft/lua/bios.lua',
+    'src/main/resources/assets/computercraft/lua/bios.lua'
-    'src/test/resources/test-rom',
 }
 
 files['src/main/resources/assets/computercraft/lua/bios.lua'] = {

.travis.yml

@@ -0,0 +1,14 @@
+language: java
+
+script: ./gradlew build --no-daemon
+
+before_cache:
+  - rm -f  $HOME/.gradle/caches/modules-2/modules-2.lock
+  - rm -fr $HOME/.gradle/caches/*/plugin-resolution/
+cache:
+  directories:
+    - $HOME/.gradle/caches/
+    - $HOME/.gradle/wrapper/s
+
+jdk:
+    - oraclejdk8

LICENSE-luaj

@@ -0,0 +1,19 @@
+Copyright (c) 2007 LuaJ. All rights reserved.
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.

README.md

@@ -1,35 +1,35 @@
 # ![CC: Tweaked](logo.png)
-[![Current build status](https://github.com/SquidDev-CC/CC-Tweaked/workflows/Build/badge.svg)](https://github.com/SquidDev-CC/CC-Tweaked/actions "Current build status") [![Download CC: Tweaked on CurseForge](http://cf.way2muchnoise.eu/title/cc-tweaked.svg)](https://minecraft.curseforge.com/projects/cc-tweaked "Download CC: Tweaked on CurseForge")
+[![Build Status](https://travis-ci.org/SquidDev-CC/CC-Tweaked.svg?branch=master)](https://travis-ci.org/SquidDev-CC/CC-Tweaked)
 
-CC: Tweaked is a fork of [ComputerCraft](https://github.com/dan200/ComputerCraft), adding programmable computers,
+CC: Tweaked is a fork of ComputerCraft which aims to provide earlier access to the more experimental and in-development
-turtles and more to Minecraft.
+features of the mod. For a more stable experience, I recommend checking out the
+[original mod](https://github.com/dan200/ComputerCraft).
 
 ## What?
-ComputerCraft has always held a fond place in my heart: it's the mod which really got me into Minecraft, and it's the
+CC: Tweaked (or CC:T for short) does not aim to create a competing fork of ComputerCraft, nor am I planning to take it
-mod which has kept me playing it for many years. However, development of the original mod has slowed, as the original
+in in a vastly different direction to the original mod. In fact, CC:T aims to be a nurturing ground for various
-developers have had less time to work on the mod, and moved onto other projects and commitments.
+features, with a pull request against the original mod being the end goal.
 
-CC: Tweaked (or CC:T for short) is an attempt to continue ComputerCraft's legacy. It's not intended to be a competitor
+CC:T also includes many pull requests from the community which have not yet been merged, offering a large number
-to CC, nor do I want to take it in a vastly different direction to the original mod. Instead, CC:T focuses on making the
+of additional bug fixes and features over the original mod.
-ComputerCraft experience as _solid_ as possible, ironing out any wrinkles that may have developed over time.
 
 ## Features
-CC: Tweaked contains all the features of the latest version of ComputerCraft, as well as numerous fixes, performance
+CC: Tweaked contains all the features of the latest alpha, as well as numerous fixes, performance improvements and
-improvements and several nifty additions. I'd recommend checking out [the releases page](https://github.com/SquidDev-CC/CC-Tweaked/releases)
+several additional features. I'd recommend checking out [the releases page](https://github.com/SquidDev-CC/CC-Tweaked/releases)
-to see the full set of changes, but here's a couple of the more interesting additions:
+to see the full changes, but here's a couple of the more interesting changes:
 
- - Improvements to the `http` library, including websockets, support for other HTTP methods (`PUT`, `DELETE`, etc...)
+ - Replace LuaJ with Cobalt.
-   and configurable limits on HTTP usage.
+ - Allow running multiple computers at the same time.
- - Full-block wired modems, allowing one to wrap non-solid peripherals (such as turtles, or chests if Plethora is
+ - Websocket support in the HTTP library.
-   installed).
+ - Wired modems and cables act more like multiparts.
- - Pocket computers can be held like maps, allowing you to view the screen without entering a GUI.
+ - Add map-like rendering for pocket computers and printed pages/books.
- - Printed pages and books can be placed in item frames and held like maps.
+ - Adds the `/computercraft` command, offering various diagnostic tools for server owners. This allows operators to
- - Several profiling and administration tools for server owners, via the `/computercraft` command. This allows operators
+   track which computers are hogging resources, turn on and shutdown multiple computers at once and interact with
-   to track which computers are hogging resources, turn on and shutdown multiple computers at once and interact with
    computers remotely.
- - Closer emulation of standard Lua, adding the `debug` and `io` libraries. This also enables seeking within binary
+ - Add full-block wired modems, allowing one to wrap non-solid peripherals (such as turtles, or chests if Plethora is
-   files, meaning you don't need to read large files into memory.
+   installed).
- - Allow running multiple computers on multiple threads, reducing latency on worlds with many computers.
+ - Extended binary file handles. They support file seeking, and reading new lines, allowing full (and accurate)
+   emulation of the standard Lua `io` library.
 
 ## Relation to CCTweaks?
 This mod has nothing to do with CCTweaks, though there is no denying the name is a throwback to it. That being said,
@@ -37,39 +37,13 @@ several features have been included, such as full block modems, the Cobalt runti
 computers.
 
 ## Contributing
-Any contribution is welcome, be that using the mod, reporting bugs or contributing code. In order to start helping
+Any contribution is welcome, be that using the mod, reporting bugs or contributing code. If you do wish to contribute
-develop CC:T, you'll need to follow these steps:
+code, do consider submitting it to the ComputerCraft repository first.
+
+That being said, in order to start helping develop CC:T, you'll need to follow these steps:
 
  - **Clone the repository:** `git clone https://github.com/SquidDev-CC/CC-Tweaked.git && cd CC-Tweaked`
  - **Setup Forge:** `./gradlew setupDecompWorkspace`
  - **Test your changes:** `./gradlew runClient` (or run the `GradleStart` class from your IDE).
 
 If you want to run CC:T in a normal Minecraft instance, run `./gradlew build` and copy the `.jar` from `build/libs`.
-
-## Community
-If you need help getting started with CC: Tweaked, want to show off your latest project, or just want to chat about
-ComputerCraft we have a [forum](https://forums.computercraft.cc/) and [Discord guild](https://discord.gg/H2UyJXe)!
-There's also a fairly populated, albeit quiet [IRC channel](http://webchat.esper.net/?channels=#computercraft), if
-that's more your cup of tea.
-
-I'd generally recommend you don't contact me directly (email, DM, etc...) unless absolutely necessary (i.e. in order to
-report exploits). You'll get a far quicker response if you ask the whole community!
-
-## Using
-If you want to depend on CC: Tweaked, we have a maven repo. However, you should be wary that some functionality is only
-exposed by CC:T's API and not vanilla ComputerCraft. If you wish to support all variations of ComputerCraft, I recommend
-using [cc.crzd.me's maven](https://cc.crzd.me/maven/) instead.
-
-```groovy
-dependencies {
-  maven { url 'https://squiddev.cc/maven/' }
-}
-
-dependencies {
-  implementation "org.squiddev:cc-tweaked-${mc_version}:${cct_version}"
-}
-```
-
-You should also be careful to only use classes within the `dan200.computercraft.api` package. Non-API classes are
-subject to change at any point. If you depend on functionality outside the API, file an issue, and we can look into
-exposing more features.

build.gradle

@@ -5,22 +5,17 @@ buildscript {
         jcenter()
         maven {
             name = "forge"
-            url = "https://files.minecraftforge.net/maven"
+            url = "http://files.minecraftforge.net/maven"
         }
     }
     dependencies {
-        classpath 'com.google.code.gson:gson:2.8.1'
         classpath 'net.minecraftforge.gradle:ForgeGradle:2.3-SNAPSHOT'
-        classpath 'net.sf.proguard:proguard-gradle:6.1.0beta1'
         classpath 'org.ajoberstar.grgit:grgit-gradle:3.0.0'
     }
 }
 
 plugins {
-    id "checkstyle"
+    id 'com.matthewprenger.cursegradle' version '1.0.10'
-    id "com.github.hierynomus.license" version "0.15.0"
-    id "com.matthewprenger.cursegradle" version "1.3.0"
-    id "com.github.breadmoirai.github-release" version "2.2.4"
 }
 
 apply plugin: 'net.minecraftforge.gradle.forge'
@@ -28,37 +23,35 @@ apply plugin: 'org.ajoberstar.grgit'
 apply plugin: 'maven-publish'
 apply plugin: 'maven'
 
-version = mod_version
+version = "1.80pr1.14"
-
 group = "org.squiddev"
-archivesBaseName = "cc-tweaked-${mc_version}"
+archivesBaseName = "cc-tweaked"
 
 minecraft {
-    version = "${mc_version}-${forge_version}"
+    version = "1.12.2-14.23.4.2749"
     runDir = "run"
-    replace '${version}', mod_version
+    replace '${version}', project.version
 
-    mappings = mappings_version
+    // the mappings can be changed at any time, and must be in the following format.
-    makeObfSourceJar = false
+    // snapshot_YYYYMMDD   snapshot are built nightly.
+    // stable_#            stables are built at the discretion of the MCP team.
+    // Use non-default mappings at your own risk. they may not allways work.
+    // simply re-run your setup task after changing the mappings to update your workspace.
+    mappings = "snapshot_20180724"
+    // makeObfSourceJar = false // an Srg named sources jar is made by default. uncomment this to disable.
 }
 
 repositories {
     maven {
-        name "JEI"
+        name = "JEI"
-        url "https://dvs1.progwml6.com/files/maven"
+        url  = "http://dvs1.progwml6.com/files/maven"
     }
     maven {
-        name "SquidDev"
+        name = "squiddev"
-        url "https://squiddev.cc/maven"
+        url = "https://squiddev.cc/maven"
-    }
-    ivy {
-        name "Charset"
-        artifactPattern "https://asie.pl/files/mods/Charset/LibOnly/[module]-[revision](-[classifier]).[ext]"
-    }
-    maven {
-        name "Amadornes"
-        url "https://maven.amadornes.com/"
     }
+
+    ivy { artifactPattern "https://asie.pl/files/mods/Charset/LibOnly/[module]-[revision](-[classifier]).[ext]" }
 }
 
 configurations {
@@ -68,24 +61,18 @@ configurations {
 }
 
 dependencies {
-    checkstyle "com.puppycrawl.tools:checkstyle:8.25"
+    deobfProvided "mezz.jei:jei_1.12.2:4.8.5.159:api"
-
-    deobfProvided "mezz.jei:jei_1.12.2:4.15.0.269:api"
     deobfProvided "pl.asie:Charset-Lib:0.5.4.6"
-    deobfProvided "MCMultiPart2:MCMultiPart:2.5.3"
 
-    runtime "mezz.jei:jei_1.12.2:4.15.0.269"
+    runtime "mezz.jei:jei_1.12.2:4.8.5.159"
 
     shade 'org.squiddev:Cobalt:0.5.0-SNAPSHOT'
 
-    testImplementation 'org.junit.jupiter:junit-jupiter-api:5.4.2'
+    testCompile 'junit:junit:4.11'
-    testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine:5.4.2'
 
     deployerJars "org.apache.maven.wagon:wagon-ssh:3.0.0"
 }
 
-// Compile tasks
-
 javadoc {
     include "dan200/computercraft/api/**/*.java"
 }
@@ -97,78 +84,20 @@ jar {
         attributes('FMLAT': 'computercraft_at.cfg')
     }
 
-    from (sourceSets.main.allSource) {
+    into("docs", { from (javadoc.destinationDir) })
+
+    into("api", { from (sourceSets.main.allSource) {
         include "dan200/computercraft/api/**/*.java"
-    }
+    }})
 
     from configurations.shade.collect { it.isDirectory() ? it : zipTree(it) }
 }
 
-[compileJava, compileTestJava].forEach {
-    it.configure {
-        options.compilerArgs << "-Xlint" << "-Xlint:-processing" << "-Werror"
-    }
-}
-
-
-
-import java.nio.charset.StandardCharsets
-import java.nio.file.*
-import java.util.zip.*
-
-import com.google.gson.GsonBuilder
-import com.google.gson.JsonElement
-import com.hierynomus.gradle.license.tasks.LicenseCheck
-import com.hierynomus.gradle.license.tasks.LicenseFormat
 import org.ajoberstar.grgit.Grgit
-import proguard.gradle.ProGuardTask
-
-task proguard(type: ProGuardTask, dependsOn: jar) {
-    description "Removes unused shadowed classes from the jar"
-    group "compact"
-
-    injars jar.archivePath
-    outjars "${jar.archivePath.absolutePath.replace(".jar", "")}-min.jar"
-
-    // Add the main runtime jar and all non-shadowed dependencies
-    libraryjars "${System.getProperty('java.home')}/lib/rt.jar"
-    doFirst {
-        sourceSets.main.compileClasspath
-            .filter { !it.name.contains("Cobalt") }
-            .each { libraryjars it }
-    }
-
-    // We want to avoid as much obfuscation as possible. We're only doing this to shrink code size.
-    dontobfuscate; dontoptimize; keepattributes; keepparameternames
-
-    // Proguard will remove directories by default, but that breaks JarMount.
-    keepdirectories 'assets/computercraft/lua**'
-
-    // Preserve ComputerCraft classes - we only want to strip shadowed files.
-    keep 'class dan200.computercraft.** { *; }'
-
-    // Preserve the constructors in Cobalt library class, as we init them via reflection
-    keepclassmembers 'class org.squiddev.cobalt.lib.** { <init>(...); }'
-}
-
-task proguardMove(dependsOn: proguard) {
-    description "Replace the original jar with the minified version"
-    group "compact"
-
-    doLast {
-        Files.move(
-            file("${jar.archivePath.absolutePath.replace(".jar", "")}-min.jar").toPath(),
-            file(jar.archivePath).toPath(),
-            StandardCopyOption.REPLACE_EXISTING
-        )
-    }
-}
-
-reobfJar.dependsOn proguardMove
 
 processResources {
-    inputs.property "version", mod_version
+    inputs.property "version", project.version
-    inputs.property "mcversion", mc_version
+    inputs.property "mcversion", project.minecraft.version
 
     def hash = 'none'
     Set<String> contributors = []
@@ -189,9 +118,9 @@ processResources {
         include 'mcmod.info'
         include 'assets/computercraft/lua/rom/help/credits.txt'
 
-        expand 'version': mod_version,
+        expand 'version':project.version,
-               'mcversion': mc_version,
+               'mcversion':project.minecraft.version,
-               'gitcontributors': contributors.sort(false, String.CASE_INSENSITIVE_ORDER).join('\n')
+               'gitcontributors':contributors.sort(false, String.CASE_INSENSITIVE_ORDER).join('\n')
     }
 
     from(sourceSets.main.resources.srcDirs) {
@@ -200,149 +129,13 @@ processResources {
     }
 }
 
-task compressJson(dependsOn: extractAnnotationsJar) {
-    group "compact"
-    description "Minifies all JSON files, stripping whitespace"
-
-    def jarPath = file(jar.archivePath)
-
-    def tempPath = File.createTempFile("input", ".jar", temporaryDir)
-    tempPath.deleteOnExit()
-
-    def gson = new GsonBuilder().create()
-
-    doLast {
-        // Copy over all files in the current jar to the new one, running json files from GSON. As pretty printing
-        // is turned off, they should be minified.
-        new ZipFile(jarPath).withCloseable { inJar ->
-            tempPath.getParentFile().mkdirs()
-            new ZipOutputStream(new BufferedOutputStream(new FileOutputStream(tempPath))).withCloseable { outJar ->
-                inJar.entries().each { entry ->
-                    if(entry.directory) {
-                        outJar.putNextEntry(entry)
-                    } else if(!entry.name.endsWith(".json")) {
-                        outJar.putNextEntry(entry)
-                        inJar.getInputStream(entry).withCloseable { outJar << it }
-                    } else {
-                        ZipEntry newEntry = new ZipEntry(entry.name)
-                        newEntry.setTime(entry.time)
-                        outJar.putNextEntry(newEntry)
-
-                        def element = inJar.getInputStream(entry).withCloseable { gson.fromJson(it.newReader("UTF8"), JsonElement.class) }
-                        outJar.write(gson.toJson(element).getBytes(StandardCharsets.UTF_8))
-                    }
-                }
-
-            }
-        }
-
-        // And replace the original jar again
-        Files.move(tempPath.toPath(), jarPath.toPath(), StandardCopyOption.REPLACE_EXISTING)
-    }
-}
-
-assemble.dependsOn compressJson
-
-// Check tasks
-
-test {
-    useJUnitPlatform()
-    testLogging {
-        events "skipped", "failed"
-    }
-}
-
-license {
-    mapping("java", "SLASHSTAR_STYLE")
-    strictCheck true
-
-    ext.year = Calendar.getInstance().get(Calendar.YEAR)
-}
-
-[licenseMain, licenseFormatMain].forEach {
-    it.configure {
-        include("**/*.java")
-        exclude("dan200/computercraft/api/**")
-        header rootProject.file('config/license/main.txt')
-    }
-}
-
-[licenseTest, licenseFormatTest].forEach {
-    it.configure {
-        include("**/*.java")
-        header rootProject.file('config/license/main.txt')
-    }
-}
-
-gradle.projectsEvaluated {
-    tasks.withType(LicenseFormat) {
-        outputs.upToDateWhen { false }
-    }
-}
-
-
-task licenseAPI(type: LicenseCheck);
-task licenseFormatAPI(type: LicenseFormat);
-[licenseAPI, licenseFormatAPI].forEach {
-    it.configure {
-        source = sourceSets.main.java
-        include("dan200/computercraft/api/**")
-        header rootProject.file('config/license/api.txt')
-    }
-}
-
-// Upload tasks
-
-task checkRelease {
-    group "upload"
-    description "Verifies that everything is ready for a release"
-
-    inputs.property "version", mod_version
-    inputs.file("src/main/resources/assets/computercraft/lua/rom/help/changelog.txt")
-    inputs.file("src/main/resources/assets/computercraft/lua/rom/help/whatsnew.txt")
-
-    doLast {
-        def ok = true
-
-        // Check we're targetting the current version
-        def whatsnew = new File("src/main/resources/assets/computercraft/lua/rom/help/whatsnew.txt").readLines()
-        if (whatsnew[0] != "New features in CC: Tweaked $mod_version") {
-            ok = false
-            project.logger.error("Expected `whatsnew.txt' to target $mod_version.")
-        }
-
-        // Check "read more" exists and trim it
-        def idx = whatsnew.findIndexOf { it == 'Type "help changelog" to see the full version history.' }
-        if (idx == -1) {
-            ok = false
-            project.logger.error("Must mention the changelog in whatsnew.txt")
-        } else {
-            whatsnew = whatsnew.getAt(0 ..< idx)
-        }
-
-        // Check whatsnew and changelog match.
-        def versionChangelog = "# " + whatsnew.join("\n")
-        def changelog = new File("src/main/resources/assets/computercraft/lua/rom/help/changelog.txt").getText()
-        if (!changelog.startsWith(versionChangelog)) {
-            ok = false
-            project.logger.error("whatsnew and changelog are not in sync")
-        }
-
-        if (!ok) throw new IllegalStateException("Could not check release")
-    }
-}
-check.dependsOn checkRelease
 
 curseforge {
     apiKey = project.hasProperty('curseForgeApiKey') ? project.curseForgeApiKey : ''
     project {
         id = '282001'
-        releaseType = 'release'
+        releaseType = 'beta'
-        changelog = "Release notes can be found on the GitHub repository (https://github.com/SquidDev-CC/CC-Tweaked/releases/tag/v${mc_version}-${mod_version})."
+        changelog = "Release notes can be found on the GitHub repository (https://github.com/SquidDev-CC/CC-Tweaked/releases/tag/v${project.version})."
-
-        relations {
-            incompatible "computercraft"
-        }
     }
 }
 
@@ -370,22 +163,22 @@ uploadArchives {
                 pom.project {
                     name 'CC: Tweaked'
                     packaging 'jar'
-                    description 'CC: Tweaked is a fork of ComputerCraft, adding programmable computers, turtles and more to Minecraft.'
+                    description 'A fork of ComputerCraft which aims to provide earlier access to the more experimental and in-development features of the mod.'
                     url 'https://github.com/SquidDev-CC/CC-Tweaked'
 
                     scm {
-                        url 'https://github.com/SquidDev-CC/CC-Tweaked.git'
+                        url 'https://github.com/dan200/ComputerCraft.git'
                     }
 
                     issueManagement {
                         system 'github'
-                        url 'https://github.com/SquidDev-CC/CC-Tweaked/issues'
+                        url 'https://github.com/dan200/ComputerCraft/issues'
                     }
 
                     licenses {
                         license {
                             name 'ComputerCraft Public License, Version 1.0'
-                            url 'https://github.com/SquidDev-CC/CC-Tweaked/blob/master/LICENSE'
+                            url 'https://github.com/dan200/ComputerCraft/blob/master/LICENSE'
                             distribution 'repo'
                         }
                     }
@@ -399,31 +192,10 @@ uploadArchives {
     }
 }
 
-githubRelease {
+gradle.projectsEvaluated {
-    token project.hasProperty('githubApiKey') ? project.githubApiKey : ''
+    tasks.withType(JavaCompile) {
-    owner 'SquidDev-CC'
+        options.compilerArgs << "-Xlint"
-    repo 'CC-Tweaked'
-    try {
-        targetCommitish = Grgit.open(dir: '.').branch.current().name
-    } catch(Exception ignored) { }
-
-    tagName "v${mc_version}-${mod_version}"
-    releaseName "[${mc_version}] ${mod_version}"
-    body {
-        "## " + new File("src/main/resources/assets/computercraft/lua/rom/help/whatsnew.txt")
-            .readLines()
-            .takeWhile { it != 'Type "help changelog" to see the full version history.' }
-            .join("\n").trim()
     }
-    prerelease false
-}
-
-def uploadTasks = ["uploadArchives", "curseforge", "githubRelease"]
-uploadTasks.forEach { tasks.getByName(it).dependsOn checkRelease }
-
-task uploadAll(dependsOn: uploadTasks) {
-    group "upload"
-    description "Uploads to all repositories (Maven, Curse, GitHub release)"
 }
 
 runClient.outputs.upToDateWhen { false }

config/checkstyle/checkstyle.xml

@@ -1,169 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!DOCTYPE module PUBLIC
-    "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN"
-    "https://checkstyle.org/dtds/configuration_1_3.dtd">
-<module name="Checker">
-    <property name="tabWidth" value="4"/>
-    <property name="charset" value="UTF-8" />
-
-    <module name="SuppressionFilter">
-        <property name="file" value="config/checkstyle/suppressions.xml" />
-    </module>
-
-    <module name="TreeWalker">
-        <!-- Annotations -->
-        <module name="AnnotationLocation" />
-        <module name="AnnotationUseStyle" />
-        <module name="MissingDeprecated" />
-        <module name="MissingOverride" />
-
-        <!-- Blocks -->
-        <module name="EmptyBlock" />
-        <module name="EmptyCatchBlock">
-            <property name="exceptionVariableName" value="ignored" />
-        </module>
-        <module name="LeftCurly">
-            <property name="option" value="nl" />
-            <!-- The defaults, minus lambdas. -->
-            <property name="tokens" value="ANNOTATION_DEF,CLASS_DEF,CTOR_DEF,ENUM_CONSTANT_DEF,ENUM_DEF,INTERFACE_DEF,LITERAL_CASE,LITERAL_CATCH,LITERAL_DEFAULT,LITERAL_DO,LITERAL_ELSE,LITERAL_FINALLY,LITERAL_FOR,LITERAL_IF,LITERAL_SWITCH,LITERAL_SYNCHRONIZED,LITERAL_TRY,LITERAL_WHILE,METHOD_DEF,OBJBLOCK,STATIC_INIT" />
-        </module>
-        <module name="NeedBraces">
-            <property name="allowSingleLineStatement" value="true"/>
-        </module>
-        <module name="RightCurly">
-            <property name="option" value="alone" />
-        </module>
-
-        <!-- Class design. As if we've ever followed good practice here. -->
-        <module name="FinalClass" />
-        <module name="InterfaceIsType" />
-        <module name="MutableException" />
-        <module name="OneTopLevelClass" />
-
-        <!-- Coding -->
-        <module name="ArrayTrailingComma" />
-        <module name="EqualsHashCode" />
-        <!-- FallThrough does not handle unreachable code well -->
-        <module name="IllegalInstantiation" />
-        <module name="IllegalThrows" />
-        <module name="ModifiedControlVariable" />
-        <module name="NoClone" />
-        <module name="NoFinalizer" />
-        <module name="OneStatementPerLine" />
-        <module name="PackageDeclaration" />
-        <module name="SimplifyBooleanExpression" />
-        <module name="SimplifyBooleanReturn" />
-        <module name="StringLiteralEquality" />
-        <module name="UnnecessaryParentheses" />
-        <module name="UnnecessarySemicolonAfterTypeMemberDeclaration" />
-        <module name="UnnecessarySemicolonInTryWithResources" />
-        <module name="UnnecessarySemicolonInEnumeration" />
-
-        <!-- Imports -->
-        <module name="CustomImportOrder" />
-        <module name="IllegalImport" />
-        <module name="RedundantImport" />
-        <module name="UnusedImports" />
-
-        <!-- Javadoc -->
-        <!-- TODO: Missing* checks for the dan200.computercraft.api package? -->
-        <module name="AtclauseOrder" />
-        <module name="InvalidJavadocPosition" />
-        <module name="JavadocBlockTagLocation" />
-        <module name="JavadocMethod"/>
-        <module name="JavadocType"/>
-        <module name="JavadocStyle" />
-        <module name="NonEmptyAtclauseDescription" />
-        <module name="SingleLineJavadoc" />
-        <module name="SummaryJavadocCheck"/>
-
-        <!-- Misc -->
-        <module name="ArrayTypeStyle" />
-        <module name="CommentsIndentation" />
-        <module name="Indentation" />
-        <module name="OuterTypeFilename" />
-
-        <!-- Modifiers -->
-        <module name="ModifierOrder" />
-        <module name="RedundantModifier" />
-
-        <!-- Naming -->
-        <module name="ClassTypeParameterName" />
-        <module name="InterfaceTypeParameterName" />
-        <module name="LambdaParameterName" />
-        <module name="LocalFinalVariableName" />
-        <module name="LocalVariableName" />
-        <!-- Allow an optional m_ on private members -->
-        <module name="MemberName">
-            <property name="applyToPrivate" value="false" />
-            <property name="applyToPackage" value="false" />
-        </module>
-        <module name="MemberName">
-            <property name="format" value="^(m_)?[a-z][a-zA-Z0-9]*$" />
-            <property name="applyToPrivate" value="true" />
-            <property name="applyToPackage" value="true" />
-        </module>
-        <module name="MethodName" />
-        <module name="MethodTypeParameterName" />
-        <module name="PackageName">
-            <property name="format" value="^dan200\.computercraf(\.[a-z][a-z0-9]*)*" />
-        </module>
-        <module name="ParameterName" />
-        <module name="StaticVariableName">
-            <property name="format" value="^[a-z][a-zA-Z0-9]*|CAPABILITY(_[A-Z]+)?$" />
-            <property name="applyToPrivate" value="false" />
-        </module>
-        <module name="StaticVariableName">
-            <property name="format" value="^(s_)?[a-z][a-zA-Z0-9]*|CAPABILITY(_[A-Z]+)?$" />
-            <property name="applyToPrivate" value="true" />
-        </module>
-        <module name="TypeName" />
-
-        <!-- Whitespace -->
-        <module name="EmptyForInitializerPad"/>
-        <module name="EmptyForIteratorPad">
-            <property name="option" value="space"/>
-        </module>
-        <module name="GenericWhitespace" />
-        <module name="MethodParamPad" />
-        <module name="NoLineWrap" />
-        <module name="NoWhitespaceAfter">
-            <property name="tokens" value="AT,INC,DEC,UNARY_MINUS,UNARY_PLUS,BNOT,LNOT,DOT,ARRAY_DECLARATOR,INDEX_OP" />
-        </module>
-        <module name="NoWhitespaceBefore" />
-        <!-- TODO: Decide on an OperatorWrap style. -->
-        <module name="ParenPad">
-            <property name="option" value="space" />
-            <property name="tokens" value="ANNOTATION,ANNOTATION_FIELD_DEF,CTOR_CALL,CTOR_DEF,ENUM_CONSTANT_DEF,LITERAL_CATCH,LITERAL_DO,LITERAL_FOR,LITERAL_IF,LITERAL_NEW,LITERAL_SWITCH,LITERAL_SYNCHRONIZED,LITERAL_WHILE,METHOD_CALL,METHOD_DEF,RESOURCE_SPECIFICATION,SUPER_CTOR_CALL,LAMBDA" />
-        </module>
-        <module name="ParenPad">
-            <property name="option" value="nospace" />
-            <property name="tokens" value="DOT,EXPR,QUESTION" />
-        </module>
-        <module name="SeparatorWrap">
-            <property name="option" value="eol" />
-            <property name="tokens" value="COMMA,SEMI,ELLIPSIS,ARRAY_DECLARATOR,RBRACK,METHOD_REF" />
-        </module>
-        <module name="SeparatorWrap">
-            <property name="option" value="nl" />
-            <property name="tokens" value="DOT,AT" />
-        </module>
-        <module name="SingleSpaceSeparator" />
-        <module name="TypecastParenPad" />
-        <module name="WhitespaceAfter">
-            <property name="tokens" value="COMMA" />
-        </module>
-        <module name="WhitespaceAround">
-            <property name="allowEmptyConstructors" value="true" />
-            <property name="ignoreEnhancedForColon" value="false" />
-            <property name="tokens" value="ASSIGN,BAND,BAND_ASSIGN,BOR,BOR_ASSIGN,BSR,BSR_ASSIGN,BXOR,BXOR_ASSIGN,COLON,DIV,DIV_ASSIGN,DO_WHILE,EQUAL,GE,GT,LAMBDA,LAND,LCURLY,LE,LITERAL_RETURN,LOR,LT,MINUS,MINUS_ASSIGN,MOD,MOD_ASSIGN,NOT_EQUAL,PLUS,PLUS_ASSIGN,QUESTION,RCURLY,SL,SLIST,SL_ASSIGN,SR,SR_ASSIGN,STAR,STAR_ASSIGN,LITERAL_ASSERT,TYPE_EXTENSION_AND" />
-        </module>
-    </module>
-
-    <module name="FileTabCharacter" />
-    <module name="NewlineAtEndOfFile" />
-    <module name="RegexpSingleline">
-        <property name="format" value="\s+$"/>
-        <property name="message" value="Trailing whitespace"/>
-    </module>
-</module>

config/checkstyle/suppressions.xml

@@ -1,12 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!DOCTYPE suppressions PUBLIC
-    "-//Checkstyle//DTD SuppressionFilter Configuration 1.2//EN"
-    "https://checkstyle.org/dtds/suppressions_1_2.dtd">
-<suppressions>
-    <!-- All the config options and method fields. -->
-    <suppress checks="StaticVariableName" files=".*[\\/]ComputerCraft.java" />
-    <suppress checks="StaticVariableName" files=".*[\\/]ComputerCraftAPI.java" />
-
-    <!-- Do not check for missing package Javadoc. -->
-    <suppress checks="JavadocStyle" files=".*[\\/]package-info.java" />
-</suppressions>

config/license/api.txt

@@ -1,3 +0,0 @@
-This file is part of the public ComputerCraft API - http://www.computercraft.info
-Copyright Daniel Ratcliffe, 2011-${year}. This API may be redistributed unmodified and in full only.
-For help using the API, and posting your mods, visit the forums at computercraft.info.

config/license/main.txt

@@ -1,3 +0,0 @@
-This file is part of ComputerCraft - http://www.computercraft.info
-Copyright Daniel Ratcliffe, 2011-${year}. Do not distribute without permission.
-Send enquiries to dratcliffe@gmail.com

gradle.properties

@@ -1,7 +0,0 @@
-# Mod properties
-mod_version=1.85.2
-
-# Minecraft properties
-mc_version=1.12.2
-forge_version=14.23.4.2749
-mappings_version=snapshot_20180724

gradle/wrapper/gradle-wrapper.properties

@@ -2,4 +2,4 @@ distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-4.6-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-4.3-bin.zip

settings.gradle

@@ -1 +1 @@
-rootProject.name = "cc-tweaked-${mc_version}"
+rootProject.name = 'cc-tweaked'

src/main/java/dan200/computercraft/CCTweaked.java

@@ -1,30 +0,0 @@
-/*
- * This file is part of ComputerCraft - http://www.computercraft.info
- * Copyright Daniel Ratcliffe, 2011-2019. Do not distribute without permission.
- * Send enquiries to dratcliffe@gmail.com
- */
-
-package dan200.computercraft;
-
-import net.minecraftforge.fml.common.Mod;
-import net.minecraftforge.fml.common.network.NetworkCheckHandler;
-import net.minecraftforge.fml.relauncher.Side;
-
-import java.util.Map;
-
-/**
- * A stub mod for CC: Tweaked. This doesn't have any functionality (everything of note is done in
- * {@link ComputerCraft}), but people may depend on this if they require CC: Tweaked functionality.
- */
-@Mod(
-    modid = "cctweaked", name = ComputerCraft.NAME, version = ComputerCraft.VERSION,
-    acceptableRemoteVersions = "*"
-)
-public class CCTweaked
-{
-    @NetworkCheckHandler
-    public boolean onNetworkConnect( Map<String, String> mods, Side side )
-    {
-        return true;
-    }
-}

src/main/java/dan200/computercraft/ComputerCraft.java

@@ -24,15 +24,18 @@ import dan200.computercraft.api.turtle.event.TurtleAction;
 import dan200.computercraft.core.apis.AddressPredicate;
 import dan200.computercraft.core.apis.ApiFactories;
 import dan200.computercraft.core.apis.http.websocket.Websocket;
-import dan200.computercraft.core.computer.MainThread;
 import dan200.computercraft.core.filesystem.ComboMount;
 import dan200.computercraft.core.filesystem.FileMount;
 import dan200.computercraft.core.filesystem.JarMount;
+import dan200.computercraft.core.terminal.Terminal;
 import dan200.computercraft.core.tracking.Tracking;
 import dan200.computercraft.shared.*;
 import dan200.computercraft.shared.computer.blocks.BlockCommandComputer;
 import dan200.computercraft.shared.computer.blocks.BlockComputer;
+import dan200.computercraft.shared.computer.blocks.TileComputer;
 import dan200.computercraft.shared.computer.core.ClientComputerRegistry;
+import dan200.computercraft.shared.computer.core.ComputerFamily;
+import dan200.computercraft.shared.computer.core.ServerComputer;
 import dan200.computercraft.shared.computer.core.ServerComputerRegistry;
 import dan200.computercraft.shared.computer.items.ItemCommandComputer;
 import dan200.computercraft.shared.computer.items.ItemComputer;
@@ -40,19 +43,24 @@ import dan200.computercraft.shared.media.items.ItemDiskExpanded;
 import dan200.computercraft.shared.media.items.ItemDiskLegacy;
 import dan200.computercraft.shared.media.items.ItemPrintout;
 import dan200.computercraft.shared.media.items.ItemTreasureDisk;
+import dan200.computercraft.shared.network.NetworkHandler;
 import dan200.computercraft.shared.peripheral.common.BlockPeripheral;
 import dan200.computercraft.shared.peripheral.common.ItemPeripheral;
+import dan200.computercraft.shared.peripheral.diskdrive.TileDiskDrive;
 import dan200.computercraft.shared.peripheral.modem.wired.BlockCable;
 import dan200.computercraft.shared.peripheral.modem.wired.BlockWiredModemFull;
 import dan200.computercraft.shared.peripheral.modem.wired.ItemCable;
 import dan200.computercraft.shared.peripheral.modem.wireless.BlockAdvancedModem;
 import dan200.computercraft.shared.peripheral.modem.wireless.ItemAdvancedModem;
 import dan200.computercraft.shared.peripheral.modem.wireless.WirelessNetwork;
+import dan200.computercraft.shared.peripheral.printer.TilePrinter;
 import dan200.computercraft.shared.pocket.items.ItemPocketComputer;
 import dan200.computercraft.shared.pocket.peripherals.PocketModem;
 import dan200.computercraft.shared.pocket.peripherals.PocketSpeaker;
-import dan200.computercraft.shared.proxy.ComputerCraftProxyCommon;
+import dan200.computercraft.shared.proxy.ICCTurtleProxy;
+import dan200.computercraft.shared.proxy.IComputerCraftProxy;
 import dan200.computercraft.shared.turtle.blocks.BlockTurtle;
+import dan200.computercraft.shared.turtle.blocks.TileTurtle;
 import dan200.computercraft.shared.turtle.items.ItemTurtleAdvanced;
 import dan200.computercraft.shared.turtle.items.ItemTurtleLegacy;
 import dan200.computercraft.shared.turtle.items.ItemTurtleNormal;
@@ -68,11 +76,14 @@ import net.minecraft.item.ItemStack;
 import net.minecraft.server.MinecraftServer;
 import net.minecraft.tileentity.TileEntity;
 import net.minecraft.util.EnumFacing;
+import net.minecraft.util.EnumHand;
 import net.minecraft.util.math.BlockPos;
 import net.minecraft.world.IBlockAccess;
 import net.minecraft.world.World;
 import net.minecraftforge.common.DimensionManager;
-import net.minecraftforge.fml.common.*;
+import net.minecraftforge.fml.common.FMLCommonHandler;
+import net.minecraftforge.fml.common.Mod;
+import net.minecraftforge.fml.common.SidedProxy;
 import net.minecraftforge.fml.common.event.*;
 import net.minecraftforge.fml.relauncher.Side;
 import org.apache.logging.log4j.Logger;
@@ -81,21 +92,30 @@ import java.io.*;
 import java.net.MalformedURLException;
 import java.net.URISyntaxException;
 import java.net.URL;
-import java.util.*;
+import java.util.ArrayList;
-import java.util.concurrent.TimeUnit;
+import java.util.EnumSet;
+import java.util.List;
 import java.util.zip.ZipEntry;
 import java.util.zip.ZipFile;
 
 @Mod(
-    modid = ComputerCraft.MOD_ID, name = ComputerCraft.NAME, version = ComputerCraft.VERSION,
+    modid = ComputerCraft.MOD_ID, name = "CC: Tweaked", version = "${version}",
     guiFactory = "dan200.computercraft.client.gui.GuiConfigCC$Factory",
     dependencies = "required:forge@[14.23.4.2746,)"
 )
 public class ComputerCraft
 {
     public static final String MOD_ID = "computercraft";
-    static final String VERSION = "${version}";
+
-    static final String NAME = "CC: Tweaked";
+    // GUI IDs
+    public static final int diskDriveGUIID = 100;
+    public static final int computerGUIID = 101;
+    public static final int printerGUIID = 102;
+    public static final int turtleGUIID = 103;
+    // ComputerCraftEdu uses ID 104
+    public static final int printoutGUIID = 105;
+    public static final int pocketComputerGUIID = 106;
+    public static final int viewComputerGUIID = 110;
 
     // Configuration options
     public static final String[] DEFAULT_HTTP_WHITELIST = new String[] { "*" };
@@ -113,11 +133,8 @@ public class ComputerCraft
     public static boolean disable_lua51_features = false;
     public static String default_computer_settings = "";
     public static boolean debug_enable = true;
-    public static boolean logPeripheralErrors = false;
-
     public static int computer_threads = 1;
-    public static long maxMainGlobalTime = TimeUnit.MILLISECONDS.toNanos( 10 );
+    public static boolean logPeripheralErrors = false;
-    public static long maxMainComputerTime = TimeUnit.MILLISECONDS.toNanos( 5 );
 
     public static boolean http_enable = true;
     public static boolean http_websocket_enable = true;
@@ -155,7 +172,7 @@ public class ComputerCraft
     public static final int terminalHeight_pocketComputer = 20;
 
     // Blocks and Items
-    public static final class Blocks
+    public static class Blocks
     {
         public static BlockComputer computer;
         public static BlockCommandComputer commandComputer;
@@ -170,7 +187,7 @@ public class ComputerCraft
         public static BlockWiredModemFull wiredModemFull;
     }
 
-    public static final class Items
+    public static class Items
     {
         public static ItemComputer computer;
         public static ItemCommandComputer commandComputer;
@@ -193,7 +210,7 @@ public class ComputerCraft
         public static ItemBlock wiredModemFull;
     }
 
-    public static final class TurtleUpgrades
+    public static class TurtleUpgrades
     {
         public static TurtleModem wirelessModem;
         public static TurtleModem advancedModem;
@@ -207,7 +224,7 @@ public class ComputerCraft
         public static TurtleHoe diamondHoe;
     }
 
-    public static final class PocketUpgrades
+    public static class PocketUpgrades
     {
         public static PocketModem wirelessModem;
         public static PocketModem advancedModem;
@@ -218,7 +235,7 @@ public class ComputerCraft
     }
 
     @Deprecated
-    public static final class Upgrades
+    public static class Upgrades
     {
         public static TurtleModem advancedModem;
     }
@@ -237,14 +254,20 @@ public class ComputerCraft
     public static List<IPeripheralProvider> peripheralProviders = new ArrayList<>();
 
     // Implementation
-    @Mod.Instance( ComputerCraft.MOD_ID )
+    @Mod.Instance( value = ComputerCraft.MOD_ID )
     public static ComputerCraft instance;
 
     @SidedProxy(
         clientSide = "dan200.computercraft.client.proxy.ComputerCraftProxyClient",
         serverSide = "dan200.computercraft.shared.proxy.ComputerCraftProxyCommon"
     )
-    private static ComputerCraftProxyCommon proxy;
+    private static IComputerCraftProxy proxy;
+
+    @SidedProxy(
+        clientSide = "dan200.computercraft.client.proxy.CCTurtleProxyClient",
+        serverSide = "dan200.computercraft.shared.proxy.CCTurtleProxyCommon"
+    )
+    private static ICCTurtleProxy turtleProxy;
 
     @Mod.EventHandler
     public void preInit( FMLPreInitializationEvent event )
@@ -254,19 +277,24 @@ public class ComputerCraft
         // Load config
         Config.load( event.getSuggestedConfigurationFile() );
 
+        // Setup network
+        NetworkHandler.setup();
+
         proxy.preInit();
+        turtleProxy.preInit();
     }
 
     @Mod.EventHandler
     public void init( FMLInitializationEvent event )
     {
         proxy.init();
+        turtleProxy.init();
     }
 
     @Mod.EventHandler
     public void onServerStarting( FMLServerStartingEvent event )
     {
-        ComputerCraftProxyCommon.initServer( event.getServer() );
+        proxy.initServer( event.getServer() );
     }
 
     @Mod.EventHandler
@@ -276,7 +304,6 @@ public class ComputerCraft
         {
             ComputerCraft.serverComputerRegistry.reset();
             WirelessNetwork.resetNetworks();
-            MainThread.reset();
             Tracking.reset();
         }
     }
@@ -288,14 +315,65 @@ public class ComputerCraft
         {
             ComputerCraft.serverComputerRegistry.reset();
             WirelessNetwork.resetNetworks();
-            MainThread.reset();
             Tracking.reset();
         }
     }
 
     public static String getVersion()
     {
-        return VERSION;
+        return "${version}";
+    }
+
+    public static void openDiskDriveGUI( EntityPlayer player, TileDiskDrive drive )
+    {
+        BlockPos pos = drive.getPos();
+        player.openGui( ComputerCraft.instance, ComputerCraft.diskDriveGUIID, player.getEntityWorld(), pos.getX(), pos.getY(), pos.getZ() );
+    }
+
+    public static void openComputerGUI( EntityPlayer player, TileComputer computer )
+    {
+        BlockPos pos = computer.getPos();
+        player.openGui( ComputerCraft.instance, ComputerCraft.computerGUIID, player.getEntityWorld(), pos.getX(), pos.getY(), pos.getZ() );
+    }
+
+    public static void openPrinterGUI( EntityPlayer player, TilePrinter printer )
+    {
+        BlockPos pos = printer.getPos();
+        player.openGui( ComputerCraft.instance, ComputerCraft.printerGUIID, player.getEntityWorld(), pos.getX(), pos.getY(), pos.getZ() );
+    }
+
+    public static void openTurtleGUI( EntityPlayer player, TileTurtle turtle )
+    {
+        BlockPos pos = turtle.getPos();
+        player.openGui( instance, ComputerCraft.turtleGUIID, player.getEntityWorld(), pos.getX(), pos.getY(), pos.getZ() );
+    }
+
+    public static void openPrintoutGUI( EntityPlayer player, EnumHand hand )
+    {
+        player.openGui( ComputerCraft.instance, ComputerCraft.printoutGUIID, player.getEntityWorld(), hand.ordinal(), 0, 0 );
+    }
+
+    public static void openPocketComputerGUI( EntityPlayer player, EnumHand hand )
+    {
+        player.openGui( ComputerCraft.instance, ComputerCraft.pocketComputerGUIID, player.getEntityWorld(), hand.ordinal(), 0, 0 );
+    }
+
+    public static void openComputerGUI( EntityPlayer player, ServerComputer computer )
+    {
+        ComputerFamily family = computer.getFamily();
+        int width = 0, height = 0;
+        Terminal terminal = computer.getTerminal();
+        if( terminal != null )
+        {
+            width = terminal.getWidth();
+            height = terminal.getHeight();
+        }
+
+        // Pack useful terminal information into the various coordinate bits.
+        // These are extracted in ComputerCraftProxyCommon.getClientGuiElement
+        player.openGui( ComputerCraft.instance, ComputerCraft.viewComputerGUIID, player.getEntityWorld(),
+            computer.getInstanceID(), family.ordinal(), (width & 0xFFFF) << 16 | (height & 0xFFFF)
+        );
     }
 
     private static File getBaseDir()
@@ -308,6 +386,16 @@ public class ComputerCraft
         return new File( getBaseDir(), "resourcepacks" );
     }
 
+    public static boolean canPlayerUseCommands( EntityPlayer player )
+    {
+        MinecraftServer server = player.getServer();
+        if( server != null )
+        {
+            return server.getPlayerList().canSendCommands( player.getGameProfile() );
+        }
+        return false;
+    }
+
     @Deprecated
     public static void registerPermissionProvider( ITurtlePermissionProvider provider )
     {
@@ -390,27 +478,6 @@ public class ComputerCraft
         }
     }
 
-    private static void loadFromFile( List<IMount> mounts, File file, String path, boolean allowMissing )
-    {
-        try
-        {
-            if( file.isFile() )
-            {
-                mounts.add( new JarMount( file, path ) );
-            }
-            else
-            {
-                File subResource = new File( file, path );
-                if( subResource.exists() ) mounts.add( new FileMount( subResource, 0 ) );
-            }
-        }
-        catch( IOException | RuntimeException e )
-        {
-            if( allowMissing && e instanceof FileNotFoundException ) return;
-            ComputerCraft.log.error( "Could not load mount '" + path + " 'from '" + file.getName() + "'", e );
-        }
-    }
-
     @Deprecated
     public static IMount createResourceMount( Class<?> modClass, String domain, String subPath )
     {
@@ -430,26 +497,18 @@ public class ComputerCraft
             }
         }
 
-        // Mount from mod jars, preferring the specified one.
+        // Mount from mod jar
         File modJar = getContainingJar( modClass );
-        Set<File> otherMods = new HashSet<>();
-        for( ModContainer container : Loader.instance().getActiveModList() )
-        {
-            File modFile = container.getSource();
-            if( modFile != null && !modFile.equals( modJar ) && modFile.exists() )
-            {
-                otherMods.add( container.getSource() );
-            }
-        }
-
-        for( File file : otherMods )
-        {
-            loadFromFile( mounts, file, subPath, true );
-        }
-
         if( modJar != null )
         {
-            loadFromFile( mounts, modJar, subPath, false );
+            try
+            {
+                mounts.add( new JarMount( modJar, subPath ) );
+            }
+            catch( IOException | RuntimeException e )
+            {
+                ComputerCraft.log.error( "Could not load mount from mod jar", e );
+            }
         }
 
         // Mount from resource packs
@@ -459,8 +518,25 @@ public class ComputerCraft
             String[] resourcePacks = resourcePackDir.list();
             for( String resourcePackName : resourcePacks )
             {
-                File resourcePack = new File( resourcePackDir, resourcePackName );
+                try
-                loadFromFile( mounts, resourcePack, subPath, true );
+                {
+                    File resourcePack = new File( resourcePackDir, resourcePackName );
+                    if( !resourcePack.isDirectory() )
+                    {
+                        // Mount a resource pack from a jar
+                        mounts.add( new JarMount( resourcePack, subPath ) );
+                    }
+                    else
+                    {
+                        // Mount a resource pack from a folder
+                        File subResource = new File( resourcePack, subPath );
+                        if( subResource.exists() ) mounts.add( new FileMount( subResource, 0 ) );
+                    }
+                }
+                catch( IOException | RuntimeException e )
+                {
+                    ComputerCraft.log.error( "Could not load resource pack '" + resourcePackName + "'", e );
+                }
             }
         }
 
@@ -566,7 +642,7 @@ public class ComputerCraft
     private static File getContainingJar( Class<?> modClass )
     {
         String path = modClass.getProtectionDomain().getCodeSource().getLocation().getPath();
-        int bangIndex = path.indexOf( '!' );
+        int bangIndex = path.indexOf( "!" );
         if( bangIndex >= 0 )
         {
             path = path.substring( 0, bangIndex );
@@ -597,7 +673,7 @@ public class ComputerCraft
     private static File getDebugCodeDir( Class<?> modClass )
     {
         String path = modClass.getProtectionDomain().getCodeSource().getLocation().getPath();
-        int bangIndex = path.indexOf( '!' );
+        int bangIndex = path.indexOf( "!" );
         return bangIndex >= 0 ? null : new File( new File( path ).getParentFile(), "../.." );
     }
 
@@ -654,12 +730,5 @@ public class ComputerCraft
     {
         return Peripherals.getPeripheral( world, pos, side );
     }
-
-    @Deprecated
-    public static boolean canPlayerUseCommands( EntityPlayer player )
-    {
-        MinecraftServer server = player.getServer();
-        return server != null && server.getPlayerList().canSendCommands( player.getGameProfile() );
-    }
     //endregion
 }

src/main/java/dan200/computercraft/api/ComputerCraftAPI.java

@@ -32,9 +32,8 @@ import java.lang.reflect.Method;
 
 /**
  * The static entry point to the ComputerCraft API.
- *
+ * Members in this class must be called after mod_ComputerCraft has been initialised,
- * Members in this class must be called after mod_ComputerCraft has been initialised, but may be called before it is
+ * but may be called before it is fully loaded.
- * fully loaded.
  */
 public final class ComputerCraftAPI
 {
@@ -174,8 +173,8 @@ public final class ComputerCraftAPI
      * Registers a peripheral provider to convert blocks into {@link IPeripheral} implementations.
      *
      * @param provider The peripheral provider to register.
-     * @see IPeripheral
+     * @see dan200.computercraft.api.peripheral.IPeripheral
-     * @see IPeripheralProvider
+     * @see dan200.computercraft.api.peripheral.IPeripheralProvider
      */
     public static void registerPeripheralProvider( @Nonnull IPeripheralProvider provider )
     {
@@ -199,7 +198,7 @@ public final class ComputerCraftAPI
      * this during the load() method of your mod.
      *
      * @param upgrade The turtle upgrade to register.
-     * @see ITurtleUpgrade
+     * @see dan200.computercraft.api.turtle.ITurtleUpgrade
      */
     public static void registerTurtleUpgrade( @Nonnull ITurtleUpgrade upgrade )
     {
@@ -224,7 +223,7 @@ public final class ComputerCraftAPI
      * Registers a bundled redstone provider to provide bundled redstone output for blocks.
      *
      * @param provider The bundled redstone provider to register.
-     * @see IBundledRedstoneProvider
+     * @see dan200.computercraft.api.redstone.IBundledRedstoneProvider
      */
     public static void registerBundledRedstoneProvider( @Nonnull IBundledRedstoneProvider provider )
     {
@@ -250,7 +249,7 @@ public final class ComputerCraftAPI
      * @param side  The side to extract the bundled redstone output from.
      * @return If there is a block capable of emitting bundled redstone at the location, it's signal (0-65535) will be returned.
      * If there is no block capable of emitting bundled redstone at the location, -1 will be returned.
-     * @see IBundledRedstoneProvider
+     * @see dan200.computercraft.api.redstone.IBundledRedstoneProvider
      */
     public static int getBundledRedstoneOutput( @Nonnull World world, @Nonnull BlockPos pos, @Nonnull EnumFacing side )
     {
@@ -270,10 +269,10 @@ public final class ComputerCraftAPI
     }
 
     /**
-     * Registers a media provider to provide {@link IMedia} implementations for Items.
+     * Registers a media provider to provide {@link IMedia} implementations for Items
      *
      * @param provider The media provider to register.
-     * @see IMediaProvider
+     * @see dan200.computercraft.api.media.IMediaProvider
      */
     public static void registerMediaProvider( @Nonnull IMediaProvider provider )
     {
@@ -295,7 +294,7 @@ public final class ComputerCraftAPI
      * Registers a permission provider to restrict where turtles can move or build.
      *
      * @param provider The turtle permission provider to register.
-     * @see ITurtlePermissionProvider
+     * @see dan200.computercraft.api.permissions.ITurtlePermissionProvider
      * @deprecated Prefer using {@link dan200.computercraft.api.turtle.event.TurtleBlockEvent} or the standard Forge events.
      */
     @Deprecated
@@ -371,7 +370,7 @@ public final class ComputerCraftAPI
     }
 
     /**
-     * Construct a new wired node for a given wired element.
+     * Construct a new wired node for a given wired element
      *
      * @param element The element to construct it for
      * @return The element's node
@@ -399,7 +398,7 @@ public final class ComputerCraftAPI
     }
 
     /**
-     * Get the wired network element for a block in world.
+     * Get the wired network element for a block in world
      *
      * @param world The world the block exists in
      * @param pos   The position the block exists in
@@ -439,50 +438,50 @@ public final class ComputerCraftAPI
                 computerCraft_getVersion = findCCMethod( "getVersion", new Class<?>[] {
                 } );
                 computerCraft_createUniqueNumberedSaveDir = findCCMethod( "createUniqueNumberedSaveDir", new Class<?>[] {
-                    World.class, String.class,
+                    World.class, String.class
                 } );
                 computerCraft_createSaveDirMount = findCCMethod( "createSaveDirMount", new Class<?>[] {
-                    World.class, String.class, Long.TYPE,
+                    World.class, String.class, Long.TYPE
                 } );
                 computerCraft_createResourceMount = findCCMethod( "createResourceMount", new Class<?>[] {
-                    Class.class, String.class, String.class,
+                    Class.class, String.class, String.class
                 } );
                 computerCraft_registerPeripheralProvider = findCCMethod( "registerPeripheralProvider", new Class<?>[] {
-                    IPeripheralProvider.class,
+                    IPeripheralProvider.class
                 } );
                 computerCraft_registerTurtleUpgrade = findCCMethod( "registerTurtleUpgrade", new Class<?>[] {
-                    ITurtleUpgrade.class,
+                    ITurtleUpgrade.class
                 } );
                 computerCraft_registerBundledRedstoneProvider = findCCMethod( "registerBundledRedstoneProvider", new Class<?>[] {
-                    IBundledRedstoneProvider.class,
+                    IBundledRedstoneProvider.class
                 } );
                 computerCraft_getDefaultBundledRedstoneOutput = findCCMethod( "getDefaultBundledRedstoneOutput", new Class<?>[] {
-                    World.class, BlockPos.class, EnumFacing.class,
+                    World.class, BlockPos.class, EnumFacing.class
                 } );
                 computerCraft_registerMediaProvider = findCCMethod( "registerMediaProvider", new Class<?>[] {
-                    IMediaProvider.class,
+                    IMediaProvider.class
                 } );
                 computerCraft_registerPermissionProvider = findCCMethod( "registerPermissionProvider", new Class<?>[] {
-                    ITurtlePermissionProvider.class,
+                    ITurtlePermissionProvider.class
                 } );
                 computerCraft_registerPocketUpgrade = findCCMethod( "registerPocketUpgrade", new Class<?>[] {
-                    IPocketUpgrade.class,
+                    IPocketUpgrade.class
                 } );
                 computerCraft_getWirelessNetwork = findCCMethod( "getWirelessNetwork", new Class<?>[] {
                 } );
                 computerCraft_registerAPIFactory = findCCMethod( "registerAPIFactory", new Class<?>[] {
-                    ILuaAPIFactory.class,
+                    ILuaAPIFactory.class
                 } );
                 computerCraft_createWiredNodeForElement = findCCMethod( "createWiredNodeForElement", new Class<?>[] {
-                    IWiredElement.class,
+                    IWiredElement.class
                 } );
                 computerCraft_getWiredElementAt = findCCMethod( "getWiredElementAt", new Class<?>[] {
-                    IBlockAccess.class, BlockPos.class, EnumFacing.class,
+                    IBlockAccess.class, BlockPos.class, EnumFacing.class
                 } );
             }
             catch( Exception e )
             {
-                System.err.println( "ComputerCraftAPI: ComputerCraft not found." );
+                System.out.println( "ComputerCraftAPI: ComputerCraft not found." );
             }
             finally
             {
@@ -499,7 +498,7 @@ public final class ComputerCraftAPI
         }
         catch( NoSuchMethodException e )
         {
-            System.err.println( "ComputerCraftAPI: ComputerCraft method " + name + " not found." );
+            System.out.println( "ComputerCraftAPI: ComputerCraft method " + name + " not found." );
             return null;
         }
     }

src/main/java/dan200/computercraft/api/filesystem/FileOperationException.java

@@ -1,41 +0,0 @@
-/*
- * This file is part of the public ComputerCraft API - http://www.computercraft.info
- * Copyright Daniel Ratcliffe, 2011-2019. This API may be redistributed unmodified and in full only.
- * For help using the API, and posting your mods, visit the forums at computercraft.info.
- */
-package dan200.computercraft.api.filesystem;
-
-import javax.annotation.Nonnull;
-import javax.annotation.Nullable;
-import java.io.IOException;
-import java.util.Objects;
-
-/**
- * An {@link IOException} which occurred on a specific file.
- *
- * This may be thrown from a {@link IMount} or {@link IWritableMount} to give more information about a failure.
- */
-public class FileOperationException extends IOException
-{
-    private static final long serialVersionUID = -8809108200853029849L;
-
-    private final String filename;
-
-    public FileOperationException( @Nullable String filename, @Nonnull String message )
-    {
-        super( Objects.requireNonNull( message, "message cannot be null" ) );
-        this.filename = filename;
-    }
-
-    public FileOperationException( String message )
-    {
-        super( Objects.requireNonNull( message, "message cannot be null" ) );
-        this.filename = null;
-    }
-
-    @Nullable
-    public String getFilename()
-    {
-        return filename;
-    }
-}

src/main/java/dan200/computercraft/api/filesystem/IMount.java

@@ -19,7 +19,7 @@ import java.util.List;
 
 /**
  * Represents a read only part of a virtual filesystem that can be mounted onto a computer using
- * {@link IComputerAccess#mount(String, IMount)}.
+ * {@link IComputerAccess#mount(String, IMount)}
  *
  * Ready made implementations of this interface can be created using
  * {@link ComputerCraftAPI#createSaveDirMount(World, String, long)} or
@@ -60,7 +60,7 @@ public interface IMount
     void list( @Nonnull String path, @Nonnull List<String> contents ) throws IOException;
 
     /**
-     * Returns the size of a file with a given path, in bytes.
+     * Returns the size of a file with a given path, in bytes
      *
      * @param path A file path in normalised format, relative to the mount location. ie: "programs/myprogram".
      * @return The size of the file, in bytes.
@@ -90,6 +90,7 @@ public interface IMount
      * @throws IOException If the file does not exist, or could not be opened.
      */
     @Nonnull
+    @SuppressWarnings( "deprecation" )
     default ReadableByteChannel openChannelForRead( @Nonnull String path ) throws IOException
     {
         return Channels.newChannel( openForRead( path ) );

src/main/java/dan200/computercraft/api/filesystem/IWritableMount.java

@@ -67,6 +67,7 @@ public interface IWritableMount extends IMount
      * @throws IOException If the file could not be opened for writing.
      */
     @Nonnull
+    @SuppressWarnings( "deprecation" )
     default WritableByteChannel openChannelForWrite( @Nonnull String path ) throws IOException
     {
         return Channels.newChannel( openForWrite( path ) );
@@ -93,6 +94,7 @@ public interface IWritableMount extends IMount
      * @throws IOException If the file could not be opened for writing.
      */
     @Nonnull
+    @SuppressWarnings( "deprecation" )
     default WritableByteChannel openChannelForAppend( @Nonnull String path ) throws IOException
     {
         return Channels.newChannel( openForAppend( path ) );

src/main/java/dan200/computercraft/api/lua/ArgumentHelper.java

@@ -1,335 +0,0 @@
-/*
- * This file is part of the public ComputerCraft API - http://www.computercraft.info
- * Copyright Daniel Ratcliffe, 2011-2019. This API may be redistributed unmodified and in full only.
- * For help using the API, and posting your mods, visit the forums at computercraft.info.
- */
-
-package dan200.computercraft.api.lua;
-
-import dan200.computercraft.api.peripheral.IComputerAccess;
-import dan200.computercraft.api.peripheral.IPeripheral;
-
-import javax.annotation.Nonnull;
-import javax.annotation.Nullable;
-import java.util.Map;
-
-/**
- * Provides methods for extracting values and validating Lua arguments, such as those provided to
- * {@link ILuaObject#callMethod(ILuaContext, int, Object[])} or
- * {@link IPeripheral#callMethod(IComputerAccess, ILuaContext, int, Object[])}.
- *
- * This provides two sets of functions: the {@code get*} methods, which require an argument to be valid, and
- * {@code opt*}, which accept a default value and return that if the argument was not present or was {@code null}.
- * If the argument is of the wrong type, a suitable error message will be thrown, with a similar format to Lua's own
- * error messages.
- *
- * <h2>Example usage:</h2>
- * <pre>
- * {@code
- * int slot = getInt( args, 0 );
- * int amount = optInt( args, 1, 64 );
- * }
- * </pre>
- */
-public final class ArgumentHelper
-{
-    private ArgumentHelper()
-    {
-    }
-
-    /**
-     * Get a string representation of the given value's type.
-     *
-     * @param value The value whose type we are trying to compute.
-     * @return A string representation of the given value's type, in a similar format to that provided by Lua's
-     * {@code type} function.
-     */
-    @Nonnull
-    public static String getType( @Nullable Object value )
-    {
-        if( value == null ) return "nil";
-        if( value instanceof String ) return "string";
-        if( value instanceof Boolean ) return "boolean";
-        if( value instanceof Number ) return "number";
-        if( value instanceof Map ) return "table";
-        return "userdata";
-    }
-
-    /**
-     * Construct a "bad argument" exception, from an expected type and the actual value provided.
-     *
-     * @param index    The argument number, starting from 0.
-     * @param expected The expected type for this argument.
-     * @param actual   The actual value provided for this argument.
-     * @return The constructed exception, which should be thrown immediately.
-     */
-    @Nonnull
-    public static LuaException badArgumentOf( int index, @Nonnull String expected, @Nullable Object actual )
-    {
-        return badArgument( index, expected, getType( actual ) );
-    }
-
-    /**
-     * Construct a "bad argument" exception, from an expected and actual type.
-     *
-     * @param index    The argument number, starting from 0.
-     * @param expected The expected type for this argument.
-     * @param actual   The provided type for this argument.
-     * @return The constructed exception, which should be thrown immediately.
-     */
-    @Nonnull
-    public static LuaException badArgument( int index, @Nonnull String expected, @Nonnull String actual )
-    {
-        return new LuaException( "bad argument #" + (index + 1) + " (" + expected + " expected, got " + actual + ")" );
-    }
-
-    /**
-     * Get an argument as a double.
-     *
-     * @param args  The arguments to extract from.
-     * @param index The index into the argument array to read from.
-     * @return The argument's value.
-     * @throws LuaException If the value is not a number.
-     * @see #getFiniteDouble(Object[], int) if you require this to be finite (i.e. not infinite or NaN).
-     */
-    public static double getDouble( @Nonnull Object[] args, int index ) throws LuaException
-    {
-        if( index >= args.length ) throw badArgument( index, "number", "nil" );
-        Object value = args[index];
-        if( !(value instanceof Number) ) throw badArgumentOf( index, "number", value );
-        return ((Number) value).doubleValue();
-    }
-
-    /**
-     * Get an argument as an integer.
-     *
-     * @param args  The arguments to extract from.
-     * @param index The index into the argument array to read from.
-     * @return The argument's value.
-     * @throws LuaException If the value is not an integer.
-     */
-    public static int getInt( @Nonnull Object[] args, int index ) throws LuaException
-    {
-        return (int) getLong( args, index );
-    }
-
-    /**
-     * Get an argument as a long.
-     *
-     * @param args  The arguments to extract from.
-     * @param index The index into the argument array to read from.
-     * @return The argument's value.
-     * @throws LuaException If the value is not a long.
-     */
-    public static long getLong( @Nonnull Object[] args, int index ) throws LuaException
-    {
-        if( index >= args.length ) throw badArgument( index, "number", "nil" );
-        Object value = args[index];
-        if( !(value instanceof Number) ) throw badArgumentOf( index, "number", value );
-        return checkFinite( index, (Number) value ).longValue();
-    }
-
-    /**
-     * Get an argument as a finite number (not infinite or NaN).
-     *
-     * @param args  The arguments to extract from.
-     * @param index The index into the argument array to read from.
-     * @return The argument's value.
-     * @throws LuaException If the value is not finite.
-     */
-    public static double getFiniteDouble( @Nonnull Object[] args, int index ) throws LuaException
-    {
-        return checkFinite( index, getDouble( args, index ) );
-    }
-
-    /**
-     * Get an argument as a boolean.
-     *
-     * @param args  The arguments to extract from.
-     * @param index The index into the argument array to read from.
-     * @return The argument's value.
-     * @throws LuaException If the value is not a boolean.
-     */
-    public static boolean getBoolean( @Nonnull Object[] args, int index ) throws LuaException
-    {
-        if( index >= args.length ) throw badArgument( index, "boolean", "nil" );
-        Object value = args[index];
-        if( !(value instanceof Boolean) ) throw badArgumentOf( index, "boolean", value );
-        return (Boolean) value;
-    }
-
-    /**
-     * Get an argument as a string.
-     *
-     * @param args  The arguments to extract from.
-     * @param index The index into the argument array to read from.
-     * @return The argument's value.
-     * @throws LuaException If the value is not a string.
-     */
-    @Nonnull
-    public static String getString( @Nonnull Object[] args, int index ) throws LuaException
-    {
-        if( index >= args.length ) throw badArgument( index, "string", "nil" );
-        Object value = args[index];
-        if( !(value instanceof String) ) throw badArgumentOf( index, "string", value );
-        return (String) value;
-    }
-
-    /**
-     * Get an argument as a table.
-     *
-     * @param args  The arguments to extract from.
-     * @param index The index into the argument array to read from.
-     * @return The argument's value.
-     * @throws LuaException If the value is not a table.
-     */
-    @Nonnull
-    public static Map<?, ?> getTable( @Nonnull Object[] args, int index ) throws LuaException
-    {
-        if( index >= args.length ) throw badArgument( index, "table", "nil" );
-        Object value = args[index];
-        if( !(value instanceof Map) ) throw badArgumentOf( index, "table", value );
-        return (Map<?, ?>) value;
-    }
-
-    /**
-     * Get an argument as a double.
-     *
-     * @param args  The arguments to extract from.
-     * @param index The index into the argument array to read from.
-     * @param def   The default value, if this argument is not given.
-     * @return The argument's value, or {@code def} if none was provided.
-     * @throws LuaException If the value is not a number.
-     */
-    public static double optDouble( @Nonnull Object[] args, int index, double def ) throws LuaException
-    {
-        Object value = index < args.length ? args[index] : null;
-        if( value == null ) return def;
-        if( !(value instanceof Number) ) throw badArgumentOf( index, "number", value );
-        return ((Number) value).doubleValue();
-    }
-
-    /**
-     * Get an argument as an int.
-     *
-     * @param args  The arguments to extract from.
-     * @param index The index into the argument array to read from.
-     * @param def   The default value, if this argument is not given.
-     * @return The argument's value, or {@code def} if none was provided.
-     * @throws LuaException If the value is not a number.
-     */
-    public static int optInt( @Nonnull Object[] args, int index, int def ) throws LuaException
-    {
-        return (int) optLong( args, index, def );
-    }
-
-    /**
-     * Get an argument as a long.
-     *
-     * @param args  The arguments to extract from.
-     * @param index The index into the argument array to read from.
-     * @param def   The default value, if this argument is not given.
-     * @return The argument's value, or {@code def} if none was provided.
-     * @throws LuaException If the value is not a number.
-     */
-    public static long optLong( @Nonnull Object[] args, int index, long def ) throws LuaException
-    {
-        Object value = index < args.length ? args[index] : null;
-        if( value == null ) return def;
-        if( !(value instanceof Number) ) throw badArgumentOf( index, "number", value );
-        return checkFinite( index, (Number) value ).longValue();
-    }
-
-    /**
-     * Get an argument as a finite number (not infinite or NaN).
-     *
-     * @param args  The arguments to extract from.
-     * @param index The index into the argument array to read from.
-     * @param def   The default value, if this argument is not given.
-     * @return The argument's value, or {@code def} if none was provided.
-     * @throws LuaException If the value is not finite.
-     */
-    public static double optFiniteDouble( @Nonnull Object[] args, int index, double def ) throws LuaException
-    {
-        return checkFinite( index, optDouble( args, index, def ) );
-    }
-
-    /**
-     * Get an argument as a boolean.
-     *
-     * @param args  The arguments to extract from.
-     * @param index The index into the argument array to read from.
-     * @param def   The default value, if this argument is not given.
-     * @return The argument's value, or {@code def} if none was provided.
-     * @throws LuaException If the value is not a boolean.
-     */
-    public static boolean optBoolean( @Nonnull Object[] args, int index, boolean def ) throws LuaException
-    {
-        Object value = index < args.length ? args[index] : null;
-        if( value == null ) return def;
-        if( !(value instanceof Boolean) ) throw badArgumentOf( index, "boolean", value );
-        return (Boolean) value;
-    }
-
-    /**
-     * Get an argument as a string.
-     *
-     * @param args  The arguments to extract from.
-     * @param index The index into the argument array to read from.
-     * @param def   The default value, if this argument is not given.
-     * @return The argument's value, or {@code def} if none was provided.
-     * @throws LuaException If the value is not a string.
-     */
-    public static String optString( @Nonnull Object[] args, int index, String def ) throws LuaException
-    {
-        Object value = index < args.length ? args[index] : null;
-        if( value == null ) return def;
-        if( !(value instanceof String) ) throw badArgumentOf( index, "string", value );
-        return (String) value;
-    }
-
-    /**
-     * Get an argument as a table.
-     *
-     * @param args  The arguments to extract from.
-     * @param index The index into the argument array to read from.
-     * @param def   The default value, if this argument is not given.
-     * @return The argument's value, or {@code def} if none was provided.
-     * @throws LuaException If the value is not a table.
-     */
-    public static Map<?, ?> optTable( @Nonnull Object[] args, int index, Map<Object, Object> def ) throws LuaException
-    {
-        Object value = index < args.length ? args[index] : null;
-        if( value == null ) return def;
-        if( !(value instanceof Map) ) throw badArgumentOf( index, "table", value );
-        return (Map<?, ?>) value;
-    }
-
-    private static Number checkFinite( int index, Number value ) throws LuaException
-    {
-        checkFinite( index, value.doubleValue() );
-        return value;
-    }
-
-    private static double checkFinite( int index, double value ) throws LuaException
-    {
-        if( !Double.isFinite( value ) ) throw badArgument( index, "number", getNumericType( value ) );
-        return value;
-    }
-
-    /**
-     * Returns a more detailed representation of this number's type. If this is finite, it will just return "number",
-     * otherwise it returns whether it is infinite or NaN.
-     *
-     * @param value The value to extract the type for.
-     * @return This value's numeric type.
-     */
-    @Nonnull
-    public static String getNumericType( double value )
-    {
-        if( Double.isNaN( value ) ) return "nan";
-        if( value == Double.POSITIVE_INFINITY ) return "inf";
-        if( value == Double.NEGATIVE_INFINITY ) return "-inf";
-        return "number";
-    }
-}

src/main/java/dan200/computercraft/api/lua/IComputerSystem.java

@@ -26,7 +26,7 @@ public interface IComputerSystem extends IComputerAccess
     IFileSystem getFileSystem();
 
     /**
-     * Get the label for this computer.
+     * Get the label for this computer
      *
      * @return This computer's label, or {@code null} if it is not set.
      */

src/main/java/dan200/computercraft/api/lua/ILuaAPIFactory.java

@@ -17,7 +17,6 @@ import javax.annotation.Nullable;
  * @see ILuaAPI
  * @see ComputerCraftAPI#registerAPIFactory(ILuaAPIFactory)
  */
-@FunctionalInterface
 public interface ILuaAPIFactory
 {
     /**

src/main/java/dan200/computercraft/api/lua/ILuaContext.java

@@ -32,12 +32,7 @@ public interface ILuaContext
      *                              intercepted, or the computer will leak memory and end up in a broken state.
      */
     @Nonnull
-    default Object[] pullEvent( @Nullable String filter ) throws LuaException, InterruptedException
+    Object[] pullEvent( @Nullable String filter ) throws LuaException, InterruptedException;
-    {
-        Object[] results = pullEventRaw( filter );
-        if( results.length >= 1 && results[0].equals( "terminate" ) ) throw new LuaException( "Terminated", 0 );
-        return results;
-    }
 
     /**
      * The same as {@link #pullEvent(String)}, except "terminated" events are ignored. Only use this if you want to
@@ -52,10 +47,7 @@ public interface ILuaContext
      * @see #pullEvent(String)
      */
     @Nonnull
-    default Object[] pullEventRaw( @Nullable String filter ) throws InterruptedException
+    Object[] pullEventRaw( @Nullable String filter ) throws InterruptedException;
-    {
-        return yield( new Object[] { filter } );
-    }
 
     /**
      * Yield the current coroutine with some arguments until it is resumed. This method is exactly equivalent to

src/main/java/dan200/computercraft/api/media/IMedia.java

@@ -7,7 +7,6 @@
 package dan200.computercraft.api.media;
 
 import dan200.computercraft.api.filesystem.IMount;
-import net.minecraft.item.Item;
 import net.minecraft.item.ItemStack;
 import net.minecraft.util.SoundEvent;
 import net.minecraft.world.World;
@@ -17,9 +16,7 @@ import javax.annotation.Nullable;
 
 /**
  * Represents an item that can be placed in a disk drive and used by a Computer.
- *
+ * Implement this interface on your Item class to allow it to be used in the drive.
- * Implement this interface on your {@link Item} class to allow it to be used in the drive. Alternatively, register
- * a {@link IMediaProvider}.
  */
 public interface IMedia
 {
@@ -46,7 +43,7 @@ public interface IMedia
 
     /**
      * If this disk represents an item with audio (like a record), get the readable name of the audio track. ie:
-     * "Jonathan Coulton - Still Alive"
+     * "Jonathon Coulton - Still Alive"
      *
      * @param stack The {@link ItemStack} to modify.
      * @return The name, or null if this item does not represent an item with audio.
@@ -77,7 +74,7 @@ public interface IMedia
      * @param world The world in which the item and disk drive reside.
      * @return The mount, or null if this item does not represent an item with data. If the mount returned also
      * implements {@link dan200.computercraft.api.filesystem.IWritableMount}, it will mounted using mountWritable()
-     * @see IMount
+     * @see dan200.computercraft.api.filesystem.IMount
      * @see dan200.computercraft.api.filesystem.IWritableMount
      * @see dan200.computercraft.api.ComputerCraftAPI#createSaveDirMount(World, String, long)
      * @see dan200.computercraft.api.ComputerCraftAPI#createResourceMount(Class, String, String)

src/main/java/dan200/computercraft/api/media/IMediaProvider.java

@@ -23,7 +23,7 @@ public interface IMediaProvider
      * Produce an IMedia implementation from an ItemStack.
      *
      * @param stack The stack from which to extract the media information.
-     * @return An {@link IMedia} implementation, or {@code null} if the item is not something you wish to handle
+     * @return An IMedia implementation, or null if the item is not something you wish to handle
      * @see dan200.computercraft.api.ComputerCraftAPI#registerMediaProvider(IMediaProvider)
      */
     @Nullable

src/main/java/dan200/computercraft/api/peripheral/IComputerAccess.java

@@ -9,8 +9,6 @@ package dan200.computercraft.api.peripheral;
 import dan200.computercraft.api.ComputerCraftAPI;
 import dan200.computercraft.api.filesystem.IMount;
 import dan200.computercraft.api.filesystem.IWritableMount;
-import dan200.computercraft.api.lua.ILuaContext;
-import dan200.computercraft.api.lua.ILuaTask;
 import net.minecraft.world.World;
 
 import javax.annotation.Nonnull;
@@ -148,7 +146,7 @@ public interface IComputerAccess
      *
      *                  You may supply {@code null} to indicate that no arguments are to be supplied.
      * @throws RuntimeException If the peripheral has been detached.
-     * @see IPeripheral#callMethod
+     * @see dan200.computercraft.api.peripheral.IPeripheral#callMethod
      */
     void queueEvent( @Nonnull String event, @Nullable Object[] arguments );
 
@@ -181,8 +179,8 @@ public interface IComputerAccess
     }
 
     /**
-     * Get a reachable peripheral with the given attachment name. This is a equivalent to
+     * Get a reachable peripheral with the given attachement name. This is a equivalent to
-     * {@link #getAvailablePeripherals()}{@code .get(name)}, though may be more efficient.
+     * {@link #getAvailablePeripherals()}{@code .get(name)}, though may be more performant.
      *
      * @param name The peripheral's attached name
      * @return The reachable peripheral, or {@code null} if none can be found.
@@ -193,23 +191,4 @@ public interface IComputerAccess
     {
         return null;
     }
-
-    /**
-     * Get a {@link IWorkMonitor} for tasks your peripheral might execute on the main (server) thread.
-     *
-     * This should be used to ensure your peripheral integrates with ComputerCraft's monitoring and limiting of how much
-     * server time each computer consumes. You should not need to use this if you use
-     * {@link ILuaContext#issueMainThreadTask(ILuaTask)} - this is intended for mods with their own system for running
-     * work on the main thread.
-     *
-     * Please note that the returned implementation is <em>not</em> thread-safe, and should only be used from the main
-     * thread.
-     *
-     * @return The work monitor for the main thread, or {@code null} if this computer does not have one.
-     */
-    @Nullable
-    default IWorkMonitor getMainThreadMonitor()
-    {
-        return null;
-    }
 }

src/main/java/dan200/computercraft/api/peripheral/IPeripheral.java

@@ -6,7 +6,6 @@
 
 package dan200.computercraft.api.peripheral;
 
-import dan200.computercraft.api.lua.ArgumentHelper;
 import dan200.computercraft.api.lua.ILuaContext;
 import dan200.computercraft.api.lua.LuaException;
 
@@ -42,8 +41,8 @@ public interface IPeripheral
      * This is called when a lua program on an attached computer calls {@code peripheral.call()} with
      * one of the methods exposed by {@link #getMethodNames()}.
      *
-     * Be aware that this will be called from the ComputerCraft Lua thread, and must be thread-safe when interacting
+     * Be aware that this will be called from the ComputerCraft Lua thread, and must be thread-safe
-     * with Minecraft objects.
+     * when interacting with Minecraft objects.
      *
      * @param computer  The interface to the computer that is making the call. Remember that multiple
      *                  computers can be attached to a peripheral at once.
@@ -59,11 +58,9 @@ public interface IPeripheral
      *                  Lua values of type "table" will be represented by Object type Map.<br>
      *                  Lua values of any other type will be represented by a null object.<br>
      *                  This array will be empty if no arguments are passed.
-     *
-     *                  It is recommended you use {@link ArgumentHelper} in order to validate and process arguments.
      * @return An array of objects, representing values you wish to return to the lua program. Integers, Doubles, Floats,
-     * Strings, Booleans, Maps, ILuaObject and null be converted to their corresponding lua type. All other types will
+     * Strings, Booleans, Maps and ILuaObject and null be converted to their corresponding lua type. All other types
-     * be converted to nil.
+     * will be converted to nil.
      *
      * You may return null to indicate no values should be returned.
      * @throws LuaException         If you throw any exception from this function, a lua error will be raised with the
@@ -73,27 +70,25 @@ public interface IPeripheral
      *                              InterruptedException will be thrown. This exception must not be caught or
      *                              intercepted, or the computer will leak memory and end up in a broken state.
      * @see #getMethodNames
-     * @see ArgumentHelper
      */
     @Nullable
     Object[] callMethod( @Nonnull IComputerAccess computer, @Nonnull ILuaContext context, int method, @Nonnull Object[] arguments ) throws LuaException, InterruptedException;
 
     /**
-     * Is called when when a computer is attaching to the peripheral.
+     * Is called when canAttachToSide has returned true, and a computer is attaching to the peripheral.
      *
      * This will occur when a peripheral is placed next to an active computer, when a computer is turned on next to a
-     * peripheral, when a turtle travels into a square next to a peripheral, or when a wired modem adjacent to this
+     * peripheral, or when a turtle travels into a square next to a peripheral.
-     * peripheral is does any of the above.
      *
-     * Between calls to attach and {@link #detach}, the attached computer can make method calls on the peripheral using
+     * Between calls to attach() and detach(), the attached computer can make method calls on the peripheral using
      * {@code peripheral.call()}. This method can be used to keep track of which computers are attached to the
      * peripheral, or to take action when attachment occurs.
      *
-     * Be aware that will be called from both the server thread and ComputerCraft Lua thread, and so must be thread-safe
+     * Be aware that this will be called from the ComputerCraft Lua thread, and must be thread-safe
-     * and reentrant.
+     * when interacting with Minecraft objects.
      *
-     * @param computer The interface to the computer that is being attached. Remember that multiple computers can be
+     * @param computer The interface to the computer that is being attached. Remember that multiple
-     *                 attached to a peripheral at once.
+     *                 computers can be attached to a peripheral at once.
      * @see #detach
      */
     default void attach( @Nonnull IComputerAccess computer )
@@ -101,21 +96,19 @@ public interface IPeripheral
     }
 
     /**
-     * Called when a computer is detaching from the peripheral.
+     * Is called when a computer is detaching from the peripheral.
      *
-     * This will occur when a computer shuts down, when the peripheral is removed while attached to computers, when a
+     * This will occur when a computer shuts down, when the peripheral is removed while attached to computers,
-     * turtle moves away from a block attached to a peripheral, or when a wired modem adjacent to this peripheral is
+     * or when a turtle moves away from a square attached to a peripheral. This method can be used to keep track of
-     * detached.
+     * which computers are attached to the peripheral, or to take action when detachment
+     * occurs.
      *
-     * This method can be used to keep track of which computers are attached to the peripheral, or to take action when
+     * Be aware that this will be called from the ComputerCraft Lua thread, and must be thread-safe
-     * detachment occurs.
+     * when interacting with Minecraft objects.
      *
-     * Be aware that this will be called from both the server and ComputerCraft Lua thread, and must be thread-safe
+     * @param computer The interface to the computer that is being detached. Remember that multiple
-     * and reentrant.
+     *                 computers can be attached to a peripheral at once.
-     *
+     * @see #detach
-     * @param computer The interface to the computer that is being detached. Remember that multiple computers can be
-     *                 attached to a peripheral at once.
-     * @see #attach
      */
     default void detach( @Nonnull IComputerAccess computer )
     {

src/main/java/dan200/computercraft/api/peripheral/IPeripheralProvider.java

@@ -6,7 +6,6 @@
 
 package dan200.computercraft.api.peripheral;
 
-import net.minecraft.tileentity.TileEntity;
 import net.minecraft.util.EnumFacing;
 import net.minecraft.util.math.BlockPos;
 import net.minecraft.world.World;
@@ -17,8 +16,6 @@ import javax.annotation.Nullable;
 /**
  * This interface is used to create peripheral implementations for blocks.
  *
- * If you have a {@link TileEntity} which acts as a peripheral, you may alternatively implement {@link IPeripheralTile}.
- *
  * @see dan200.computercraft.api.ComputerCraftAPI#registerPeripheralProvider(IPeripheralProvider)
  */
 @FunctionalInterface

src/main/java/dan200/computercraft/api/peripheral/IPeripheralTile.java

@@ -1,32 +0,0 @@
-/*
- * This file is part of the public ComputerCraft API - http://www.computercraft.info
- * Copyright Daniel Ratcliffe, 2011-2019. This API may be redistributed unmodified and in full only.
- * For help using the API, and posting your mods, visit the forums at computercraft.info.
- */
-package dan200.computercraft.api.peripheral;
-
-import net.minecraft.util.EnumFacing;
-import net.minecraft.util.math.BlockPos;
-import net.minecraft.world.World;
-
-import javax.annotation.Nonnull;
-import javax.annotation.Nullable;
-
-/**
- * A {@link net.minecraft.tileentity.TileEntity} which may act as a peripheral.
- *
- * If you need more complex capabilities (such as handling TEs not belonging to your mod), you should use
- * {@link IPeripheralProvider}.
- */
-public interface IPeripheralTile
-{
-    /**
-     * Get the peripheral on the given {@code side}.
-     *
-     * @param side The side to get the peripheral from.
-     * @return A peripheral, or {@code null} if there is not a peripheral here.
-     * @see IPeripheralProvider#getPeripheral(World, BlockPos, EnumFacing)
-     */
-    @Nullable
-    IPeripheral getPeripheral( @Nonnull EnumFacing side );
-}

src/main/java/dan200/computercraft/api/peripheral/IWorkMonitor.java

@@ -1,77 +0,0 @@
-/*
- * This file is part of the public ComputerCraft API - http://www.computercraft.info
- * Copyright Daniel Ratcliffe, 2011-2019. This API may be redistributed unmodified and in full only.
- * For help using the API, and posting your mods, visit the forums at computercraft.info.
- */
-package dan200.computercraft.api.peripheral;
-
-import javax.annotation.Nonnull;
-import java.util.Objects;
-import java.util.concurrent.TimeUnit;
-
-/**
- * Monitors "work" associated with a computer, keeping track of how much a computer has done, and ensuring every
- * computer receives a fair share of any processing time.
- *
- * This is primarily intended for work done by peripherals on the main thread (such as on a tile entity's tick), but
- * could be used for other purposes (such as complex computations done on another thread).
- *
- * Before running a task, one should call {@link #canWork()} to determine if the computer is currently allowed to
- * execute work. If that returns true, you should execute the task and use {@link #trackWork(long, TimeUnit)} to inform
- * the monitor how long that task took.
- *
- * Alternatively, use {@link #runWork(Runnable)} to run and keep track of work.
- *
- * @see IComputerAccess#getMainThreadMonitor()
- */
-public interface IWorkMonitor
-{
-    /**
-     * If the owning computer is currently allowed to execute work.
-     *
-     * @return If we can execute work right now.
-     */
-    boolean canWork();
-
-    /**
-     * If the owning computer is currently allowed to execute work, and has ample time to do so.
-     *
-     * This is effectively a more restrictive form of {@link #canWork()}. One should use that in order to determine if
-     * you may do an initial piece of work, and shouldWork to determine if any additional task may be performed.
-     *
-     * @return If we should execute work right now.
-     */
-    boolean shouldWork();
-
-    /**
-     * Inform the monitor how long some piece of work took to execute.
-     *
-     * @param time The time some task took to run
-     * @param unit The unit that {@code time} was measured in.
-     */
-    void trackWork( long time, @Nonnull TimeUnit unit );
-
-    /**
-     * Run a task if possible, and inform the monitor of how long it took.
-     *
-     * @param runnable The task to run.
-     * @return If the task was actually run (namely, {@link #canWork()} returned {@code true}).
-     */
-    default boolean runWork( @Nonnull Runnable runnable )
-    {
-        Objects.requireNonNull( runnable, "runnable should not be null" );
-        if( !canWork() ) return false;
-
-        long start = System.nanoTime();
-        try
-        {
-            runnable.run();
-        }
-        finally
-        {
-            trackWork( System.nanoTime() - start, TimeUnit.NANOSECONDS );
-        }
-
-        return true;
-    }
-}

src/main/java/dan200/computercraft/api/pocket/IPocketAccess.java

@@ -16,7 +16,7 @@ import javax.annotation.Nullable;
 import java.util.Map;
 
 /**
- * Wrapper class for pocket computers.
+ * Wrapper class for pocket computers
  */
 public interface IPocketAccess
 {
@@ -24,22 +24,10 @@ public interface IPocketAccess
      * Gets the entity holding this item.
      *
      * @return The holding entity. This may be {@code null}.
-     * @deprecated Use {@link #getValidEntity()} where possible.
      */
     @Nullable
-    @Deprecated
     Entity getEntity();
 
-    /**
-     * Gets the entity holding this item with additional safety checks.
-     *
-     * This must be called on the server thread.
-     *
-     * @return The holding entity, or {@code null} if none exists.
-     */
-    @Nullable
-    Entity getValidEntity();
-
     /**
      * Get the colour of this pocket computer as a RGB number.
      *

src/main/java/dan200/computercraft/api/pocket/IPocketUpgrade.java

@@ -19,7 +19,7 @@ import javax.annotation.Nullable;
 /**
  * Additional peripherals for pocket computers.
  *
- * This is similar to {@link ITurtleUpgrade}.
+ * This is similar to {@link dan200.computercraft.api.turtle.ITurtleUpgrade}.
  */
 public interface IPocketUpgrade
 {
@@ -54,9 +54,6 @@ public interface IPocketUpgrade
      * pocket computer which holds this upgrade. This item stack is also used to determine the upgrade given by
      * {@code pocket.equip()}/{@code pocket.unequip()}.
      *
-     * Ideally this should be constant over a session. It is recommended that you cache
-     * the item too, in order to prevent constructing it every time the method is called.
-     *
      * @return The item stack used for crafting. This can be {@link ItemStack#EMPTY} if crafting is disabled.
      */
     @Nonnull

src/main/java/dan200/computercraft/api/turtle/ITurtleAccess.java

@@ -145,9 +145,7 @@ public interface ITurtleAccess
     GameProfile getOwningPlayer();
 
     /**
-     * Get the inventory of this turtle.
+     * Get the inventory of this turtle
-     *
-     * Note: this inventory should only be accessed and modified on the server thread.
      *
      * @return This turtle's inventory
      * @see #getItemHandler()
@@ -158,8 +156,6 @@ public interface ITurtleAccess
     /**
      * Get the inventory of this turtle as an {@link IItemHandlerModifiable}.
      *
-     * Note: this inventory should only be accessed and modified on the server thread.
-     *
      * @return This turtle's inventory
      * @see #getInventory()
      * @see IItemHandlerModifiable

src/main/java/dan200/computercraft/api/turtle/ITurtleUpgrade.java

@@ -79,9 +79,6 @@ public interface ITurtleUpgrade
      * with to create a turtle which holds this upgrade. This item stack is also used
      * to determine the upgrade given by {@code turtle.equip()}
      *
-     * Ideally this should be constant over a session. It is recommended that you cache
-     * the item too, in order to prevent constructing it every time the method is called.
-     *
      * @return The item stack to craft with, or {@link ItemStack#EMPTY} if it cannot be crafted.
      */
     @Nonnull
@@ -109,8 +106,8 @@ public interface ITurtleUpgrade
      * Will only be called for Tool turtle. Called when turtle.dig() or turtle.attack() is called
      * by the turtle, and the tool is required to do some work.
      *
-     * Conforming implementations should fire {@link BlockEvent.BreakEvent} and {@link TurtleBlockEvent.Dig} for
+     * Conforming implementations should fire {@link BlockEvent.BreakEvent} and {@link TurtleBlockEvent.Dig}for digging,
-     * digging, {@link AttackEntityEvent} and {@link TurtleAttackEvent} for attacking.
+     * {@link AttackEntityEvent} and {@link TurtleAttackEvent} for attacking.
      *
      * @param turtle    Access to the turtle that the tool resides on.
      * @param side      Which side of the turtle (left or right) the tool resides on.

src/main/java/dan200/computercraft/api/turtle/TurtleSide.java

@@ -12,12 +12,12 @@ package dan200.computercraft.api.turtle;
 public enum TurtleSide
 {
     /**
-     * The turtle's left side (where the pickaxe usually is on a Wireless Mining Turtle).
+     * The turtle's left side (where the pickaxe usually is on a Wireless Mining Turtle)
      */
     Left,
 
     /**
-     * The turtle's right side (where the modem usually is on a Wireless Mining Turtle).
+     * The turtle's right side (where the modem usually is on a Wireless Mining Turtle)
      */
     Right,
 }

src/main/java/dan200/computercraft/api/turtle/TurtleVerb.java

@@ -18,12 +18,12 @@ import net.minecraft.util.EnumFacing;
 public enum TurtleVerb
 {
     /**
-     * The turtle called {@code turtle.dig()}, {@code turtle.digUp()} or {@code turtle.digDown()}.
+     * The turtle called {@code turtle.dig()}, {@code turtle.digUp()} or {@code turtle.digDown()}
      */
     Dig,
 
     /**
-     * The turtle called {@code turtle.attack()}, {@code turtle.attackUp()} or {@code turtle.attackDown()}.
+     * The turtle called {@code turtle.attack()}, {@code turtle.attackUp()} or {@code turtle.attackDown()}
      */
     Attack,
 }

src/main/java/dan200/computercraft/api/turtle/event/TurtleAction.java

@@ -71,7 +71,7 @@ public enum TurtleAction
     EQUIP,
 
     /**
-     * Inspect a block in world.
+     * Inspect a block in world
      *
      * @see TurtleBlockEvent.Inspect
      */

src/main/java/dan200/computercraft/api/turtle/event/TurtleBlockEvent.java

@@ -19,6 +19,7 @@ import net.minecraft.util.math.BlockPos;
 import net.minecraft.world.World;
 import net.minecraftforge.common.util.FakePlayer;
 import net.minecraftforge.event.world.BlockEvent;
+import net.minecraftforge.fml.common.eventhandler.Cancelable;
 
 import javax.annotation.Nonnull;
 import java.util.Map;
@@ -36,6 +37,7 @@ import java.util.Objects;
  * Be aware that some events (such as {@link TurtleInventoryEvent}) do not necessarily interact
  * with a block, simply objects within that block space.
  */
+@Cancelable
 public abstract class TurtleBlockEvent extends TurtlePlayerEvent
 {
     private final World world;
@@ -82,6 +84,7 @@ public abstract class TurtleBlockEvent extends TurtlePlayerEvent
      *
      * @see TurtleAction#DIG
      */
+    @Cancelable
     public static class Dig extends TurtleBlockEvent
     {
         private final IBlockState block;
@@ -112,7 +115,7 @@ public abstract class TurtleBlockEvent extends TurtlePlayerEvent
         }
 
         /**
-         * Get the upgrade doing the digging.
+         * Get the upgrade doing the digging
          *
          * @return The upgrade doing the digging.
          */
@@ -139,6 +142,7 @@ public abstract class TurtleBlockEvent extends TurtlePlayerEvent
      *
      * @see TurtleAction#MOVE
      */
+    @Cancelable
     public static class Move extends TurtleBlockEvent
     {
         public Move( @Nonnull ITurtleAccess turtle, @Nonnull FakePlayer player, @Nonnull World world, @Nonnull BlockPos pos )
@@ -152,6 +156,7 @@ public abstract class TurtleBlockEvent extends TurtlePlayerEvent
      *
      * @see TurtleAction#PLACE
      */
+    @Cancelable
     public static class Place extends TurtleBlockEvent
     {
         private final ItemStack stack;
@@ -183,6 +188,7 @@ public abstract class TurtleBlockEvent extends TurtlePlayerEvent
      *
      * @see TurtleAction#INSPECT
      */
+    @Cancelable
     public static class Inspect extends TurtleBlockEvent
     {
         private final IBlockState state;
@@ -223,7 +229,7 @@ public abstract class TurtleBlockEvent extends TurtlePlayerEvent
         /**
          * Add new information to the inspection result. Note this will override fields with the same name.
          *
-         * @param newData The data to add. Note all values should be convertible to Lua (see
+         * @param newData The data to add. Note all values should be convertable to Lua (see
          *                {@link dan200.computercraft.api.peripheral.IPeripheral#callMethod(IComputerAccess, ILuaContext, int, Object[])}).
          */
         public void addData( @Nonnull Map<String, ?> newData )

src/main/java/dan200/computercraft/api/turtle/event/TurtleInspectItemEvent.java

@@ -1,73 +0,0 @@
-/*
- * This file is part of the public ComputerCraft API - http://www.computercraft.info
- * Copyright Daniel Ratcliffe, 2011-2019. This API may be redistributed unmodified and in full only.
- * For help using the API, and posting your mods, visit the forums at computercraft.info.
- */
-package dan200.computercraft.api.turtle.event;
-
-import dan200.computercraft.api.lua.ILuaContext;
-import dan200.computercraft.api.peripheral.IComputerAccess;
-import dan200.computercraft.api.turtle.ITurtleAccess;
-import net.minecraft.item.ItemStack;
-
-import javax.annotation.Nonnull;
-import java.util.Map;
-import java.util.Objects;
-
-/**
- * Fired when a turtle gathers data on an item in its inventory.
- *
- * You may prevent items being inspected, or add additional information to the result. Be aware that this is fired on
- * the computer thread, and so any operations on it must be thread safe.
- *
- * @see TurtleAction#INSPECT_ITEM
- */
-public class TurtleInspectItemEvent extends TurtleActionEvent
-{
-    private final ItemStack stack;
-    private final Map<String, Object> data;
-
-    public TurtleInspectItemEvent( @Nonnull ITurtleAccess turtle, @Nonnull ItemStack stack, @Nonnull Map<String, Object> data )
-    {
-        super( turtle, TurtleAction.INSPECT_ITEM );
-
-        Objects.requireNonNull( stack, "stack cannot be null" );
-        Objects.requireNonNull( data, "data cannot be null" );
-        this.stack = stack;
-        this.data = data;
-    }
-
-    /**
-     * The item which is currently being inspected.
-     *
-     * @return The item stack which is being inspected. This should <b>not</b> be modified.
-     */
-    @Nonnull
-    public ItemStack getStack()
-    {
-        return stack;
-    }
-
-    /**
-     * Get the "inspection data" from this item, which will be returned to the user.
-     *
-     * @return This items's inspection data.
-     */
-    @Nonnull
-    public Map<String, Object> getData()
-    {
-        return data;
-    }
-
-    /**
-     * Add new information to the inspection result. Note this will override fields with the same name.
-     *
-     * @param newData The data to add. Note all values should be convertible to Lua (see
-     *                {@link dan200.computercraft.api.peripheral.IPeripheral#callMethod(IComputerAccess, ILuaContext, int, Object[])}).
-     */
-    public void addData( @Nonnull Map<String, ?> newData )
-    {
-        Objects.requireNonNull( newData, "newData cannot be null" );
-        data.putAll( newData );
-    }
-}

src/main/java/dan200/computercraft/api/turtle/event/TurtleInventoryEvent.java

@@ -11,6 +11,7 @@ import net.minecraft.item.ItemStack;
 import net.minecraft.util.math.BlockPos;
 import net.minecraft.world.World;
 import net.minecraftforge.common.util.FakePlayer;
+import net.minecraftforge.fml.common.eventhandler.Cancelable;
 import net.minecraftforge.items.IItemHandler;
 
 import javax.annotation.Nonnull;
@@ -20,6 +21,7 @@ import java.util.Objects;
 /**
  * Fired when a turtle attempts to interact with an inventory.
  */
+@Cancelable
 public abstract class TurtleInventoryEvent extends TurtleBlockEvent
 {
     private final IItemHandler handler;
@@ -31,7 +33,7 @@ public abstract class TurtleInventoryEvent extends TurtleBlockEvent
     }
 
     /**
-     * Get the inventory being interacted with.
+     * Get the inventory being interacted with
      *
      * @return The inventory being interacted with, {@code null} if the item will be dropped to/sucked from the world.
      */
@@ -46,6 +48,7 @@ public abstract class TurtleInventoryEvent extends TurtleBlockEvent
      *
      * @see TurtleAction#SUCK
      */
+    @Cancelable
     public static class Suck extends TurtleInventoryEvent
     {
         public Suck( @Nonnull ITurtleAccess turtle, @Nonnull FakePlayer player, @Nonnull World world, @Nonnull BlockPos pos, @Nullable IItemHandler handler )
@@ -59,6 +62,7 @@ public abstract class TurtleInventoryEvent extends TurtleBlockEvent
      *
      * @see TurtleAction#DROP
      */
+    @Cancelable
     public static class Drop extends TurtleInventoryEvent
     {
         private final ItemStack stack;
@@ -74,12 +78,13 @@ public abstract class TurtleInventoryEvent extends TurtleBlockEvent
         /**
          * The item which will be inserted into the inventory/dropped on the ground.
          *
-         * @return The item stack which will be dropped. This should <b>not</b> be modified.
+         * Note that this is a copy of the original stack, and so should not be modified, as that will have no effect.
+         *
+         * @return The item stack which will be dropped.
          */
-        @Nonnull
         public ItemStack getStack()
         {
-            return stack;
+            return stack.copy();
         }
     }
 }

src/main/java/dan200/computercraft/api/turtle/event/TurtleRefuelEvent.java

@@ -1,90 +0,0 @@
-/*
- * This file is part of the public ComputerCraft API - http://www.computercraft.info
- * Copyright Daniel Ratcliffe, 2011-2019. This API may be redistributed unmodified and in full only.
- * For help using the API, and posting your mods, visit the forums at computercraft.info.
- */
-package dan200.computercraft.api.turtle.event;
-
-import dan200.computercraft.api.turtle.ITurtleAccess;
-import net.minecraft.item.ItemStack;
-
-import javax.annotation.Nonnull;
-import javax.annotation.Nullable;
-import java.util.Objects;
-
-/**
- * Fired when a turtle attempts to refuel from an item.
- *
- * One may use {@link #setCanceled(boolean, String)} to prevent refueling from this specific item. Additionally, you
- * may use {@link #setHandler(Handler)} to register a custom fuel provider.
- */
-public class TurtleRefuelEvent extends TurtleActionEvent
-{
-    private final ItemStack stack;
-    private Handler handler;
-
-    public TurtleRefuelEvent( @Nonnull ITurtleAccess turtle, @Nonnull ItemStack stack )
-    {
-        super( turtle, TurtleAction.REFUEL );
-
-        Objects.requireNonNull( turtle, "turtle cannot be null" );
-        this.stack = stack;
-    }
-
-    /**
-     * Get the stack we are attempting to refuel from.
-     *
-     * Do not modify the returned stack - all modifications should be done within the {@link Handler}.
-     *
-     * @return The stack to refuel from.
-     */
-    public ItemStack getStack()
-    {
-        return stack;
-    }
-
-    /**
-     * Get the refuel handler for this stack.
-     *
-     * @return The refuel handler, or {@code null} if none has currently been set.
-     * @see #setHandler(Handler)
-     */
-    @Nullable
-    public Handler getHandler()
-    {
-        return handler;
-    }
-
-    /**
-     * Set the refuel handler for this stack.
-     *
-     * You should call this if you can actually refuel from this item, and ideally only if there are no existing
-     * handlers.
-     *
-     * @param handler The new refuel handler.
-     * @see #getHandler()
-     */
-    public void setHandler( @Nullable Handler handler )
-    {
-        this.handler = handler;
-    }
-
-    /**
-     * Handles refuelling a turtle from a specific item.
-     */
-    @FunctionalInterface
-    public interface Handler
-    {
-        /**
-         * Refuel a turtle using an item.
-         *
-         * @param turtle The turtle to refuel.
-         * @param stack  The stack to refuel with.
-         * @param slot   The slot the stack resides within. This may be used to modify the inventory afterwards.
-         * @param limit  The maximum number of refuel operations to perform. This will often correspond to the number of
-         *               items to consume.
-         * @return The amount of fuel gained.
-         */
-        int refuel( @Nonnull ITurtleAccess turtle, @Nonnull ItemStack stack, int slot, int limit );
-    }
-}

src/main/java/dan200/computercraft/client/ClientRegistry.java

@@ -9,7 +9,6 @@ package dan200.computercraft.client;
 import dan200.computercraft.ComputerCraft;
 import dan200.computercraft.client.render.TurtleModelLoader;
 import dan200.computercraft.shared.media.items.ItemDiskLegacy;
-import dan200.computercraft.shared.pocket.items.ItemPocketComputer;
 import dan200.computercraft.shared.turtle.items.ItemTurtleBase;
 import dan200.computercraft.shared.util.Colour;
 import net.minecraft.client.Minecraft;
@@ -39,9 +38,9 @@ import javax.annotation.Nonnull;
  * Registers textures and models for items.
  */
 @Mod.EventBusSubscriber( modid = ComputerCraft.MOD_ID, value = Side.CLIENT )
-public final class ClientRegistry
+public class ClientRegistry
 {
-    private static final String[] EXTRA_MODELS = new String[] {
+    private static final String[] EXTRA_MODELS = {
         "turtle_modem_off_left",
         "turtle_modem_on_left",
         "turtle_modem_off_right",
@@ -59,8 +58,6 @@ public final class ClientRegistry
         "turtle_elf_overlay",
     };
 
-    private ClientRegistry() {}
-
     @SubscribeEvent
     public static void registerModels( ModelRegistryEvent event )
     {
@@ -120,7 +117,7 @@ public final class ClientRegistry
     public static void onItemColours( ColorHandlerEvent.Item event )
     {
         event.getItemColors().registerItemColorHandler(
-            ( stack, layer ) -> layer == 1 ? ((ItemDiskLegacy) stack.getItem()).getColour( stack ) : 0xFFFFFF,
+            ( stack, layer ) -> layer == 0 ? 0xFFFFFF : ((ItemDiskLegacy) stack.getItem()).getColour( stack ),
             ComputerCraft.Items.disk, ComputerCraft.Items.diskExpanded
         );
 
@@ -130,21 +127,32 @@ public final class ClientRegistry
                 case 0:
                 default:
                     return 0xFFFFFF;
-                case 1: // Frame colour
+                case 1:
-                    return ComputerCraft.Items.pocketComputer.getColour( stack );
-                case 2: // Light colour
                 {
-                    int light = ItemPocketComputer.getLightState( stack );
+                    // Frame colour
-                    return light == -1 ? Colour.Black.getHex() : light;
+                    int colour = ComputerCraft.Items.pocketComputer.getColour( stack );
+                    return colour == -1 ? 0xFFFFFF : colour;
+                }
+                case 2:
+                {
+                    // Light colour
+                    int colour = ComputerCraft.Items.pocketComputer.getLightState( stack );
+                    return colour == -1 ? Colour.Black.getHex() : colour;
                 }
             }
         }, ComputerCraft.Items.pocketComputer );
 
         // Setup turtle colours
-        event.getItemColors().registerItemColorHandler(
+        event.getItemColors().registerItemColorHandler( ( stack, tintIndex ) -> {
-            ( stack, tintIndex ) -> tintIndex == 0 ? ((ItemTurtleBase) stack.getItem()).getColour( stack ) : 0xFFFFFF,
+            if( tintIndex == 0 )
-            ComputerCraft.Blocks.turtle, ComputerCraft.Blocks.turtleExpanded, ComputerCraft.Blocks.turtleAdvanced
+            {
-        );
+                ItemTurtleBase turtle = (ItemTurtleBase) stack.getItem();
+                int colour = turtle.getColour( stack );
+                if( colour != -1 ) return colour;
+            }
+
+            return 0xFFFFFF;
+        }, ComputerCraft.Blocks.turtle, ComputerCraft.Blocks.turtleExpanded, ComputerCraft.Blocks.turtleAdvanced );
     }
 
     private static void registerItemModel( Item item, int damage, String name )

src/main/java/dan200/computercraft/client/ClientTableFormatter.java

@@ -13,14 +13,12 @@ import it.unimi.dsi.fastutil.ints.Int2IntOpenHashMap;
 import net.minecraft.client.Minecraft;
 import net.minecraft.client.gui.FontRenderer;
 import net.minecraft.client.gui.GuiNewChat;
-import net.minecraft.client.gui.GuiUtilRenderComponents;
 import net.minecraft.util.math.MathHelper;
 import net.minecraft.util.text.ITextComponent;
 import net.minecraft.util.text.TextFormatting;
 import org.apache.commons.lang3.StringUtils;
 
 import javax.annotation.Nullable;
-import java.util.List;
 
 public class ClientTableFormatter implements TableFormatter
 {
@@ -28,7 +26,7 @@ public class ClientTableFormatter implements TableFormatter
 
     private static Int2IntOpenHashMap lastHeights = new Int2IntOpenHashMap();
 
-    private static FontRenderer renderer()
+    private FontRenderer renderer()
     {
         return Minecraft.getMinecraft().fontRenderer;
     }
@@ -64,13 +62,7 @@ public class ClientTableFormatter implements TableFormatter
     @Override
     public void writeLine( int id, ITextComponent component )
     {
-        Minecraft mc = Minecraft.getMinecraft();
+        Minecraft.getMinecraft().ingameGUI.getChatGUI().printChatMessageWithOptionalDeletion( component, id );
-        GuiNewChat chat = mc.ingameGUI.getChatGUI();
-
-        // Trim the text if it goes over the allowed length
-        int maxWidth = MathHelper.floor( chat.getChatWidth() / chat.getChatScale() );
-        List<ITextComponent> list = GuiUtilRenderComponents.splitText( component, maxWidth, mc.fontRenderer, false, false );
-        if( !list.isEmpty() ) chat.printChatMessageWithOptionalDeletion( list.get( 0 ), id );
     }
 
     @Override

src/main/java/dan200/computercraft/client/gui/FixedWidthFontRenderer.java

@@ -19,7 +19,7 @@ import org.lwjgl.opengl.GL11;
 
 import java.util.Arrays;
 
-public final class FixedWidthFontRenderer
+public class FixedWidthFontRenderer
 {
     private static final ResourceLocation FONT = new ResourceLocation( "computercraft", "textures/gui/term_font.png" );
     public static final ResourceLocation BACKGROUND = new ResourceLocation( "computercraft", "textures/gui/term_background.png" );
@@ -93,7 +93,7 @@ public final class FixedWidthFontRenderer
 
     private boolean isGreyScale( int colour )
     {
-        return colour == 0 || colour == 15 || colour == 7 || colour == 8;
+        return (colour == 0 || colour == 15 || colour == 7 || colour == 8);
     }
 
     public void drawStringBackgroundPart( int x, int y, TextBuffer backgroundColour, double leftMarginSize, double rightMarginSize, boolean greyScale, Palette p )

src/main/java/dan200/computercraft/client/gui/GuiComputer.java

@@ -24,10 +24,9 @@ import java.io.IOException;
 
 public class GuiComputer extends GuiContainer
 {
-    public static final ResourceLocation BACKGROUND_NORMAL = new ResourceLocation( ComputerCraft.MOD_ID, "textures/gui/corners.png" );
+    private static final ResourceLocation BACKGROUND = new ResourceLocation( "computercraft", "textures/gui/corners.png" );
-    public static final ResourceLocation BACKGROUND_ADVANCED = new ResourceLocation( ComputerCraft.MOD_ID, "textures/gui/corners_advanced.png" );
+    private static final ResourceLocation BACKGROUND_ADVANCED = new ResourceLocation( "computercraft", "textures/gui/corners_advanced.png" );
-    public static final ResourceLocation BACKGROUND_COMMAND = new ResourceLocation( ComputerCraft.MOD_ID, "textures/gui/corners_command.png" );
+    private static final ResourceLocation BACKGROUND_COMMAND = new ResourceLocation( "computercraft", "textures/gui/corners_command.png" );
-    public static final ResourceLocation BACKGROUND_COLOUR = new ResourceLocation( ComputerCraft.MOD_ID, "textures/gui/corners_colour.png" );
 
     private final ComputerFamily m_family;
     private final ClientComputer m_computer;
@@ -81,6 +80,12 @@ public class GuiComputer extends GuiContainer
         Keyboard.enableRepeatEvents( false );
     }
 
+    @Override
+    public boolean doesGuiPauseGame()
+    {
+        return false;
+    }
+
     @Override
     public void updateScreen()
     {
@@ -139,7 +144,7 @@ public class GuiComputer extends GuiContainer
     }
 
     @Override
-    public void drawScreen( int mouseX, int mouseY, float partialTicks )
+    public void drawScreen( int mouseX, int mouseY, float f )
     {
         // Work out where to draw
         int startX = (width - m_terminal.getWidth()) / 2;
@@ -151,7 +156,7 @@ public class GuiComputer extends GuiContainer
         drawDefaultBackground();
 
         // Draw terminal
-        m_terminal.draw( mc, startX, startY, mouseX, mouseY );
+        m_terminal.draw( this.mc, startX, startY, mouseX, mouseY );
 
         // Draw a border around the terminal
         GlStateManager.color( 1.0f, 1.0f, 1.0f, 1.0f );
@@ -159,23 +164,29 @@ public class GuiComputer extends GuiContainer
         {
             case Normal:
             default:
-                mc.getTextureManager().bindTexture( BACKGROUND_NORMAL );
+            {
+                this.mc.getTextureManager().bindTexture( BACKGROUND );
                 break;
+            }
             case Advanced:
-                mc.getTextureManager().bindTexture( BACKGROUND_ADVANCED );
+            {
+                this.mc.getTextureManager().bindTexture( BACKGROUND_ADVANCED );
                 break;
+            }
             case Command:
-                mc.getTextureManager().bindTexture( BACKGROUND_COMMAND );
+            {
+                this.mc.getTextureManager().bindTexture( BACKGROUND_COMMAND );
                 break;
+            }
         }
 
         drawTexturedModalRect( startX - 12, startY - 12, 12, 28, 12, 12 );
-        drawTexturedModalRect( startX - 12, endY, 12, 40, 12, 12 );
+        drawTexturedModalRect( startX - 12, endY, 12, 40, 12, 16 );
         drawTexturedModalRect( endX, startY - 12, 24, 28, 12, 12 );
-        drawTexturedModalRect( endX, endY, 24, 40, 12, 12 );
+        drawTexturedModalRect( endX, endY, 24, 40, 12, 16 );
 
         drawTexturedModalRect( startX, startY - 12, 0, 0, endX - startX, 12 );
-        drawTexturedModalRect( startX, endY, 0, 12, endX - startX, 12 );
+        drawTexturedModalRect( startX, endY, 0, 12, endX - startX, 16 );
 
         drawTexturedModalRect( startX - 12, startY, 0, 28, 12, endY - startY );
         drawTexturedModalRect( endX, startY, 36, 28, 12, endY - startY );

src/main/java/dan200/computercraft/client/gui/GuiConfigCC.java

@@ -22,8 +22,10 @@ public class GuiConfigCC extends GuiConfig
         super( parentScreen, Config.getConfigElements(), ComputerCraft.MOD_ID, false, false, "CC: Tweaked" );
     }
 
-    public static class Factory implements IModGuiFactory
+    public static class Factory
+        implements IModGuiFactory
     {
+
         @Override
         public void initialize( Minecraft minecraft )
         {

src/main/java/dan200/computercraft/client/gui/GuiDiskDrive.java

@@ -25,19 +25,21 @@ public class GuiDiskDrive extends GuiContainer
     }
 
     @Override
-    protected void drawGuiContainerForegroundLayer( int mouseX, int mouseY )
+    protected void drawGuiContainerForegroundLayer( int par1, int par2 )
     {
         String title = m_container.getDiskDrive().getDisplayName().getUnformattedText();
         fontRenderer.drawString( title, (xSize - fontRenderer.getStringWidth( title )) / 2, 6, 0x404040 );
-        fontRenderer.drawString( I18n.format( "container.inventory" ), 8, ySize - 96 + 2, 0x404040 );
+        fontRenderer.drawString( I18n.format( "container.inventory" ), 8, (ySize - 96) + 2, 0x404040 );
     }
 
     @Override
-    protected void drawGuiContainerBackgroundLayer( float partialTicks, int mouseX, int mouseY )
+    protected void drawGuiContainerBackgroundLayer( float f, int i, int j )
     {
         GlStateManager.color( 1.0F, 1.0F, 1.0F, 1.0F );
-        mc.getTextureManager().bindTexture( BACKGROUND );
+        this.mc.getTextureManager().bindTexture( BACKGROUND );
-        drawTexturedModalRect( guiLeft, guiTop, 0, 0, xSize, ySize );
+        int l = (width - xSize) / 2;
+        int i1 = (height - ySize) / 2;
+        drawTexturedModalRect( l, i1, 0, 0, xSize, ySize );
     }
 
     @Override

src/main/java/dan200/computercraft/client/gui/GuiPocketComputer.java

@@ -8,7 +8,6 @@ package dan200.computercraft.client.gui;
 
 import dan200.computercraft.ComputerCraft;
 import dan200.computercraft.shared.media.inventory.ContainerHeldItem;
-import dan200.computercraft.shared.pocket.items.ItemPocketComputer;
 
 public class GuiPocketComputer extends GuiComputer
 {
@@ -17,7 +16,7 @@ public class GuiPocketComputer extends GuiComputer
         super(
             container,
             ComputerCraft.Items.pocketComputer.getFamily( container.getStack() ),
-            ItemPocketComputer.createClientComputer( container.getStack() ),
+            ComputerCraft.Items.pocketComputer.createClientComputer( container.getStack() ),
             ComputerCraft.terminalWidth_pocketComputer,
             ComputerCraft.terminalHeight_pocketComputer
         );

src/main/java/dan200/computercraft/client/gui/GuiPrinter.java

@@ -16,30 +16,36 @@ public class GuiPrinter extends GuiContainer
 {
     private static final ResourceLocation BACKGROUND = new ResourceLocation( "computercraft", "textures/gui/printer.png" );
 
-    private final ContainerPrinter container;
+    private final ContainerPrinter m_container;
 
     public GuiPrinter( ContainerPrinter container )
     {
         super( container );
-        this.container = container;
+        m_container = container;
     }
 
     @Override
-    protected void drawGuiContainerForegroundLayer( int mouseX, int mouseY )
+    protected void drawGuiContainerForegroundLayer( int par1, int par2 )
     {
-        String title = container.getPrinter().getDisplayName().getUnformattedText();
+        String title = m_container.getPrinter().getDisplayName().getUnformattedText();
         fontRenderer.drawString( title, (xSize - fontRenderer.getStringWidth( title )) / 2, 6, 0x404040 );
-        fontRenderer.drawString( I18n.format( "container.inventory" ), 8, ySize - 96 + 2, 0x404040 );
+        fontRenderer.drawString( I18n.format( "container.inventory" ), 8, (ySize - 96) + 2, 0x404040 );
     }
 
     @Override
-    protected void drawGuiContainerBackgroundLayer( float partialTicks, int mouseX, int mouseY )
+    protected void drawGuiContainerBackgroundLayer( float f, int i, int j )
     {
         GlStateManager.color( 1.0F, 1.0F, 1.0F, 1.0F );
-        mc.getTextureManager().bindTexture( BACKGROUND );
+        this.mc.getTextureManager().bindTexture( BACKGROUND );
-        drawTexturedModalRect( guiLeft, guiTop, 0, 0, xSize, ySize );
+        int startX = (width - xSize) / 2;
+        int startY = (height - ySize) / 2;
+        drawTexturedModalRect( startX, startY, 0, 0, xSize, ySize );
 
-        if( container.isPrinting() ) drawTexturedModalRect( guiLeft + 34, guiTop + 21, 176, 0, 25, 45 );
+        boolean printing = m_container.isPrinting();
+        if( printing )
+        {
+            drawTexturedModalRect( startX + 34, startY + 21, 176, 0, 25, 45 );
+        }
     }
 
     @Override

src/main/java/dan200/computercraft/client/gui/GuiPrintout.java

@@ -29,8 +29,6 @@ public class GuiPrintout extends GuiContainer
     {
         super( container );
 
-        ySize = Y_SIZE;
-
         String[] text = ItemPrintout.getText( container.getStack() );
         m_text = new TextBuffer[text.length];
         for( int i = 0; i < m_text.length; i++ ) m_text[i] = new TextBuffer( text[i] );
@@ -44,6 +42,12 @@ public class GuiPrintout extends GuiContainer
         m_book = ItemPrintout.getType( container.getStack() ) == ItemPrintout.Type.Book;
     }
 
+    @Override
+    public boolean doesGuiPauseGame()
+    {
+        return false;
+    }
+
     @Override
     protected void keyTyped( char c, int k ) throws IOException
     {
@@ -69,35 +73,41 @@ public class GuiPrintout extends GuiContainer
         int mouseWheelChange = Mouse.getEventDWheel();
         if( mouseWheelChange < 0 )
         {
-            // Scroll up goes to the next page
+            // Up
             if( m_page < m_pages - 1 ) m_page++;
         }
         else if( mouseWheelChange > 0 )
         {
-            // Scroll down goes to the previous page
+            // Down
             if( m_page > 0 ) m_page--;
         }
     }
 
     @Override
-    protected void drawGuiContainerBackgroundLayer( float partialTicks, int mouseX, int mouseY )
+    protected void drawGuiContainerForegroundLayer( int par1, int par2 )
     {
-        // Draw the printout
-        GlStateManager.color( 1.0f, 1.0f, 1.0f, 1.0f );
-
-        drawBorder( guiLeft, guiTop, zLevel, m_page, m_pages, m_book );
-        drawText( guiLeft + X_TEXT_MARGIN, guiTop + Y_TEXT_MARGIN, ItemPrintout.LINES_PER_PAGE * m_page, m_text, m_colours );
     }
 
     @Override
-    public void drawScreen( int mouseX, int mouseY, float partialTicks )
+    protected void drawGuiContainerBackgroundLayer( float var1, int var2, int var3 )
     {
-        // We must take the background further back in order to not overlap with our printed pages.
+    }
-        zLevel--;
-        drawDefaultBackground();
-        zLevel++;
 
-        super.drawScreen( mouseX, mouseY, partialTicks );
+    @Override
-        renderHoveredToolTip( mouseX, mouseY );
+    public void drawScreen( int mouseX, int mouseY, float f )
+    {
+        // Draw background
+        zLevel = zLevel - 1;
+        drawDefaultBackground();
+        zLevel = zLevel + 1;
+
+        // Draw the printout
+        GlStateManager.color( 1.0f, 1.0f, 1.0f, 1.0f );
+
+        int startY = (height - Y_SIZE) / 2;
+        int startX = (width - X_SIZE) / 2;
+
+        drawBorder( startX, startY, zLevel, m_page, m_pages, m_book );
+        drawText( startX + X_TEXT_MARGIN, startY + Y_TEXT_MARGIN, ItemPrintout.LINES_PER_PAGE * m_page, m_text, m_colours );
     }
 }

src/main/java/dan200/computercraft/client/gui/GuiTurtle.java

@@ -23,7 +23,7 @@ import java.io.IOException;
 
 public class GuiTurtle extends GuiContainer
 {
-    private static final ResourceLocation BACKGROUND_NORMAL = new ResourceLocation( "computercraft", "textures/gui/turtle.png" );
+    private static final ResourceLocation BACKGROUND = new ResourceLocation( "computercraft", "textures/gui/turtle.png" );
     private static final ResourceLocation BACKGROUND_ADVANCED = new ResourceLocation( "computercraft", "textures/gui/turtle_advanced.png" );
 
     private ContainerTurtle m_container;
@@ -50,8 +50,8 @@ public class GuiTurtle extends GuiContainer
         super.initGui();
         Keyboard.enableRepeatEvents( true );
         m_terminalGui = new WidgetTerminal(
-            guiLeft + 8,
+            (width - xSize) / 2 + 8,
-            guiTop + 8,
+            (height - ySize) / 2 + 8,
             ComputerCraft.terminalWidth_turtle,
             ComputerCraft.terminalHeight_turtle,
             () -> m_computer,
@@ -98,8 +98,8 @@ public class GuiTurtle extends GuiContainer
     public void handleMouseInput() throws IOException
     {
         super.handleMouseInput();
-        int x = Mouse.getEventX() * width / mc.displayWidth;
+        int x = Mouse.getEventX() * this.width / mc.displayWidth;
-        int y = height - Mouse.getEventY() * height / mc.displayHeight - 1;
+        int y = this.height - Mouse.getEventY() * this.height / mc.displayHeight - 1;
         m_terminalGui.handleMouseInput( x, y );
     }
 
@@ -112,29 +112,34 @@ public class GuiTurtle extends GuiContainer
 
     protected void drawSelectionSlot( boolean advanced )
     {
+        int x = (width - xSize) / 2;
+        int y = (height - ySize) / 2;
+
         // Draw selection slot
         int slot = m_container.getSelectedSlot();
         if( slot >= 0 )
         {
             GlStateManager.color( 1.0F, 1.0F, 1.0F, 1.0F );
-            int slotX = slot % 4;
+            int slotX = (slot % 4);
-            int slotY = slot / 4;
+            int slotY = (slot / 4);
-            mc.getTextureManager().bindTexture( advanced ? BACKGROUND_ADVANCED : BACKGROUND_NORMAL );
+            this.mc.getTextureManager().bindTexture( advanced ? BACKGROUND_ADVANCED : BACKGROUND );
-            drawTexturedModalRect( guiLeft + m_container.turtleInvStartX - 2 + slotX * 18, guiTop + m_container.playerInvStartY - 2 + slotY * 18, 0, 217, 24, 24 );
+            drawTexturedModalRect( x + m_container.m_turtleInvStartX - 2 + slotX * 18, y + m_container.m_playerInvStartY - 2 + slotY * 18, 0, 217, 24, 24 );
         }
     }
 
     @Override
-    protected void drawGuiContainerBackgroundLayer( float partialTicks, int mouseX, int mouseY )
+    protected void drawGuiContainerBackgroundLayer( float f, int mouseX, int mouseY )
     {
         // Draw term
-        boolean advanced = m_family == ComputerFamily.Advanced;
+        boolean advanced = (m_family == ComputerFamily.Advanced);
         m_terminalGui.draw( Minecraft.getMinecraft(), 0, 0, mouseX, mouseY );
 
         // Draw border/inventory
         GlStateManager.color( 1.0F, 1.0F, 1.0F, 1.0F );
-        mc.getTextureManager().bindTexture( advanced ? BACKGROUND_ADVANCED : BACKGROUND_NORMAL );
+        this.mc.getTextureManager().bindTexture( advanced ? BACKGROUND_ADVANCED : BACKGROUND );
-        drawTexturedModalRect( guiLeft, guiTop, 0, 0, xSize, ySize );
+        int x = (width - xSize) / 2;
+        int y = (height - ySize) / 2;
+        drawTexturedModalRect( x, y, 0, 0, xSize, ySize );
 
         drawSelectionSlot( advanced );
     }

src/main/java/dan200/computercraft/client/gui/widgets/WidgetTerminal.java

@@ -31,23 +31,23 @@ public class WidgetTerminal extends Widget
 
     private final IComputerContainer m_computer;
 
-    private float m_terminateTimer = 0.0f;
+    private float m_terminateTimer;
-    private float m_rebootTimer = 0.0f;
+    private float m_rebootTimer;
-    private float m_shutdownTimer = 0.0f;
+    private float m_shutdownTimer;
 
-    private int m_lastClickButton = -1;
+    private int m_lastClickButton;
-    private int m_lastClickX = -1;
+    private int m_lastClickX;
-    private int m_lastClickY = -1;
+    private int m_lastClickY;
 
-    private boolean m_focus = false;
+    private boolean m_focus;
-    private boolean m_allowFocusLoss = true;
+    private boolean m_allowFocusLoss;
 
     private int m_leftMargin;
     private int m_rightMargin;
     private int m_topMargin;
     private int m_bottomMargin;
 
-    private final ArrayList<Integer> m_keysDown = new ArrayList<>();
+    private ArrayList<Integer> m_keysDown;
 
     public WidgetTerminal( int x, int y, int termWidth, int termHeight, IComputerContainer computer, int leftMargin, int rightMargin, int topMargin, int bottomMargin )
     {
@@ -58,11 +58,23 @@ public class WidgetTerminal extends Widget
         );
 
         m_computer = computer;
+        m_terminateTimer = 0.0f;
+        m_rebootTimer = 0.0f;
+        m_shutdownTimer = 0.0f;
+
+        m_lastClickButton = -1;
+        m_lastClickX = -1;
+        m_lastClickY = -1;
+
+        m_focus = false;
+        m_allowFocusLoss = true;
 
         m_leftMargin = leftMargin;
         m_rightMargin = rightMargin;
         m_topMargin = topMargin;
         m_bottomMargin = bottomMargin;
+
+        m_keysDown = new ArrayList<>();
     }
 
     public void setAllowFocusLoss( boolean allowFocusLoss )
@@ -82,9 +94,9 @@ public class WidgetTerminal extends Widget
                 String clipboard = GuiScreen.getClipboardString();
                 if( clipboard != null )
                 {
-                    // Clip to the first occurrence of \r or \n
+                    // Clip to the first occurance of \r or \n
-                    int newLineIndex1 = clipboard.indexOf( '\r' );
+                    int newLineIndex1 = clipboard.indexOf( "\r" );
-                    int newLineIndex2 = clipboard.indexOf( '\n' );
+                    int newLineIndex2 = clipboard.indexOf( "\n" );
                     if( newLineIndex1 >= 0 && newLineIndex2 >= 0 )
                     {
                         clipboard = clipboard.substring( 0, Math.min( newLineIndex1, newLineIndex2 ) );
@@ -110,7 +122,9 @@ public class WidgetTerminal extends Widget
                         }
 
                         // Queue the "paste" event
-                        queueEvent( "paste", new Object[] { clipboard } );
+                        queueEvent( "paste", new Object[] {
+                            clipboard
+                        } );
                     }
                 }
                 return true;
@@ -129,15 +143,18 @@ public class WidgetTerminal extends Widget
                     }
 
                     // Queue the "key" event
-                    IComputer computer = m_computer.getComputer();
+                    queueEvent( "key", new Object[] {
-                    if( computer != null ) computer.keyDown( key, repeat );
+                        key, repeat
+                    } );
                     handled = true;
                 }
 
                 if( (ch >= 32 && ch <= 126) || (ch >= 160 && ch <= 255) ) // printable chars in byte range
                 {
                     // Queue the "char" event
-                    queueEvent( "char", new Object[] { Character.toString( ch ) } );
+                    queueEvent( "char", new Object[] {
+                        Character.toString( ch )
+                    } );
                     handled = true;
                 }
 
@@ -172,7 +189,9 @@ public class WidgetTerminal extends Widget
                         charX = Math.min( Math.max( charX, 0 ), term.getWidth() - 1 );
                         charY = Math.min( Math.max( charY, 0 ), term.getHeight() - 1 );
 
-                        computer.mouseClick( button + 1, charX + 1, charY + 1 );
+                        computer.queueEvent( "mouse_click", new Object[] {
+                            button + 1, charX + 1, charY + 1
+                        } );
 
                         m_lastClickButton = button;
                         m_lastClickX = charX;
@@ -203,8 +222,9 @@ public class WidgetTerminal extends Widget
                 if( m_focus )
                 {
                     // Queue the "key_up" event
-                    IComputer computer = m_computer.getComputer();
+                    queueEvent( "key_up", new Object[] {
-                    if( computer != null ) computer.keyUp( key );
+                        key
+                    } );
                     handled = true;
                 }
             }
@@ -231,7 +251,12 @@ public class WidgetTerminal extends Widget
 
                 if( m_lastClickButton >= 0 && !Mouse.isButtonDown( m_lastClickButton ) )
                 {
-                    if( m_focus ) computer.mouseUp( m_lastClickButton + 1, charX + 1, charY + 1 );
+                    if( m_focus )
+                    {
+                        computer.queueEvent( "mouse_up", new Object[] {
+                            m_lastClickButton + 1, charX + 1, charY + 1
+                        } );
+                    }
                     m_lastClickButton = -1;
                 }
 
@@ -245,16 +270,22 @@ public class WidgetTerminal extends Widget
                 {
                     if( wheelChange < 0 )
                     {
-                        computer.mouseScroll( 1, charX + 1, charY + 1 );
+                        computer.queueEvent( "mouse_scroll", new Object[] {
+                            1, charX + 1, charY + 1
+                        } );
                     }
                     else if( wheelChange > 0 )
                     {
-                        computer.mouseScroll( -1, charX + 1, charY + 1 );
+                        computer.queueEvent( "mouse_scroll", new Object[] {
+                            -1, charX + 1, charY + 1
+                        } );
                     }
 
                     if( m_lastClickButton >= 0 && (charX != m_lastClickX || charY != m_lastClickY) )
                     {
-                        computer.mouseDrag( m_lastClickButton + 1, charX + 1, charY + 1 );
+                        computer.queueEvent( "mouse_drag", new Object[] {
+                            m_lastClickButton + 1, charX + 1, charY + 1
+                        } );
                         m_lastClickX = charX;
                         m_lastClickY = charY;
                     }
@@ -274,8 +305,11 @@ public class WidgetTerminal extends Widget
             {
                 if( m_terminateTimer < TERMINATE_TIME )
                 {
-                    m_terminateTimer += 0.05f;
+                    m_terminateTimer = m_terminateTimer + 0.05f;
-                    if( m_terminateTimer >= TERMINATE_TIME ) queueEvent( "terminate" );
+                    if( m_terminateTimer >= TERMINATE_TIME )
+                    {
+                        queueEvent( "terminate" );
+                    }
                 }
             }
             else
@@ -288,11 +322,14 @@ public class WidgetTerminal extends Widget
             {
                 if( m_rebootTimer < TERMINATE_TIME )
                 {
-                    m_rebootTimer += 0.05f;
+                    m_rebootTimer = m_rebootTimer + 0.05f;
                     if( m_rebootTimer >= TERMINATE_TIME )
                     {
                         IComputer computer = m_computer.getComputer();
-                        if( computer != null ) computer.reboot();
+                        if( computer != null )
+                        {
+                            computer.reboot();
+                        }
                     }
                 }
             }
@@ -306,11 +343,14 @@ public class WidgetTerminal extends Widget
             {
                 if( m_shutdownTimer < TERMINATE_TIME )
                 {
-                    m_shutdownTimer += 0.05f;
+                    m_shutdownTimer = m_shutdownTimer + 0.05f;
                     if( m_shutdownTimer >= TERMINATE_TIME )
                     {
                         IComputer computer = m_computer.getComputer();
-                        if( computer != null ) computer.shutdown();
+                        if( computer != null )
+                        {
+                            computer.shutdown();
+                        }
                     }
                 }
             }
@@ -337,7 +377,7 @@ public class WidgetTerminal extends Widget
         {
             // Draw the screen contents
             IComputer computer = m_computer.getComputer();
-            Terminal terminal = computer != null ? computer.getTerminal() : null;
+            Terminal terminal = (computer != null) ? computer.getTerminal() : null;
             if( terminal != null )
             {
                 // Draw the terminal
@@ -415,12 +455,18 @@ public class WidgetTerminal extends Widget
     private void queueEvent( String event )
     {
         IComputer computer = m_computer.getComputer();
-        if( computer != null ) computer.queueEvent( event );
+        if( computer != null )
+        {
+            computer.queueEvent( event );
+        }
     }
 
     private void queueEvent( String event, Object[] args )
     {
         IComputer computer = m_computer.getComputer();
-        if( computer != null ) computer.queueEvent( event, args );
+        if( computer != null )
+        {
+            computer.queueEvent( event, args );
+        }
     }
 }

src/main/java/dan200/computercraft/client/proxy/CCTurtleProxyClient.java

@@ -0,0 +1,24 @@
+/*
+ * This file is part of ComputerCraft - http://www.computercraft.info
+ * Copyright Daniel Ratcliffe, 2011-2019. Do not distribute without permission.
+ * Send enquiries to dratcliffe@gmail.com
+ */
+
+package dan200.computercraft.client.proxy;
+
+import dan200.computercraft.client.render.TileEntityTurtleRenderer;
+import dan200.computercraft.shared.proxy.CCTurtleProxyCommon;
+import dan200.computercraft.shared.turtle.blocks.TileTurtle;
+import net.minecraftforge.fml.client.registry.ClientRegistry;
+
+public class CCTurtleProxyClient extends CCTurtleProxyCommon
+{
+    @Override
+    public void init()
+    {
+        super.init();
+
+        // Setup renderers
+        ClientRegistry.bindTileEntitySpecialRenderer( TileTurtle.class, new TileEntityTurtleRenderer() );
+    }
+}

src/main/java/dan200/computercraft/client/proxy/ComputerCraftProxyClient.java

@@ -9,13 +9,11 @@ package dan200.computercraft.client.proxy;
 import dan200.computercraft.ComputerCraft;
 import dan200.computercraft.client.render.TileEntityCableRenderer;
 import dan200.computercraft.client.render.TileEntityMonitorRenderer;
-import dan200.computercraft.client.render.TileEntityTurtleRenderer;
 import dan200.computercraft.shared.command.CommandCopy;
 import dan200.computercraft.shared.peripheral.modem.wired.TileCable;
 import dan200.computercraft.shared.peripheral.monitor.ClientMonitor;
 import dan200.computercraft.shared.peripheral.monitor.TileMonitor;
 import dan200.computercraft.shared.proxy.ComputerCraftProxyCommon;
-import dan200.computercraft.shared.turtle.blocks.TileTurtle;
 import net.minecraftforge.client.ClientCommandHandler;
 import net.minecraftforge.event.world.WorldEvent;
 import net.minecraftforge.fml.client.registry.ClientRegistry;
@@ -42,11 +40,10 @@ public class ComputerCraftProxyClient extends ComputerCraftProxyCommon
         // Setup renderers
         ClientRegistry.bindTileEntitySpecialRenderer( TileMonitor.class, new TileEntityMonitorRenderer() );
         ClientRegistry.bindTileEntitySpecialRenderer( TileCable.class, new TileEntityCableRenderer() );
-        ClientRegistry.bindTileEntitySpecialRenderer( TileTurtle.class, new TileEntityTurtleRenderer() );
     }
 
     @Mod.EventBusSubscriber( modid = ComputerCraft.MOD_ID, value = Side.CLIENT )
-    public static final class ForgeHandlers
+    public static class ForgeHandlers
     {
         @SubscribeEvent
         public static void onWorldUnload( WorldEvent.Unload event )

src/main/java/dan200/computercraft/client/render/ItemMapLikeRenderer.java

@@ -18,7 +18,7 @@ import net.minecraft.util.math.MathHelper;
 public abstract class ItemMapLikeRenderer
 {
     /**
-     * The main rendering method for the item.
+     * The main rendering method for the item
      *
      * @param stack The stack to render
      * @see ItemRenderer#renderMapFirstPerson(ItemStack)
@@ -87,7 +87,7 @@ public abstract class ItemMapLikeRenderer
     }
 
     /**
-     * Render an item in the middle of the screen.
+     * Render an item in the middle of the screen
      *
      * @param pitch         The pitch of the player
      * @param equipProgress The equip progress of this item

src/main/java/dan200/computercraft/client/render/ItemPocketRenderer.java

@@ -12,35 +12,32 @@ import dan200.computercraft.client.gui.FixedWidthFontRenderer;
 import dan200.computercraft.core.terminal.Terminal;
 import dan200.computercraft.core.terminal.TextBuffer;
 import dan200.computercraft.shared.computer.core.ClientComputer;
-import dan200.computercraft.shared.computer.core.ComputerFamily;
 import dan200.computercraft.shared.pocket.items.ItemPocketComputer;
-import dan200.computercraft.shared.util.Colour;
 import dan200.computercraft.shared.util.Palette;
 import net.minecraft.client.Minecraft;
-import net.minecraft.client.renderer.BufferBuilder;
 import net.minecraft.client.renderer.GlStateManager;
-import net.minecraft.client.renderer.Tessellator;
+import net.minecraft.client.renderer.RenderItem;
-import net.minecraft.client.renderer.vertex.DefaultVertexFormats;
+import net.minecraft.client.renderer.block.model.IBakedModel;
+import net.minecraft.client.renderer.block.model.ItemCameraTransforms;
+import net.minecraft.client.renderer.texture.TextureManager;
+import net.minecraft.client.renderer.texture.TextureMap;
 import net.minecraft.item.ItemStack;
+import net.minecraftforge.client.ForgeHooksClient;
 import net.minecraftforge.client.event.RenderSpecificHandEvent;
 import net.minecraftforge.fml.common.Mod;
 import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
 import net.minecraftforge.fml.relauncher.Side;
 import org.lwjgl.opengl.GL11;
 
-import static dan200.computercraft.client.gui.FixedWidthFontRenderer.*;
+import static dan200.computercraft.client.gui.FixedWidthFontRenderer.FONT_HEIGHT;
-import static dan200.computercraft.client.gui.GuiComputer.*;
+import static dan200.computercraft.client.gui.FixedWidthFontRenderer.FONT_WIDTH;
 
 /**
- * Emulates map rendering for pocket computers.
+ * Emulates map rendering for pocket computers
  */
 @Mod.EventBusSubscriber( modid = ComputerCraft.MOD_ID, value = Side.CLIENT )
 public final class ItemPocketRenderer extends ItemMapLikeRenderer
 {
-    private static final int MARGIN = 2;
-    private static final int FRAME = 12;
-    private static final int LIGHT_HEIGHT = 8;
-
     private static final ItemPocketRenderer INSTANCE = new ItemPocketRenderer();
 
     private ItemPocketRenderer()
@@ -60,194 +57,116 @@ public final class ItemPocketRenderer extends ItemMapLikeRenderer
     @Override
     protected void renderItem( ItemStack stack )
     {
-        ClientComputer computer = ItemPocketComputer.createClientComputer( stack );
+        // Setup various transformations. Note that these are partially adapated from the corresponding method
-        Terminal terminal = computer == null ? null : computer.getTerminal();
-
-        int termWidth, termHeight;
-        if( terminal == null )
-        {
-            termWidth = ComputerCraft.terminalWidth_pocketComputer;
-            termHeight = ComputerCraft.terminalHeight_pocketComputer;
-        }
-        else
-        {
-            termWidth = terminal.getWidth();
-            termHeight = terminal.getHeight();
-        }
-
-        int width = termWidth * FONT_WIDTH + MARGIN * 2;
-        int height = termHeight * FONT_HEIGHT + MARGIN * 2;
-
-        // Setup various transformations. Note that these are partially adapted from the corresponding method
         // in ItemRenderer
-        GlStateManager.pushMatrix();
-
         GlStateManager.disableLighting();
-        GlStateManager.disableDepth();
 
         GlStateManager.rotate( 180f, 0f, 1f, 0f );
         GlStateManager.rotate( 180f, 0f, 0f, 1f );
         GlStateManager.scale( 0.5, 0.5, 0.5 );
 
-        double scale = 0.75 / Math.max( width + FRAME * 2, height + FRAME * 2 + LIGHT_HEIGHT );
+        ItemPocketComputer pocketComputer = ComputerCraft.Items.pocketComputer;
-        GlStateManager.scale( scale, scale, 0 );
+        ClientComputer computer = pocketComputer.createClientComputer( stack );
-        GlStateManager.translate( -0.5 * width, -0.5 * height, 0 );
 
-        // Render the main frame
-        ComputerFamily family = ComputerCraft.Items.pocketComputer.getFamily( stack );
-        int frameColour = ComputerCraft.Items.pocketComputer.getColour( stack );
-        renderFrame( family, frameColour, width, height );
-
-        // Render the light
-        int lightColour = ItemPocketComputer.getLightState( stack );
-        if( lightColour == -1 ) lightColour = Colour.Black.getHex();
-        renderLight( lightColour, width, height );
-
-        if( computer != null && terminal != null )
         {
-            // If we've a computer and terminal then attempt to render it.
+            // First render the background item. We use the item's model rather than a direct texture as this ensures
-            renderTerminal( terminal, !computer.isColour(), width, height );
+            // we display the pocket light and other such decorations.
-        }
+            GlStateManager.pushMatrix();
-        else
-        {
-            // Otherwise render a plain background
-            Minecraft.getMinecraft().getTextureManager().bindTexture( BACKGROUND );
 
-            Tessellator tessellator = Tessellator.getInstance();
+            GlStateManager.scale( 1.0f, -1.0f, 1.0f );
-            BufferBuilder buffer = tessellator.getBuffer();
 
-            Colour black = Colour.Black;
+            Minecraft minecraft = Minecraft.getMinecraft();
-            buffer.begin( GL11.GL_QUADS, DefaultVertexFormats.POSITION );
+            TextureManager textureManager = minecraft.getTextureManager();
-            renderTexture( buffer, 0, 0, 0, 0, width, height, black.getR(), black.getG(), black.getB() );
+            RenderItem renderItem = minecraft.getRenderItem();
-            tessellator.draw();
+
+            // Copy of RenderItem#renderItemModelIntoGUI but without the translation or scaling
+            textureManager.bindTexture( TextureMap.LOCATION_BLOCKS_TEXTURE );
+            textureManager.getTexture( TextureMap.LOCATION_BLOCKS_TEXTURE ).setBlurMipmap( false, false );
+
+            GlStateManager.enableRescaleNormal();
+            GlStateManager.enableAlpha();
+            GlStateManager.alphaFunc( GL11.GL_GREATER, 0.1F );
+            GlStateManager.enableBlend();
+            GlStateManager.blendFunc( GlStateManager.SourceFactor.SRC_ALPHA, GlStateManager.DestFactor.ONE_MINUS_SRC_ALPHA );
+            GlStateManager.color( 1.0F, 1.0F, 1.0F, 1.0F );
+
+            IBakedModel bakedmodel = renderItem.getItemModelWithOverrides( stack, null, null );
+            bakedmodel = ForgeHooksClient.handleCameraTransforms( bakedmodel, ItemCameraTransforms.TransformType.GUI, false );
+            renderItem.renderItem( stack, bakedmodel );
+
+            GlStateManager.disableAlpha();
+            GlStateManager.disableRescaleNormal();
+
+            GlStateManager.popMatrix();
+        }
+
+        // If we've a computer and terminal then attempt to render it.
+        if( computer != null )
+        {
+            Terminal terminal = computer.getTerminal();
+            if( terminal != null )
+            {
+                synchronized( terminal )
+                {
+                    GlStateManager.pushMatrix();
+                    GlStateManager.disableDepth();
+
+                    // Reset the position to be at the top left corner of the pocket computer
+                    // Note we translate towards the screen slightly too.
+                    GlStateManager.translate( -8 / 16.0, -8 / 16.0, 0.5 / 16.0 );
+                    // Translate to the top left of the screen.
+                    GlStateManager.translate( 4 / 16.0, 3 / 16.0, 0 );
+
+                    // Work out the scaling required to resize the terminal in order to fit on the computer
+                    final int margin = 2;
+                    int tw = terminal.getWidth();
+                    int th = terminal.getHeight();
+                    int width = tw * FONT_WIDTH + margin * 2;
+                    int height = th * FONT_HEIGHT + margin * 2;
+                    int max = Math.max( height, width );
+
+                    // The grid is 8 * 8 wide, so we start with a base of 1/2 (8 / 16).
+                    double scale = 1.0 / 2.0 / max;
+                    GlStateManager.scale( scale, scale, scale );
+
+                    // The margin/start positions are determined in order for the terminal to be centred.
+                    int startX = (max - width) / 2 + margin;
+                    int startY = (max - height) / 2 + margin;
+
+                    FixedWidthFontRenderer fontRenderer = FixedWidthFontRenderer.instance();
+                    boolean greyscale = !computer.isColour();
+                    Palette palette = terminal.getPalette();
+
+                    // Render the actual text
+                    for( int line = 0; line < th; line++ )
+                    {
+                        TextBuffer text = terminal.getLine( line );
+                        TextBuffer colour = terminal.getTextColourLine( line );
+                        TextBuffer backgroundColour = terminal.getBackgroundColourLine( line );
+                        fontRenderer.drawString(
+                            text, startX, startY + line * FONT_HEIGHT,
+                            colour, backgroundColour, margin, margin, greyscale, palette
+                        );
+                    }
+
+                    // And render the cursor;
+                    int tx = terminal.getCursorX(), ty = terminal.getCursorY();
+                    if( terminal.getCursorBlink() && FrameInfo.getGlobalCursorBlink() &&
+                        tx >= 0 && ty >= 0 && tx < tw && ty < th )
+                    {
+                        TextBuffer cursorColour = new TextBuffer( "0123456789abcdef".charAt( terminal.getTextColour() ), 1 );
+                        fontRenderer.drawString(
+                            new TextBuffer( '_', 1 ), startX + FONT_WIDTH * tx, startY + FONT_HEIGHT * ty,
+                            cursorColour, null, 0, 0, greyscale, palette
+                        );
+                    }
+
+                    GlStateManager.enableDepth();
+                    GlStateManager.popMatrix();
+                }
+            }
         }
 
-        GlStateManager.enableDepth();
         GlStateManager.enableLighting();
-        GlStateManager.popMatrix();
-    }
-
-    private static void renderFrame( ComputerFamily family, int colour, int width, int height )
-    {
-
-        Minecraft.getMinecraft().getTextureManager().bindTexture( colour != -1
-            ? BACKGROUND_COLOUR
-            : family == ComputerFamily.Normal ? BACKGROUND_NORMAL : BACKGROUND_ADVANCED
-        );
-
-        float r = ((colour >>> 16) & 0xFF) / 255.0f;
-        float g = ((colour >>> 8) & 0xFF) / 255.0f;
-        float b = (colour & 0xFF) / 255.0f;
-
-        Tessellator tessellator = Tessellator.getInstance();
-        BufferBuilder buffer = tessellator.getBuffer();
-        buffer.begin( GL11.GL_QUADS, DefaultVertexFormats.POSITION_TEX_COLOR );
-
-        // Top left, middle, right
-        renderTexture( buffer, -FRAME, -FRAME, 12, 28, FRAME, FRAME, r, g, b );
-        renderTexture( buffer, 0, -FRAME, 0, 0, width, FRAME, r, g, b );
-        renderTexture( buffer, width, -FRAME, 24, 28, FRAME, FRAME, r, g, b );
-
-        // Left and bright border
-        renderTexture( buffer, -FRAME, 0, 0, 28, FRAME, height, r, g, b );
-        renderTexture( buffer, width, 0, 36, 28, FRAME, height, r, g, b );
-
-        // Bottom left, middle, right. We do this in three portions: the top inner corners, an extended region for
-        // lights, and then the bottom outer corners.
-        renderTexture( buffer, -FRAME, height, 12, 40, FRAME, FRAME / 2, r, g, b );
-        renderTexture( buffer, 0, height, 0, 12, width, FRAME / 2, r, g, b );
-        renderTexture( buffer, width, height, 24, 40, FRAME, FRAME / 2, r, g, b );
-
-        renderTexture( buffer, -FRAME, height + FRAME / 2, 12, 44, FRAME, LIGHT_HEIGHT, FRAME, 4, r, g, b );
-        renderTexture( buffer, 0, height + FRAME / 2, 0, 16, width, LIGHT_HEIGHT, FRAME, 4, r, g, b );
-        renderTexture( buffer, width, height + FRAME / 2, 24, 44, FRAME, LIGHT_HEIGHT, FRAME, 4, r, g, b );
-
-        renderTexture( buffer, -FRAME, height + LIGHT_HEIGHT + FRAME / 2, 12, 40 + FRAME / 2, FRAME, FRAME / 2, r, g, b );
-        renderTexture( buffer, 0, height + LIGHT_HEIGHT + FRAME / 2, 0, 12 + FRAME / 2, width, FRAME / 2, r, g, b );
-        renderTexture( buffer, width, height + LIGHT_HEIGHT + FRAME / 2, 24, 40 + FRAME / 2, FRAME, FRAME / 2, r, g, b );
-
-        tessellator.draw();
-    }
-
-    private static void renderLight( int colour, int width, int height )
-    {
-        GlStateManager.enableBlend();
-        GlStateManager.disableTexture2D();
-
-        float r = ((colour >>> 16) & 0xFF) / 255.0f;
-        float g = ((colour >>> 8) & 0xFF) / 255.0f;
-        float b = (colour & 0xFF) / 255.0f;
-
-        Tessellator tessellator = Tessellator.getInstance();
-        BufferBuilder buffer = tessellator.getBuffer();
-        buffer.begin( GL11.GL_QUADS, DefaultVertexFormats.POSITION_COLOR );
-        buffer.pos( width - LIGHT_HEIGHT * 2, height + LIGHT_HEIGHT + FRAME / 2.0f, 0.0D ).color( r, g, b, 1.0f ).endVertex();
-        buffer.pos( width, height + LIGHT_HEIGHT + FRAME / 2.0f, 0.0D ).color( r, g, b, 1.0f ).endVertex();
-        buffer.pos( width, height + FRAME / 2.0f, 0.0D ).color( r, g, b, 1.0f ).endVertex();
-        buffer.pos( width - LIGHT_HEIGHT * 2, height + FRAME / 2.0f, 0.0D ).color( r, g, b, 1.0f ).endVertex();
-
-        tessellator.draw();
-        GlStateManager.enableTexture2D();
-    }
-
-    private static void renderTerminal( Terminal terminal, boolean greyscale, int width, int height )
-    {
-        synchronized( terminal )
-        {
-            int termWidth = terminal.getWidth();
-            int termHeight = terminal.getHeight();
-
-            FixedWidthFontRenderer fontRenderer = FixedWidthFontRenderer.instance();
-            Palette palette = terminal.getPalette();
-
-            // Render top/bottom borders
-            TextBuffer emptyLine = new TextBuffer( ' ', termWidth );
-            fontRenderer.drawString(
-                emptyLine, MARGIN, 0,
-                terminal.getTextColourLine( 0 ), terminal.getBackgroundColourLine( 0 ), MARGIN, MARGIN, greyscale, palette
-            );
-            fontRenderer.drawString(
-                emptyLine, MARGIN, 2 * MARGIN + (termHeight - 1) * FixedWidthFontRenderer.FONT_HEIGHT,
-                terminal.getTextColourLine( termHeight - 1 ), terminal.getBackgroundColourLine( termHeight - 1 ), MARGIN, MARGIN, greyscale, palette
-            );
-
-            // Render the actual text
-            for( int line = 0; line < termWidth; line++ )
-            {
-                TextBuffer text = terminal.getLine( line );
-                TextBuffer colour = terminal.getTextColourLine( line );
-                TextBuffer backgroundColour = terminal.getBackgroundColourLine( line );
-                fontRenderer.drawString(
-                    text, MARGIN, MARGIN + line * FONT_HEIGHT,
-                    colour, backgroundColour, MARGIN, MARGIN, greyscale, palette
-                );
-            }
-
-            // And render the cursor;
-            int tx = terminal.getCursorX(), ty = terminal.getCursorY();
-            if( terminal.getCursorBlink() && FrameInfo.getGlobalCursorBlink() &&
-                tx >= 0 && ty >= 0 && tx < termWidth && ty < termHeight )
-            {
-                TextBuffer cursorColour = new TextBuffer( "0123456789abcdef".charAt( terminal.getTextColour() ), 1 );
-                fontRenderer.drawString(
-                    new TextBuffer( '_', 1 ), MARGIN + FONT_WIDTH * tx, MARGIN + FONT_HEIGHT * ty,
-                    cursorColour, null, 0, 0, greyscale, palette
-                );
-            }
-        }
-    }
-
-    private static void renderTexture( BufferBuilder builder, int x, int y, int textureX, int textureY, int width, int height, float r, float g, float b )
-    {
-        renderTexture( builder, x, y, textureX, textureY, width, height, width, height, r, g, b );
-    }
-
-    private static void renderTexture( BufferBuilder builder, int x, int y, int textureX, int textureY, int width, int height, int textureWidth, int textureHeight, float r, float g, float b )
-    {
-        float scale = 1 / 255.0f;
-        builder.pos( x, y + height, 0 ).tex( textureX * scale, (textureY + textureHeight) * scale ).color( r, g, b, 1.0f ).endVertex();
-        builder.pos( x + width, y + height, 0 ).tex( (textureX + textureWidth) * scale, (textureY + textureHeight) * scale ).color( r, g, b, 1.0f ).endVertex();
-        builder.pos( x + width, y, 0 ).tex( (textureX + textureWidth) * scale, textureY * scale ).color( r, g, b, 1.0f ).endVertex();
-        builder.pos( x, y, 0 ).tex( textureX * scale, textureY * scale ).color( r, g, b, 1.0f ).endVertex();
     }
 }

src/main/java/dan200/computercraft/client/render/ItemPrintoutRenderer.java

@@ -23,7 +23,7 @@ import static dan200.computercraft.shared.media.items.ItemPrintout.LINES_PER_PAG
 import static dan200.computercraft.shared.media.items.ItemPrintout.LINE_MAX_LENGTH;
 
 /**
- * Emulates map and item-frame rendering for printouts.
+ * Emulates map and item-frame rendering for prinouts
  */
 @Mod.EventBusSubscriber( modid = ComputerCraft.MOD_ID, value = Side.CLIENT )
 public final class ItemPrintoutRenderer extends ItemMapLikeRenderer

src/main/java/dan200/computercraft/client/render/ModelTransformer.java

@@ -94,7 +94,7 @@ public final class ModelTransformer
         private final Point3f[] before = new Point3f[4];
         private final Point3f[] after = new Point3f[4];
 
-        NormalAwareTransformer( IVertexConsumer parent, Matrix4f positionMatrix, Matrix4f normalMatrix )
+        public NormalAwareTransformer( IVertexConsumer parent, Matrix4f positionMatrix, Matrix4f normalMatrix )
         {
             super( parent );
             this.positionMatrix = positionMatrix;
@@ -180,7 +180,7 @@ public final class ModelTransformer
      *
      * This also provides the ability to swap vertices through {@link #swap(int, int)} to allow reordering.
      */
-    private static final class BakedQuadBuilder implements IVertexConsumer
+    private static class BakedQuadBuilder implements IVertexConsumer
     {
         private final VertexFormat format;
 
@@ -195,7 +195,7 @@ public final class ModelTransformer
         private BakedQuadBuilder( VertexFormat format )
         {
             this.format = format;
-            vertexData = new int[format.getSize()];
+            this.vertexData = new int[format.getSize()];
         }
 
         @Nonnull
@@ -208,7 +208,7 @@ public final class ModelTransformer
         @Override
         public void setQuadTint( int tint )
         {
-            quadTint = tint;
+            this.quadTint = tint;
         }
 
         @Override

src/main/java/dan200/computercraft/client/render/MonitorHighlightRenderer.java

@@ -1,118 +0,0 @@
-/*
- * This file is part of ComputerCraft - http://www.computercraft.info
- * Copyright Daniel Ratcliffe, 2011-2019. Do not distribute without permission.
- * Send enquiries to dratcliffe@gmail.com
- */
-
-package dan200.computercraft.client.render;
-
-import dan200.computercraft.ComputerCraft;
-import dan200.computercraft.shared.peripheral.monitor.TileMonitor;
-import net.minecraft.client.renderer.BufferBuilder;
-import net.minecraft.client.renderer.GlStateManager;
-import net.minecraft.client.renderer.Tessellator;
-import net.minecraft.client.renderer.vertex.DefaultVertexFormats;
-import net.minecraft.entity.player.EntityPlayer;
-import net.minecraft.tileentity.TileEntity;
-import net.minecraft.util.EnumFacing;
-import net.minecraft.util.math.BlockPos;
-import net.minecraft.util.math.RayTraceResult;
-import net.minecraft.world.World;
-import net.minecraftforge.client.event.DrawBlockHighlightEvent;
-import net.minecraftforge.fml.common.Mod;
-import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
-import net.minecraftforge.fml.relauncher.Side;
-import org.lwjgl.opengl.GL11;
-
-import java.util.EnumSet;
-
-import static net.minecraft.util.EnumFacing.*;
-
-@Mod.EventBusSubscriber( modid = ComputerCraft.MOD_ID, value = Side.CLIENT )
-public final class MonitorHighlightRenderer
-{
-    private static final float EXPAND = 0.002f;
-
-    private MonitorHighlightRenderer()
-    {
-    }
-
-    @SubscribeEvent
-    public static void drawHighlight( DrawBlockHighlightEvent event )
-    {
-        if( event.getTarget().typeOfHit != RayTraceResult.Type.BLOCK || event.getPlayer().isSneaking() ) return;
-
-        World world = event.getPlayer().getEntityWorld();
-        BlockPos pos = event.getTarget().getBlockPos();
-
-        if( world.getBlockState( pos ).getBlock() != ComputerCraft.Blocks.peripheral ) return;
-
-        TileEntity tile = world.getTileEntity( pos );
-        if( !(tile instanceof TileMonitor) ) return;
-
-        TileMonitor monitor = (TileMonitor) tile;
-        event.setCanceled( true );
-
-        // Determine which sides are part of the external faces of the monitor, and so which need to be rendered.
-        EnumSet<EnumFacing> faces = EnumSet.allOf( EnumFacing.class );
-        EnumFacing front = monitor.getFront();
-        faces.remove( front );
-        if( monitor.getXIndex() != 0 ) faces.remove( monitor.getRight().getOpposite() );
-        if( monitor.getXIndex() != monitor.getWidth() - 1 ) faces.remove( monitor.getRight() );
-        if( monitor.getYIndex() != 0 ) faces.remove( monitor.getDown().getOpposite() );
-        if( monitor.getYIndex() != monitor.getHeight() - 1 ) faces.remove( monitor.getDown() );
-
-        GlStateManager.enableBlend();
-        GlStateManager.tryBlendFuncSeparate( GlStateManager.SourceFactor.SRC_ALPHA, GlStateManager.DestFactor.ONE_MINUS_SRC_ALPHA, GlStateManager.SourceFactor.ONE, GlStateManager.DestFactor.ZERO );
-        GL11.glLineWidth( 2.0F );
-        GlStateManager.disableTexture2D();
-        GlStateManager.depthMask( false );
-        GlStateManager.pushMatrix();
-
-        EntityPlayer player = event.getPlayer();
-        double x = player.lastTickPosX + (player.posX - player.lastTickPosX) * event.getPartialTicks();
-        double y = player.lastTickPosY + (player.posY - player.lastTickPosY) * event.getPartialTicks();
-        double z = player.lastTickPosZ + (player.posZ - player.lastTickPosZ) * event.getPartialTicks();
-
-        GlStateManager.translate( -x + pos.getX(), -y + pos.getY(), -z + pos.getZ() );
-
-        Tessellator tessellator = Tessellator.getInstance();
-        BufferBuilder buffer = tessellator.getBuffer();
-        buffer.begin( GL11.GL_LINES, DefaultVertexFormats.POSITION_COLOR );
-
-        // I wish I could think of a better way to do this
-        if( faces.contains( NORTH ) || faces.contains( WEST ) ) line( buffer, 0, 0, 0, UP );
-        if( faces.contains( SOUTH ) || faces.contains( WEST ) ) line( buffer, 0, 0, 1, UP );
-        if( faces.contains( NORTH ) || faces.contains( EAST ) ) line( buffer, 1, 0, 0, UP );
-        if( faces.contains( SOUTH ) || faces.contains( EAST ) ) line( buffer, 1, 0, 1, UP );
-        if( faces.contains( NORTH ) || faces.contains( DOWN ) ) line( buffer, 0, 0, 0, EAST );
-        if( faces.contains( SOUTH ) || faces.contains( DOWN ) ) line( buffer, 0, 0, 1, EAST );
-        if( faces.contains( NORTH ) || faces.contains( UP ) ) line( buffer, 0, 1, 0, EAST );
-        if( faces.contains( SOUTH ) || faces.contains( UP ) ) line( buffer, 0, 1, 1, EAST );
-        if( faces.contains( WEST ) || faces.contains( DOWN ) ) line( buffer, 0, 0, 0, SOUTH );
-        if( faces.contains( EAST ) || faces.contains( DOWN ) ) line( buffer, 1, 0, 0, SOUTH );
-        if( faces.contains( WEST ) || faces.contains( UP ) ) line( buffer, 0, 1, 0, SOUTH );
-        if( faces.contains( EAST ) || faces.contains( UP ) ) line( buffer, 1, 1, 0, SOUTH );
-
-        tessellator.draw();
-
-        GlStateManager.popMatrix();
-        GlStateManager.depthMask( true );
-        GlStateManager.enableTexture2D();
-        GlStateManager.disableBlend();
-    }
-
-    private static void line( BufferBuilder buffer, int x, int y, int z, EnumFacing direction )
-    {
-        double minX = x == 0 ? -EXPAND : 1 + EXPAND;
-        double minY = y == 0 ? -EXPAND : 1 + EXPAND;
-        double minZ = z == 0 ? -EXPAND : 1 + EXPAND;
-
-        buffer.pos( minX, minY, minZ ).color( 0, 0, 0, 0.4f ).endVertex();
-        buffer.pos(
-            minX + direction.getXOffset() * (1 + EXPAND * 2),
-            minY + direction.getYOffset() * (1 + EXPAND * 2),
-            minZ + direction.getZOffset() * (1 + EXPAND * 2)
-        ).color( 0, 0, 0, 0.4f ).endVertex();
-    }
-}

src/main/java/dan200/computercraft/client/render/PrintoutRenderer.java

@@ -12,8 +12,6 @@ import dan200.computercraft.shared.util.Palette;
 import net.minecraft.client.Minecraft;
 import net.minecraft.client.renderer.BufferBuilder;
 import net.minecraft.client.renderer.GlStateManager;
-import net.minecraft.client.renderer.GlStateManager.DestFactor;
-import net.minecraft.client.renderer.GlStateManager.SourceFactor;
 import net.minecraft.client.renderer.Tessellator;
 import net.minecraft.client.renderer.vertex.DefaultVertexFormats;
 import net.minecraft.util.ResourceLocation;
@@ -22,46 +20,44 @@ import org.lwjgl.opengl.GL11;
 import static dan200.computercraft.client.gui.FixedWidthFontRenderer.FONT_HEIGHT;
 import static dan200.computercraft.shared.media.items.ItemPrintout.LINES_PER_PAGE;
 
-public final class PrintoutRenderer
+public class PrintoutRenderer
 {
     private static final ResourceLocation BG = new ResourceLocation( "computercraft", "textures/gui/printout.png" );
     private static final double BG_SIZE = 256.0;
 
     /**
-     * Width of a page.
+     * Width of a page
      */
     public static final int X_SIZE = 172;
 
     /**
-     * Height of a page.
+     * Height of a page
      */
     public static final int Y_SIZE = 209;
 
     /**
-     * Padding between the left and right of a page and the text.
+     * Padding between the left and right of a page and the text
      */
     public static final int X_TEXT_MARGIN = 13;
 
     /**
-     * Padding between the top and bottom of a page and the text.
+     * Padding between the top and bottom of a page and the text
      */
     public static final int Y_TEXT_MARGIN = 11;
 
     /**
-     * Width of the extra page texture.
+     * Width of the extra page texture
      */
     private static final int X_FOLD_SIZE = 12;
 
     /**
-     * Size of the leather cover.
+     * Size of the leather cover
      */
     public static final int COVER_SIZE = 12;
 
     private static final int COVER_Y = Y_SIZE;
     private static final int COVER_X = X_SIZE + 4 * X_FOLD_SIZE;
 
-    private PrintoutRenderer() {}
-
     public static void drawText( int x, int y, int start, TextBuffer[] text, TextBuffer[] colours )
     {
         FixedWidthFontRenderer fontRenderer = FixedWidthFontRenderer.instance();
@@ -77,7 +73,6 @@ public final class PrintoutRenderer
         GlStateManager.color( 1.0f, 1.0f, 1.0f, 1.0f );
         GlStateManager.enableBlend();
         GlStateManager.enableTexture2D();
-        GlStateManager.tryBlendFuncSeparate( SourceFactor.SRC_ALPHA, DestFactor.ONE_MINUS_SRC_ALPHA, SourceFactor.ONE, DestFactor.ZERO );
 
         FixedWidthFontRenderer fontRenderer = FixedWidthFontRenderer.instance();
 
@@ -92,7 +87,6 @@ public final class PrintoutRenderer
         GlStateManager.color( 1.0f, 1.0f, 1.0f, 1.0f );
         GlStateManager.enableBlend();
         GlStateManager.enableTexture2D();
-        GlStateManager.tryBlendFuncSeparate( SourceFactor.SRC_ALPHA, DestFactor.ONE_MINUS_SRC_ALPHA, SourceFactor.ONE, DestFactor.ZERO );
 
         Minecraft.getMinecraft().getTextureManager().bindTexture( BG );
 

src/main/java/dan200/computercraft/client/render/RenderOverlayCable.java

@@ -29,13 +29,13 @@ import net.minecraftforge.fml.relauncher.Side;
 import org.lwjgl.opengl.GL11;
 
 @Mod.EventBusSubscriber( modid = ComputerCraft.MOD_ID, value = Side.CLIENT )
-public final class CableHighlightRenderer
+public final class RenderOverlayCable
 {
     private static final float EXPAND = 0.002f;
     private static final double MIN = CableBounds.MIN - EXPAND;
     private static final double MAX = CableBounds.MAX + EXPAND;
 
-    private CableHighlightRenderer()
+    private RenderOverlayCable()
     {
     }
 
@@ -53,7 +53,7 @@ public final class CableHighlightRenderer
         state = state.getActualState( world, pos );
 
         event.setCanceled( true );
-        PeripheralType type = BlockCable.getPeripheralType( state );
+        PeripheralType type = ComputerCraft.Blocks.cable.getPeripheralType( state );
 
         GlStateManager.enableBlend();
         GlStateManager.tryBlendFuncSeparate( GL11.GL_SRC_ALPHA, GL11.GL_ONE_MINUS_SRC_ALPHA, 1, 0 );

src/main/java/dan200/computercraft/client/render/RenderOverlayNetwork.java

@@ -0,0 +1,188 @@
+package dan200.computercraft.client.render;
+
+import com.google.common.collect.Sets;
+import dan200.computercraft.ComputerCraft;
+import dan200.computercraft.api.network.wired.IWiredElement;
+import dan200.computercraft.shared.wired.WiredNetwork;
+import dan200.computercraft.shared.wired.WiredNode;
+import net.minecraft.client.Minecraft;
+import net.minecraft.client.gui.FontRenderer;
+import net.minecraft.client.renderer.BufferBuilder;
+import net.minecraft.client.renderer.GlStateManager;
+import net.minecraft.client.renderer.Tessellator;
+import net.minecraft.client.renderer.entity.RenderManager;
+import net.minecraft.client.renderer.vertex.DefaultVertexFormats;
+import net.minecraft.init.Items;
+import net.minecraft.item.ItemStack;
+import net.minecraft.util.math.RayTraceResult;
+import net.minecraft.util.math.Vec3d;
+import net.minecraft.world.World;
+import net.minecraftforge.client.event.RenderWorldLastEvent;
+import net.minecraftforge.fml.common.FMLCommonHandler;
+import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
+import org.lwjgl.opengl.GL11;
+
+import java.awt.*;
+import java.util.Collection;
+import java.util.Set;
+
+/**
+ * This is a helper to render a network when testing.
+ */
+public final class RenderOverlayNetwork
+{
+    private int ticksInGame;
+    private IWiredElement element;
+
+    @SubscribeEvent
+    public void onWorldRenderLast( RenderWorldLastEvent event )
+    {
+        ++ticksInGame;
+
+        RayTraceResult result = Minecraft.getMinecraft().objectMouseOver;
+        if( result != null && result.typeOfHit == RayTraceResult.Type.BLOCK )
+        {
+            World clientWorld = Minecraft.getMinecraft().world;
+            World world = FMLCommonHandler.instance().getMinecraftServerInstance().getWorld( clientWorld.provider.getDimension() );
+
+            IWiredElement newElement = ComputerCraft.getWiredElementAt( world, result.getBlockPos(), result.sideHit );
+            if( newElement != null ) element = newElement;
+        }
+
+        if( element == null ) return;
+
+        Minecraft minecraft = Minecraft.getMinecraft();
+        ItemStack stack = minecraft.player.getHeldItemMainhand();
+        ItemStack otherStack = minecraft.player.getHeldItemOffhand();
+
+        if( stack.getItem() != Items.STICK && otherStack.getItem() != Items.STICK ) return;
+
+        GlStateManager.pushMatrix();
+        RenderManager renderManager = minecraft.getRenderManager();
+        GlStateManager.translate( -renderManager.viewerPosX, -renderManager.viewerPosY, -renderManager.viewerPosZ );
+
+        GlStateManager.disableDepth();
+        GlStateManager.disableTexture2D();
+        GlStateManager.enableBlend();
+        GlStateManager.blendFunc( GL11.GL_SRC_ALPHA, GL11.GL_ONE_MINUS_SRC_ALPHA );
+
+        Set<Pair<IWiredElement>> connections = Sets.newHashSet();
+        WiredNetwork network = (WiredNetwork) element.getNode().getNetwork();
+
+        for( WiredNode node : network.getNodes() )
+        {
+            for( WiredNode other : node.getNeighbours() )
+            {
+                connections.add( new Pair<>( node.getElement(), other.getElement() ) );
+            }
+        }
+
+        renderNetworkConnections( connections, new Color( Color.HSBtoRGB( ticksInGame % 200 / 200F, 0.6F, 1F ) ), 1f );
+
+        GlStateManager.enableDepth();
+        GlStateManager.enableTexture2D();
+        GlStateManager.disableBlend();
+        GlStateManager.popMatrix();
+    }
+
+    private void renderNetworkConnections( Collection<Pair<IWiredElement>> data, Color color, float thickness )
+    {
+        renderConnections( data, color, 1.0f, thickness );
+        renderConnections( data, color, 64.0f / 255.0f, thickness * 3 );
+    }
+
+    private void renderConnections( Collection<Pair<IWiredElement>> connections, Color color, float alpha, float thickness )
+    {
+        Tessellator tessellator = Tessellator.getInstance();
+        BufferBuilder renderer = tessellator.getBuffer();
+
+        GlStateManager.pushMatrix();
+        GlStateManager.scale( 1, 1, 1 );
+
+        GlStateManager.color( color.getRed() / 255.0f, color.getGreen() / 255.0f, color.getBlue() / 255.0f, alpha );
+        GL11.glLineWidth( thickness );
+
+        renderer.begin( GL11.GL_LINES, DefaultVertexFormats.POSITION );
+        for( Pair<IWiredElement> connection : connections )
+        {
+            Vec3d a = connection.x.getPosition(), b = connection.y.getPosition();
+
+            renderer.pos( a.x, a.y, a.z ).endVertex();
+            renderer.pos( b.x, b.y, b.z ).endVertex();
+        }
+
+        tessellator.draw();
+
+        GlStateManager.popMatrix();
+    }
+
+    private void renderLabel( double x, double y, double z, String label )
+    {
+        RenderManager renderManager = Minecraft.getMinecraft().getRenderManager();
+        FontRenderer fontrenderer = renderManager.getFontRenderer();
+        if( fontrenderer == null ) return;
+
+        GlStateManager.pushMatrix();
+        GlStateManager.disableLighting();
+
+        float scale = 0.02666667f;
+        GlStateManager.translate( x, y, z );
+        GlStateManager.rotate( -renderManager.playerViewY, 0, 1, 0 );
+        GlStateManager.rotate( renderManager.playerViewX, 1, 0, 0 );
+        GlStateManager.scale( -scale, -scale, scale );
+
+        // Render label background
+        Tessellator tessellator = Tessellator.getInstance();
+        BufferBuilder renderer = tessellator.getBuffer();
+
+        int width = fontrenderer.getStringWidth( label );
+        int xOffset = width / 2;
+
+        GlStateManager.disableTexture2D();
+        GlStateManager.color( 0, 0, 0, 65 / 225.0f );
+
+        renderer.begin( GL11.GL_QUADS, DefaultVertexFormats.POSITION );
+        renderer.pos( -xOffset - 1, -1, 0 ).endVertex();
+        renderer.pos( -xOffset - 1, 8, 0 ).endVertex();
+        renderer.pos( xOffset + 1, 8, 0 ).endVertex();
+        renderer.pos( xOffset + 1, -1, 0 ).endVertex();
+
+        tessellator.draw();
+        GlStateManager.enableTexture2D();
+
+        // Render label
+        fontrenderer.drawString( label, -width / 2, 0, 0xFFFFFFFF );
+
+        GlStateManager.enableLighting();
+        GlStateManager.popMatrix();
+    }
+
+    private static class Pair<T>
+    {
+        public final T x;
+        public final T y;
+
+        public Pair( T right, T y )
+        {
+            this.x = right;
+            this.y = y;
+        }
+
+        @Override
+        public boolean equals( Object o )
+        {
+            if( this == o ) return true;
+            if( o == null || getClass() != o.getClass() ) return false;
+
+            Pair<?> p = (Pair<?>) o;
+            return (x.equals( p.x ) && y.equals( p.y ))
+                || (x.equals( p.y ) && y.equals( p.x ));
+        }
+
+        @Override
+        public int hashCode()
+        {
+            return x.hashCode() ^ y.hashCode();
+        }
+    }
+}

src/main/java/dan200/computercraft/client/render/TileEntityCableRenderer.java

@@ -61,11 +61,11 @@ public class TileEntityCableRenderer extends TileEntitySpecialRenderer<TileCable
         state = state.getActualState( world, pos );
         if( te.getPeripheralType() != PeripheralType.Cable && WorldUtil.isVecInsideInclusive( CableBounds.getModemBounds( state ), hit.hitVec.subtract( pos.getX(), pos.getY(), pos.getZ() ) ) )
         {
-            state = block.getDefaultState().withProperty( BlockCable.MODEM, state.getValue( BlockCable.MODEM ) );
+            state = block.getDefaultState().withProperty( BlockCable.Properties.MODEM, state.getValue( BlockCable.Properties.MODEM ) );
         }
         else
         {
-            state = state.withProperty( BlockCable.MODEM, BlockCableModemVariant.None );
+            state = state.withProperty( BlockCable.Properties.MODEM, BlockCableModemVariant.None );
         }
 
         IBakedModel model = mc.getBlockRendererDispatcher().getModelForState( state );
@@ -97,8 +97,6 @@ public class TileEntityCableRenderer extends TileEntitySpecialRenderer<TileCable
     }
 
     /**
-     * Set up the state for rendering block-breaking progress.
-     *
      * @see RenderGlobal#preRenderDamagedBlocks()
      */
     private void preRenderDamagedBlocks()
@@ -117,8 +115,6 @@ public class TileEntityCableRenderer extends TileEntitySpecialRenderer<TileCable
     }
 
     /**
-     * Tear down the state for rendering block-breaking progress.
-     *
      * @see RenderGlobal#postRenderDamagedBlocks()
      */
     private void postRenderDamagedBlocks()

src/main/java/dan200/computercraft/client/render/TileEntityMonitorRenderer.java

@@ -37,7 +37,7 @@ public class TileEntityMonitorRenderer extends TileEntitySpecialRenderer<TileMon
         }
     }
 
-    private static void renderMonitorAt( TileMonitor monitor, double posX, double posY, double posZ, float f, int i )
+    private void renderMonitorAt( TileMonitor monitor, double posX, double posY, double posZ, float f, int i )
     {
         // Render from the origin monitor
         ClientMonitor originTerminal = monitor.getClientMonitor();
@@ -78,7 +78,7 @@ public class TileEntityMonitorRenderer extends TileEntitySpecialRenderer<TileMon
             GlStateManager.rotate( pitch, 1.0f, 0.0f, 0.0f );
             GlStateManager.translate(
                 -0.5 + TileMonitor.RENDER_BORDER + TileMonitor.RENDER_MARGIN,
-                origin.getHeight() - 0.5 - (TileMonitor.RENDER_BORDER + TileMonitor.RENDER_MARGIN),
+                (origin.getHeight() - 0.5) - (TileMonitor.RENDER_BORDER + TileMonitor.RENDER_MARGIN),
                 0.5
             );
             double xSize = origin.getWidth() - 2.0 * (TileMonitor.RENDER_MARGIN + TileMonitor.RENDER_BORDER);

src/main/java/dan200/computercraft/client/render/TileEntityTurtleRenderer.java

@@ -40,14 +40,14 @@ import java.util.List;
 public class TileEntityTurtleRenderer extends TileEntitySpecialRenderer<TileTurtle>
 {
     private static final ModelResourceLocation NORMAL_TURTLE_MODEL = new ModelResourceLocation( "computercraft:turtle", "inventory" );
-    private static final ModelResourceLocation ADVANCED_TURTLE_MODEL = new ModelResourceLocation( "computercraft:turtle_advanced", "inventory" );
+    private static final ModelResourceLocation ADVANCED_TURTLE_MODEL = new ModelResourceLocation( "computercraft:advanced_turtle", "inventory" );
     private static final ModelResourceLocation COLOUR_TURTLE_MODEL = new ModelResourceLocation( "computercraft:turtle_white", "inventory" );
     private static final ModelResourceLocation ELF_OVERLAY_MODEL = new ModelResourceLocation( "computercraft:turtle_elf_overlay", "inventory" );
 
     @Override
-    public void render( TileTurtle tileEntity, double posX, double posY, double posZ, float partialTicks, int breaking, float f2 )
+    public void render( TileTurtle tileEntity, double posX, double posY, double posZ, float f, int i, float f2 )
     {
-        if( tileEntity != null ) renderTurtleAt( tileEntity, posX, posY, posZ, partialTicks );
+        if( tileEntity != null ) renderTurtleAt( tileEntity, posX, posY, posZ, f, i );
     }
 
     public static ModelResourceLocation getTurtleModel( ComputerFamily family, boolean coloured )
@@ -78,7 +78,7 @@ public class TileEntityTurtleRenderer extends TileEntitySpecialRenderer<TileTurt
         }
     }
 
-    private void renderTurtleAt( TileTurtle turtle, double posX, double posY, double posZ, float partialTicks )
+    private void renderTurtleAt( TileTurtle turtle, double posX, double posY, double posZ, float f, int i )
     {
         // Render the label
         String label = turtle.createProxy().getLabel();
@@ -93,13 +93,15 @@ public class TileEntityTurtleRenderer extends TileEntitySpecialRenderer<TileTurt
             setLightmapDisabled( false );
         }
 
+        IBlockState state = turtle.getWorld().getBlockState( turtle.getPos() );
         GlStateManager.pushMatrix();
         try
         {
-            IBlockState state = turtle.getWorld().getBlockState( turtle.getPos() );
             // Setup the transform
-            Vec3d offset = turtle.getRenderOffset( partialTicks );
+            Vec3d offset;
-            float yaw = turtle.getRenderYaw( partialTicks );
+            float yaw;
+            offset = turtle.getRenderOffset( f );
+            yaw = turtle.getRenderYaw( f );
             GlStateManager.translate( posX + offset.x, posY + offset.y, posZ + offset.z );
 
             // Render the turtle
@@ -113,9 +115,12 @@ public class TileEntityTurtleRenderer extends TileEntitySpecialRenderer<TileTurt
             }
             GlStateManager.translate( -0.5f, -0.5f, -0.5f );
             // Render the turtle
-            int colour = turtle.getColour();
+            int colour;
-            ComputerFamily family = turtle.getFamily();
+            ComputerFamily family;
-            ResourceLocation overlay = turtle.getOverlay();
+            ResourceLocation overlay;
+            colour = turtle.getColour();
+            family = turtle.getFamily();
+            overlay = turtle.getOverlay();
 
             renderModel( state, getTurtleModel( family, colour != -1 ), colour == -1 ? null : new int[] { colour } );
 
@@ -141,8 +146,8 @@ public class TileEntityTurtleRenderer extends TileEntitySpecialRenderer<TileTurt
             }
 
             // Render the upgrades
-            renderUpgrade( state, turtle, TurtleSide.Left, partialTicks );
+            renderUpgrade( state, turtle, TurtleSide.Left, f );
-            renderUpgrade( state, turtle, TurtleSide.Right, partialTicks );
+            renderUpgrade( state, turtle, TurtleSide.Right, f );
         }
         finally
         {
@@ -151,7 +156,7 @@ public class TileEntityTurtleRenderer extends TileEntitySpecialRenderer<TileTurt
         }
     }
 
-    private static void renderUpgrade( IBlockState state, TileTurtle turtle, TurtleSide side, float f )
+    private void renderUpgrade( IBlockState state, TileTurtle turtle, TurtleSide side, float f )
     {
         ITurtleUpgrade upgrade = turtle.getUpgrade( side );
         if( upgrade != null )
@@ -184,14 +189,14 @@ public class TileEntityTurtleRenderer extends TileEntitySpecialRenderer<TileTurt
         }
     }
 
-    private static void renderModel( IBlockState state, ModelResourceLocation modelLocation, int[] tints )
+    private void renderModel( IBlockState state, ModelResourceLocation modelLocation, int[] tints )
     {
         Minecraft mc = Minecraft.getMinecraft();
         ModelManager modelManager = mc.getRenderItem().getItemModelMesher().getModelManager();
         renderModel( state, modelManager.getModel( modelLocation ), tints );
     }
 
-    private static void renderModel( IBlockState state, IBakedModel model, int[] tints )
+    private void renderModel( IBlockState state, IBakedModel model, int[] tints )
     {
         Minecraft mc = Minecraft.getMinecraft();
         Tessellator tessellator = Tessellator.getInstance();
@@ -203,7 +208,7 @@ public class TileEntityTurtleRenderer extends TileEntitySpecialRenderer<TileTurt
         }
     }
 
-    private static void renderQuads( Tessellator tessellator, List<BakedQuad> quads, int[] tints )
+    private void renderQuads( Tessellator tessellator, List<BakedQuad> quads, int[] tints )
     {
         BufferBuilder buffer = tessellator.getBuffer();
         VertexFormat format = DefaultVertexFormats.ITEM;

src/main/java/dan200/computercraft/client/render/TurtleModelLoader.java

@@ -21,7 +21,7 @@ import net.minecraftforge.common.model.IModelState;
 import javax.annotation.Nonnull;
 import java.util.function.Function;
 
-public final class TurtleModelLoader implements ICustomModelLoader
+public class TurtleModelLoader implements ICustomModelLoader
 {
     private static final ResourceLocation NORMAL_TURTLE_MODEL = new ResourceLocation( ComputerCraft.MOD_ID, "block/turtle" );
     private static final ResourceLocation ADVANCED_TURTLE_MODEL = new ResourceLocation( ComputerCraft.MOD_ID, "block/advanced_turtle" );
@@ -64,7 +64,7 @@ public final class TurtleModelLoader implements ICustomModelLoader
         throw new IllegalStateException( "Loader does not accept " + name );
     }
 
-    private static final class TurtleModel implements IModel
+    private static class TurtleModel implements IModel
     {
         private final IModel family;
         private final IModel colour;

src/main/java/dan200/computercraft/client/render/TurtleMultiModel.java

@@ -17,7 +17,7 @@ import net.minecraft.util.EnumFacing;
 import javax.annotation.Nonnull;
 import javax.vecmath.Matrix4f;
 import java.util.ArrayList;
-import java.util.EnumMap;
+import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 
@@ -30,8 +30,8 @@ public class TurtleMultiModel implements IBakedModel
     private final Matrix4f m_leftUpgradeTransform;
     private final IBakedModel m_rightUpgradeModel;
     private final Matrix4f m_rightUpgradeTransform;
-    private List<BakedQuad> m_generalQuads = null;
+    private List<BakedQuad> m_generalQuads;
-    private Map<EnumFacing, List<BakedQuad>> m_faceQuads = new EnumMap<>( EnumFacing.class );
+    private Map<EnumFacing, List<BakedQuad>> m_faceQuads;
 
     public TurtleMultiModel( IBakedModel baseModel, IBakedModel overlayModel, Matrix4f generalTransform, IBakedModel leftUpgradeModel, Matrix4f leftUpgradeTransform, IBakedModel rightUpgradeModel, Matrix4f rightUpgradeTransform )
     {
@@ -43,6 +43,8 @@ public class TurtleMultiModel implements IBakedModel
         m_rightUpgradeModel = rightUpgradeModel;
         m_rightUpgradeTransform = rightUpgradeTransform;
         m_generalTransform = generalTransform;
+        m_generalQuads = null;
+        m_faceQuads = new HashMap<>();
     }
 
     @Nonnull

src/main/java/dan200/computercraft/client/render/TurtleSmartItemModel.java

@@ -143,10 +143,10 @@ public class TurtleSmartItemModel implements IBakedModel
         ModelResourceLocation overlayModelLocation = TileEntityTurtleRenderer.getTurtleOverlayModel( combo.m_overlay, combo.m_christmas );
 
         IBakedModel baseModel = combo.m_colour ? colourModel : familyModel;
-        IBakedModel overlayModel = overlayModelLocation != null ? modelManager.getModel( overlayModelLocation ) : null;
+        IBakedModel overlayModel = (overlayModelLocation != null) ? modelManager.getModel( overlayModelLocation ) : null;
         Matrix4f transform = combo.m_flip ? s_flip : s_identity;
-        Pair<IBakedModel, Matrix4f> leftModel = combo.m_leftUpgrade != null ? combo.m_leftUpgrade.getModel( null, TurtleSide.Left ) : null;
+        Pair<IBakedModel, Matrix4f> leftModel = (combo.m_leftUpgrade != null) ? combo.m_leftUpgrade.getModel( null, TurtleSide.Left ) : null;
-        Pair<IBakedModel, Matrix4f> rightModel = combo.m_rightUpgrade != null ? combo.m_rightUpgrade.getModel( null, TurtleSide.Right ) : null;
+        Pair<IBakedModel, Matrix4f> rightModel = (combo.m_rightUpgrade != null) ? combo.m_rightUpgrade.getModel( null, TurtleSide.Right ) : null;
         if( leftModel != null && rightModel != null )
         {
             return new TurtleMultiModel( baseModel, overlayModel, transform, leftModel.getLeft(), leftModel.getRight(), rightModel.getLeft(), rightModel.getRight() );

src/main/java/dan200/computercraft/core/apis/AddressPredicate.java

@@ -20,7 +20,7 @@ import java.util.regex.Pattern;
  */
 public class AddressPredicate
 {
-    private static final class HostRange
+    private static class HostRange
     {
         private final byte[] min;
         private final byte[] max;
@@ -69,10 +69,7 @@ public class AddressPredicate
                 }
                 catch( NumberFormatException e )
                 {
-                    ComputerCraft.log.error(
+                    ComputerCraft.log.warn( "Cannot parse CIDR size from {} ({})", filter, prefixSizeStr );
-                        "Malformed http whitelist/blacklist entry '{}': Cannot extract size of CIDR mask from '{}'.",
-                        filter, prefixSizeStr
-                    );
                     continue;
                 }
 
@@ -83,10 +80,7 @@ public class AddressPredicate
                 }
                 catch( IllegalArgumentException e )
                 {
-                    ComputerCraft.log.error(
+                    ComputerCraft.log.warn( "Cannot parse IP address from {} ({})", filter, addressStr );
-                        "Malformed http whitelist/blacklist entry '{}': Cannot extract IP address from '{}'.",
-                        filter, prefixSizeStr
-                    );
                     continue;
                 }
 
@@ -154,7 +148,7 @@ public class AddressPredicate
     }
 
     /**
-     * Determine whether the given address matches a series of patterns.
+     * Determine whether the given address matches a series of patterns
      *
      * @param address The address to check.
      * @return Whether it matches any of these patterns.

src/main/java/dan200/computercraft/core/apis/ApiFactories.java

@@ -6,13 +6,13 @@
 
 package dan200.computercraft.core.apis;
 
+import com.google.common.base.Preconditions;
 import dan200.computercraft.api.lua.ILuaAPIFactory;
 
 import javax.annotation.Nonnull;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.LinkedHashSet;
-import java.util.Objects;
 
 public final class ApiFactories
 {
@@ -25,7 +25,7 @@ public final class ApiFactories
 
     public static void register( @Nonnull ILuaAPIFactory factory )
     {
-        Objects.requireNonNull( factory, "provider cannot be null" );
+        Preconditions.checkNotNull( factory, "provider cannot be null" );
         factories.add( factory );
     }
 

src/main/java/dan200/computercraft/core/apis/ArgumentHelper.java

@@ -13,106 +13,256 @@ import javax.annotation.Nullable;
 import java.util.Map;
 
 /**
- * A stub for any mods which depended on this version of the argument helper.
+ * Various helpers for arguments
- *
- * @deprecated Use {@link dan200.computercraft.api.lua.ArgumentHelper}.
  */
-@Deprecated
 public final class ArgumentHelper
 {
     private ArgumentHelper()
     {
+        throw new IllegalStateException( "Cannot instantiate singleton " + getClass().getName() );
     }
 
     @Nonnull
     public static String getType( @Nullable Object type )
     {
-        return dan200.computercraft.api.lua.ArgumentHelper.getType( type );
+        if( type == null ) return "nil";
+        if( type instanceof String ) return "string";
+        if( type instanceof Boolean ) return "boolean";
+        if( type instanceof Number ) return "number";
+        if( type instanceof Map ) return "table";
+
+        Class<?> klass = type.getClass();
+        if( klass.isArray() )
+        {
+            StringBuilder name = new StringBuilder();
+            while( klass.isArray() )
+            {
+                name.append( "[]" );
+                klass = klass.getComponentType();
+            }
+            name.insert( 0, klass.getName() );
+            return name.toString();
+        }
+        else
+        {
+            return klass.getName();
+        }
     }
 
     @Nonnull
     public static LuaException badArgument( int index, @Nonnull String expected, @Nullable Object actual )
     {
-        return dan200.computercraft.api.lua.ArgumentHelper.badArgumentOf( index, expected, actual );
+        return badArgument( index, expected, getType( actual ) );
     }
 
     @Nonnull
     public static LuaException badArgument( int index, @Nonnull String expected, @Nonnull String actual )
     {
-        return dan200.computercraft.api.lua.ArgumentHelper.badArgument( index, expected, actual );
+        return new LuaException( "bad argument #" + (index + 1) + " (" + expected + " expected, got " + actual + ")" );
     }
 
     public static double getNumber( @Nonnull Object[] args, int index ) throws LuaException
     {
-        return dan200.computercraft.api.lua.ArgumentHelper.getDouble( args, index );
+        if( index >= args.length ) throw badArgument( index, "number", "nil" );
+        Object value = args[index];
+        if( value instanceof Number )
+        {
+            return ((Number) value).doubleValue();
+        }
+        else
+        {
+            throw badArgument( index, "number", value );
+        }
     }
 
     public static int getInt( @Nonnull Object[] args, int index ) throws LuaException
     {
-        return dan200.computercraft.api.lua.ArgumentHelper.getInt( args, index );
+        return (int) getLong( args, index );
     }
 
     public static long getLong( @Nonnull Object[] args, int index ) throws LuaException
     {
-        return dan200.computercraft.api.lua.ArgumentHelper.getLong( args, index );
+        if( index >= args.length ) throw badArgument( index, "number", "nil" );
+        Object value = args[index];
+        if( value instanceof Number )
+        {
+            return checkReal( index, (Number) value ).longValue();
+        }
+        else
+        {
+            throw badArgument( index, "number", value );
+        }
     }
 
     public static double getReal( @Nonnull Object[] args, int index ) throws LuaException
     {
-        return dan200.computercraft.api.lua.ArgumentHelper.getFiniteDouble( args, index );
+        return checkReal( index, getNumber( args, index ) );
     }
 
     public static boolean getBoolean( @Nonnull Object[] args, int index ) throws LuaException
     {
-        return dan200.computercraft.api.lua.ArgumentHelper.getBoolean( args, index );
+        if( index >= args.length ) throw badArgument( index, "boolean", "nil" );
+        Object value = args[index];
+        if( value instanceof Boolean )
+        {
+            return (Boolean) value;
+        }
+        else
+        {
+            throw badArgument( index, "boolean", value );
+        }
     }
 
     @Nonnull
     public static String getString( @Nonnull Object[] args, int index ) throws LuaException
     {
-        return dan200.computercraft.api.lua.ArgumentHelper.getString( args, index );
+        if( index >= args.length ) throw badArgument( index, "string", "nil" );
+        Object value = args[index];
+        if( value instanceof String )
+        {
+            return (String) value;
+        }
+        else
+        {
+            throw badArgument( index, "string", value );
+        }
     }
 
-    @Nonnull
     @SuppressWarnings( "unchecked" )
+    @Nonnull
     public static Map<Object, Object> getTable( @Nonnull Object[] args, int index ) throws LuaException
     {
-        return (Map<Object, Object>) dan200.computercraft.api.lua.ArgumentHelper.getTable( args, index );
+        if( index >= args.length ) throw badArgument( index, "table", "nil" );
+        Object value = args[index];
+        if( value instanceof Map )
+        {
+            return (Map<Object, Object>) value;
+        }
+        else
+        {
+            throw badArgument( index, "table", value );
+        }
     }
 
     public static double optNumber( @Nonnull Object[] args, int index, double def ) throws LuaException
     {
-        return dan200.computercraft.api.lua.ArgumentHelper.optDouble( args, index, def );
+        Object value = index < args.length ? args[index] : null;
+        if( value == null )
+        {
+            return def;
+        }
+        else if( value instanceof Number )
+        {
+            return ((Number) value).doubleValue();
+        }
+        else
+        {
+            throw badArgument( index, "number", value );
+        }
     }
 
     public static int optInt( @Nonnull Object[] args, int index, int def ) throws LuaException
     {
-        return dan200.computercraft.api.lua.ArgumentHelper.optInt( args, index, def );
+        return (int) optLong( args, index, def );
     }
 
     public static long optLong( @Nonnull Object[] args, int index, long def ) throws LuaException
     {
-        return dan200.computercraft.api.lua.ArgumentHelper.optLong( args, index, def );
+        Object value = index < args.length ? args[index] : null;
+        if( value == null )
+        {
+            return def;
+        }
+        else if( value instanceof Number )
+        {
+            return checkReal( index, (Number) value ).longValue();
+        }
+        else
+        {
+            throw badArgument( index, "number", value );
+        }
     }
 
     public static double optReal( @Nonnull Object[] args, int index, double def ) throws LuaException
     {
-        return dan200.computercraft.api.lua.ArgumentHelper.optFiniteDouble( args, index, def );
+        return checkReal( index, optNumber( args, index, def ) );
     }
 
     public static boolean optBoolean( @Nonnull Object[] args, int index, boolean def ) throws LuaException
     {
-        return dan200.computercraft.api.lua.ArgumentHelper.optBoolean( args, index, def );
+        Object value = index < args.length ? args[index] : null;
+        if( value == null )
+        {
+            return def;
+        }
+        else if( value instanceof Boolean )
+        {
+            return (Boolean) value;
+        }
+        else
+        {
+            throw badArgument( index, "boolean", value );
+        }
     }
 
     public static String optString( @Nonnull Object[] args, int index, String def ) throws LuaException
     {
-        return dan200.computercraft.api.lua.ArgumentHelper.optString( args, index, def );
+        Object value = index < args.length ? args[index] : null;
+        if( value == null )
+        {
+            return def;
+        }
+        else if( value instanceof String )
+        {
+            return (String) value;
+        }
+        else
+        {
+            throw badArgument( index, "string", value );
+        }
     }
 
     @SuppressWarnings( "unchecked" )
     public static Map<Object, Object> optTable( @Nonnull Object[] args, int index, Map<Object, Object> def ) throws LuaException
     {
-        return (Map<Object, Object>) dan200.computercraft.api.lua.ArgumentHelper.optTable( args, index, def );
+        Object value = index < args.length ? args[index] : null;
+        if( value == null )
+        {
+            return def;
+        }
+        else if( value instanceof Map )
+        {
+            return (Map<Object, Object>) value;
+        }
+        else
+        {
+            throw badArgument( index, "table", value );
+        }
+    }
+
+    private static Number checkReal( int index, Number value ) throws LuaException
+    {
+        checkReal( index, value.doubleValue() );
+        return value;
+    }
+
+    private static double checkReal( int index, double value ) throws LuaException
+    {
+        if( Double.isNaN( value ) )
+        {
+            throw badArgument( index, "number", "nan" );
+        }
+        else if( value == Double.POSITIVE_INFINITY )
+        {
+            throw badArgument( index, "number", "inf" );
+        }
+        else if( value == Double.NEGATIVE_INFINITY )
+        {
+            throw badArgument( index, "number", "-inf" );
+        }
+        else
+        {
+            return value;
+        }
     }
 }

src/main/java/dan200/computercraft/core/apis/ComputerAccess.java

@@ -6,10 +6,12 @@
 
 package dan200.computercraft.core.apis;
 
+import com.google.common.base.Preconditions;
 import dan200.computercraft.api.filesystem.IMount;
 import dan200.computercraft.api.filesystem.IWritableMount;
 import dan200.computercraft.api.peripheral.IComputerAccess;
-import dan200.computercraft.api.peripheral.IWorkMonitor;
+import dan200.computercraft.core.computer.Computer;
+import dan200.computercraft.core.computer.IComputerOwned;
 import dan200.computercraft.core.filesystem.FileSystem;
 import dan200.computercraft.core.filesystem.FileSystemException;
 
@@ -19,22 +21,22 @@ import java.util.HashSet;
 import java.util.Objects;
 import java.util.Set;
 
-public abstract class ComputerAccess implements IComputerAccess
+public abstract class ComputerAccess implements IComputerAccess, IComputerOwned
 {
     private final IAPIEnvironment m_environment;
     private final Set<String> m_mounts = new HashSet<>();
 
-    protected ComputerAccess( IAPIEnvironment environment )
+    protected ComputerAccess( IAPIEnvironment m_environment )
     {
-        this.m_environment = environment;
+        this.m_environment = m_environment;
     }
 
     public void unmountAll()
     {
         FileSystem fileSystem = m_environment.getFileSystem();
-        for( String mount : m_mounts )
+        for( String m_mount : m_mounts )
         {
-            fileSystem.unmount( mount );
+            fileSystem.unmount( m_mount );
         }
         m_mounts.clear();
     }
@@ -120,15 +122,15 @@ public abstract class ComputerAccess implements IComputerAccess
     @Override
     public void queueEvent( @Nonnull final String event, final Object[] arguments )
     {
-        Objects.requireNonNull( event, "event cannot be null" );
+        Preconditions.checkNotNull( event, "event cannot be null" );
         m_environment.queueEvent( event, arguments );
     }
 
     @Nullable
     @Override
-    public IWorkMonitor getMainThreadMonitor()
+    public Computer getComputer()
     {
-        return m_environment.getMainThreadMonitor();
+        return m_environment.getComputer();
     }
 
     private String findFreeLocation( String desiredLoc )

src/main/java/dan200/computercraft/core/apis/FSAPI.java

@@ -27,23 +27,25 @@ import java.util.HashMap;
 import java.util.Map;
 import java.util.function.Function;
 
-import static dan200.computercraft.api.lua.ArgumentHelper.getString;
+import static dan200.computercraft.core.apis.ArgumentHelper.getString;
 
 public class FSAPI implements ILuaAPI
 {
     private IAPIEnvironment m_env;
     private FileSystem m_fileSystem;
 
-    public FSAPI( IAPIEnvironment env )
+    public FSAPI( IAPIEnvironment _env )
     {
-        m_env = env;
+        m_env = _env;
         m_fileSystem = null;
     }
 
     @Override
     public String[] getNames()
     {
-        return new String[] { "fs" };
+        return new String[] {
+            "fs"
+        };
     }
 
     @Override
@@ -351,8 +353,10 @@ public class FSAPI implements ILuaAPI
                 return new Object[] { FileSystem.getDirectory( path ) };
             }
             default:
-                assert false;
+            {
+                assert (false);
                 return null;
+            }
         }
     }
 }

src/main/java/dan200/computercraft/core/apis/HTTPAPI.java

@@ -23,7 +23,7 @@ import java.util.Collections;
 import java.util.Locale;
 import java.util.Map;
 
-import static dan200.computercraft.api.lua.ArgumentHelper.*;
+import static dan200.computercraft.core.apis.ArgumentHelper.*;
 import static dan200.computercraft.core.apis.TableHelper.*;
 
 public class HTTPAPI implements ILuaAPI
@@ -42,7 +42,9 @@ public class HTTPAPI implements ILuaAPI
     @Override
     public String[] getNames()
     {
-        return new String[] { "http" };
+        return new String[] {
+            "http"
+        };
     }
 
     @Override
@@ -81,7 +83,6 @@ public class HTTPAPI implements ILuaAPI
     }
 
     @Override
-    @SuppressWarnings( "resource" )
     public Object[] callMethod( @Nonnull ILuaContext context, int method, @Nonnull Object[] args ) throws LuaException
     {
         switch( method )
@@ -89,12 +90,12 @@ public class HTTPAPI implements ILuaAPI
             case 0: // request
             {
                 String address, postString, requestMethod;
-                Map<?, ?> headerTable;
+                Map<Object, Object> headerTable;
                 boolean binary, redirect;
 
                 if( args.length >= 1 && args[0] instanceof Map )
                 {
-                    Map<?, ?> options = (Map<?, ?>) args[0];
+                    Map<?, ?> options = (Map) args[0];
                     address = getStringField( options, "url" );
                     postString = optStringField( options, "body", null );
                     headerTable = optTableField( options, "headers", Collections.emptyMap() );
@@ -134,6 +135,7 @@ public class HTTPAPI implements ILuaAPI
                 try
                 {
                     URI uri = HttpRequest.checkUri( address );
+
                     HttpRequest request = new HttpRequest( requests, m_apiEnvironment, address, postString, headers, binary, redirect );
 
                     long requestBody = request.body().readableBytes() + HttpRequest.getHeaderSize( headers );
@@ -172,7 +174,7 @@ public class HTTPAPI implements ILuaAPI
             case 2: // websocket
             {
                 String address = getString( args, 0 );
-                Map<?, ?> headerTbl = optTable( args, 1, Collections.emptyMap() );
+                Map<Object, Object> headerTbl = optTable( args, 1, Collections.emptyMap() );
 
                 if( !ComputerCraft.http_websocket_enable )
                 {
@@ -197,7 +199,9 @@ public class HTTPAPI implements ILuaAPI
                 }
             }
             default:
+            {
                 return null;
+            }
         }
     }
 
@@ -205,14 +209,14 @@ public class HTTPAPI implements ILuaAPI
     private static HttpHeaders getHeaders( @Nonnull Map<?, ?> headerTable ) throws LuaException
     {
         HttpHeaders headers = new DefaultHttpHeaders();
-        for( Map.Entry<?, ?> entry : headerTable.entrySet() )
+        for( Object key : headerTable.keySet() )
         {
-            Object value = entry.getValue();
+            Object value = headerTable.get( key );
-            if( entry.getKey() instanceof String && value instanceof String )
+            if( key instanceof String && value instanceof String )
             {
                 try
                 {
-                    headers.add( (String) entry.getKey(), value );
+                    headers.add( (String) key, value );
                 }
                 catch( IllegalArgumentException e )
                 {

src/main/java/dan200/computercraft/core/apis/IAPIEnvironment.java

@@ -7,33 +7,27 @@
 package dan200.computercraft.core.apis;
 
 import dan200.computercraft.api.peripheral.IPeripheral;
-import dan200.computercraft.api.peripheral.IWorkMonitor;
+import dan200.computercraft.core.computer.Computer;
-import dan200.computercraft.core.computer.ComputerSide;
 import dan200.computercraft.core.computer.IComputerEnvironment;
+import dan200.computercraft.core.computer.IComputerOwned;
 import dan200.computercraft.core.filesystem.FileSystem;
 import dan200.computercraft.core.terminal.Terminal;
 import dan200.computercraft.core.tracking.TrackingField;
 
-import javax.annotation.Nonnull;
+public interface IAPIEnvironment extends IComputerOwned
-import javax.annotation.Nullable;
-
-public interface IAPIEnvironment
 {
-    @FunctionalInterface
     interface IPeripheralChangeListener
     {
-        void onPeripheralChanged( ComputerSide side, @Nullable IPeripheral newPeripheral );
+        void onPeripheralChanged( int side, IPeripheral newPeripheral );
     }
 
+    @Override
+    Computer getComputer();
+
     int getComputerID();
 
-    @Nonnull
     IComputerEnvironment getComputerEnvironment();
 
-    @Nonnull
-    IWorkMonitor getMainThreadMonitor();
-
-    @Nonnull
     Terminal getTerminal();
 
     FileSystem getFileSystem();
@@ -44,30 +38,29 @@ public interface IAPIEnvironment
 
     void queueEvent( String event, Object[] args );
 
-    void setOutput( ComputerSide side, int output );
+    void setOutput( int side, int output );
 
-    int getOutput( ComputerSide side );
+    int getOutput( int side );
 
-    int getInput( ComputerSide side );
+    int getInput( int side );
 
-    void setBundledOutput( ComputerSide side, int output );
+    void setBundledOutput( int side, int output );
 
-    int getBundledOutput( ComputerSide side );
+    int getBundledOutput( int side );
 
-    int getBundledInput( ComputerSide side );
+    int getBundledInput( int side );
 
-    void setPeripheralChangeListener( @Nullable IPeripheralChangeListener listener );
+    void setPeripheralChangeListener( IPeripheralChangeListener listener );
 
-    @Nullable
+    IPeripheral getPeripheral( int side );
-    IPeripheral getPeripheral( ComputerSide side );
 
     String getLabel();
 
-    void setLabel( @Nullable String label );
+    void setLabel( String label );
 
-    void addTrackingChange( @Nonnull TrackingField field, long change );
+    void addTrackingChange( TrackingField field, long change );
 
-    default void addTrackingChange( @Nonnull TrackingField field )
+    default void addTrackingChange( TrackingField field )
     {
         addTrackingChange( field, 1 );
     }

src/main/java/dan200/computercraft/core/apis/ILuaAPI.java

@@ -10,7 +10,6 @@ package dan200.computercraft.core.apis;
  * This exists purely to ensure binary compatibility.
  *
  * @see dan200.computercraft.api.lua.ILuaAPI
- * @deprecated Use the version in the public API. Only exists for compatibility with CCEmuX.
  */
 @Deprecated
 public interface ILuaAPI extends dan200.computercraft.api.lua.ILuaAPI

src/main/java/dan200/computercraft/core/apis/LuaDateTime.java

@@ -1,281 +0,0 @@
-/*
- * This file is part of ComputerCraft - http://www.computercraft.info
- * Copyright Daniel Ratcliffe, 2011-2019. Do not distribute without permission.
- * Send enquiries to dratcliffe@gmail.com
- */
-
-package dan200.computercraft.core.apis;
-
-import dan200.computercraft.api.lua.LuaException;
-
-import java.time.Instant;
-import java.time.LocalDateTime;
-import java.time.ZoneId;
-import java.time.ZoneOffset;
-import java.time.format.DateTimeFormatterBuilder;
-import java.time.format.TextStyle;
-import java.time.temporal.*;
-import java.util.HashMap;
-import java.util.Map;
-import java.util.function.LongUnaryOperator;
-
-final class LuaDateTime
-{
-    private LuaDateTime()
-    {
-    }
-
-    static void format( DateTimeFormatterBuilder formatter, String format, ZoneOffset offset ) throws LuaException
-    {
-        for( int i = 0; i < format.length(); )
-        {
-            char c;
-            switch( c = format.charAt( i++ ) )
-            {
-                case '\n':
-                    formatter.appendLiteral( '\n' );
-                    break;
-                default:
-                    formatter.appendLiteral( c );
-                    break;
-                case '%':
-                    if( i >= format.length() ) break;
-                    switch( c = format.charAt( i++ ) )
-                    {
-                        default:
-                            throw new LuaException( "bad argument #1: invalid conversion specifier '%" + c + "'" );
-
-                        case '%':
-                            formatter.appendLiteral( '%' );
-                            break;
-                        case 'a':
-                            formatter.appendText( ChronoField.DAY_OF_WEEK, TextStyle.SHORT );
-                            break;
-                        case 'A':
-                            formatter.appendText( ChronoField.DAY_OF_WEEK, TextStyle.FULL );
-                            break;
-                        case 'b':
-                        case 'h':
-                            formatter.appendText( ChronoField.MONTH_OF_YEAR, TextStyle.SHORT );
-                            break;
-                        case 'B':
-                            formatter.appendText( ChronoField.MONTH_OF_YEAR, TextStyle.FULL );
-                            break;
-                        case 'c':
-                            format( formatter, "%a %b %e %H:%M:%S %Y", offset );
-                            break;
-                        case 'C':
-                            formatter.appendValueReduced( CENTURY, 2, 2, 0 );
-                            break;
-                        case 'd':
-                            formatter.appendValue( ChronoField.DAY_OF_MONTH, 2 );
-                            break;
-                        case 'D':
-                        case 'x':
-                            format( formatter, "%m/%d/%y", offset );
-                            break;
-                        case 'e':
-                            formatter.padNext( 2 ).appendValue( ChronoField.DAY_OF_MONTH );
-                            break;
-                        case 'F':
-                            format( formatter, "%Y-%m-%d", offset );
-                            break;
-                        case 'g':
-                            formatter.appendValueReduced( IsoFields.WEEK_BASED_YEAR, 2, 2, 0 );
-                            break;
-                        case 'G':
-                            formatter.appendValue( IsoFields.WEEK_BASED_YEAR );
-                            break;
-                        case 'H':
-                            formatter.appendValue( ChronoField.HOUR_OF_DAY, 2 );
-                            break;
-                        case 'I':
-                            formatter.appendValue( ChronoField.HOUR_OF_AMPM );
-                            break;
-                        case 'j':
-                            formatter.appendValue( ChronoField.DAY_OF_YEAR, 3 );
-                            break;
-                        case 'm':
-                            formatter.appendValue( ChronoField.MONTH_OF_YEAR, 2 );
-                            break;
-                        case 'M':
-                            formatter.appendValue( ChronoField.MINUTE_OF_HOUR, 2 );
-                            break;
-                        case 'n':
-                            formatter.appendLiteral( '\n' );
-                            break;
-                        case 'p':
-                            formatter.appendText( ChronoField.AMPM_OF_DAY );
-                            break;
-                        case 'r':
-                            format( formatter, "%I:%M:%S %p", offset );
-                            break;
-                        case 'R':
-                            format( formatter, "%H:%M", offset );
-                            break;
-                        case 'S':
-                            formatter.appendValue( ChronoField.SECOND_OF_MINUTE, 2 );
-                            break;
-                        case 't':
-                            formatter.appendLiteral( '\t' );
-                            break;
-                        case 'T':
-                        case 'X':
-                            format( formatter, "%H:%M:%S", offset );
-                            break;
-                        case 'u':
-                            formatter.appendValue( ChronoField.DAY_OF_WEEK );
-                            break;
-                        case 'U':
-                            formatter.appendValue( ChronoField.ALIGNED_WEEK_OF_YEAR, 2 );
-                            break;
-                        case 'V':
-                            formatter.appendValue( IsoFields.WEEK_OF_WEEK_BASED_YEAR, 2 );
-                            break;
-                        case 'w':
-                            formatter.appendValue( ZERO_WEEK );
-                            break;
-                        case 'W':
-                            formatter.appendValue( WeekFields.ISO.weekOfYear(), 2 );
-                            break;
-                        case 'y':
-                            formatter.appendValueReduced( ChronoField.YEAR, 2, 2, 0 );
-                            break;
-                        case 'Y':
-                            formatter.appendValue( ChronoField.YEAR );
-                            break;
-                        case 'z':
-                            formatter.appendOffset( "+HHMM", "+0000" );
-                            break;
-                        case 'Z':
-                            formatter.appendChronologyId();
-                            break;
-                    }
-            }
-        }
-    }
-
-    static long fromTable( Map<?, ?> table ) throws LuaException
-    {
-        int year = getField( table, "year", -1 );
-        int month = getField( table, "month", -1 );
-        int day = getField( table, "day", -1 );
-        int hour = getField( table, "hour", 12 );
-        int minute = getField( table, "min", 12 );
-        int second = getField( table, "sec", 12 );
-        LocalDateTime time = LocalDateTime.of( year, month, day, hour, minute, second );
-
-        Boolean isDst = getBoolField( table, "isdst" );
-        if( isDst != null )
-        {
-            boolean requireDst = isDst;
-            for( ZoneOffset possibleOffset : ZoneOffset.systemDefault().getRules().getValidOffsets( time ) )
-            {
-                Instant instant = time.toInstant( possibleOffset );
-                if( possibleOffset.getRules().getDaylightSavings( instant ).isZero() == requireDst )
-                {
-                    return instant.getEpochSecond();
-                }
-            }
-        }
-
-        ZoneOffset offset = ZoneOffset.systemDefault().getRules().getOffset( time );
-        return time.toInstant( offset ).getEpochSecond();
-    }
-
-    static Map<String, ?> toTable( TemporalAccessor date, ZoneId offset, Instant instant )
-    {
-        HashMap<String, Object> table = new HashMap<>( 9 );
-        table.put( "year", date.getLong( ChronoField.YEAR ) );
-        table.put( "month", date.getLong( ChronoField.MONTH_OF_YEAR ) );
-        table.put( "day", date.getLong( ChronoField.DAY_OF_MONTH ) );
-        table.put( "hour", date.getLong( ChronoField.HOUR_OF_DAY ) );
-        table.put( "min", date.getLong( ChronoField.MINUTE_OF_HOUR ) );
-        table.put( "sec", date.getLong( ChronoField.SECOND_OF_MINUTE ) );
-        table.put( "wday", date.getLong( WeekFields.SUNDAY_START.dayOfWeek() ) );
-        table.put( "yday", date.getLong( ChronoField.DAY_OF_YEAR ) );
-        table.put( "isdst", offset.getRules().isDaylightSavings( instant ) );
-        return table;
-    }
-
-    private static int getField( Map<?, ?> table, String field, int def ) throws LuaException
-    {
-        Object value = table.get( field );
-        if( value instanceof Number ) return ((Number) value).intValue();
-        if( def < 0 ) throw new LuaException( "field \"" + field + "\" missing in date table" );
-        return def;
-    }
-
-    private static Boolean getBoolField( Map<?, ?> table, String field ) throws LuaException
-    {
-        Object value = table.get( field );
-        if( value instanceof Boolean || value == null ) return (Boolean) value;
-        throw new LuaException( "field \"" + field + "\" missing in date table" );
-    }
-
-    private static final TemporalField CENTURY = map( ChronoField.YEAR, ValueRange.of( 0, 6 ), x -> (x / 100) % 100 );
-    private static final TemporalField ZERO_WEEK = map( WeekFields.SUNDAY_START.dayOfWeek(), ValueRange.of( 0, 6 ), x -> x - 1 );
-
-    private static TemporalField map( TemporalField field, ValueRange range, LongUnaryOperator convert )
-    {
-        return new TemporalField()
-        {
-            private final ValueRange range = ValueRange.of( 0, 99 );
-
-            @Override
-            public TemporalUnit getBaseUnit()
-            {
-                return field.getBaseUnit();
-            }
-
-            @Override
-            public TemporalUnit getRangeUnit()
-            {
-                return field.getRangeUnit();
-            }
-
-            @Override
-            public ValueRange range()
-            {
-                return range;
-            }
-
-            @Override
-            public boolean isDateBased()
-            {
-                return field.isDateBased();
-            }
-
-            @Override
-            public boolean isTimeBased()
-            {
-                return field.isTimeBased();
-            }
-
-            @Override
-            public boolean isSupportedBy( TemporalAccessor temporal )
-            {
-                return field.isSupportedBy( temporal );
-            }
-
-            @Override
-            public ValueRange rangeRefinedBy( TemporalAccessor temporal )
-            {
-                return range;
-            }
-
-            @Override
-            public long getFrom( TemporalAccessor temporal )
-            {
-                return convert.applyAsLong( temporal.getLong( field ) );
-            }
-
-            @Override
-            @SuppressWarnings( "unchecked" )
-            public <R extends Temporal> R adjustInto( R temporal, long newValue )
-            {
-                return (R) temporal.with( field, newValue );
-            }
-        };
-    }
-}

src/main/java/dan200/computercraft/core/apis/OSAPI.java

@@ -12,14 +12,9 @@ import dan200.computercraft.api.lua.LuaException;
 import dan200.computercraft.shared.util.StringUtil;
 
 import javax.annotation.Nonnull;
-import java.time.Instant;
-import java.time.ZoneId;
-import java.time.ZoneOffset;
-import java.time.ZonedDateTime;
-import java.time.format.DateTimeFormatterBuilder;
 import java.util.*;
 
-import static dan200.computercraft.api.lua.ArgumentHelper.*;
+import static dan200.computercraft.core.apis.ArgumentHelper.*;
 
 public class OSAPI implements ILuaAPI
 {
@@ -36,20 +31,20 @@ public class OSAPI implements ILuaAPI
 
     private static class Timer
     {
-        int m_ticksLeft;
+        public int m_ticksLeft;
 
-        Timer( int ticksLeft )
+        public Timer( int ticksLeft )
         {
             m_ticksLeft = ticksLeft;
         }
     }
 
-    private static class Alarm implements Comparable<Alarm>
+    private class Alarm implements Comparable<Alarm>
     {
-        final double m_time;
+        public final double m_time;
-        final int m_day;
+        public final int m_day;
 
-        Alarm( double time, int day )
+        public Alarm( double time, int day )
         {
             m_time = time;
             m_day = day;
@@ -78,7 +73,9 @@ public class OSAPI implements ILuaAPI
     @Override
     public String[] getNames()
     {
-        return new String[] { "os" };
+        return new String[] {
+            "os"
+        };
     }
 
     @Override
@@ -113,7 +110,7 @@ public class OSAPI implements ILuaAPI
             {
                 Map.Entry<Integer, Timer> entry = it.next();
                 Timer timer = entry.getValue();
-                timer.m_ticksLeft--;
+                timer.m_ticksLeft = timer.m_ticksLeft - 1;
                 if( timer.m_ticksLeft <= 0 )
                 {
                     // Queue the "timer" event
@@ -187,12 +184,11 @@ public class OSAPI implements ILuaAPI
             "day",
             "cancelTimer",
             "cancelAlarm",
-            "epoch",
+            "epoch"
-            "date",
         };
     }
 
-    private static float getTimeForCalendar( Calendar c )
+    private float getTimeForCalendar( Calendar c )
     {
         float time = c.get( Calendar.HOUR_OF_DAY );
         time += c.get( Calendar.MINUTE ) / 60.0f;
@@ -200,9 +196,9 @@ public class OSAPI implements ILuaAPI
         return time;
     }
 
-    private static int getDayForCalendar( Calendar c )
+    private int getDayForCalendar( Calendar c )
     {
-        GregorianCalendar g = c instanceof GregorianCalendar ? (GregorianCalendar) c : new GregorianCalendar();
+        GregorianCalendar g = (c instanceof GregorianCalendar) ? (GregorianCalendar) c : new GregorianCalendar();
         int year = c.get( Calendar.YEAR );
         int day = 0;
         for( int y = 1970; y < year; y++ )
@@ -213,7 +209,7 @@ public class OSAPI implements ILuaAPI
         return day;
     }
 
-    private static long getEpochForCalendar( Calendar c )
+    private long getEpochForCalendar( Calendar c )
     {
         return c.getTime().getTime();
     }
@@ -223,13 +219,16 @@ public class OSAPI implements ILuaAPI
     {
         switch( method )
         {
-            case 0: // queueEvent
+            case 0:
+            {
+                // queueEvent
                 queueLuaEvent( getString( args, 0 ), trimArray( args, 1 ) );
                 return null;
+            }
             case 1:
             {
                 // startTimer
-                double timer = getFiniteDouble( args, 0 );
+                double timer = getReal( args, 0 );
                 synchronized( m_timers )
                 {
                     m_timers.put( m_nextTimerToken, new Timer( (int) Math.round( timer / 0.05 ) ) );
@@ -239,27 +238,36 @@ public class OSAPI implements ILuaAPI
             case 2:
             {
                 // setAlarm
-                double time = getFiniteDouble( args, 0 );
+                double time = getReal( args, 0 );
                 if( time < 0.0 || time >= 24.0 )
                 {
                     throw new LuaException( "Number out of range" );
                 }
                 synchronized( m_alarms )
                 {
-                    int day = time > m_time ? m_day : m_day + 1;
+                    int day = (time > m_time) ? m_day : (m_day + 1);
                     m_alarms.put( m_nextAlarmToken, new Alarm( time, day ) );
                     return new Object[] { m_nextAlarmToken++ };
                 }
             }
-            case 3: // shutdown
+            case 3:
+            {
+                // shutdown
                 m_apiEnvironment.shutdown();
                 return null;
-            case 4: // reboot
+            }
+            case 4:
+            {
+                // reboot
                 m_apiEnvironment.reboot();
                 return null;
+            }
             case 5:
-            case 6: // computerID/getComputerID
+            case 6:
+            {
+                // computerID/getComputerID
                 return new Object[] { getComputerID() };
+            }
             case 7:
             {
                 // setComputerLabel
@@ -278,19 +286,19 @@ public class OSAPI implements ILuaAPI
                 }
                 return null;
             }
-            case 10: // clock
+            case 10:
+            {
+                // clock
                 synchronized( m_timers )
                 {
                     return new Object[] { m_clock * 0.05 };
                 }
+            }
             case 11:
             {
                 // time
-                Object value = args.length > 0 ? args[0] : null;
-                if( value instanceof Map ) return new Object[] { LuaDateTime.fromTable( (Map<?, ?>) value ) };
-
                 String param = optString( args, 0, "ingame" );
-                switch( param.toLowerCase( Locale.ROOT ) )
+                switch( param )
                 {
                     case "utc":
                     {
@@ -318,7 +326,7 @@ public class OSAPI implements ILuaAPI
             {
                 // day
                 String param = optString( args, 0, "ingame" );
-                switch( param.toLowerCase( Locale.ROOT ) )
+                switch( param )
                 {
                     case "utc":
                     {
@@ -348,7 +356,10 @@ public class OSAPI implements ILuaAPI
                 int token = getInt( args, 0 );
                 synchronized( m_timers )
                 {
-                    m_timers.remove( token );
+                    if( m_timers.containsKey( token ) )
+                    {
+                        m_timers.remove( token );
+                    }
                 }
                 return null;
             }
@@ -358,14 +369,18 @@ public class OSAPI implements ILuaAPI
                 int token = getInt( args, 0 );
                 synchronized( m_alarms )
                 {
-                    m_alarms.remove( token );
+                    if( m_alarms.containsKey( token ) )
+                    {
+                        m_alarms.remove( token );
+                    }
                 }
                 return null;
             }
-            case 15: // epoch
+            case 15:
             {
+                // epoch
                 String param = optString( args, 0, "ingame" );
-                switch( param.toLowerCase( Locale.ROOT ) )
+                switch( param )
                 {
                     case "utc":
                     {
@@ -383,41 +398,18 @@ public class OSAPI implements ILuaAPI
                         // Get in-game epoch
                         synchronized( m_alarms )
                         {
-                            return new Object[] { m_day * 86400000 + (int) (m_time * 3600000.0f) };
+                            return new Object[] {
+                                m_day * 86400000 + (int) (m_time * 3600000.0f)
+                            };
                         }
                     default:
                         throw new LuaException( "Unsupported operation" );
                 }
             }
-            case 16: // date
-            {
-                String format = optString( args, 0, "%c" );
-                long time = optLong( args, 1, Instant.now().getEpochSecond() );
-
-                Instant instant = Instant.ofEpochSecond( time );
-                ZonedDateTime date;
-                ZoneOffset offset;
-                if( format.startsWith( "!" ) )
-                {
-                    offset = ZoneOffset.UTC;
-                    date = ZonedDateTime.ofInstant( instant, offset );
-                    format = format.substring( 1 );
-                }
-                else
-                {
-                    ZoneId id = ZoneId.systemDefault();
-                    offset = id.getRules().getOffset( instant );
-                    date = ZonedDateTime.ofInstant( instant, id );
-                }
-
-                if( format.equals( "*t" ) ) return new Object[] { LuaDateTime.toTable( date, offset, instant ) };
-
-                DateTimeFormatterBuilder formatter = new DateTimeFormatterBuilder();
-                LuaDateTime.format( formatter, format, offset );
-                return new Object[] { formatter.toFormatter( Locale.ROOT ).format( date ) };
-            }
             default:
+            {
                 return null;
+            }
         }
     }
 

src/main/java/dan200/computercraft/core/apis/PeripheralAPI.java

@@ -12,7 +12,9 @@ import dan200.computercraft.api.lua.ILuaAPI;
 import dan200.computercraft.api.lua.ILuaContext;
 import dan200.computercraft.api.lua.LuaException;
 import dan200.computercraft.api.peripheral.IPeripheral;
-import dan200.computercraft.core.computer.ComputerSide;
+import dan200.computercraft.core.computer.Computer;
+import dan200.computercraft.core.computer.ComputerThread;
+import dan200.computercraft.core.computer.ITask;
 import dan200.computercraft.core.tracking.TrackingField;
 
 import javax.annotation.Nonnull;
@@ -22,7 +24,7 @@ import java.util.Collections;
 import java.util.HashMap;
 import java.util.Map;
 
-import static dan200.computercraft.api.lua.ArgumentHelper.getString;
+import static dan200.computercraft.core.apis.ArgumentHelper.getString;
 
 public class PeripheralAPI implements ILuaAPI, IAPIEnvironment.IPeripheralChangeListener
 {
@@ -36,7 +38,7 @@ public class PeripheralAPI implements ILuaAPI, IAPIEnvironment.IPeripheralChange
         private Map<String, Integer> m_methodMap;
         private boolean m_attached;
 
-        PeripheralWrapper( IPeripheral peripheral, String side )
+        public PeripheralWrapper( IPeripheral peripheral, String side )
         {
             super( m_environment );
             m_side = side;
@@ -45,8 +47,8 @@ public class PeripheralAPI implements ILuaAPI, IAPIEnvironment.IPeripheralChange
 
             m_type = peripheral.getType();
             m_methods = peripheral.getMethodNames();
-            assert m_type != null;
+            assert (m_type != null);
-            assert m_methods != null;
+            assert (m_methods != null);
 
             m_methodMap = new HashMap<>();
             for( int i = 0; i < m_methods.length; i++ )
@@ -229,9 +231,9 @@ public class PeripheralAPI implements ILuaAPI, IAPIEnvironment.IPeripheralChange
     private final PeripheralWrapper[] m_peripherals;
     private boolean m_running;
 
-    public PeripheralAPI( IAPIEnvironment environment )
+    public PeripheralAPI( IAPIEnvironment _environment )
     {
-        m_environment = environment;
+        m_environment = _environment;
         m_environment.setPeripheralChangeListener( this );
 
         m_peripherals = new PeripheralWrapper[6];
@@ -246,33 +248,76 @@ public class PeripheralAPI implements ILuaAPI, IAPIEnvironment.IPeripheralChange
     // IPeripheralChangeListener
 
     @Override
-    public void onPeripheralChanged( ComputerSide side, IPeripheral newPeripheral )
+    public void onPeripheralChanged( int side, IPeripheral newPeripheral )
     {
         synchronized( m_peripherals )
         {
-            int index = side.ordinal();
+            if( m_peripherals[side] != null )
-            if( m_peripherals[index] != null )
             {
                 // Queue a detachment
-                final PeripheralWrapper wrapper = m_peripherals[index];
+                final PeripheralWrapper wrapper = m_peripherals[side];
-                if( wrapper.isAttached() ) wrapper.detach();
+                ComputerThread.queueTask( new ITask()
+                {
+                    @Override
+                    public Computer getOwner()
+                    {
+                        return m_environment.getComputer();
+                    }
+
+                    @Override
+                    public void execute()
+                    {
+                        synchronized( m_peripherals )
+                        {
+                            if( wrapper.isAttached() )
+                            {
+                                wrapper.detach();
+                            }
+                        }
+                    }
+                }, null );
 
                 // Queue a detachment event
-                m_environment.queueEvent( "peripheral_detach", new Object[] { side.getName() } );
+                m_environment.queueEvent( "peripheral_detach", new Object[] { Computer.s_sideNames[side] } );
             }
 
             // Assign the new peripheral
-            m_peripherals[index] = newPeripheral == null ? null
+            if( newPeripheral != null )
-                : new PeripheralWrapper( newPeripheral, side.getName() );
+            {
+                m_peripherals[side] = new PeripheralWrapper( newPeripheral, Computer.s_sideNames[side] );
+            }
+            else
+            {
+                m_peripherals[side] = null;
+            }
 
-            if( m_peripherals[index] != null )
+            if( m_peripherals[side] != null )
             {
                 // Queue an attachment
-                final PeripheralWrapper wrapper = m_peripherals[index];
+                final PeripheralWrapper wrapper = m_peripherals[side];
-                if( m_running && !wrapper.isAttached() ) wrapper.attach();
+                ComputerThread.queueTask( new ITask()
+                {
+                    @Override
+                    public Computer getOwner()
+                    {
+                        return m_environment.getComputer();
+                    }
+
+                    @Override
+                    public void execute()
+                    {
+                        synchronized( m_peripherals )
+                        {
+                            if( m_running && !wrapper.isAttached() )
+                            {
+                                wrapper.attach();
+                            }
+                        }
+                    }
+                }, null );
 
                 // Queue an attachment event
-                m_environment.queueEvent( "peripheral", new Object[] { side.getName() } );
+                m_environment.queueEvent( "peripheral", new Object[] { Computer.s_sideNames[side] } );
             }
         }
     }
@@ -282,7 +327,9 @@ public class PeripheralAPI implements ILuaAPI, IAPIEnvironment.IPeripheralChange
     @Override
     public String[] getNames()
     {
-        return new String[] { "peripheral" };
+        return new String[] {
+            "peripheral"
+        };
     }
 
     @Override
@@ -294,7 +341,10 @@ public class PeripheralAPI implements ILuaAPI, IAPIEnvironment.IPeripheralChange
             for( int i = 0; i < 6; i++ )
             {
                 PeripheralWrapper wrapper = m_peripherals[i];
-                if( wrapper != null && !wrapper.isAttached() ) wrapper.attach();
+                if( wrapper != null && !wrapper.isAttached() )
+                {
+                    wrapper.attach();
+                }
             }
         }
     }
@@ -324,7 +374,7 @@ public class PeripheralAPI implements ILuaAPI, IAPIEnvironment.IPeripheralChange
             "isPresent",
             "getType",
             "getMethods",
-            "call",
+            "call"
         };
     }
 
@@ -337,13 +387,16 @@ public class PeripheralAPI implements ILuaAPI, IAPIEnvironment.IPeripheralChange
             {
                 // isPresent
                 boolean present = false;
-                ComputerSide side = ComputerSide.valueOfInsensitive( getString( args, 0 ) );
+                int side = parseSide( args );
-                if( side != null )
+                if( side >= 0 )
                 {
                     synchronized( m_peripherals )
                     {
-                        PeripheralWrapper p = m_peripherals[side.ordinal()];
+                        PeripheralWrapper p = m_peripherals[side];
-                        if( p != null ) present = true;
+                        if( p != null )
+                        {
+                            present = true;
+                        }
                     }
                 }
                 return new Object[] { present };
@@ -351,13 +404,21 @@ public class PeripheralAPI implements ILuaAPI, IAPIEnvironment.IPeripheralChange
             case 1:
             {
                 // getType
-                ComputerSide side = ComputerSide.valueOfInsensitive( getString( args, 0 ) );
+                String type = null;
-                if( side != null )
+                int side = parseSide( args );
+                if( side >= 0 )
                 {
                     synchronized( m_peripherals )
                     {
-                        PeripheralWrapper p = m_peripherals[side.ordinal()];
+                        PeripheralWrapper p = m_peripherals[side];
-                        if( p != null ) return new Object[] { p.getType() };
+                        if( p != null )
+                        {
+                            type = p.getType();
+                        }
+                    }
+                    if( type != null )
+                    {
+                        return new Object[] { type };
                     }
                 }
                 return null;
@@ -366,12 +427,12 @@ public class PeripheralAPI implements ILuaAPI, IAPIEnvironment.IPeripheralChange
             {
                 // getMethods
                 String[] methods = null;
-                ComputerSide side = ComputerSide.valueOfInsensitive( getString( args, 0 ) );
+                int side = parseSide( args );
-                if( side != null )
+                if( side >= 0 )
                 {
                     synchronized( m_peripherals )
                     {
-                        PeripheralWrapper p = m_peripherals[side.ordinal()];
+                        PeripheralWrapper p = m_peripherals[side];
                         if( p != null )
                         {
                             methods = p.getMethods();
@@ -392,16 +453,16 @@ public class PeripheralAPI implements ILuaAPI, IAPIEnvironment.IPeripheralChange
             case 3:
             {
                 // call
-                ComputerSide side = ComputerSide.valueOfInsensitive( getString( args, 0 ) );
+                int side = parseSide( args );
                 String methodName = getString( args, 1 );
                 Object[] methodArgs = Arrays.copyOfRange( args, 2, args.length );
 
-                if( side != null )
+                if( side >= 0 )
                 {
                     PeripheralWrapper p;
                     synchronized( m_peripherals )
                     {
-                        p = m_peripherals[side.ordinal()];
+                        p = m_peripherals[side];
                     }
                     if( p != null )
                     {
@@ -411,7 +472,24 @@ public class PeripheralAPI implements ILuaAPI, IAPIEnvironment.IPeripheralChange
                 throw new LuaException( "No peripheral attached" );
             }
             default:
+            {
                 return null;
+            }
         }
     }
+
+    // Privates
+
+    private int parseSide( Object[] args ) throws LuaException
+    {
+        String side = getString( args, 0 );
+        for( int n = 0; n < Computer.s_sideNames.length; n++ )
+        {
+            if( side.equals( Computer.s_sideNames[n] ) )
+            {
+                return n;
+            }
+        }
+        return -1;
+    }
 }

src/main/java/dan200/computercraft/core/apis/RedstoneAPI.java

@@ -9,13 +9,13 @@ package dan200.computercraft.core.apis;
 import dan200.computercraft.api.lua.ILuaAPI;
 import dan200.computercraft.api.lua.ILuaContext;
 import dan200.computercraft.api.lua.LuaException;
-import dan200.computercraft.core.computer.ComputerSide;
+import dan200.computercraft.core.computer.Computer;
 
 import javax.annotation.Nonnull;
 import java.util.HashMap;
 import java.util.Map;
 
-import static dan200.computercraft.api.lua.ArgumentHelper.*;
+import static dan200.computercraft.core.apis.ArgumentHelper.*;
 
 public class RedstoneAPI implements ILuaAPI
 {
@@ -29,7 +29,9 @@ public class RedstoneAPI implements ILuaAPI
     @Override
     public String[] getNames()
     {
-        return new String[] { "rs", "redstone" };
+        return new String[] {
+            "rs", "redstone"
+        };
     }
 
     @Nonnull
@@ -63,49 +65,65 @@ public class RedstoneAPI implements ILuaAPI
             {
                 // getSides
                 Map<Object, Object> table = new HashMap<>();
-                for( int i = 0; i < ComputerSide.NAMES.length; i++ )
+                for( int i = 0; i < Computer.s_sideNames.length; i++ )
                 {
-                    table.put( i + 1, ComputerSide.NAMES[i] );
+                    table.put( i + 1, Computer.s_sideNames[i] );
                 }
                 return new Object[] { table };
             }
             case 1:
             {
                 // setOutput
-                ComputerSide side = parseSide( args );
+                int side = parseSide( args );
                 boolean output = getBoolean( args, 1 );
                 m_environment.setOutput( side, output ? 15 : 0 );
                 return null;
             }
-            case 2: // getOutput
+            case 2:
-                return new Object[] { m_environment.getOutput( parseSide( args ) ) > 0 };
+            {
-            case 3: // getInput
+                // getOutput
-                return new Object[] { m_environment.getInput( parseSide( args ) ) > 0 };
+                int side = parseSide( args );
+                return new Object[] { m_environment.getOutput( side ) > 0 };
+            }
+            case 3:
+            {
+                // getInput
+                int side = parseSide( args );
+                return new Object[] { m_environment.getInput( side ) > 0 };
+            }
             case 4:
             {
                 // setBundledOutput
-                ComputerSide side = parseSide( args );
+                int side = parseSide( args );
                 int output = getInt( args, 1 );
                 m_environment.setBundledOutput( side, output );
                 return null;
             }
-            case 5: // getBundledOutput
+            case 5:
-                return new Object[] { m_environment.getBundledOutput( parseSide( args ) ) };
+            {
-            case 6: // getBundledInput
+                // getBundledOutput
-                return new Object[] { m_environment.getBundledInput( parseSide( args ) ) };
+                int side = parseSide( args );
+                return new Object[] { m_environment.getBundledOutput( side ) };
+            }
+            case 6:
+            {
+                // getBundledInput
+                int side = parseSide( args );
+                return new Object[] { m_environment.getBundledInput( side ) };
+            }
             case 7:
             {
                 // testBundledInput
-                ComputerSide side = parseSide( args );
+                int side = parseSide( args );
                 int mask = getInt( args, 1 );
                 int input = m_environment.getBundledInput( side );
-                return new Object[] { (input & mask) == mask };
+                return new Object[] { ((input & mask) == mask) };
             }
             case 8:
             case 9:
             {
                 // setAnalogOutput/setAnalogueOutput
-                ComputerSide side = parseSide( args );
+                int side = parseSide( args );
                 int output = getInt( args, 1 );
                 if( output < 0 || output > 15 )
                 {
@@ -115,20 +133,36 @@ public class RedstoneAPI implements ILuaAPI
                 return null;
             }
             case 10:
-            case 11: // getAnalogOutput/getAnalogueOutput
+            case 11:
-                return new Object[] { m_environment.getOutput( parseSide( args ) ) };
+            {
+                // getAnalogOutput/getAnalogueOutput
+                int side = parseSide( args );
+                return new Object[] { m_environment.getOutput( side ) };
+            }
             case 12:
-            case 13: // getAnalogInput/getAnalogueInput
+            case 13:
-                return new Object[] { m_environment.getInput( parseSide( args ) ) };
+            {
+                // getAnalogInput/getAnalogueInput
+                int side = parseSide( args );
+                return new Object[] { m_environment.getInput( side ) };
+            }
             default:
+            {
                 return null;
+            }
         }
     }
 
-    private static ComputerSide parseSide( Object[] args ) throws LuaException
+    private int parseSide( Object[] args ) throws LuaException
     {
-        ComputerSide side = ComputerSide.valueOfInsensitive( getString( args, 0 ) );
+        String side = getString( args, 0 );
-        if( side == null ) throw new LuaException( "Invalid side." );
+        for( int n = 0; n < Computer.s_sideNames.length; n++ )
-        return side;
+        {
+            if( side.equals( Computer.s_sideNames[n] ) )
+            {
+                return n;
+            }
+        }
+        throw new LuaException( "Invalid side." );
     }
 }

src/main/java/dan200/computercraft/core/apis/TableHelper.java

@@ -6,17 +6,14 @@
 
 package dan200.computercraft.core.apis;
 
-import dan200.computercraft.api.lua.ArgumentHelper;
 import dan200.computercraft.api.lua.LuaException;
 
 import javax.annotation.Nonnull;
 import javax.annotation.Nullable;
 import java.util.Map;
 
-import static dan200.computercraft.api.lua.ArgumentHelper.getNumericType;
-
 /**
- * Various helpers for tables.
+ * Various helpers for tables
  */
 public final class TableHelper
 {
@@ -203,7 +200,21 @@ public final class TableHelper
 
     private static double checkReal( @Nonnull String key, double value ) throws LuaException
     {
-        if( !Double.isFinite( value ) ) throw badKey( key, "number", getNumericType( value ) );
+        if( Double.isNaN( value ) )
-        return value;
+        {
+            throw badKey( key, "number", "nan" );
+        }
+        else if( value == Double.POSITIVE_INFINITY )
+        {
+            throw badKey( key, "number", "inf" );
+        }
+        else if( value == Double.NEGATIVE_INFINITY )
+        {
+            throw badKey( key, "number", "-inf" );
+        }
+        else
+        {
+            return value;
+        }
     }
 }

src/main/java/dan200/computercraft/core/apis/TermAPI.java

@@ -11,29 +11,30 @@ import dan200.computercraft.api.lua.ILuaContext;
 import dan200.computercraft.api.lua.LuaException;
 import dan200.computercraft.core.computer.IComputerEnvironment;
 import dan200.computercraft.core.terminal.Terminal;
-import dan200.computercraft.shared.util.Colour;
 import dan200.computercraft.shared.util.Palette;
 import org.apache.commons.lang3.ArrayUtils;
 
 import javax.annotation.Nonnull;
 
-import static dan200.computercraft.api.lua.ArgumentHelper.*;
+import static dan200.computercraft.core.apis.ArgumentHelper.*;
 
 public class TermAPI implements ILuaAPI
 {
     private final Terminal m_terminal;
     private final IComputerEnvironment m_environment;
 
-    public TermAPI( IAPIEnvironment environment )
+    public TermAPI( IAPIEnvironment _environment )
     {
-        m_terminal = environment.getTerminal();
+        m_terminal = _environment.getTerminal();
-        m_environment = environment.getComputerEnvironment();
+        m_environment = _environment.getComputerEnvironment();
     }
 
     @Override
     public String[] getNames()
     {
-        return new String[] { "term" };
+        return new String[] {
+            "term"
+        };
     }
 
     @Nonnull
@@ -64,8 +65,6 @@ public class TermAPI implements ILuaAPI
             "setPaletteColor",
             "getPaletteColour",
             "getPaletteColor",
-            "nativePaletteColour",
-            "nativePaletteColor",
             "getCursorBlink",
         };
     }
@@ -87,7 +86,9 @@ public class TermAPI implements ILuaAPI
 
     public static Object[] encodeColour( int colour ) throws LuaException
     {
-        return new Object[] { 1 << colour };
+        return new Object[] {
+            1 << colour
+        };
     }
 
     public static void setColour( Terminal terminal, int colour, double r, double g, double b )
@@ -107,7 +108,16 @@ public class TermAPI implements ILuaAPI
             case 0:
             {
                 // write
-                String text = args.length > 0 && args[0] != null ? args[0].toString() : "";
+                String text;
+                if( args.length > 0 && args[0] != null )
+                {
+                    text = args[0].toString();
+                }
+                else
+                {
+                    text = "";
+                }
+
                 synchronized( m_terminal )
                 {
                     m_terminal.write( text );
@@ -168,18 +178,24 @@ public class TermAPI implements ILuaAPI
                 }
                 return new Object[] { width, height };
             }
-            case 6: // clear
+            case 6:
+            {
+                // clear
                 synchronized( m_terminal )
                 {
                     m_terminal.clear();
                 }
                 return null;
-            case 7: // clearLine
+            }
+            case 7:
+            {
+                // clearLine
                 synchronized( m_terminal )
                 {
                     m_terminal.clearLine();
                 }
                 return null;
+            }
             case 8:
             case 9:
             {
@@ -203,14 +219,23 @@ public class TermAPI implements ILuaAPI
                 return null;
             }
             case 12:
-            case 13: // isColour/isColor
+            case 13:
+            {
+                // isColour/isColor
                 return new Object[] { m_environment.isColour() };
+            }
             case 14:
-            case 15: // getTextColour/getTextColor
+            case 15:
+            {
+                // getTextColour/getTextColor
                 return encodeColour( m_terminal.getTextColour() );
+            }
             case 16:
-            case 17: // getBackgroundColour/getBackgroundColor
+            case 17:
+            {
+                // getBackgroundColour/getBackgroundColor
                 return encodeColour( m_terminal.getBackgroundColour() );
+            }
             case 18:
             {
                 // blit
@@ -242,9 +267,9 @@ public class TermAPI implements ILuaAPI
                 }
                 else
                 {
-                    double r = getFiniteDouble( args, 1 );
+                    double r = getReal( args, 1 );
-                    double g = getFiniteDouble( args, 2 );
+                    double g = getReal( args, 2 );
-                    double b = getFiniteDouble( args, 3 );
+                    double b = getReal( args, 3 );
                     setColour( m_terminal, colour, r, g, b );
                 }
                 return null;
@@ -264,23 +289,12 @@ public class TermAPI implements ILuaAPI
                 return null;
             }
             case 23:
-            case 24:
-            {
-                // nativePaletteColour/nativePaletteColor
-                int colour = 15 - parseColour( args );
-                Colour c = Colour.fromInt( colour );
-
-                float[] rgb = c.getRGB();
-
-                Object[] rgbObj = new Object[rgb.length];
-                for( int i = 0; i < rgbObj.length; ++i ) rgbObj[i] = rgb[i];
-                return rgbObj;
-            }
-            case 25:
                 // getCursorBlink
                 return new Object[] { m_terminal.getCursorBlink() };
             default:
+            {
                 return null;
+            }
         }
     }
 

src/main/java/dan200/computercraft/core/apis/handles/ArrayByteChannel.java

@@ -6,11 +6,13 @@
 
 package dan200.computercraft.core.apis.handles;
 
+import com.google.common.base.Preconditions;
+
+import java.io.IOException;
 import java.nio.ByteBuffer;
 import java.nio.channels.ClosedChannelException;
 import java.nio.channels.NonWritableChannelException;
 import java.nio.channels.SeekableByteChannel;
-import java.util.Objects;
 
 /**
  * A seekable, readable byte channel which is backed by a simple byte array.
@@ -28,10 +30,10 @@ public class ArrayByteChannel implements SeekableByteChannel
     }
 
     @Override
-    public int read( ByteBuffer destination ) throws ClosedChannelException
+    public int read( ByteBuffer destination ) throws IOException
     {
         if( closed ) throw new ClosedChannelException();
-        Objects.requireNonNull( destination, "destination" );
+        Preconditions.checkNotNull( destination, "destination" );
 
         if( position >= backing.length ) return -1;
 
@@ -42,21 +44,21 @@ public class ArrayByteChannel implements SeekableByteChannel
     }
 
     @Override
-    public int write( ByteBuffer src ) throws ClosedChannelException
+    public int write( ByteBuffer src ) throws IOException
     {
         if( closed ) throw new ClosedChannelException();
         throw new NonWritableChannelException();
     }
 
     @Override
-    public long position() throws ClosedChannelException
+    public long position() throws IOException
     {
         if( closed ) throw new ClosedChannelException();
         return position;
     }
 
     @Override
-    public SeekableByteChannel position( long newPosition ) throws ClosedChannelException
+    public SeekableByteChannel position( long newPosition ) throws IOException
     {
         if( closed ) throw new ClosedChannelException();
         if( newPosition < 0 || newPosition > Integer.MAX_VALUE )
@@ -68,14 +70,14 @@ public class ArrayByteChannel implements SeekableByteChannel
     }
 
     @Override
-    public long size() throws ClosedChannelException
+    public long size() throws IOException
     {
         if( closed ) throw new ClosedChannelException();
         return backing.length;
     }
 
     @Override
-    public SeekableByteChannel truncate( long size ) throws ClosedChannelException
+    public SeekableByteChannel truncate( long size ) throws IOException
     {
         if( closed ) throw new ClosedChannelException();
         throw new NonWritableChannelException();

src/main/java/dan200/computercraft/core/apis/handles/BinaryReadableHandle.java

@@ -21,8 +21,8 @@ import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.List;
 
-import static dan200.computercraft.api.lua.ArgumentHelper.getInt;
+import static dan200.computercraft.core.apis.ArgumentHelper.getInt;
-import static dan200.computercraft.api.lua.ArgumentHelper.optBoolean;
+import static dan200.computercraft.core.apis.ArgumentHelper.optBoolean;
 
 public class BinaryReadableHandle extends HandleGeneric
 {
@@ -38,8 +38,8 @@ public class BinaryReadableHandle extends HandleGeneric
     public BinaryReadableHandle( ReadableByteChannel channel, Closeable closeable )
     {
         super( closeable );
-        m_reader = channel;
+        this.m_reader = channel;
-        m_seekable = asSeekable( channel );
+        this.m_seekable = asSeekable( channel );
     }
 
     public BinaryReadableHandle( ReadableByteChannel channel )
@@ -169,42 +169,27 @@ public class BinaryReadableHandle extends HandleGeneric
                 {
                     ByteArrayOutputStream stream = new ByteArrayOutputStream();
 
-                    boolean readAnything = false, readRc = false;
+                    boolean readAnything = false;
                     while( true )
                     {
                         single.clear();
-                        int read = m_reader.read( single );
+                        int r = m_reader.read( single );
-                        if( read <= 0 )
+                        if( r == -1 ) break;
-                        {
-                            // Nothing else to read, and we saw no \n. Return the array. If we saw a \r, then add it
-                            // back.
-                            if( readRc ) stream.write( '\r' );
-                            return readAnything ? new Object[] { stream.toByteArray() } : null;
-                        }
 
                         readAnything = true;
-
+                        byte b = single.get( 0 );
-                        byte chr = single.get( 0 );
+                        if( b == '\n' )
-                        if( chr == '\n' )
                         {
-                            if( withTrailing )
+                            if( withTrailing ) stream.write( b );
-                            {
+                            break;
-                                if( readRc ) stream.write( '\r' );
-                                stream.write( chr );
-                            }
-                            return new Object[] { stream.toByteArray() };
                         }
                         else
                         {
-                            // We want to skip \r\n, but obviously need to include cases where \r is not followed by \n.
+                            stream.write( b );
-                            // Note, this behaviour is non-standard compliant (strictly speaking we should have no
-                            // special logic for \r), but we preserve compatibility with EncodedReadableHandle and
-                            // previous behaviour of the io library.
-                            if( readRc ) stream.write( '\r' );
-                            readRc = chr == '\r';
-                            if( !readRc ) stream.write( chr );
                         }
                     }
+
+                    return readAnything ? new Object[] { stream.toByteArray() } : null;
                 }
                 catch( IOException e )
                 {
@@ -212,7 +197,6 @@ public class BinaryReadableHandle extends HandleGeneric
                 }
             }
             case 3: // close
-                checkOpen();
                 close();
                 return null;
             case 4: // seek

src/main/java/dan200/computercraft/core/apis/handles/BinaryWritableHandle.java

@@ -7,9 +7,9 @@
 package dan200.computercraft.core.apis.handles;
 
 import com.google.common.collect.ObjectArrays;
-import dan200.computercraft.api.lua.ArgumentHelper;
 import dan200.computercraft.api.lua.ILuaContext;
 import dan200.computercraft.api.lua.LuaException;
+import dan200.computercraft.core.apis.ArgumentHelper;
 import dan200.computercraft.shared.util.StringUtil;
 
 import javax.annotation.Nonnull;
@@ -32,8 +32,8 @@ public class BinaryWritableHandle extends HandleGeneric
     public BinaryWritableHandle( WritableByteChannel channel, Closeable closeable )
     {
         super( closeable );
-        m_writer = channel;
+        this.m_writer = channel;
-        m_seekable = asSeekable( channel );
+        this.m_seekable = asSeekable( channel );
     }
 
     public BinaryWritableHandle( WritableByteChannel channel )
@@ -73,7 +73,7 @@ public class BinaryWritableHandle extends HandleGeneric
                     }
                     else
                     {
-                        throw ArgumentHelper.badArgumentOf( 0, "string or number", args.length > 0 ? args[0] : null );
+                        throw ArgumentHelper.badArgument( 0, "string or number", args.length > 0 ? args[0] : null );
                     }
                     return null;
                 }
@@ -95,7 +95,6 @@ public class BinaryWritableHandle extends HandleGeneric
                     return null;
                 }
             case 2: // close
-                checkOpen();
                 close();
                 return null;
             case 3: // seek

src/main/java/dan200/computercraft/core/apis/handles/EncodedReadableHandle.java

@@ -20,8 +20,8 @@ import java.nio.charset.CharsetDecoder;
 import java.nio.charset.CodingErrorAction;
 import java.nio.charset.StandardCharsets;
 
-import static dan200.computercraft.api.lua.ArgumentHelper.optBoolean;
+import static dan200.computercraft.core.apis.ArgumentHelper.optBoolean;
-import static dan200.computercraft.api.lua.ArgumentHelper.optInt;
+import static dan200.computercraft.core.apis.ArgumentHelper.optInt;
 
 public class EncodedReadableHandle extends HandleGeneric
 {
@@ -32,7 +32,7 @@ public class EncodedReadableHandle extends HandleGeneric
     public EncodedReadableHandle( @Nonnull BufferedReader reader, @Nonnull Closeable closable )
     {
         super( closable );
-        m_reader = reader;
+        this.m_reader = reader;
     }
 
     public EncodedReadableHandle( @Nonnull BufferedReader reader )
@@ -84,7 +84,7 @@ public class EncodedReadableHandle extends HandleGeneric
                 checkOpen();
                 try
                 {
-                    StringBuilder result = new StringBuilder();
+                    StringBuilder result = new StringBuilder( "" );
                     String line = m_reader.readLine();
                     while( line != null )
                     {
@@ -152,7 +152,6 @@ public class EncodedReadableHandle extends HandleGeneric
                     return null;
                 }
             case 3: // close
-                checkOpen();
                 close();
                 return null;
             default:

src/main/java/dan200/computercraft/core/apis/handles/EncodedWritableHandle.java

@@ -27,7 +27,7 @@ public class EncodedWritableHandle extends HandleGeneric
     public EncodedWritableHandle( @Nonnull BufferedWriter writer, @Nonnull Closeable closable )
     {
         super( closable );
-        m_writer = writer;
+        this.m_writer = writer;
     }
 
     public EncodedWritableHandle( @Nonnull BufferedWriter writer )
@@ -93,7 +93,6 @@ public class EncodedWritableHandle extends HandleGeneric
                     return null;
                 }
             case 3: // close
-                checkOpen();
                 close();
                 return null;
             default:

src/main/java/dan200/computercraft/core/apis/handles/HandleGeneric.java

@@ -16,8 +16,8 @@ import java.io.IOException;
 import java.nio.channels.Channel;
 import java.nio.channels.SeekableByteChannel;
 
-import static dan200.computercraft.api.lua.ArgumentHelper.optLong;
+import static dan200.computercraft.core.apis.ArgumentHelper.optLong;
-import static dan200.computercraft.api.lua.ArgumentHelper.optString;
+import static dan200.computercraft.core.apis.ArgumentHelper.optString;
 
 public abstract class HandleGeneric implements ILuaObject
 {
@@ -26,7 +26,7 @@ public abstract class HandleGeneric implements ILuaObject
 
     protected HandleGeneric( @Nonnull Closeable closable )
     {
-        m_closable = closable;
+        this.m_closable = closable;
     }
 
     protected void checkOpen() throws LuaException
@@ -37,21 +37,16 @@ public abstract class HandleGeneric implements ILuaObject
     protected final void close()
     {
         m_open = false;
-
+        IoUtil.closeQuietly( m_closable );
-        Closeable closeable = m_closable;
+        m_closable = null;
-        if( closeable != null )
-        {
-            IoUtil.closeQuietly( closeable );
-            m_closable = null;
-        }
     }
 
     /**
-     * Shared implementation for various file handle types.
+     * Shared implementation for various file handle types
      *
      * @param channel The channel to seek in
      * @param args    The Lua arguments to process, like Lua's {@code file:seek}.
-     * @return The new position of the file, or null if some error occurred.
+     * @return The new position of the file, or null if some error occured.
      * @throws LuaException If the arguments were invalid
      * @see <a href="https://www.lua.org/manual/5.1/manual.html#pdf-file:seek">{@code file:seek} in the Lua manual.</a>
      */

src/main/java/dan200/computercraft/core/apis/http/CheckUrl.java

@@ -31,7 +31,7 @@ public class CheckUrl extends Resource<CheckUrl>
         super( limiter );
         this.environment = environment;
         this.address = address;
-        host = uri.getHost();
+        this.host = uri.getHost();
     }
 
     public void run()

src/main/java/dan200/computercraft/core/apis/http/NetworkUtils.java

@@ -99,7 +99,7 @@ public final class NetworkUtils
     }
 
     /**
-     * Checks a host is allowed.
+     * Checks a host is allowed
      *
      * @param host The domain to check against
      * @throws HTTPRequestException If the host is not permitted.

src/main/java/dan200/computercraft/core/apis/http/Resource.java

@@ -20,8 +20,6 @@ import java.util.function.Consumer;
 
 /**
  * A holder for one or more resources, with a lifetime.
- *
- * @param <T> The type of this resource. Should be the class extending from {@link Resource}.
  */
 public abstract class Resource<T extends Resource<T>> implements Closeable
 {
@@ -44,9 +42,8 @@ public abstract class Resource<T extends Resource<T>> implements Closeable
     }
 
     /**
-     * Checks if this has been cancelled. If so, it'll clean up any existing resources and cancel any pending futures.
+     * Checks if this has been cancelled. If so, it'll clean up any
-     *
+     * existing resources and cancel any pending futures.
-     * @return Whether this resource has been closed.
      */
     public final boolean checkClosed()
     {
@@ -75,15 +72,13 @@ public abstract class Resource<T extends Resource<T>> implements Closeable
      */
     protected void dispose()
     {
-        @SuppressWarnings( "unchecked" )
+        @SuppressWarnings( "unchecked" ) T thisT = (T) this;
-        T thisT = (T) this;
         limiter.release( thisT );
     }
 
     /**
      * Create a {@link WeakReference} which will close {@code this} when collected.
      *
-     * @param <R>    The object we are wrapping in a reference.
      * @param object The object to reference to
      * @return The weak reference.
      */
@@ -100,8 +95,7 @@ public abstract class Resource<T extends Resource<T>> implements Closeable
 
     public boolean queue( Consumer<T> task )
     {
-        @SuppressWarnings( "unchecked" )
+        @SuppressWarnings( "unchecked" ) T thisT = (T) this;
-        T thisT = (T) this;
         return limiter.queue( thisT, () -> task.accept( thisT ) );
     }
 
@@ -146,6 +140,6 @@ public abstract class Resource<T extends Resource<T>> implements Closeable
     public static void cleanup()
     {
         Reference<?> reference;
-        while( (reference = QUEUE.poll()) != null ) ((CloseReference<?>) reference).resource.close();
+        while( (reference = QUEUE.poll()) != null ) ((CloseReference) reference).resource.close();
     }
 }

src/main/java/dan200/computercraft/core/apis/http/ResourceGroup.java

@@ -14,8 +14,6 @@ import java.util.function.Supplier;
 
 /**
  * A collection of {@link Resource}s, with an upper bound on capacity.
- *
- * @param <T> The type of the resource this group manages.
  */
 public class ResourceGroup<T extends Resource<T>>
 {
@@ -34,7 +32,7 @@ public class ResourceGroup<T extends Resource<T>>
 
     public ResourceGroup()
     {
-        limit = ZERO;
+        this.limit = ZERO;
     }
 
     public void startup()

src/main/java/dan200/computercraft/core/apis/http/ResourceQueue.java

@@ -12,8 +12,6 @@ import java.util.function.Supplier;
 
 /**
  * A {@link ResourceGroup} which will queue items when the group at capacity.
- *
- * @param <T> The type of the resource this queue manages.
  */
 public class ResourceQueue<T extends Resource<T>> extends ResourceGroup<T>
 {

src/main/java/dan200/computercraft/core/apis/http/request/HttpRequest.java

@@ -40,7 +40,7 @@ import java.util.concurrent.TimeUnit;
 import java.util.concurrent.atomic.AtomicInteger;
 
 /**
- * Represents an in-progress HTTP request.
+ * Represents one or more
  */
 public class HttpRequest extends Resource<HttpRequest>
 {
@@ -67,12 +67,12 @@ public class HttpRequest extends Resource<HttpRequest>
         super( limiter );
         this.environment = environment;
         this.address = address;
-        postBuffer = postText != null
+        this.postBuffer = postText != null
             ? Unpooled.wrappedBuffer( postText.getBytes( StandardCharsets.UTF_8 ) )
             : Unpooled.buffer( 0 );
         this.headers = headers;
         this.binary = binary;
-        redirects = new AtomicInteger( followRedirects ? MAX_REDIRECTS : 0 );
+        this.redirects = new AtomicInteger( followRedirects ? MAX_REDIRECTS : 0 );
 
         if( postText != null )
         {
@@ -113,7 +113,6 @@ public class HttpRequest extends Resource<HttpRequest>
     {
         // Validate the URL
         if( url.getScheme() == null ) throw new HTTPRequestException( "Must specify http or https" );
-        if( url.getHost() == null ) throw new HTTPRequestException( "URL malformed" );
 
         String scheme = url.getScheme().toLowerCase( Locale.ROOT );
         if( !scheme.equalsIgnoreCase( "http" ) && !scheme.equalsIgnoreCase( "https" ) )