Try to remove some locking

Ideally we would be able to avoid locking at all on the main thread, but
needs must.

src/main/java/dan200/computercraft/shared/peripheral/modem/ModemPeripheral.java

@@ -26,7 +26,7 @@
 public abstract class ModemPeripheral implements IPeripheral, IPacketSender, IPacketReceiver
 {
     private IPacketNetwork m_network;
-    private Set<IComputerAccess> m_computers = new HashSet<>( 1 );
+    private final Set<IComputerAccess> m_computers = new HashSet<>( 1 );
     private final ModemState m_state;
 
     protected ModemPeripheral( ModemState state )
@@ -58,7 +58,7 @@ protected void switchNetwork()
         setNetwork( getNetwork() );
     }
 
-    public synchronized void destroy()
+    public void destroy()
     {
         setNetwork( null );
     }
@@ -68,7 +68,7 @@ public void receiveSameDimension( @Nonnull Packet packet, double distance )
     {
         if( packet.getSender() == this || !m_state.isOpen( packet.getChannel() ) ) return;
 
-        synchronized( this )
+        synchronized( m_computers )
         {
             for( IComputerAccess computer : m_computers )
             {
@@ -84,7 +84,7 @@ public void receiveDifferentDimension( @Nonnull Packet packet )
     {
         if( packet.getSender() == this || !m_state.isOpen( packet.getChannel() ) ) return;
 
-        synchronized( this )
+        synchronized( m_computers )
         {
             for( IComputerAccess computer : m_computers )
             {
@@ -202,29 +202,42 @@ public Object[] callMethod( @Nonnull IComputerAccess computer, @Nonnull ILuaCont
     @Override
     public synchronized void attach( @Nonnull IComputerAccess computer )
     {
-        m_computers.add( computer );
+        synchronized( m_computers )
+        {
+            m_computers.add( computer );
+        }
+
         setNetwork( getNetwork() );
     }
 
     @Override
     public synchronized void detach( @Nonnull IComputerAccess computer )
     {
-        m_computers.remove( computer );
+        boolean empty;
-        if( m_computers.isEmpty() ) setNetwork( null );
+        synchronized( m_computers )
+        {
+            m_computers.remove( computer );
+            empty = m_computers.isEmpty();
+        }
+
+        if( empty ) setNetwork( null );
     }
 
     @Nonnull
     @Override
-    public synchronized String getSenderID()
+    public String getSenderID()
     {
-        if( m_computers.size() != 1 )
+        synchronized( m_computers )
         {
-            return "unknown";
+            if( m_computers.size() != 1 )
-        }
+            {
-        else
+                return "unknown";
-        {
+            }
-            IComputerAccess computer = m_computers.iterator().next();
+            else
-            return computer.getID() + "_" + computer.getAttachmentName();
+            {
+                IComputerAccess computer = m_computers.iterator().next();
+                return computer.getID() + "_" + computer.getAttachmentName();
+            }
         }
     }
 }

src/main/java/dan200/computercraft/shared/peripheral/modem/WirelessModemPeripheral.java

@@ -21,6 +21,12 @@ public WirelessModemPeripheral( ModemState state, boolean advanced )
         m_advanced = advanced;
     }
 
+    @Deprecated
+    public WirelessModemPeripheral( boolean advanced )
+    {
+        this( new ModemState(), advanced );
+    }
+
     @Override
     public boolean isInterdimensional()
     {

src/main/java/dan200/computercraft/shared/peripheral/modem/WirelessNetwork.java

@@ -13,8 +13,9 @@
 import dan200.computercraft.api.network.Packet;
 
 import javax.annotation.Nonnull;
-import java.util.HashSet;
+import java.util.Collections;
 import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
 
 public class WirelessNetwork implements IPacketNetwork
 {
@@ -34,45 +35,34 @@ public static void resetNetworks()
         s_universalNetwork = null;
     }
 
-    private final Set<IPacketReceiver> m_receivers;
+    private final Set<IPacketReceiver> m_receivers = Collections.newSetFromMap( new ConcurrentHashMap<>() );
-
-    private WirelessNetwork()
-    {
-        m_receivers = new HashSet<>();
-    }
 
     @Override
-    public synchronized void addReceiver( @Nonnull IPacketReceiver receiver )
+    public void addReceiver( @Nonnull IPacketReceiver receiver )
     {
         Preconditions.checkNotNull( receiver, "device cannot be null" );
         m_receivers.add( receiver );
     }
 
     @Override
-    public synchronized void removeReceiver( @Nonnull IPacketReceiver receiver )
+    public void removeReceiver( @Nonnull IPacketReceiver receiver )
     {
         Preconditions.checkNotNull( receiver, "device cannot be null" );
         m_receivers.remove( receiver );
     }
 
     @Override
-    public synchronized void transmitSameDimension( @Nonnull Packet packet, double range )
+    public void transmitSameDimension( @Nonnull Packet packet, double range )
     {
         Preconditions.checkNotNull( packet, "packet cannot be null" );
-        for( IPacketReceiver device : m_receivers )
+        for( IPacketReceiver device : m_receivers ) tryTransmit( device, packet, range, false );
-        {
-            tryTransmit( device, packet, range, false );
-        }
     }
 
     @Override
-    public synchronized void transmitInterdimensional( @Nonnull Packet packet )
+    public void transmitInterdimensional( @Nonnull Packet packet )
     {
         Preconditions.checkNotNull( packet, "packet cannot be null" );
-        for (IPacketReceiver device : m_receivers)
+        for( IPacketReceiver device : m_receivers ) tryTransmit( device, packet, 0, true );
-        {
-            tryTransmit( device, packet, 0, true );
-        }
     }
 
     private void tryTransmit( IPacketReceiver receiver, Packet packet, double range, boolean interdimensional )