From 1977556da474c288aa763e821e57dda9b4e86131 Mon Sep 17 00:00:00 2001 From: Jonathan Coates Date: Sat, 1 Jul 2023 18:32:19 +0100 Subject: [PATCH] Deprecate IPocketAccess.getUpgrades I think this left over from CCTweaks or Peripheral++. It doesn't really make sense as an API - if/when we add multiple upgrades, we'll want a different API for this. --- .../dan200/computercraft/api/pocket/IPocketAccess.java | 7 ++++++- .../shared/pocket/core/PocketServerComputer.java | 1 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/projects/common-api/src/main/java/dan200/computercraft/api/pocket/IPocketAccess.java b/projects/common-api/src/main/java/dan200/computercraft/api/pocket/IPocketAccess.java index 7cadb1b8b..07cb8e768 100644 --- a/projects/common-api/src/main/java/dan200/computercraft/api/pocket/IPocketAccess.java +++ b/projects/common-api/src/main/java/dan200/computercraft/api/pocket/IPocketAccess.java @@ -80,7 +80,10 @@ public interface IPocketAccess { void updateUpgradeNBTData(); /** - * Remove the current peripheral and create a new one. You may wish to do this if the methods available change. + * Remove the current peripheral and create a new one. + *

+ * You may wish to do this if the methods available change, for instance when the {@linkplain #getEntity() owning + * entity} changes. */ void invalidatePeripheral(); @@ -88,6 +91,8 @@ public interface IPocketAccess { * Get a list of all upgrades for the pocket computer. * * @return A collection of all upgrade names. + * @deprecated This is a relic of a previous API, which no longer makes sense with newer versions of ComputerCraft. */ + @Deprecated(forRemoval = true) Map getUpgrades(); } diff --git a/projects/common/src/main/java/dan200/computercraft/shared/pocket/core/PocketServerComputer.java b/projects/common/src/main/java/dan200/computercraft/shared/pocket/core/PocketServerComputer.java index 6ac22f3dd..937da3341 100644 --- a/projects/common/src/main/java/dan200/computercraft/shared/pocket/core/PocketServerComputer.java +++ b/projects/common/src/main/java/dan200/computercraft/shared/pocket/core/PocketServerComputer.java @@ -104,6 +104,7 @@ public void invalidatePeripheral() { } @Override + @Deprecated(forRemoval = true) public Map getUpgrades() { return upgrade == null ? Collections.emptyMap() : Collections.singletonMap(upgrade.getUpgradeID(), getPeripheral(ComputerSide.BACK)); }