mirror of
https://github.com/SquidDev-CC/CC-Tweaked
synced 2025-10-21 17:07:39 +00:00
Turn inspections up to 11
OK, so let's get this out of the way, there's some actual changes mixed in here too. I'm really sorry: - Turtles can now not be renamed with unnamed item tags (previously it would clear the name, this seemed a little unideal). - commands.getBlock(s)Data will also include NBT. Now, onto the horror story which is these inspection changes: - Make a lot of methods static - Typo fixes - Make utility classes final + private constructor - Lots of reformatting (ifs -> ternary, invert control flow, etc...) - ??? - Profit! I'm so going to regret this - can pretty much guarantee this is going to break something.
This commit is contained in:
@@ -21,7 +21,7 @@ import net.minecraftforge.common.model.IModelState;
|
||||
import javax.annotation.Nonnull;
|
||||
import java.util.function.Function;
|
||||
|
||||
public class TurtleModelLoader implements ICustomModelLoader
|
||||
public final class TurtleModelLoader implements ICustomModelLoader
|
||||
{
|
||||
private static final ResourceLocation NORMAL_TURTLE_MODEL = new ResourceLocation( ComputerCraft.MOD_ID, "block/turtle" );
|
||||
private static final ResourceLocation ADVANCED_TURTLE_MODEL = new ResourceLocation( ComputerCraft.MOD_ID, "block/advanced_turtle" );
|
||||
@@ -64,7 +64,7 @@ public class TurtleModelLoader implements ICustomModelLoader
|
||||
throw new IllegalStateException( "Loader does not accept " + name );
|
||||
}
|
||||
|
||||
private static class TurtleModel implements IModel
|
||||
private static final class TurtleModel implements IModel
|
||||
{
|
||||
private final IModel family;
|
||||
private final IModel colour;
|
||||
|
Reference in New Issue
Block a user